transpec 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23e8df69cf26a5fe92e93cb0817062746ab6ceaa
-  data.tar.gz: 615b879c9b613ff061b6e2cbc2268eb2b77f229e
+  metadata.gz: 51efb48bbde5bb4b866edc7919290fd09c1286ea
+  data.tar.gz: 0a2a2f6ad3b6310f0dd4ecb53b8ac157c3ab9642
 SHA512:
-  metadata.gz: 3d6bd922cb89047a78a052b933dedb9aa720136603e06a2e63ee9da37b2b81807dccad7defb05d7d09b2ec42601ce01681c3d0ef633981cc64dc9c7b1475cee3
-  data.tar.gz: d2a37cf90928208e85486b5de0b5f8d40603f0239a7591586cdeca69637ce553e2ff71aad28811d3f871ceefd69ef1201605b94a77dbe544cd2ccaed5f6308b9
+  metadata.gz: 2141b0d96bcc0e92b4fa4652010f560abbe10745172b3cf2140fecaec9c454ef9e05ab61a6a73f8df6b0a2e4d13437bdae157c4ec78b95284cd10e6d6452854d
+  data.tar.gz: d5a6b210ee1559ed1dc5b99f478959108f3a7a2d2b8815bd50961cca190430609266ee1cb946f859aef485f8cbac9373a8dead74605757f537a66713b3f8efe7

data/.rubocop.yml

@@ -47,3 +47,11 @@ Documentation:
 # Currently IndentationWidth reports false positive offence around here document.
 IndentationWidth:
   Enabled: false
+
+# Custom error classes require custom arguments.
+RaiseArgs:
+  Enabled: false
+
+# Currently ClassLength counts innner class' codes in a namespace class.
+ClassLength:
+  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Master
 
+## v0.2.3
+
+* Fix a bug where arguments of positive error expectation with block were removed (e.g. `expect { }.to raise_error(SpecificErrorClass) { |e| ... }` was converted to `expect { }.to raise_error { |e| ... }` unintentionally)
+
 ## v0.2.2
 
 * Fix a crash on syntax configuration with variable in `RSpec.configure` (e.g. `RSpec.configure { |config| config.expect_with { |c| c.syntax = some_syntax } }`)

data/lib/transpec/syntax/raise_error.rb

@@ -20,8 +20,13 @@ module Transpec
       end
 
       def positive?
-        expectation_method_name = parent_node.children[1]
-        [:should, :to].include?(expectation_method_name)
+        ancestor_nodes.reverse_each do |ancestor_node|
+          next unless ancestor_node.type == :send
+          expectation_method_name = ancestor_node.children[1]
+          return [:should, :to].include?(expectation_method_name)
+        end
+
+        false
       end
 
       private

data/lib/transpec/version.rb

@@ -5,7 +5,7 @@ module Transpec
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 2
+    PATCH = 3
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/transpec/syntax/raise_error_spec.rb

@@ -22,6 +22,94 @@ module Transpec
 
       let(:record) { raise_error_object.report.records.first }
 
+      describe '#positive?' do
+        subject { raise_error_object.positive? }
+
+        context 'when it is `lambda { }.should raise_error` form' do
+          let(:source) do
+            <<-END
+              it 'raises error' do
+                lambda { do_something }.should raise_error
+              end
+            END
+          end
+
+          it { should be_true }
+        end
+
+        context 'when it is `expect { }.to raise_error` form' do
+          let(:source) do
+            <<-END
+              it 'raises error' do
+                expect { do_something }.to raise_error
+              end
+            END
+          end
+
+          it { should be_true }
+        end
+
+        context 'when it is `lambda { }.should raise_error { |error| ... }` form' do
+          let(:source) do
+            <<-END
+              it 'raises error' do
+                lambda { do_something }.should raise_error { |error| do_anything }
+              end
+            END
+          end
+
+          it { should be_true }
+        end
+
+        context 'when it is `expect { }.to raise_error { |error| ... }` form' do
+          let(:source) do
+            <<-END
+              it 'raises error' do
+                expect { do_something }.to raise_error { |error| do_anything }
+              end
+            END
+          end
+
+          it { should be_true }
+        end
+
+        context 'when it is `lambda { }.should_not raise_error` form' do
+          let(:source) do
+            <<-END
+              it 'does not raise error' do
+                lambda { do_something }.should_not raise_error
+              end
+            END
+          end
+
+          it { should be_false }
+        end
+
+        context 'when it is `expect { }.not_to raise_error` form' do
+          let(:source) do
+            <<-END
+              it 'does not raise error' do
+                expect { do_something }.not_to raise_error
+              end
+            END
+          end
+
+          it { should be_false }
+        end
+
+        context 'when it is `expect { }.to_not raise_error` form' do
+          let(:source) do
+            <<-END
+              it 'does not raise error' do
+                expect { do_something }.to_not raise_error
+              end
+            END
+          end
+
+          it { should be_false }
+        end
+      end
+
       describe '#remove_error_specification_with_negative_expectation!' do
         before do
           raise_error_object.remove_error_specification_with_negative_expectation!
@@ -63,6 +151,42 @@ module Transpec
           end
         end
 
+        context 'when it is `lambda { }.should raise_error(SpecificErrorClass) { |error| ... }` form' do
+          let(:source) do
+            <<-END
+              it 'raises SpecificErrorClass' do
+                lambda { do_something }.should raise_error(SpecificErrorClass) { |error| do_anything }
+              end
+            END
+          end
+
+          it 'does nothing' do
+            rewritten_source.should == source
+          end
+
+          it 'reports nothing' do
+            raise_error_object.report.records.should be_empty
+          end
+        end
+
+        context 'when it is `expect { }.to raise_error(SpecificErrorClass) { |error| ... }` form' do
+          let(:source) do
+            <<-END
+              it 'raises SpecificErrorClass' do
+                expect { do_something }.to raise_error(SpecificErrorClass) { |error| do_anything }
+              end
+            END
+          end
+
+          it 'does nothing' do
+            rewritten_source.should == source
+          end
+
+          it 'reports nothing' do
+            raise_error_object.report.records.should be_empty
+          end
+        end
+
         context 'when it is `lambda { }.should_not raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: transpec
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Yuji Nakayama