transpec 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d602d29834b9ea79fc7bc396d76bfc450958491
-  data.tar.gz: 9bdc9410fd4eb71537ce875d30d74012ba657423
+  metadata.gz: 23e8df69cf26a5fe92e93cb0817062746ab6ceaa
+  data.tar.gz: 615b879c9b613ff061b6e2cbc2268eb2b77f229e
 SHA512:
-  metadata.gz: 3dcf40c9f6f8572a5d8e52c29e3e1129fb838ae8a9f156416a3aeff098e4e96e0c2875c311a235596f3d7c97aea39815cdfc20e5a02b7000c34f4b13d5d59239
-  data.tar.gz: 30c6807002ede033c51db526f201863c787c1926250c6ada8e9d34457e192c8ede222b6c2fb4f9a26cdc36558169406b1d8582c42a9d3e7a56cd7a75da46b811
+  metadata.gz: 3d6bd922cb89047a78a052b933dedb9aa720136603e06a2e63ee9da37b2b81807dccad7defb05d7d09b2ec42601ce01681c3d0ef633981cc64dc9c7b1475cee3
+  data.tar.gz: d2a37cf90928208e85486b5de0b5f8d40603f0239a7591586cdeca69637ce553e2ff71aad28811d3f871ceefd69ef1201605b94a77dbe544cd2ccaed5f6308b9

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Master
 
+## v0.2.2
+
+* Fix a crash on syntax configuration with variable in `RSpec.configure` (e.g. `RSpec.configure { |config| config.expect_with { |c| c.syntax = some_syntax } }`)
+
 ## v0.2.1
 
 * Fix a crash on operator matcher that have `__FILE__` in its arguments

data/lib/transpec/rewriter.rb

@@ -152,12 +152,16 @@ module Transpec
     def need_to_modify_expectation_syntax_configuration?(rspec_configure)
       return false unless @configuration.convert_to_expect_to_matcher?
       rspec_configure.expectation_syntaxes == [:should]
+    rescue Syntax::RSpecConfigure::UnknownSyntaxError
+      false
     end
 
     def need_to_modify_mock_syntax_configuration?(rspec_configure)
       return false if !@configuration.convert_to_expect_to_receive? &&
                       !@configuration.convert_to_allow_to_receive?
       rspec_configure.mock_syntaxes == [:should]
+    rescue Syntax::RSpecConfigure::UnknownSyntaxError
+      false
     end
 
     class OverlappedRewriteError < StandardError; end

data/lib/transpec/syntax/rspec_configure.rb

@@ -27,7 +27,7 @@ module Transpec
               child_node.children.first
             end
           else
-            fail
+            fail UnknownSyntaxError, "Unknown syntax specification: #{syntaxes_node}"
           end
         end
 
@@ -108,6 +108,8 @@ module Transpec
 
       add_framework_configuration :expectation, :expect_with
       add_framework_configuration :mock,        :mock_with
+
+      class UnknownSyntaxError < StandardError; end
     end
   end
 end

data/lib/transpec/version.rb

@@ -5,7 +5,7 @@ module Transpec
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 1
+    PATCH = 2
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/transpec/rewriter_spec.rb

@@ -526,6 +526,16 @@ module Transpec
           end
         end
       end
+
+      context "and RSpecConfigure##{syntaxes_reader} raises UnknownSyntaxError" do
+        before do
+          rspec_configure.stub(syntaxes_reader).and_raise(Syntax::RSpecConfigure::UnknownSyntaxError)
+        end
+
+        it 'returns false' do
+          should be_false
+        end
+      end
     end
 
     describe '#need_to_modify_expectation_syntax_configuration?' do

data/spec/transpec/syntax/rspec_configure_spec.rb

@@ -59,6 +59,22 @@ module Transpec
             end
           end
 
+          context 'when the syntax is specified indirectly with method or variable' do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{config_block_method} :rspec do |c|
+                    c.syntax = some_syntax
+                  end
+                end
+              END
+            end
+
+            it 'raises error' do
+              -> { subject }.should raise_error(RSpecConfigure::UnknownSyntaxError)
+            end
+          end
+
           context "when RSpec::Core::Configuration##{config_block_method} block does not exist" do
             let(:source) do
               <<-END

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transpec
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Yuji Nakayama
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-06 00:00:00.000000000 Z
+date: 2013-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser