transpec 0.1.3 → 0.2.0

data/spec/transpec/syntax/raise_error_spec.rb

@@ -20,16 +20,18 @@ module Transpec
         fail 'No raise_error node is found!'
       end
 
+      let(:record) { raise_error_object.report.records.first }
+
       describe '#remove_error_specification_with_negative_expectation!' do
         before do
           raise_error_object.remove_error_specification_with_negative_expectation!
         end
 
-        context 'when it is `lambda { ... }.should raise_error(SomeErrorClass)` form' do
+        context 'when it is `lambda { }.should raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END
-              it 'raises SomeErrorClass' do
-                lambda { do_something }.should raise_error(SomeErrorClass)
+              it 'raises SpecificErrorClass' do
+                lambda { do_something }.should raise_error(SpecificErrorClass)
               end
             END
           end
@@ -37,13 +39,17 @@ module Transpec
           it 'does nothing' do
             rewritten_source.should == source
           end
+
+          it 'reports nothing' do
+            raise_error_object.report.records.should be_empty
+          end
         end
 
-        context 'when it is `expect { ... }.to raise_error(SomeErrorClass)` form' do
+        context 'when it is `expect { }.to raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END
-              it 'raises SomeErrorClass' do
-                expect { do_something }.to raise_error(SomeErrorClass)
+              it 'raises SpecificErrorClass' do
+                expect { do_something }.to raise_error(SpecificErrorClass)
               end
             END
           end
@@ -51,13 +57,17 @@ module Transpec
           it 'does nothing' do
             rewritten_source.should == source
           end
+
+          it 'reports nothing' do
+            raise_error_object.report.records.should be_empty
+          end
         end
 
-        context 'when it is `lambda { ... }.should_not raise_error(SomeErrorClass)` form' do
+        context 'when it is `lambda { }.should_not raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                lambda { do_something }.should_not raise_error(SomeErrorClass)
+                lambda { do_something }.should_not raise_error(SpecificErrorClass)
               end
             END
           end
@@ -70,16 +80,22 @@ module Transpec
             END
           end
 
-          it 'converts into `lambda { ... }.should_not raise_error` form' do
+          it 'converts into `lambda { }.should_not raise_error` form' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`expect { }.not_to raise_error(SpecificErrorClass)` -> `expect { }.not_to raise_error`\"' do
+            record.original_syntax.should  == 'expect { }.not_to raise_error(SpecificErrorClass)'
+            record.converted_syntax.should == 'expect { }.not_to raise_error'
+          end
         end
 
-        context 'when it is `expect { ... }.not_to raise_error(SomeErrorClass)` form' do
+        context 'when it is `expect { }.not_to raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                expect { do_something }.not_to raise_error(SomeErrorClass)
+                expect { do_something }.not_to raise_error(SpecificErrorClass)
               end
             END
           end
@@ -92,16 +108,16 @@ module Transpec
             END
           end
 
-          it 'converts into `expect { ... }.not_to raise_error` form' do
+          it 'converts into `expect { }.not_to raise_error` form' do
             rewritten_source.should == expected_source
           end
         end
 
-        context 'when it is `expect { ... }.to_not raise_error(SomeErrorClass)` form' do
+        context 'when it is `expect { }.to_not raise_error(SpecificErrorClass)` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                expect { do_something }.to_not raise_error(SomeErrorClass)
+                expect { do_something }.to_not raise_error(SpecificErrorClass)
               end
             END
           end
@@ -114,16 +130,22 @@ module Transpec
             END
           end
 
-          it 'converts into `expect { ... }.to_not raise_error` form' do
+          it 'converts into `expect { }.to_not raise_error` form' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`expect { }.not_to raise_error(SpecificErrorClass)` -> `expect { }.not_to raise_error`\"' do
+            record.original_syntax.should  == 'expect { }.not_to raise_error(SpecificErrorClass)'
+            record.converted_syntax.should == 'expect { }.not_to raise_error'
+          end
         end
 
-        context 'when it is `expect { ... }.not_to raise_error SomeErrorClass` form' do
+        context 'when it is `expect { }.not_to raise_error SpecificErrorClass` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                expect { do_something }.not_to raise_error SomeErrorClass
+                expect { do_something }.not_to raise_error SpecificErrorClass
               end
             END
           end
@@ -136,16 +158,22 @@ module Transpec
             END
           end
 
-          it 'converts into `expect { ... }.not_to raise_error` form' do
+          it 'converts into `expect { }.not_to raise_error` form' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`expect { }.not_to raise_error(SpecificErrorClass)` -> `expect { }.not_to raise_error`\"' do
+            record.original_syntax.should  == 'expect { }.not_to raise_error(SpecificErrorClass)'
+            record.converted_syntax.should == 'expect { }.not_to raise_error'
+          end
         end
 
-        context "when it is `expect { ... }.not_to raise_error(SomeErrorClass, 'message')` form" do
+        context 'when it is `expect { }.not_to raise_error(SpecificErrorClass, message)` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                expect { do_something }.not_to raise_error(SomeErrorClass, 'message')
+                expect { do_something }.not_to raise_error(SpecificErrorClass, message)
               end
             END
           end
@@ -158,16 +186,22 @@ module Transpec
             END
           end
 
-          it 'converts into `expect { ... }.not_to raise_error` form' do
+          it 'converts into `expect { }.not_to raise_error` form' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`expect { }.not_to raise_error(SpecificErrorClass, message)` -> `expect { }.not_to raise_error`"' do
+            record.original_syntax.should  == 'expect { }.not_to raise_error(SpecificErrorClass, message)'
+            record.converted_syntax.should == 'expect { }.not_to raise_error'
+          end
         end
 
-        context "when it is `expect { ... }.not_to raise_error(nil, 'message')` form" do
+        context 'when it is `expect { }.not_to raise_error(message)` form' do
           let(:source) do
             <<-END
               it 'does not raise error' do
-                expect { do_something }.not_to raise_error(nil, 'message')
+                expect { do_something }.not_to raise_error(message)
               end
             END
           end
@@ -180,9 +214,15 @@ module Transpec
             END
           end
 
-          it 'converts into `expect { ... }.not_to raise_error` form' do
+          it 'converts into `expect { }.not_to raise_error` form' do
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`expect { }.not_to raise_error(message)` -> `expect { }.not_to raise_error`"' do
+            record.original_syntax.should  == 'expect { }.not_to raise_error(message)'
+            record.converted_syntax.should == 'expect { }.not_to raise_error'
+          end
         end
       end
     end

data/spec/transpec/syntax/should_receive_spec.rb

@@ -20,6 +20,8 @@ module Transpec
         fail 'No should_receive node is found!'
       end
 
+      let(:record) { should_receive_object.report.records.first }
+
       before do
         should_receive_object.context.stub(:in_example_group?).and_return(true)
       end
@@ -46,6 +48,12 @@ module Transpec
             should_receive_object.expectize!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record "`obj.should_receive(:message)` -> `expect(obj).to receive(:message)`"' do
+            should_receive_object.expectize!
+            record.original_syntax.should  == 'obj.should_receive(:message)'
+            record.converted_syntax.should == 'expect(obj).to receive(:message)'
+          end
         end
 
         context 'when it is `subject.should_not_receive(:method)` form' do
@@ -70,6 +78,13 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
+          it 'adds record ' +
+             '"`obj.should_not_receive(:message)` -> `expect(obj).not_to receive(:message)`"' do
+            should_receive_object.expectize!
+            record.original_syntax.should  == 'obj.should_not_receive(:message)'
+            record.converted_syntax.should == 'expect(obj).not_to receive(:message)'
+          end
+
           context 'and "to_not" is passed as negative form' do
             let(:expected_source) do
             <<-END
@@ -83,6 +98,13 @@ module Transpec
               should_receive_object.expectize!('to_not')
               rewritten_source.should == expected_source
             end
+
+            it 'adds record ' +
+               '"`obj.should_not_receive(:message)` -> `expect(obj).to_not receive(:message)`"' do
+              should_receive_object.expectize!('to_not')
+              record.original_syntax.should  == 'obj.should_not_receive(:message)'
+              record.converted_syntax.should == 'expect(obj).to_not receive(:message)'
+            end
           end
         end
 
@@ -281,6 +303,13 @@ module Transpec
             should_receive_object.expectize!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record "`SomeClass.any_instance.should_receive(:message)` ' +
+             '-> `expect_any_instance_of(SomeClass).to receive(:message)`"' do
+            should_receive_object.expectize!
+            record.original_syntax.should  == 'SomeClass.any_instance.should_receive(:message)'
+            record.converted_syntax.should == 'expect_any_instance_of(SomeClass).to receive(:message)'
+          end
         end
       end
 
@@ -349,6 +378,10 @@ module Transpec
       end
 
       describe '#allowize_useless_expectation!' do
+        before do
+          should_receive_object.allowize_useless_expectation!
+        end
+
         context 'when it is `subject.should_receive(:method).any_number_of_times` form' do
           let(:source) do
             <<-END
@@ -367,9 +400,14 @@ module Transpec
           end
 
           it 'converts into `allow(subject).to receive(:method)` form' do
-            should_receive_object.allowize_useless_expectation!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`obj.should_receive(:message).any_number_of_times` -> `allow(obj).to receive(:message)`"' do
+            record.original_syntax.should  == 'obj.should_receive(:message).any_number_of_times'
+            record.converted_syntax.should == 'allow(obj).to receive(:message)'
+          end
         end
 
         context 'when it is `SomeClass.any_instance.should_receive(:method).any_number_of_times` form' do
@@ -390,9 +428,14 @@ module Transpec
           end
 
           it 'converts into `allow_any_instance_of(subject).to receive(:method)` form' do
-            should_receive_object.allowize_useless_expectation!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record "`SomeClass.any_instance.should_receive(:message).any_number_of_times` ' +
+             '-> `allow_any_instance_of(SomeClass).to receive(:message)`"' do
+            record.original_syntax.should  == 'SomeClass.any_instance.should_receive(:message).any_number_of_times'
+            record.converted_syntax.should == 'allow_any_instance_of(SomeClass).to receive(:message)'
+          end
         end
 
         context 'when it is `subject.should_receive(:method).at_least(0)` form' do
@@ -413,9 +456,14 @@ module Transpec
           end
 
           it 'converts into `allow(subject).to receive(:method)` form' do
-            should_receive_object.allowize_useless_expectation!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`obj.should_receive(:message).at_least(0)` -> `allow(obj).to receive(:message)`"' do
+            record.original_syntax.should  == 'obj.should_receive(:message).at_least(0)'
+            record.converted_syntax.should == 'allow(obj).to receive(:message)'
+          end
         end
 
         context 'when it is `SomeClass.any_instance.should_receive(:method).at_least(0)` form' do
@@ -436,9 +484,14 @@ module Transpec
           end
 
           it 'converts into `allow_any_instance_of(subject).to receive(:method)` form' do
-            should_receive_object.allowize_useless_expectation!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record "`SomeClass.any_instance.should_receive(:message).at_least(0)` ' +
+             '-> `allow_any_instance_of(SomeClass).to receive(:message)`"' do
+            record.original_syntax.should  == 'SomeClass.any_instance.should_receive(:message).at_least(0)'
+            record.converted_syntax.should == 'allow_any_instance_of(SomeClass).to receive(:message)'
+          end
         end
 
         context 'when it is `subject.should_receive(:method)` form' do
@@ -451,13 +504,16 @@ module Transpec
           end
 
           it 'does nothing' do
-            should_receive_object.allowize_useless_expectation!
             rewritten_source.should == source
           end
         end
       end
 
       describe '#stubize_useless_expectation!' do
+        before do
+          should_receive_object.stubize_useless_expectation!
+        end
+
         context 'when it is `subject.should_receive(:method).any_number_of_times` form' do
           let(:source) do
             <<-END
@@ -476,9 +532,14 @@ module Transpec
           end
 
           it 'converts into `subject.stub(:method)` form' do
-            should_receive_object.stubize_useless_expectation!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record ' +
+             '"`obj.should_receive(:message).any_number_of_times` -> `obj.stub(:message)`"' do
+            record.original_syntax.should  == 'obj.should_receive(:message).any_number_of_times'
+            record.converted_syntax.should == 'obj.stub(:message)'
+          end
         end
 
         context 'when it is `subject.should_receive(:method)` form' do
@@ -491,7 +552,6 @@ module Transpec
           end
 
           it 'does nothing' do
-            should_receive_object.stubize_useless_expectation!
             rewritten_source.should == source
           end
         end

data/spec/transpec/syntax/should_spec.rb

@@ -9,6 +9,8 @@ module Transpec
       include_context 'parsed objects'
       include_context 'should object'
 
+      let(:record) { should_object.report.records.first }
+
       before do
         should_object.context.stub(:in_example_group?).and_return(true)
       end
@@ -121,6 +123,12 @@ module Transpec
             should_object.expectize!
             rewritten_source.should == expected_source
           end
+
+          it 'adds record "`obj.should` -> `expect(obj).to`"' do
+            should_object.expectize!
+            record.original_syntax.should  == 'obj.should'
+            record.converted_syntax.should == 'expect(obj).to'
+          end
         end
 
         context 'when it is `subject.should_not` form' do
@@ -145,6 +153,12 @@ module Transpec
             rewritten_source.should == expected_source
           end
 
+          it 'adds record "`obj.should_not` -> `expect(obj).not_to`"' do
+            should_object.expectize!
+            record.original_syntax.should  == 'obj.should_not'
+            record.converted_syntax.should == 'expect(obj).not_to'
+          end
+
           context 'and "to_not" is passed as negative form' do
             let(:expected_source) do
             <<-END
@@ -158,6 +172,12 @@ module Transpec
               should_object.expectize!('to_not')
               rewritten_source.should == expected_source
             end
+
+            it 'adds record "`obj.should_not` -> `expect(obj).to_not`"' do
+              should_object.expectize!('to_not')
+              record.original_syntax.should  == 'obj.should_not'
+              record.converted_syntax.should == 'expect(obj).to_not'
+            end
           end
         end
 
@@ -234,6 +254,12 @@ module Transpec
               should_object.expectize!
               rewritten_source.should == expected_source
             end
+
+            it 'adds record "`lambda { }.should` -> `expect { }.to`"' do
+              should_object.expectize!
+              record.original_syntax.should  == 'lambda { }.should'
+              record.converted_syntax.should == 'expect { }.to'
+            end
           end
         end
 

data/tasks/test.rake

@@ -37,14 +37,9 @@ class TranspecTest
 
     puts " Testing on #{name} Project ".center(80, '=')
 
-    prepare_project
-
-    in_project_dir do
-      with_clean_bundler_env do
-        sh 'bundle', 'install', *bundler_args
-        sh File.join(Transpec.root, 'bin', 'transpec'), '--force'
-        sh 'bundle exec rspec'
-      end
+    [%w(--force), %w(--force --no-parentheses-matcher-arg)].each do |args|
+      prepare_project
+      run_test(args)
     end
   end
 
@@ -72,19 +67,31 @@ class TranspecTest
         FileUtils.cp_r(entry, project_dir)
       end
     end
+
+    bundle_install
   end
 
   def prepare_with_git_repo
     if Dir.exist?(project_dir)
       if current_ref == ref
         git_reset_hard
+        return
       else
         require 'fileutils'
         FileUtils.rm_rf(project_dir)
-        git_clone
       end
-    else
-      git_clone
+    end
+
+    git_clone
+    bundle_install
+  end
+
+  def run_test(transpec_args = [])
+    in_project_dir do
+      with_clean_bundler_env do
+        sh File.join(Transpec.root, 'bin', 'transpec'), *transpec_args
+        sh 'bundle exec rspec'
+      end
     end
   end
 
@@ -115,6 +122,14 @@ class TranspecTest
     end
   end
 
+  def bundle_install
+    in_project_dir do
+      with_clean_bundler_env do
+        sh 'bundle', 'install', *bundler_args
+      end
+    end
+  end
+
   def with_clean_bundler_env
     if defined?(Bundler)
       Bundler.with_clean_env do
@@ -145,7 +160,7 @@ namespace :test do
 
   # rubocop:disable LineLength
   tests = [
-    TranspecTest.new(File.expand_path('.'), nil, []),
+    TranspecTest.new(File.expand_path('.'), nil, ['--quiet']),
     TranspecTest.new('https://github.com/sferik/twitter.git', 'v4.1.0', bundler_args),
     TranspecTest.new('https://github.com/yujinakayama/guard.git', 'transpec', bundler_args + %w(--without development)),
     TranspecTest.new('https://github.com/yujinakayama/mail.git', 'transpec', bundler_args)