transpec 0.1.2 → 0.1.3

data/lib/transpec/syntax/method_stub.rb

@@ -11,7 +11,10 @@ module Transpec
     class MethodStub < Syntax
       include AbleToAllowNoMessage, AbleToTargetAnyInstance, Util
 
-      RECEIVER_CLASS_WHITELIST = ['Typhoeus']
+      CLASSES_DEFINING_OWN_STUB_METHOD = [
+        'Typhoeus', # https://github.com/typhoeus/typhoeus/blob/6a59c62/lib/typhoeus.rb#L66-L85
+        'Excon'     # https://github.com/geemus/excon/blob/6af4f9c/lib/excon.rb#L143-L178
+      ]
 
       def allowize!
         # There's no way of unstubbing in #allow syntax.
@@ -19,7 +22,7 @@ module Transpec
 
         fail 'Already replaced deprecated method, cannot allowize.' if @replaced_deprecated_method
 
-        unless in_example_group_context?
+        unless context.in_example_group?
           fail NotInExampleGroupContextError.new(selector_range, "##{method_name}", '#allow')
         end
 
@@ -54,7 +57,7 @@ module Transpec
       def self.target_receiver_node?(node)
         return false if node.nil?
         const_name = Util.const_name(node)
-        !RECEIVER_CLASS_WHITELIST.include?(const_name)
+        !CLASSES_DEFINING_OWN_STUB_METHOD.include?(const_name)
       end
 
       def self.target_method_names
@@ -76,7 +79,7 @@ module Transpec
 
       def build_allow_expression(message_node, return_value_node = nil, keep_form_around_arg = true)
         expression =  allow_source
-        expression << range_in_between_subject_and_selector.source
+        expression << range_in_between_receiver_and_selector.source
         expression << 'to receive'
         expression << (keep_form_around_arg ? range_in_between_selector_and_arg.source : '(')
         expression << message_source(message_node)
@@ -104,30 +107,6 @@ module Transpec
         message_source.prepend(':') if node.type == :sym && !message_source.start_with?(':')
         message_source
       end
-
-      def range_in_between_subject_and_selector
-        Parser::Source::Range.new(
-          subject_range.source_buffer,
-          subject_range.end_pos,
-          selector_range.begin_pos
-        )
-      end
-
-      def range_in_between_selector_and_arg
-        Parser::Source::Range.new(
-          selector_range.source_buffer,
-          selector_range.end_pos,
-          arg_range.begin_pos
-        )
-      end
-
-      def range_after_arg
-        Parser::Source::Range.new(
-          arg_range.source_buffer,
-          arg_range.end_pos,
-          expression_range.end_pos
-        )
-      end
     end
   end
 end

data/lib/transpec/syntax/send_node_syntax.rb

@@ -36,6 +36,18 @@ module Transpec
       def parentheses_range
         selector_range.end.join(expression_range.end)
       end
+
+      def range_in_between_receiver_and_selector
+        receiver_range.end.join(selector_range.begin)
+      end
+
+      def range_in_between_selector_and_arg
+        selector_range.end.join(arg_range.begin)
+      end
+
+      def range_after_arg
+        arg_range.end.join(expression_range.end)
+      end
     end
   end
 end

data/lib/transpec/syntax/should.rb

@@ -15,7 +15,7 @@ module Transpec
       end
 
       def expectize!(negative_form = 'not_to', parenthesize_matcher_arg = true)
-        unless in_example_group_context?
+        unless context.in_example_group?
           fail NotInExampleGroupContextError.new(selector_range, "##{method_name}", '#expect')
         end
 
@@ -31,7 +31,7 @@ module Transpec
       end
 
       def matcher
-        @matcher ||= Matcher.new(matcher_node, in_example_group_context?, @source_rewriter)
+        @matcher ||= Matcher.new(matcher_node, @source_rewriter)
       end
 
       def matcher_node

data/lib/transpec/syntax/should_receive.rb

@@ -37,7 +37,7 @@ module Transpec
       private
 
       def convert_to_syntax!(syntax, negative_form)
-        unless in_example_group_context?
+        unless context.in_example_group?
           fail NotInExampleGroupContextError.new(selector_range, "##{method_name}", "##{syntax}")
         end
 

data/lib/transpec/version.rb

@@ -5,7 +5,7 @@ module Transpec
   module Version
     MAJOR = 0
     MINOR = 1
-    PATCH = 2
+    PATCH = 3
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/spec_helper.rb

@@ -12,7 +12,6 @@ RSpec.configure do |config|
 
   config.color_enabled = true
   config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.filter_run_excluding do_not_run_in_converted_spec: ENV['TRANSPEC_CONVERTED_SPEC']
 
   config.before(:all) do
     require 'rainbow'
@@ -25,22 +24,20 @@ RSpec.configure do |config|
   end
 end
 
-unless ENV['TRANSPEC_CONVERTED_SPEC']
-  require 'simplecov'
-  SimpleCov.coverage_dir(File.join('spec', 'coverage'))
+require 'simplecov'
+SimpleCov.coverage_dir(File.join('spec', 'coverage'))
 
-  if ENV['TRAVIS']
-    require 'coveralls'
-    SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-  elsif ENV['CI']
-    require 'simplecov-rcov'
-    SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
-  end
+if ENV['TRAVIS']
+  require 'coveralls'
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+elsif ENV['CI']
+  require 'simplecov-rcov'
+  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+end
 
-  SimpleCov.start do
-    add_filter '/spec/'
-    add_filter '/vendor/bundle/'
-  end
+SimpleCov.start do
+  add_filter '/spec/'
+  add_filter '/vendor/bundle/'
 end
 
 Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|

data/spec/support/shared_context.rb

@@ -33,15 +33,12 @@ shared_context 'should object' do
       return Transpec::Syntax::Should.new(
         node,
         ancestor_nodes,
-        in_example_group_context?,
         source_rewriter
       )
     end
 
     fail 'No should node is found!'
   end
-
-  let(:in_example_group_context?) { true }
 end
 
 shared_context 'isolated environment' do

data/spec/transpec/ast/scanner_spec.rb

@@ -119,59 +119,6 @@ module Transpec
           index.should_not == 0
         end
       end
-
-      describe '#scope_stack' do
-        def brief_of_node(node)
-          brief = node.type.to_s
-          node.children.each do |child|
-            break if child.is_a?(Parser::AST::Node)
-            brief << " #{child.inspect}"
-          end
-          brief
-        end
-
-        it 'returns current scope stack' do
-          scanner = Scanner.new do |node|
-            expected_scope_stack = begin
-              case brief_of_node(node)
-              when 'lvasgn :some_var'
-                []
-              when 'send nil :prepare_something'
-                [:rspec_configure, :block]
-              when 'module'
-                []
-              when 'const nil :SomeModule'
-                # [:module] # TODO
-              when 'casgn nil :SOME_CONST'
-                [:module]
-              when 'send nil :describe'
-                # [:module] # TODO
-              when 'def :some_method'
-                [:module, :example_group]
-              when 'arg :some_arg'
-                # [:module, :example_group] # TODO
-              when 'send nil :do_something'
-                [:module, :example_group, :def]
-              when 'send nil :it'
-                # [:module, :example_group] # TODO
-              when 'str "is 1"'
-                # [:module, :example_group] # TODO
-              when 'send nil :something'
-                [:module, :example_group, :block]
-              end
-            end
-
-            # TODO: Some scope nodes have special child nodes
-            #   such as their arguments or their subject.
-            #   But from scope point of view, the child nodes are not in the parent's scope,
-            #   they should be in the next outer scope.
-
-            scanner.scope_stack.should == expected_scope_stack if expected_scope_stack
-          end
-
-          scanner.scan(ast, true)
-        end
-      end
     end
   end
 end

data/spec/transpec/context_spec.rb

@@ -0,0 +1,256 @@
+# coding: utf-8
+
+require 'spec_helper'
+require 'transpec/context'
+
+module Transpec
+  describe Context do
+    include_context 'parsed objects'
+
+    def node_id(node)
+      id = node.type.to_s
+      node.children.each do |child|
+        break if child.is_a?(Parser::AST::Node)
+        id << " #{child.inspect}"
+      end
+      id
+    end
+
+    describe '#scopes' do
+      let(:source) do
+        <<-END
+          some_var = 1
+
+          RSpec.configure do |config|
+            config.before do
+              prepare_something
+            end
+          end
+
+          module SomeModule
+            SOME_CONST = 1
+
+            describe 'something' do
+              def some_method(some_arg)
+                do_something
+              end
+
+              it 'is 1' do
+                something.should == 1
+              end
+            end
+          end
+        END
+      end
+
+      it 'returns scope stack' do
+        AST::Scanner.scan(ast) do |node, ancestor_nodes|
+          expected_scopes = begin
+            case node_id(node)
+            when 'lvasgn :some_var'
+              []
+            when 'send nil :prepare_something'
+              [:rspec_configure, :block]
+            when 'module'
+              []
+            when 'const nil :SomeModule'
+              # [:module] # TODO
+            when 'casgn nil :SOME_CONST'
+              [:module]
+            when 'send nil :describe'
+              # [:module] # TODO
+            when 'def :some_method'
+              [:module, :example_group]
+            when 'arg :some_arg'
+              # [:module, :example_group] # TODO
+            when 'send nil :do_something'
+              [:module, :example_group, :def]
+            when 'send nil :it'
+              # [:module, :example_group] # TODO
+            when 'str "is 1"'
+              # [:module, :example_group] # TODO
+            when 'send nil :something'
+              [:module, :example_group, :block]
+            end
+          end
+
+          # TODO: Some scope nodes have special child nodes
+          #   such as their arguments or their subject.
+          #   But from scope point of view, the child nodes are not in the parent's scope,
+          #   they should be in the next outer scope.
+
+          next unless expected_scopes
+
+          context_object = Context.new(ancestor_nodes)
+          context_object.scopes.should == expected_scopes
+        end
+      end
+    end
+
+    describe '#in_example_group?' do
+      let(:source) do
+        <<-END
+          top
+
+          def some_method
+            imethod_top
+
+            1.times do
+              block_imethod_top
+            end
+          end
+
+          describe 'foo' do
+            describe_top
+
+            def some_method
+              imethod_describe_top
+            end
+
+            it 'is an example' do
+              block_describe_top
+
+              class SomeClass
+                class_block_describe_top
+
+                def some_method
+                  imethod_class_block_describe_top
+                end
+              end
+            end
+          end
+
+          module SomeModule
+            describe 'bar' do
+              describe_module
+
+              def some_method
+                imethod_describe_module
+              end
+
+              it 'is an example' do
+                block_describe_module
+              end
+            end
+          end
+
+          module AnotherModule
+            def some_method
+              imethod_module
+            end
+          end
+
+          class SomeClass
+            def some_method
+              imethod_class
+            end
+          end
+
+          RSpec.configure do |config|
+            rspecconfigure
+
+            def some_method
+              imethod_rspecconfigure
+            end
+
+            config.before do
+              block_rspecconfigure
+            end
+          end
+        END
+      end
+
+      let(:context_object) do
+        AST::Scanner.scan(ast) do |node, ancestor_nodes|
+          next unless node_id(node) == target_node_id
+          return Context.new(ancestor_nodes)
+        end
+
+        fail 'Target node not found!'
+      end
+
+      subject { context_object.in_example_group? }
+
+      context 'when in top level' do
+        let(:target_node_id) { 'send nil :top' }
+        it { should be_false }
+      end
+
+      context 'when in an instance method in top level' do
+        let(:target_node_id) { 'send nil :imethod_top' }
+        it { should be_true }
+      end
+
+      context 'when in a block in an instance method in top level' do
+        let(:target_node_id) { 'send nil :block_imethod_top' }
+        it { should be_true }
+      end
+
+      context 'when in #describe block in top level' do
+        let(:target_node_id) { 'send nil :describe_top' }
+        it { should be_false }
+      end
+
+      context 'when in an instance method in #describe block in top level' do
+        let(:target_node_id) { 'send nil :imethod_describe_top' }
+        it { should be_true }
+      end
+
+      context 'when in a block in #describe block in top level' do
+        let(:target_node_id) { 'send nil :block_describe_top' }
+        it { should be_true }
+      end
+
+      context 'when in a class in a block in #describe block' do
+        let(:target_node_id) { 'send nil :class_block_describe_top' }
+        it { should be_false }
+      end
+
+      context 'when in an instance method in a class in a block in #describe block' do
+        let(:target_node_id) { 'send nil :imethod_class_block_describe_top' }
+        it { should be_false }
+      end
+
+      context 'when in #describe block in a module' do
+        let(:target_node_id) { 'send nil :describe_module' }
+        it { should be_false }
+      end
+
+      context 'when in an instance method in #describe block in a module' do
+        let(:target_node_id) { 'send nil :imethod_describe_module' }
+        it { should be_true }
+      end
+
+      context 'when in a block in #describe block in a module' do
+        let(:target_node_id) { 'send nil :block_describe_module' }
+        it { should be_true }
+      end
+
+      context 'when in an instance method in a module' do
+        # Instance methods of module can be used by `include SomeModule` in #describe block.
+        let(:target_node_id) { 'send nil :imethod_module' }
+        it { should be_true }
+      end
+
+      context 'when in an instance method in a class' do
+        let(:target_node_id) { 'send nil :imethod_class' }
+        it { should be_false }
+      end
+
+      context 'when in RSpec.configure' do
+        let(:target_node_id) { 'send nil :rspecconfigure' }
+        it { should be_false }
+      end
+
+      context 'when in a block in RSpec.configure' do
+        let(:target_node_id) { 'send nil :block_rspecconfigure' }
+        it { should be_true }
+      end
+
+      context 'when in an instance method in RSpec.configure' do
+        let(:target_node_id) { 'send nil :imethod_rspecconfigure' }
+        it { should be_true }
+      end
+    end
+  end
+end