transpec 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3d0d724597250da7c8777978b0966f79bb8ef4a
-  data.tar.gz: d8cd06841df2954393cbe9ce26bb6d4b892fb8d7
+  metadata.gz: 1c33db67b6816b403a76cc42ab37c1a2fa20f0a5
+  data.tar.gz: 5842ca3f82cdd32eda912aabc59fe59b0b9e857f
 SHA512:
-  metadata.gz: eaf64a911679b0b2277c3643ee3e53a2b92b8ac3b0f8d5730f6a5399e4179114b0290c32b4c308968601884a47728f52f77d8babbfdafb3309407a8ef7e8dddd
-  data.tar.gz: 081bd5d3f7d4e0b91a7ec37754cee098c0fcc714862044304549daff2f2e263ecb3c0d3a120c1299e049d4dcdcd7750d4cc93d9d8e9b5cf548e3fd6f69b101c6
+  metadata.gz: 57d17382d629af2561f02042eb31f8d1f64ac6d95c63251e55699974c1340da56947d91c51dd198e19c67b26e53edc0843c8aa58eb1fc73fa405ca8f99850327
+  data.tar.gz: 586efdc379d22a195160a5d5e83b4f0284b23c67fdb2b74c9f5b9917167c6de5ab55037ee20720925dbf1cce082463e0f3f9ce4140c4d9b62a11fbc7ea167873

data/.travis.yml

@@ -3,4 +3,4 @@ rvm:
   - 1.9.3
   - 2.0.0
   - jruby-19mode
-script: bundle exec rake all
+script: bundle exec rake

data/CHANGELOG.md

@@ -1,4 +1,11 @@
-# CHANGELOG
+# Changelog
+
+## Master
+
+## v0.0.3
+
+* Suppress addition of superfluous parentheses when converting operator matcher that have argument in parentheses to non-operator matcher (e.g. from `== (2 - 1)` to `eq(2 - 1)`)
+* Support auto-modification of syntax configuration in `RSpec.configure`
 
 ## v0.0.2
 

data/Guardfile

@@ -14,5 +14,7 @@ guard :rubocop do
 end
 
 guard :shell do
-  watch('README.md.erb') { `rake readme` }
+  watch('README.md.erb') do
+    system('rake', 'readme') || n('Failed to build README.md', 'README Build Result', :failed)
+  end
 end

data/README.md

@@ -121,6 +121,77 @@ This will convert and overwrite all spec files in the `spec` directory.
 
 After the conversion, run `rspec` again and check if all pass.
 
+## Options
+
+### `-d/--disable`
+
+Disable specific conversions.
+
+```bash
+$ transpec --disable expect_to_receive,allow_to_receive
+```
+
+#### Available conversion types
+
+Conversion Type     | Target Syntax                    | Converted Syntax
+--------------------|----------------------------------|----------------------------
+`expect_to_matcher` | `obj.should`                     | `expect(obj).to`
+`expect_to_receive` | `obj.should_receive`             | `expect(obj).to receive`
+`allow_to_receive`  | `obj.stub`                       | `allow(obj).to receive`
+`deprecated`        | `obj.stub!`, `mock('foo')`, etc. | `obj.stub`, `double('foo')`
+
+### `-n/--negative-form`
+
+Specify negative form of `to` that is used in `expect` syntax.
+Either `not_to` or `to_not`.
+`not_to` is used by default.
+
+```bash
+$ transpec --negative-form to_not
+```
+
+### `-p/--no-parentheses-matcher-arg`
+
+Suppress parenthesizing argument of matcher when converting
+`should` with operator matcher to `expect` with non-operator matcher
+(`expect` syntax does not directly support the operator matchers).
+Note that it will be parenthesized even if this option is specified
+when parentheses are necessary to keep the meaning of the expression.
+
+```ruby
+describe 'original spec' do
+  it 'is example' do
+    1.should == 1
+    2.should > 1
+    'string'.should =~ /str/
+    [1, 2, 3].should =~ [2, 1, 3]
+    { key: value }.should == { key: value }
+  end
+end
+
+describe 'converted spec' do
+  it 'is example' do
+    expect(1).to eq(1)
+    expect(2).to be > 1
+    expect('string').to match(/str/)
+    expect([1, 2, 3]).to match_array([2, 1, 3])
+    expect({ key: value }).to eq({ key: value })
+  end
+end
+
+describe 'converted spec with -p/--no-parentheses-matcher-arg option' do
+  it 'is example' do
+    expect(1).to eq 1
+    expect(2).to be > 1
+    expect('string').to match /str/
+    expect([1, 2, 3]).to match_array [2, 1, 3]
+    # With non-operator method, the parentheses are always required
+    # to prevent the hash from being interpreted as a block.
+    expect({ key: value }).to eq({ key: value })
+  end
+end
+```
+
 ## Compatibility
 
 Tested on MRI 1.9, MRI 2.0 and JRuby in 1.9 mode.

data/README.md.erb

@@ -94,6 +94,100 @@ This will convert and overwrite all spec files in the `spec` directory.
 
 After the conversion, run `rspec` again and check if all pass.
 
+## Options
+
+### `-d/--disable`
+
+Disable specific conversions.
+
+```bash
+$ transpec --disable expect_to_receive,allow_to_receive
+```
+
+#### Available conversion types
+
+Conversion Type     | Target Syntax                    | Converted Syntax
+--------------------|----------------------------------|----------------------------
+<%=
+conversion_type_table = <<END
+`expect_to_matcher` | `obj.should`                     | `expect(obj).to`
+`expect_to_receive` | `obj.should_receive`             | `expect(obj).to receive`
+`allow_to_receive`  | `obj.stub`                       | `allow(obj).to receive`
+`deprecated`        | `obj.stub!`, `mock('foo')`, etc. | `obj.stub`, `double('foo')`
+END
+
+types_in_readme = conversion_type_table.lines.map do |line|
+  first_column = line.split('|').first
+  first_column.gsub(/[^\w]/, '').to_sym
+end.sort
+
+types_in_code = Transpec::CLI::CONFIG_ATTRS_FOR_CLI_TYPES.keys.sort
+
+unless types_in_readme == types_in_code
+  types_missing_description = types_in_code - types_in_readme
+  fail "No descriptions for conversion types #{types_missing_description}"
+end
+
+conversion_type_table
+-%>
+
+### `-n/--negative-form`
+
+Specify negative form of `to` that is used in `expect` syntax.
+Either `not_to` or `to_not`.
+`not_to` is used by default.
+
+```bash
+$ transpec --negative-form to_not
+```
+
+### `-p/--no-parentheses-matcher-arg`
+
+Suppress parenthesizing argument of matcher when converting
+`should` with operator matcher to `expect` with non-operator matcher
+(`expect` syntax does not directly support the operator matchers).
+Note that it will be parenthesized even if this option is specified
+when parentheses are necessary to keep the meaning of the expression.
+
+```ruby
+<%=
+parenthesizing_example = <<END
+describe 'original spec' do
+  it 'is example' do
+    1.should == 1
+    2.should > 1
+    'string'.should =~ /str/
+    [1, 2, 3].should =~ [2, 1, 3]
+    { key: value }.should == { key: value }
+  end
+end
+END
+-%>
+
+<%=
+Transpec::Rewriter.new.rewrite(parenthesizing_example).gsub(
+  'original spec',
+  'converted spec'
+)
+-%>
+
+<%=
+configuration = Transpec::Configuration.new
+configuration.parenthesize_matcher_arg = false
+rewriter = Transpec::Rewriter.new(configuration)
+rewriter.rewrite(parenthesizing_example)
+  .gsub(
+    'original spec',
+    'converted spec with -p/--no-parentheses-matcher-arg option'
+  )
+  .gsub(/^.+\{ key: value \}/) do |match|
+    "    # With non-operator method, the parentheses are always required\n" +
+    "    # to prevent the hash from being interpreted as a block.\n" +
+    match
+  end
+-%>
+```
+
 ## Compatibility
 
 Tested on MRI 1.9, MRI 2.0 and JRuby in 1.9 mode.

data/Rakefile

@@ -18,13 +18,10 @@ namespace :ci do
   end
 end
 
-desc 'Run RSpec and RuboCop'
-task all: [:spec, :style]
-
 desc 'Generate README.md'
 task :readme do
   require 'erb'
-  require 'transpec'
+  require 'transpec/cli'
 
   gem_specification = Gem::Specification.load('transpec.gemspec')
   rspec_dependency = gem_specification.dependencies.find { |d| d.name == 'rspec' }
@@ -45,4 +42,4 @@ end
 
 Rake::Task[:release].enhance([:abort_unless_latest_readme_is_committed])
 
-task default: :all
+task default: [:spec, :style, :readme]

data/lib/transpec/ast/scanner.rb

@@ -13,6 +13,7 @@ module Transpec
       def self.scan(origin_node, &block)
         instance = new(&block)
         instance.scan(origin_node, true)
+        nil
       end
 
       def initialize(&block)

data/lib/transpec/rewriter.rb

@@ -7,6 +7,7 @@ require 'transpec/syntax/be_close'
 require 'transpec/syntax/double'
 require 'transpec/syntax/matcher'
 require 'transpec/syntax/method_stub'
+require 'transpec/syntax/rspec_configure'
 require 'transpec/syntax/should'
 require 'transpec/syntax/should_receive'
 require 'parser/current'
@@ -117,5 +118,26 @@ module Transpec
     def process_be_close(be_close)
       be_close.convert_to_be_within! if @configuration.replace_deprecated_method?
     end
+
+    def process_rspec_configure(rspec_configure)
+      if need_to_modify_expectation_syntax_configuration?(rspec_configure)
+        rspec_configure.modify_expectation_syntaxes!(:expect)
+      end
+
+      if need_to_modify_mock_syntax_configuration?(rspec_configure)
+        rspec_configure.modify_mock_syntaxes!(:expect)
+      end
+    end
+
+    def need_to_modify_expectation_syntax_configuration?(rspec_configure)
+      return false unless @configuration.convert_to_expect_to_matcher?
+      rspec_configure.expectation_syntaxes == [:should]
+    end
+
+    def need_to_modify_mock_syntax_configuration?(rspec_configure)
+      return false if !@configuration.convert_to_expect_to_receive? &&
+                      !@configuration.convert_to_allow_to_receive?
+      rspec_configure.mock_syntaxes == [:should]
+    end
   end
 end

data/lib/transpec/syntax/expectizable.rb

@@ -1,6 +1,7 @@
 # coding: utf-8
 
 require 'transpec/syntax/send_node_syntax'
+require 'transpec/util'
 
 module Transpec
   class Syntax
@@ -8,7 +9,7 @@ module Transpec
       include SendNodeSyntax
 
       def wrap_subject_in_expect!
-        if subject_range.source[0] == '('
+        if Util.in_parentheses?(subject_range)
           insert_before(subject_range, 'expect')
         else
           insert_before(subject_range, 'expect(')

data/lib/transpec/syntax/matcher.rb

@@ -41,7 +41,9 @@ module Transpec
 
         case left_parenthesis_range.source
         when ' '
-          if always || arg_node.type == :hash
+          if in_parentheses?(arg_node)
+            remove(left_parenthesis_range)
+          elsif always || arg_node.type == :hash
             replace(left_parenthesis_range, '(')
             insert_after(expression_range, ')')
           end

data/lib/transpec/syntax/rspec_configure.rb

@@ -0,0 +1,113 @@
+# coding: utf-8
+
+require 'transpec/syntax'
+require 'transpec/util'
+require 'transpec/ast/scanner'
+
+module Transpec
+  class Syntax
+    class RSpecConfigure < Syntax
+      class FrameworkConfiguration
+        include ::AST::Sexp
+
+        def initialize(rspec_configure_node, framework_config_method_name, source_rewriter)
+          @rspec_configure_node = rspec_configure_node
+          @framework_config_method_name = framework_config_method_name
+          @source_rewriter = source_rewriter
+        end
+
+        def syntaxes
+          return [] unless syntaxes_node
+
+          case syntaxes_node.type
+          when :sym
+            [syntaxes_node.children.first]
+          when :array
+            syntaxes_node.children.map do |child_node|
+              child_node.children.first
+            end
+          else
+            fail
+          end
+        end
+
+        def modify_syntaxes!(syntaxes)
+          unless [Array, Symbol].include?(syntaxes.class)
+            fail ArgumentError, 'Syntaxes must be either an array or a symbol.'
+          end
+
+          @source_rewriter.replace(syntaxes_node.loc.expression, syntaxes.inspect)
+        end
+
+        private
+
+        def syntaxes_node
+          return nil unless framework_block_node
+
+          @syntaxes_node ||= begin
+            framework_config_variable_name = first_block_arg_name(framework_block_node)
+
+            AST::Scanner.scan(framework_block_node) do |descendent_node|
+              next unless descendent_node.type == :send
+              receiver_node, method_name, arg_node, *_ = *descendent_node
+              next unless receiver_node == s(:lvar, framework_config_variable_name)
+              next unless method_name == :syntax=
+              break arg_node
+            end
+          end
+        end
+
+        def framework_block_node
+          @framework_block_node ||= begin
+            AST::Scanner.scan(@rspec_configure_node) do |descendent_node|
+              next unless descendent_node.type == :block
+              send_node = descendent_node.children.first
+              receiver_node, method_name, *_ = *send_node
+              next unless receiver_node == s(:lvar, rspec_configure_block_arg_name)
+              next unless method_name == @framework_config_method_name
+              # TODO: Check expectation framework.
+              break descendent_node
+            end
+          end
+        end
+
+        def rspec_configure_block_arg_name
+          first_block_arg_name(@rspec_configure_node)
+        end
+
+        def first_block_arg_name(block_node)
+          args_node = block_node.children[1]
+          first_arg_node = args_node.children.first
+          first_arg_node.children.first
+        end
+      end
+
+      def self.target_node?(node)
+        return false unless node.type == :block
+        send_node = node.children.first
+        receiver_node, method_name, *_ = *send_node
+        Util.const_name(receiver_node) == 'RSpec' && method_name == :configure
+      end
+
+      def self.add_framework_configuration(type, config_method_name)
+        class_eval <<-END
+          def #{type}_syntaxes
+            #{type}_framework_configuration.syntaxes
+          end
+
+          def modify_#{type}_syntaxes!(syntaxes)
+            #{type}_framework_configuration.modify_syntaxes!(syntaxes)
+          end
+
+          def #{type}_framework_configuration
+            @#{type}_framework_configuration ||=
+              FrameworkConfiguration.new(node, :#{config_method_name}, source_rewriter)
+          end
+        END
+      end
+
+      add_framework_configuration :expectation, :expect_with
+      add_framework_configuration :mock,        :mock_with
+    end
+  end
+end

data/lib/transpec/util.rb

@@ -41,6 +41,21 @@ module Transpec
       node.loc.begin.source.start_with?('<<')
     end
 
+    def in_parentheses?(subject)
+      source = case subject
+               when String
+                 subject
+               when Parser::Source::Range
+                 subject.source
+               when Parser::AST::Node
+                 subject.loc.expression.source
+               else
+                 fail ArgumentError
+               end
+
+      source[0] == '('
+    end
+
     def indentation_of_line(node)
       line = node.loc.expression.source_line
       /^(?<indentation>\s*)\S/ =~ line

data/lib/transpec/version.rb

@@ -5,7 +5,7 @@ module Transpec
   module Version
     MAJOR = 0
     MINOR = 0
-    PATCH = 2
+    PATCH = 3
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/spec_helper.rb

@@ -11,23 +11,32 @@ RSpec.configure do |config|
   end
 
   config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.filter_run_excluding do_not_run_in_transpeced_spec: ENV['TRANSPECED_SPEC']
+  config.filter_run_excluding do_not_run_in_converted_spec: ENV['TRANSPEC_CONVERTED_SPEC']
+
+  if ENV['TRAVIS']
+    config.before(:all) do
+      system('git config --global user.email "you@example.com"')
+      system('git config --global user.name "Your Name"')
+    end
+  end
 end
 
-require 'simplecov'
-SimpleCov.coverage_dir(File.join('spec', 'coverage'))
+unless ENV['TRANSPEC_CONVERTED_SPEC']
+  require 'simplecov'
+  SimpleCov.coverage_dir(File.join('spec', 'coverage'))
 
-if ENV['TRAVIS']
-  require 'coveralls'
-  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-elsif ENV['CI']
-  require 'simplecov-rcov'
-  SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
-end
+  if ENV['TRAVIS']
+    require 'coveralls'
+    SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  elsif ENV['CI']
+    require 'simplecov-rcov'
+    SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter
+  end
 
-SimpleCov.start do
-  add_filter '/spec/'
-  add_filter '/vendor/bundle/'
+  SimpleCov.start do
+    add_filter '/spec/'
+    add_filter '/vendor/bundle/'
+  end
 end
 
 Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|

data/spec/spec_spec.rb

@@ -4,23 +4,22 @@ require 'spec_helper'
 require 'tmpdir'
 require 'English'
 
-describe 'Transpec project spec', :do_not_run_in_transpeced_spec do
-  around do |example|
+describe 'Transpec project spec', :do_not_run_in_converted_spec do
+  copied_project_root = Dir.mktmpdir
+
+  before(:all) do
+    project_root = File.expand_path('..', File.dirname(__FILE__))
     Dir.chdir(project_root) do
-      example.run
+      FileUtils.cp_r(Dir['*'], copied_project_root)
     end
   end
 
-  let(:project_root) do
-    File.expand_path('..', File.dirname(__FILE__))
-  end
-
-  let(:spec_dir) do
-    File.join(project_root, 'spec')
+  around do |example|
+    Dir.chdir(copied_project_root) do
+      example.run
+    end
   end
 
-  TRANSPECED_SPEC_DIR = File.join(Dir.mktmpdir, 'transpeced_spec')
-
   def silent_system(*args)
     original_env = ENV.to_hash
 
@@ -40,15 +39,13 @@ describe 'Transpec project spec', :do_not_run_in_transpeced_spec do
   end
 
   it 'can be converted by Transpec itself without error' do
-    FileUtils.cp_r(spec_dir, TRANSPECED_SPEC_DIR)
-    silent_system('./bin/transpec', '--force', TRANSPECED_SPEC_DIR).should be_true
+    silent_system('./bin/transpec', '--force').should be_true
   end
 
   describe 'converted spec' do
     it 'passes all' do
-      pending 'Need to rewrite syntax configuration in RSpec.configure'
-      env = { 'TRANSPECED_SPEC' => 'true' }
-      silent_system(env, 'rspec', TRANSPECED_SPEC_DIR).should be_true
+      env = { 'TRANSPEC_CONVERTED_SPEC' => 'true' }
+      silent_system(env, 'rspec').should be_true
     end
   end
 end

data/spec/support/shared_context.rb

@@ -46,21 +46,8 @@ end
 shared_context 'isolated environment' do
   around do |example|
     Dir.mktmpdir do |tmpdir|
-      original_home = ENV['HOME']
-
-      begin
-        virtual_home = File.expand_path(File.join(tmpdir, 'home'))
-        Dir.mkdir(virtual_home)
-        ENV['HOME'] = virtual_home
-
-        working_dir = File.join(tmpdir, 'work')
-        Dir.mkdir(working_dir)
-
-        Dir.chdir(working_dir) do
-          example.run
-        end
-      ensure
-        ENV['HOME'] = original_home
+      Dir.chdir(tmpdir) do
+        example.run
       end
     end
   end

data/spec/transpec/git_spec.rb

@@ -7,13 +7,6 @@ module Transpec
   describe Git do
     include_context 'isolated environment'
 
-    if ENV['TRAVIS']
-      before do
-        system('git config --global user.email "you@example.com"')
-        system('git config --global user.name "Your Name"')
-      end
-    end
-
     describe '.command_available?' do
       subject { Git.command_available? }
 

data/spec/transpec/rewriter_spec.rb

@@ -29,6 +29,16 @@ module Transpec
 
       let(:source) do
         <<-END
+          RSpec.configure do |config|
+            config.expect_with :rspec do |c|
+              c.syntax = :should
+            end
+
+            config.mock_with :rspec do |c|
+              c.syntax = :should
+            end
+          end
+
           describe 'example group' do
             it 'is an example' do
               something = mock('something')
@@ -41,10 +51,10 @@ module Transpec
         END
       end
 
-      context 'when the configuration #convert_to_expect_to_matcher? is true' do
+      context 'when Configuration#convert_to_expect_to_matcher? is true' do
         before { configuration.convert_to_expect_to_matcher = true }
 
-        context 'and configuration #negative_form_of_to is "not_to"' do
+        context 'and Configuration#negative_form_of_to is "not_to"' do
           before { configuration.negative_form_of_to = 'not_to' }
 
           it 'invokes Should#expectize! with "not_to"' do
@@ -53,7 +63,7 @@ module Transpec
           end
         end
 
-        context 'and configuration #negative_form_of_to is "to_not"' do
+        context 'and Configuration#negative_form_of_to is "to_not"' do
           before { configuration.negative_form_of_to = 'to_not' }
 
           it 'invokes Should#expectize! with "to_not"' do
@@ -62,7 +72,7 @@ module Transpec
           end
         end
 
-        context 'and configuration #parenthesize_matcher_arg is true' do
+        context 'and Configuration#parenthesize_matcher_arg is true' do
           before { configuration.parenthesize_matcher_arg = true }
 
           it 'invokes Should#expectize! with true as second argument' do
@@ -71,7 +81,7 @@ module Transpec
           end
         end
 
-        context 'and configuration #parenthesize_matcher_arg is false' do
+        context 'and Configuration#parenthesize_matcher_arg is false' do
           before { configuration.parenthesize_matcher_arg = false }
 
           it 'invokes Should#expectize! with false as second argument' do
@@ -81,7 +91,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #convert_to_expect_to_matcher? is false' do
+      context 'when Configuration#convert_to_expect_to_matcher? is false' do
         before { configuration.convert_to_expect_to_matcher = false }
 
         it 'does not invoke Should#expectize!' do
@@ -90,10 +100,10 @@ module Transpec
         end
       end
 
-      context 'when the configuration #convert_to_expect_to_receive? is true' do
+      context 'when Configuration#convert_to_expect_to_receive? is true' do
         before { configuration.convert_to_expect_to_receive = true }
 
-        context 'and configuration #negative_form_of_to is "not_to"' do
+        context 'and Configuration#negative_form_of_to is "not_to"' do
           before { configuration.negative_form_of_to = 'not_to' }
 
           it 'invokes ShouldReceive#expectize! with "not_to"' do
@@ -102,7 +112,7 @@ module Transpec
           end
         end
 
-        context 'and configuration #negative_form_of_to is "to_not"' do
+        context 'and Configuration#negative_form_of_to is "to_not"' do
           before { configuration.negative_form_of_to = 'to_not' }
 
           it 'invokes ShouldReceive#expectize! with "to_not"' do
@@ -112,7 +122,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #convert_to_expect_to_receive? is false' do
+      context 'when Configuration#convert_to_expect_to_receive? is false' do
         before { configuration.convert_to_expect_to_receive = false }
 
         it 'does not invoke ShouldReceive#expectize!' do
@@ -121,7 +131,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #convert_to_allow_to_receive? is true' do
+      context 'when Configuration#convert_to_allow_to_receive? is true' do
         before { configuration.convert_to_allow_to_receive = true }
 
         it 'invokes MethodStub#allowize!' do
@@ -130,7 +140,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #convert_to_allow_to_receive? is false' do
+      context 'when Configuration#convert_to_allow_to_receive? is false' do
         before { configuration.convert_to_allow_to_receive = false }
 
         it 'does not invoke MethodStub#allowize!' do
@@ -139,7 +149,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #replace_deprecated_method? is true' do
+      context 'when Configuration#replace_deprecated_method? is true' do
         before { configuration.replace_deprecated_method = true }
 
         it 'invokes Double#convert_to_double!' do
@@ -153,7 +163,7 @@ module Transpec
         end
       end
 
-      context 'when the configuration #replace_deprecated_method? is true' do
+      context 'when Configuration#replace_deprecated_method? is true' do
         before { configuration.replace_deprecated_method = false }
 
         it 'does not invoke Double#convert_to_double!' do
@@ -167,6 +177,52 @@ module Transpec
         end
       end
 
+      context 'when #need_to_modify_expectation_syntax_configuration? returns true' do
+        before do
+          rewriter.stub(:need_to_modify_expectation_syntax_configuration?).and_return(true)
+        end
+
+        it 'invokes RSpecConfigure#modify_expectation_syntaxes! with :expect' do
+          Syntax::RSpecConfigure.any_instance
+            .should_receive(:modify_expectation_syntaxes!).with(:expect)
+          rewriter.rewrite(source)
+        end
+      end
+
+      context 'when #need_to_modify_expectation_syntax_configuration? returns false' do
+        before do
+          rewriter.stub(:need_to_modify_expectation_syntax_configuration?).and_return(false)
+        end
+
+        it 'does not invoke RSpecConfigure#modify_expectation_syntaxes!' do
+          Syntax::RSpecConfigure.any_instance.should_not_receive(:modify_expectation_syntaxes!)
+          rewriter.rewrite(source)
+        end
+      end
+
+      context 'when #need_to_modify_mock_syntax_configuration? returns true' do
+        before do
+          rewriter.stub(:need_to_modify_mock_syntax_configuration?).and_return(true)
+        end
+
+        it 'invokes RSpecConfigure#modify_mock_syntaxes! with :expect' do
+          Syntax::RSpecConfigure.any_instance
+            .should_receive(:modify_mock_syntaxes!).with(:expect)
+          rewriter.rewrite(source)
+        end
+      end
+
+      context 'when #need_to_modify_mock_syntax_configuration? returns false' do
+        before do
+          rewriter.stub(:need_to_modify_mock_syntax_configuration?).and_return(false)
+        end
+
+        it 'does not invoke RSpecConfigure#modify_mock_syntaxes!' do
+          Syntax::RSpecConfigure.any_instance.should_not_receive(:modify_mock_syntaxes!)
+          rewriter.rewrite(source)
+        end
+      end
+
       context 'when the source have overlapped rewrite targets' do
         let(:source) do
           <<-END
@@ -229,5 +285,103 @@ module Transpec
         end
       end
     end
+
+    shared_examples 'syntaxes' do |syntaxes_reader, expectations|
+      expectations.each do |current_syntaxes, return_value|
+        context "and RSpecConfigure##{syntaxes_reader} returns #{current_syntaxes.inspect}" do
+          before do
+            rspec_configure.stub(syntaxes_reader).and_return(current_syntaxes)
+          end
+
+          it "returns #{return_value}" do
+            should == return_value
+          end
+        end
+      end
+    end
+
+    describe '#need_to_modify_expectation_syntax_configuration?' do
+      subject { rewriter.need_to_modify_expectation_syntax_configuration?(rspec_configure) }
+      let(:rspec_configure) { double('rspec_configure') }
+
+      context 'when Configuration#convert_to_expect_to_matcher? is true' do
+        before { configuration.convert_to_expect_to_matcher = true }
+
+        include_examples 'syntaxes', :expectation_syntaxes, {
+          []                 => false,
+          [:should]          => true,
+          [:expect]          => false,
+          [:should, :expect] => false
+        }
+      end
+
+      context 'when Configuration#convert_to_expect_to_matcher? is false' do
+        before { configuration.convert_to_expect_to_matcher = false }
+
+        include_examples 'syntaxes', :expectation_syntaxes, {
+          []                 => false,
+          [:should]          => false,
+          [:expect]          => false,
+          [:should, :expect] => false
+        }
+      end
+    end
+
+    describe '#need_to_modify_mock_syntax_configuration?' do
+      subject { rewriter.need_to_modify_mock_syntax_configuration?(rspec_configure) }
+      let(:rspec_configure) { double('rspec_configure') }
+
+      context 'when Configuration#convert_to_expect_to_receive? is true' do
+        before { configuration.convert_to_expect_to_receive = true }
+
+        context 'and Configuration#convert_to_allow_to_receive? is true' do
+          before { configuration.convert_to_allow_to_receive = true }
+
+          include_examples 'syntaxes', :mock_syntaxes, {
+            []                 => false,
+            [:should]          => true,
+            [:expect]          => false,
+            [:should, :expect] => false
+          }
+        end
+
+        context 'and Configuration#convert_to_allow_to_receive? is false' do
+          before { configuration.convert_to_allow_to_receive = false }
+
+          include_examples 'syntaxes', :mock_syntaxes, {
+            []                 => false,
+            [:should]          => true,
+            [:expect]          => false,
+            [:should, :expect] => false
+          }
+        end
+      end
+
+      context 'when Configuration#convert_to_expect_to_receive? is false' do
+        before { configuration.convert_to_expect_to_receive = false }
+
+        context 'and Configuration#convert_to_allow_to_receive? is true' do
+          before { configuration.convert_to_allow_to_receive = true }
+
+          include_examples 'syntaxes', :mock_syntaxes, {
+            []                 => false,
+            [:should]          => true,
+            [:expect]          => false,
+            [:should, :expect] => false
+          }
+        end
+
+        context 'and Configuration#convert_to_allow_to_receive? is false' do
+          before { configuration.convert_to_allow_to_receive = false }
+
+          include_examples 'syntaxes', :mock_syntaxes, {
+            []                 => false,
+            [:should]          => false,
+            [:expect]          => false,
+            [:should, :expect] => false
+          }
+        end
+      end
+    end
   end
 end

data/spec/transpec/syntax/matcher_spec.rb

@@ -133,6 +133,28 @@ module Transpec
           end
         end
 
+        context 'when it is `== (2 - 1)` form' do
+          let(:source) do
+            <<-END
+              it 'is 1' do
+                subject.should == (2 - 1)
+              end
+            END
+          end
+
+          let(:expected_source) do
+            <<-END
+              it 'is 1' do
+                subject.should eq(2 - 1)
+              end
+            END
+          end
+
+          it 'converts into `eq(2 - 1)` form without superfluous parentheses' do
+            rewritten_source.should == expected_source
+          end
+        end
+
         context "when it is `== { 'key' => 'value' }` form" do
           let(:source) do
             <<-END

data/spec/transpec/syntax/rspec_configure_spec.rb

@@ -0,0 +1,161 @@
+# coding: utf-8
+
+require 'spec_helper'
+require 'transpec/syntax/rspec_configure'
+
+module Transpec
+  class Syntax
+    describe RSpecConfigure do
+      include_context 'parsed objects'
+
+      subject(:rspec_configure) do
+        AST::Scanner.scan(ast) do |node, ancestor_nodes|
+          next unless RSpecConfigure.target_node?(node)
+          return RSpecConfigure.new(
+            node,
+            ancestor_nodes,
+            in_example_group_context?,
+            source_rewriter
+          )
+        end
+        fail 'No RSpec.configure node is found!'
+      end
+
+      let(:in_example_group_context?) { true }
+
+      [
+        [:expectation_syntaxes, :expect_with, 'RSpec::Matchers::Configuration'],
+        [:mock_syntaxes,        :mock_with,   'RSpec::Mocks::Configuration']
+      ].each do |subject_method, config_block_method, framework_config_class|
+        describe "##{subject_method}" do
+          subject { rspec_configure.send(subject_method) }
+
+          context 'when :should is enabled' do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{config_block_method} :rspec do |c|
+                    c.syntax = :should
+                  end
+                end
+              END
+            end
+
+            it 'returns [:should]' do
+              should == [:should]
+            end
+          end
+
+          context 'when :should and :expect are enabled' do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{config_block_method} :rspec do |c|
+                    c.syntax = [:should, :expect]
+                  end
+                end
+              END
+            end
+
+            it 'returns [:should, :expect]' do
+              should == [:should, :expect]
+            end
+          end
+
+          context "when RSpec::Core::Configuration##{config_block_method} block does not exist" do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                end
+              END
+            end
+
+            it 'returns empty array' do
+              should == []
+            end
+          end
+
+          context "when #{framework_config_class}#syntax= does not exist" do
+            let(:source) do
+              <<-END
+                RSpec.configure do |config|
+                  config.#{config_block_method} :rspec do |c|
+                  end
+                end
+              END
+            end
+
+            it 'returns empty array' do
+              should == []
+            end
+          end
+        end
+      end
+
+      [
+        [:modify_expectation_syntaxes!, :expect_with, 'RSpec::Matchers::Configuration'],
+        [:modify_mock_syntaxes!,        :mock_with,   'RSpec::Mocks::Configuration']
+      ].each do |subject_method, config_block_method, framework_config_class|
+        describe "##{subject_method}" do
+          before do
+            rspec_configure.send(subject_method, syntaxes)
+          end
+
+          let(:source) do
+            <<-END
+              RSpec.configure do |config|
+                config.#{config_block_method} :rspec do |c|
+                  c.syntax = :should
+                end
+              end
+            END
+          end
+
+          context 'when :expect is passed' do
+            let(:syntaxes) { :expect }
+
+            let(:expected_source) do
+            <<-END
+              RSpec.configure do |config|
+                config.#{config_block_method} :rspec do |c|
+                  c.syntax = :expect
+                end
+              end
+            END
+            end
+
+            it 'rewrites syntax specification to `c.syntax = :expect`' do
+              rewritten_source.should == expected_source
+            end
+          end
+
+          context 'when [:should, :expect] is passed' do
+            let(:syntaxes) { [:should, :expect] }
+
+            let(:expected_source) do
+            <<-END
+              RSpec.configure do |config|
+                config.#{config_block_method} :rspec do |c|
+                  c.syntax = [:should, :expect]
+                end
+              end
+            END
+            end
+
+            it 'rewrites syntax specification to `c.syntax = [:should, :expect]`' do
+              rewritten_source.should == expected_source
+            end
+          end
+
+          context 'when RSpec::Core::Configuration#expect_with block does not exist' do
+            pending
+          end
+
+          context "when #{framework_config_class}#syntax= does not exist" do
+            pending
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transpec
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Yuji Nakayama
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-28 00:00:00.000000000 Z
+date: 2013-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -183,6 +183,7 @@ files:
 - lib/transpec/syntax/expectizable.rb
 - lib/transpec/syntax/matcher.rb
 - lib/transpec/syntax/method_stub.rb
+- lib/transpec/syntax/rspec_configure.rb
 - lib/transpec/syntax/send_node_syntax.rb
 - lib/transpec/syntax/should.rb
 - lib/transpec/syntax/should_receive.rb
@@ -203,6 +204,7 @@ files:
 - spec/transpec/syntax/double_spec.rb
 - spec/transpec/syntax/matcher_spec.rb
 - spec/transpec/syntax/method_stub_spec.rb
+- spec/transpec/syntax/rspec_configure_spec.rb
 - spec/transpec/syntax/should_receive_spec.rb
 - spec/transpec/syntax/should_spec.rb
 - spec/transpec/util_spec.rb
@@ -247,6 +249,7 @@ test_files:
 - spec/transpec/syntax/double_spec.rb
 - spec/transpec/syntax/matcher_spec.rb
 - spec/transpec/syntax/method_stub_spec.rb
+- spec/transpec/syntax/rspec_configure_spec.rb
 - spec/transpec/syntax/should_receive_spec.rb
 - spec/transpec/syntax/should_spec.rb
 - spec/transpec/util_spec.rb