transmission-rpc-ruby 0.1.0 → 0.2.0

data/spec/transmission/model/torrent_spec.rb

@@ -143,4 +143,86 @@ describe Transmission::Model::Torrent do
 
   end
 
+  describe '#method_missing' do
+    let(:torrent) { Transmission::Model::Torrent.new({'id' => 1, 'name' => 'some name', 'some-key' => 'some-value'}, nil) }
+
+    before :each do
+      stub_const("Transmission::Fields::TorrentGet::ATTRIBUTES", [{field: 'id'}, {field: 'name'}, {field: 'some-key'}])
+      stub_const("Transmission::Arguments::TorrentSet::ATTRIBUTES", [{field: 'name'}])
+    end
+
+    describe 'with existing attributes' do
+      it 'should return the correct values' do
+        expect(torrent.id).to eq(1)
+        expect(torrent.name).to eq('some name')
+        expect(torrent.some_key).to eq('some-value')
+      end
+
+      it 'should set the correct values' do
+        torrent.name = 'ok'
+        expect(torrent.name).to eq('ok')
+      end
+    end
+
+    describe 'with none existing attributes' do
+      it 'should raise error' do
+        expect {
+          torrent.i_dont_exist
+        }.to raise_error(NoMethodError)
+      end
+
+      it 'should raise error' do
+        expect {
+          torrent.i_dont_exist = 'some value'
+        }.to raise_error(NoMethodError)
+      end
+    end
+  end
+
+  describe '#save!' do
+    let(:rpc) {Transmission::RPC.new}
+
+    before :each do
+      stub_const("Transmission::Arguments::TorrentSet::ATTRIBUTES", [{field: 'name'}, {field: 'ids'}])
+      stub_get_torrent({ids: [1]}, [{id: 1, name: 'test', comment: 'comment'}])
+      stub_rpc_request
+          .with(body: torrent_set_body({name: 'new value', ids: [1]}))
+          .to_return(successful_response)
+    end
+
+    it 'should send the right parameters' do
+      torrent = Transmission::Model::Torrent.find 1, connector: rpc
+      torrent.name = 'new value'
+      torrent.save!
+    end
+  end
+
+  [
+      {method: 'start!', rpc_method: 'torrent-start'},
+      {method: 'start_now!', rpc_method: 'torrent-start-now'},
+      {method: 'stop!', rpc_method: 'torrent-stop'},
+      {method: 'verify!', rpc_method: 'torrent-verify'},
+      {method: 're_announce!', rpc_method: 'torrent-reannounce'},
+      {method: 'move_up!', rpc_method: 'queue-move-up'},
+      {method: 'move_down!', rpc_method: 'queue-move-down'},
+      {method: 'move_top!', rpc_method: 'queue-move-top'},
+      {method: 'move_bottom!', rpc_method: 'queue-move-bottom'}
+  ].each do |object|
+    describe "##{object[:method]}" do
+      let(:rpc) {Transmission::RPC.new}
+
+      before :each do
+        stub_get_torrent({ids: [1]}, [{id: 1}])
+        stub_rpc_request
+            .with(body: torrent_method_body(object[:rpc_method], {ids: [1]}))
+            .to_return(successful_response)
+      end
+
+      it "should #{object[:method]} torrent" do
+        torrent = Transmission::Model::Torrent.find 1, connector: rpc
+        torrent.send object[:method].to_sym
+      end
+    end
+  end
+
 end

data/spec/transmission/rpc/connector_spec.rb

@@ -39,12 +39,13 @@ describe Transmission::RPC::Connector do
         @connector = Transmission::RPC::Connector.new
         stub_rpc_request
             .to_return(conflict_response({headers: {'x-transmission-session-id' => 'abc'}}))
+        stub_rpc_request
+            .with(headers: {'x-transmission-session-id' => 'abc'})
+            .to_return(successful_response)
       end
 
       it 'should save the transmission session ID' do
-        expect {
-          @connector.post
-        }.to raise_error(Transmission::RPC::Connector::InvalidSessionError)
+        @connector.post
         expect(@connector.session_id).to eq('abc')
       end
     end

data/spec/transmission/rpc_spec.rb

@@ -1,29 +1,26 @@
 describe Transmission::RPC do
 
   describe '#get_session' do
-
     describe 'with fields' do
-
       before :each do
         @rpc = Transmission::RPC.new
-        fields = Transmission::Arguments::SessionGet.new(['version']).to_arguments
+        fields = Transmission::Fields::SessionGet.new(['version']).to_fields
         stub_rpc_request
             .with({body: session_get_body({fields: fields})})
             .to_return(successful_response)
       end
 
       it 'should send the proper arguments' do
-        @rpc.get_session fields: ['version']
+        @rpc.get_session ['version']
         expect(@rpc.connector.response.status).to eq(200)
       end
 
     end
 
     describe 'without fields' do
-
       before :each do
         @rpc = Transmission::RPC.new
-        fields = Transmission::Arguments::SessionGet.new.to_arguments
+        fields = Transmission::Fields::SessionGet.new.to_fields
         stub_rpc_request
             .with({body: session_get_body({fields: fields})})
             .to_return(successful_response)
@@ -33,9 +30,7 @@ describe Transmission::RPC do
         @rpc.get_session
         expect(@rpc.connector.response.status).to eq(200)
       end
-
     end
-
   end
 
 end

data/spec/transmission/utils_spec.rb

@@ -0,0 +1,70 @@
+describe Transmission::Utils do
+  let(:utils) {
+    Class.new do
+      include Transmission::Utils
+    end
+  }
+
+  subject { utils.new }
+
+  describe '.is_valid_key?' do
+    describe 'with dashes' do
+      let(:arguments) {[{field: 'test-me'}]}
+
+      it 'should find valid key' do
+        expect(subject.is_valid_key?('test_me', arguments)).to eq(true)
+      end
+    end
+
+    describe 'with camelcase' do
+      let(:arguments) {[{field: 'testMe'}]}
+
+      it 'should find valid key' do
+        expect(subject.is_valid_key?('test_me', arguments)).to eq(true)
+      end
+    end
+
+    describe 'with invalid key' do
+      let(:arguments) {[{field: 'testMe'}]}
+
+      it 'should not find any key' do
+        expect(subject.is_valid_key?('i_dont_exit', arguments)).to eq(false)
+      end
+    end
+  end
+
+  describe '.option_keys' do
+    it 'should return the right option keys' do
+      options = subject.option_keys('test_me')
+      expect(options.include?('testMe')).to eq(true)
+      expect(options.include?('test-me')).to eq(true)
+    end
+  end
+
+  describe '.option_key' do
+    describe 'with dashes' do
+      let(:arguments) {[{field: 'test-me'}]}
+
+      it 'should return the correct key' do
+        expect(subject.option_key('test_me', arguments)).to eq('test-me')
+      end
+    end
+
+    describe 'with camelcase' do
+      let(:arguments) {[{field: 'testMe'}]}
+
+      it 'should return the correct key' do
+        expect(subject.option_key('test_me', arguments)).to eq('testMe')
+      end
+    end
+
+    describe 'with invalid key' do
+      let(:arguments) {[{field: 'testMe'}]}
+
+      it 'should return nil' do
+        expect(subject.option_key('i_dont_exit', arguments)).to eq(nil)
+      end
+    end
+  end
+
+end

data/transmission-rpc-ruby.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = 'transmission-rpc-ruby'
-  s.version     = '0.1.0'
+  s.version     = '0.2.0'
   s.date        = '2015-03-27'
   s.summary     = "Transmission RPC wrapper in Ruby"
   s.description = "A new transmission RPC wrapper for Ruby. All object oriented for controlling remote transmission daemons."
@@ -13,5 +13,5 @@ Gem::Specification.new do |s|
   s.add_dependency "faraday", "~> 0.9"
   s.add_development_dependency "rake", "~> 10.4"
   s.add_development_dependency "rspec", "~> 3.2"
-  s.add_development_dependency "webmock", "~> 1.20"
+  s.add_development_dependency "webmock", "~> 1.21"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: transmission-rpc-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Max Hoffmann
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.20'
+        version: '1.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.20'
+        version: '1.21'
 description: A new transmission RPC wrapper for Ruby. All object oriented for controlling
   remote transmission daemons.
 email: tsov@me.com
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -82,24 +83,30 @@ files:
 - Rakefile
 - lib/transmission.rb
 - lib/transmission/arguments.rb
-- lib/transmission/arguments/session_get.rb
 - lib/transmission/arguments/session_set.rb
-- lib/transmission/arguments/session_stats.rb
 - lib/transmission/arguments/torrent_add.rb
-- lib/transmission/arguments/torrent_get.rb
 - lib/transmission/arguments/torrent_set.rb
 - lib/transmission/config.rb
+- lib/transmission/fields.rb
+- lib/transmission/fields/session_get.rb
+- lib/transmission/fields/session_stats.rb
+- lib/transmission/fields/torrent_get.rb
 - lib/transmission/model.rb
 - lib/transmission/model/session.rb
+- lib/transmission/model/session_stats.rb
 - lib/transmission/model/torrent.rb
 - lib/transmission/rpc.rb
 - lib/transmission/rpc/connector.rb
+- lib/transmission/utils.rb
 - spec/helpers/stubs.rb
 - spec/spec_helper.rb
 - spec/transmission/arguments_spec.rb
+- spec/transmission/fields_spec.rb
+- spec/transmission/model/session_spec.rb
 - spec/transmission/model/torrent_spec.rb
 - spec/transmission/rpc/connector_spec.rb
 - spec/transmission/rpc_spec.rb
+- spec/transmission/utils_spec.rb
 - transmission-rpc-ruby.gemspec
 homepage: https://github.com/transmission-rails/transmission-rpc-ruby
 licenses:

data/lib/transmission/arguments/session_get.rb

@@ -1,63 +0,0 @@
-module Transmission
-  class Arguments
-    class SessionGet < Transmission::Arguments
-
-      ATTRIBUTES = [
-          'alt-speed-down',
-          'alt-speed-enabled',
-          'alt-speed-time-begin',
-          'alt-speed-time-enabled',
-          'alt-speed-time-end',
-          'alt-speed-time-day',
-          'alt-speed-up',
-          'blocklist-url',
-          'blocklist-update',
-          'blocklist-enabled',
-          'blocklist-size',
-          'cache-size-mb',
-          'config-dir',
-          'download-dir',
-          'download-queue-size',
-          'download-queue-enabled',
-          'dht-enabled',
-          'encryption',
-          'required',
-          'preferred',
-          'tolerated',
-          'idle-seeding-limit',
-          'idle-seeding-limit-enabled',
-          'incomplete-dir',
-          'incomplete-dir-enabled',
-          'lpd-enabled',
-          'peer-limit-global',
-          'peer-limit-per-torrent',
-          'pex-enabled',
-          'peer-port',
-          'peer-port-random-on-start',
-          'port-forwarding-enabled',
-          'queue-stalled-enabled',
-          'queue-stalled-minutes',
-          'rename-partial-files',
-          'rpc-version',
-          'rpc-version-minimum',
-          'script-torrent-done-filename',
-          'script-torrent-done-enabled',
-          'done',
-          'seedRatioLimit',
-          'seedRatioLimited',
-          'seed-queue-size',
-          'seed-queue-enabled',
-          'speed-limit-down',
-          'speed-limit-down-enabled',
-          'speed-limit-up',
-          'speed-limit-up-enabled',
-          'start-added-torrents',
-          'trash-original-torrent-files',
-          'units',
-          'utp-enabled',
-          'version'
-      ]
-
-    end
-  end
-end

data/lib/transmission/arguments/session_stats.rb

@@ -1,17 +0,0 @@
-module Transmission
-  class Arguments
-    class SessionStats < Transmission::Arguments
-
-      ATTRIBUTES = [
-          'activeTorrentCount',
-          'downloadSpeed',
-          'pausedTorrentCount',
-          'torrentCount',
-          'uploadSpeed',
-          'cumulative-stats',
-          'current-stats'
-      ]
-
-    end
-  end
-end

data/lib/transmission/arguments/torrent_get.rb

@@ -1,78 +0,0 @@
-module Transmission
-  class Arguments
-    class TorrentGet < Transmission::Arguments
-
-      ATTRIBUTES = [
-          'id',
-          'activityDate',
-          'addedDate',
-          'bandwidthPriority',
-          'comment',
-          'corruptEver',
-          'creator',
-          'dateCreated',
-          'desiredAvailable',
-          'doneDate',
-          'downloadDir',
-          'downloadedEver',
-          'downloadLimit',
-          'downloadLimited',
-          'error',
-          'errorString',
-          'eta',
-          'etaIdle',
-          'files',
-          'fileStats',
-          'hashString',
-          'haveUnchecked',
-          'haveValid',
-          'honorsSessionLimits',
-          'isFinished',
-          'isPrivate',
-          'isStalled',
-          'leftUntilDone',
-          'magnetLink',
-          'manualAnnounceTime',
-          'maxConnectedPeers',
-          'metadataPercentComplete',
-          'name',
-          'peer-limit',
-          'peers',
-          'peersConnected',
-          'peersFrom',
-          'peersGettingFromUs',
-          'peersSendingToUs',
-          'percentDone',
-          'pieces',
-          'pieceCount',
-          'pieceSize',
-          'priorities',
-          'queuePosition',
-          'rateDownload',
-          'rateUpload',
-          'recheckProgress',
-          'secondsDownloading',
-          'secondsSeeding',
-          'seedIdleLimit',
-          'seedIdleMode',
-          'seedRatioLimit',
-          'seedRatioMode',
-          'sizeWhenDone',
-          'startDate',
-          'status',
-          'trackers',
-          'trackerStats',
-          'totalSize',
-          'torrentFile',
-          'uploadedEver',
-          'uploadLimit',
-          'uploadLimited',
-          'uploadRatio',
-          'wanted',
-          'webseeds',
-          'webseedsSendingToUs'
-      ]
-
-    end
-  end
-end