transloadit 2.0.1 → 3.0.0

data/test/unit/transloadit/test_response.rb

@@ -1,170 +1,170 @@
-require 'test_helper'
+require "test_helper"
 
 describe Transloadit::Response do
-  REQUEST_URI = 'http://api2.jane.transloadit.com/assemblies/76fe5df1c93a0a530f3e583805cf98b4'
+  request_uri = "https://api2.jane.transloadit.com/assemblies/76fe5df1c93a0a530f3e583805cf98b4"
 
-  it 'must allow delegate initialization' do
-    response = Transloadit::Response.new('test')
-    response.class.must_equal Transloadit::Response
+  it "must allow delegate initialization" do
+    response = Transloadit::Response.new("test")
+    _(response.class).must_equal Transloadit::Response
   end
 
-  describe 'when initialized' do
+  describe "when initialized" do
     before do
-      VCR.use_cassette 'fetch_assembly_ok' do
+      VCR.use_cassette "fetch_assembly_ok" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         )
       end
     end
 
-    it 'must parse the body' do
-      @response.body.must_be_kind_of Hash
+    it "must parse the body" do
+      _(@response.body).must_be_kind_of Hash
     end
 
-    it 'must allow access to body attributes' do
-      %w{ ok message assembly_id assembly_url }.each do |attribute|
-        @response[attribute].must_equal @response.body[attribute]
+    it "must allow access to body attributes" do
+      %w[ok message assembly_id assembly_ssl_url].each do |attribute|
+        _(@response[attribute]).must_equal @response.body[attribute]
       end
     end
 
-    it 'must allow access to body attributes as symbols' do
-      [:ok, :message, :assembly_id, :assembly_url].each do |attribute|
-        @response[attribute].must_equal @response.body[attribute.to_s]
+    it "must allow access to body attributes as symbols" do
+      [:ok, :message, :assembly_id, :assembly_ssl_url].each do |attribute|
+        _(@response[attribute]).must_equal @response.body[attribute.to_s]
       end
     end
 
-    it 'must inspect as the body' do
-      @response.inspect.must_equal @response.body.inspect
+    it "must inspect as the body" do
+      _(@response.inspect).must_equal @response.body.inspect
     end
   end
 
-  describe 'when extended as an assembly' do
+  describe "when extended as an assembly" do
     before do
-      VCR.use_cassette 'fetch_assembly_ok' do
+      VCR.use_cassette "fetch_assembly_ok" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
     end
 
-    it 'must allow checking for completion' do
-      @response.completed?.must_equal true
-      @response.finished?.must_equal true
-      @response.error?.must_equal false
+    it "must allow checking for completion" do
+      _(@response.completed?).must_equal true
+      _(@response.finished?).must_equal true
+      _(@response.error?).must_equal false
     end
 
     # TODO: can this be tested better?
-    it 'must allow reloading the assembly' do
-      VCR.use_cassette 'fetch_assembly_ok', :allow_playback_repeats => true do
-        @response.send(:__getobj__).
-          wont_be_same_as @response.reload!.send(:__getobj__)
+    it "must allow reloading the assembly" do
+      VCR.use_cassette "fetch_assembly_ok", allow_playback_repeats: true do
+        _(@response.send(:__getobj__))
+          .wont_be_same_as @response.reload!.send(:__getobj__)
 
-        @response.object_id.
-          must_equal @response.reload!.object_id
+        _(@response.object_id)
+          .must_equal @response.reload!.object_id
       end
     end
 
-    it 'must allow canceling' do
-      VCR.use_cassette 'cancel_assembly' do
+    it "must allow canceling" do
+      VCR.use_cassette "cancel_assembly" do
         @response.cancel!
 
-        @response.completed?.must_equal false
-        @response['ok']     .must_equal 'ASSEMBLY_CANCELED'
-        @response.canceled?.must_equal true
-        @response.finished?.must_equal true
+        _(@response.completed?).must_equal false
+        _(@response["ok"]).must_equal "ASSEMBLY_CANCELED"
+        _(@response.canceled?).must_equal true
+        _(@response.finished?).must_equal true
       end
     end
   end
 
-  describe 'long-running assembly' do
+  describe "long-running assembly" do
     before do
-      VCR.use_cassette 'fetch_assembly_executing' do
+      VCR.use_cassette "fetch_assembly_executing" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
     end
 
-    it 'must allow reloading until finished' do
-      @response.finished?.must_equal false
+    it "must allow reloading until finished" do
+      _(@response.finished?).must_equal false
 
-      VCR.use_cassette 'fetch_assembly_ok' do
-        VCR.use_cassette 'fetch_assembly_executing' do
+      VCR.use_cassette "fetch_assembly_ok" do
+        VCR.use_cassette "fetch_assembly_executing" do
           @response.reload_until_finished!
         end
       end
 
-      @response.finished?.must_equal true
+      _(@response.finished?).must_equal true
     end
 
-    it 'must raise exception if reload until finished tries exceeded' do
+    it "must raise exception if reload until finished tries exceeded" do
       assert_raises Transloadit::Exception::ReloadLimitReached do
-        VCR.use_cassette 'fetch_assembly_executing', :allow_playback_repeats => true do
+        VCR.use_cassette "fetch_assembly_executing", allow_playback_repeats: true do
           @response.reload_until_finished! tries: 1
         end
       end
     end
   end
 
-  describe 'statuses' do
-    it 'must allow checking for upload' do
-      VCR.use_cassette 'fetch_assembly_uploading' do
+  describe "statuses" do
+    it "must allow checking for upload" do
+      VCR.use_cassette "fetch_assembly_uploading" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
 
-      @response.finished?.must_equal false
-      @response.uploading?.must_equal true
-      @response.error?.must_equal false
+      _(@response.finished?).must_equal false
+      _(@response.uploading?).must_equal true
+      _(@response.error?).must_equal false
     end
 
-    it 'must allow to check for executing' do
-      VCR.use_cassette 'fetch_assembly_executing' do
+    it "must allow to check for executing" do
+      VCR.use_cassette "fetch_assembly_executing" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
 
-      @response.finished?.must_equal false
-      @response.executing?.must_equal true
-      @response.error?.must_equal false
+      _(@response.finished?).must_equal false
+      _(@response.executing?).must_equal true
+      _(@response.error?).must_equal false
     end
 
-    it 'must allow to check for replaying' do
-      VCR.use_cassette 'replay_assembly' do
+    it "must allow to check for replaying" do
+      VCR.use_cassette "replay_assembly" do
         @response = Transloadit::Response.new(
           RestClient::Resource.new(
-            'http://api2.transloadit.com/assemblies/55c965a063a311e6ba2d379ef10b28f7/replay'
+            "https://api2.transloadit.com/assemblies/55c965a063a311e6ba2d379ef10b28f7/replay"
           ).post({})
         ).extend!(Transloadit::Response::Assembly)
       end
 
-      @response.finished?.must_equal false
-      @response.replaying?.must_equal true
-      @response.error?.must_equal false
+      _(@response.finished?).must_equal false
+      _(@response.replaying?).must_equal true
+      _(@response.error?).must_equal false
     end
 
-    it 'must allow to check for aborted' do
-      VCR.use_cassette 'fetch_assembly_aborted' do
+    it "must allow to check for aborted" do
+      VCR.use_cassette "fetch_assembly_aborted" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
 
-      @response.finished?.must_equal true
-      @response.aborted?.must_equal true
+      _(@response.finished?).must_equal true
+      _(@response.aborted?).must_equal true
     end
 
-    it 'must allow to check for errors' do
-      VCR.use_cassette 'fetch_assembly_errors' do
+    it "must allow to check for errors" do
+      VCR.use_cassette "fetch_assembly_errors" do
         @response = Transloadit::Response.new(
-          RestClient::Resource.new(REQUEST_URI).get
+          RestClient::Resource.new(request_uri).get
         ).extend!(Transloadit::Response::Assembly)
       end
 
-      @response.error?.must_equal true
-      @response.finished?.must_equal true
+      _(@response.error?).must_equal true
+      _(@response.finished?).must_equal true
     end
   end
 end

data/test/unit/transloadit/test_step.rb

@@ -1,97 +1,97 @@
-require 'test_helper'
+require "test_helper"
 
 describe Transloadit::Step do
-  it 'must allow initialization' do
-    Transloadit::Step.new('store', '/s3/store').
-      must_be_kind_of Transloadit::Step
+  it "must allow initialization" do
+    _(Transloadit::Step.new("store", "/s3/store"))
+      .must_be_kind_of Transloadit::Step
   end
 
-  describe 'when initialized' do
+  describe "when initialized" do
     before do
-      @name   = 'store'
-      @robot  = '/s3/store'
-      @key    = 'aws-access-key-id'
-      @secret = 'aws-secret-access-key'
-      @bucket = 's3-bucket-name'
+      @name = "store"
+      @robot = "/s3/store"
+      @key = "aws-access-key-id"
+      @secret = "aws-secret-access-key"
+      @bucket = "s3-bucket-name"
 
       @step = Transloadit::Step.new @name, @robot,
-        :key    => @key,
-        :secret => @secret,
-        :bucket => @bucket
+        key: @key,
+        secret: @secret,
+        bucket: @bucket
     end
 
-    it 'should use the name given' do
-      @step.name.must_equal @name
+    it "should use the name given" do
+      _(@step.name).must_equal @name
     end
 
-    it 'must remember the type' do
-      @step.robot.must_equal @robot
+    it "must remember the type" do
+      _(@step.robot).must_equal @robot
     end
 
-    it 'must remember the parameters' do
-      @step.options.must_equal(
-        :key    => @key,
-        :secret => @secret,
-        :bucket => @bucket
+    it "must remember the parameters" do
+      _(@step.options).must_equal(
+        key: @key,
+        secret: @secret,
+        bucket: @bucket
       )
     end
 
-    it 'must inspect like a hash' do
-      @step.inspect.must_equal @step.to_hash[@step.name].inspect
+    it "must inspect like a hash" do
+      _(@step.inspect).must_equal @step.to_hash[@step.name].inspect
     end
 
-    it 'must produce Transloadit-compatible hash output' do
-      @step.to_hash.must_equal(
+    it "must produce Transloadit-compatible hash output" do
+      _(@step.to_hash).must_equal(
         @step.name => {
-          :robot  => @robot,
-          :key    => @key,
-          :secret => @secret,
-          :bucket => @bucket
+          robot: @robot,
+          key: @key,
+          secret: @secret,
+          bucket: @bucket
         }
       )
     end
 
-    it 'must produce Transloadit-compatible JSON output' do
-      @step.to_json.must_equal MultiJson.dump(@step.to_hash)
+    it "must produce Transloadit-compatible JSON output" do
+      _(@step.to_json).must_equal MultiJson.dump(@step.to_hash)
     end
   end
 
-  describe 'when using alternative inputs' do
+  describe "when using alternative inputs" do
     before do
-      @step = Transloadit::Step.new 'resize', '/image/resize'
+      @step = Transloadit::Step.new "resize", "/image/resize"
     end
 
-    it 'must allow using the original file as input' do
-      @step.use(:original).must_equal ':original'
-      @step.options[:use] .must_equal ':original'
+    it "must allow using the original file as input" do
+      _(@step.use(:original)).must_equal ":original"
+      _(@step.options[:use]).must_equal ":original"
     end
 
-    it 'must allow using another step' do
-      input = Transloadit::Step.new 'thumbnail', '/video/thumbnail'
+    it "must allow using another step" do
+      input = Transloadit::Step.new "thumbnail", "/video/thumbnail"
 
-      @step.use(input).   must_equal [ input.name ]
-      @step.options[:use].must_equal [ input.name ]
+      _(@step.use(input)).must_equal [input.name]
+      _(@step.options[:use]).must_equal [input.name]
     end
 
-    it 'must allow using multiple steps' do
+    it "must allow using multiple steps" do
       inputs = [
-        Transloadit::Step.new('thumbnail', '/video/thumbnail'),
-        Transloadit::Step.new('resize',    '/image/resize')
+        Transloadit::Step.new("thumbnail", "/video/thumbnail"),
+        Transloadit::Step.new("resize", "/image/resize")
       ]
 
-      @step.use(inputs).  must_equal inputs.map {|i| i.name }
-      @step.options[:use].must_equal inputs.map {|i| i.name }
+      _(@step.use(inputs)).must_equal(inputs.map { |i| i.name })
+      _(@step.options[:use]).must_equal(inputs.map { |i| i.name })
     end
 
-    it 'must allow using nothing' do
+    it "must allow using nothing" do
       @step.use :original
-      @step.use(nil).must_equal nil
-      @step.options.keys.wont_include(:use)
+      assert_nil @step.use(nil)
+      _(@step.options.keys).wont_include(:use)
     end
 
-    it 'must include the used steps in the hash output' do
-      @step.use(:original).           must_equal ':original'
-      @step.to_hash[@step.name][:use].must_equal ':original'
+    it "must include the used steps in the hash output" do
+      _(@step.use(:original)).must_equal ":original"
+      _(@step.to_hash[@step.name][:use]).must_equal ":original"
     end
   end
 end

data/test/unit/transloadit/test_template.rb

@@ -1,116 +1,111 @@
-require 'test_helper'
+require "test_helper"
 
 describe Transloadit::Template do
-
-  it 'must inherit from Transloadit::ApiModel class' do
-    (Transloadit::Template < Transloadit::ApiModel).must_equal true
+  it "must inherit from Transloadit::ApiModel class" do
+    _(Transloadit::Template < Transloadit::ApiModel).must_equal true
   end
 
-  describe 'using template API methods' do
+  describe "using template API methods" do
     include WebMock::API
 
     before do
       WebMock.reset!
-      @transloadit = Transloadit.new(:key => '')
+      @transloadit = Transloadit.new(key: "")
       @template = Transloadit::Template.new @transloadit
     end
 
-    it 'must allow to create new template' do
-      VCR.use_cassette 'create_template' do
+    it "must allow to create new template" do
+      VCR.use_cassette "create_template" do
         response = @template.create(
           {
-            :name => 'foo',
-            :template => {'key' => 'value'}
+            name: "foo",
+            template: {"key" => "value"}
           }
         )
-        response['ok'].must_equal 'TEMPLATE_CREATED'
-        response['template_name'].must_equal 'foo'
-        response['template_content']['key'].must_equal 'value'
+        _(response["ok"]).must_equal "TEMPLATE_CREATED"
+        _(response["template_name"]).must_equal "foo"
+        _(response["template_content"]["key"]).must_equal "value"
       end
     end
 
-    describe 'when fetching all templates' do
-
-      it 'must perform GET request to /templates' do
-        stub = stub_request(:get, 'api2.transloadit.com/templates?params=%7B%22auth%22:%7B%22key%22:%22%22%7D%7D')
+    describe "when fetching all templates" do
+      it "must perform GET request to /templates" do
+        stub = stub_request(:get, "https://api2.transloadit.com/templates?params=%7B%22auth%22:%7B%22key%22:%22%22%7D%7D")
         @template.list
 
         assert_requested(stub)
       end
 
-      it 'must return a list of items' do
-        VCR.use_cassette 'fetch_templates' do
+      it "must return a list of items" do
+        VCR.use_cassette "fetch_templates" do
           response = @template.list
 
-          response['items'].must_equal []
-          response['count'].must_equal 0
+          _(response["items"]).must_equal []
+          _(response["count"]).must_equal 0
         end
       end
     end
 
-    describe 'when fetching single template' do
-
-      it 'must perform GET request to /templates/[id]' do
+    describe "when fetching single template" do
+      it "must perform GET request to /templates/[id]" do
         stub = stub_request(
           :get,
-          'api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4?params=%7B%22auth%22:%7B%22key%22:%22%22%7D%7D'
+          "https://api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4?params=%7B%22auth%22:%7B%22key%22:%22%22%7D%7D"
         )
-        @template.get '76fe5df1c93a0a530f3e583805cf98b4'
+        @template.get "76fe5df1c93a0a530f3e583805cf98b4"
 
         assert_requested(stub)
       end
 
-      it 'must get template with specified id' do
-        VCR.use_cassette 'fetch_template' do
-          response = @template.get '76fe5df1c93a0a530f3e583805cf98b4'
-          response['ok'].must_equal 'TEMPLATE_FOUND'
-          response['template_id'].must_equal '76fe5df1c93a0a530f3e583805cf98b4'
+      it "must get template with specified id" do
+        VCR.use_cassette "fetch_template" do
+          response = @template.get "76fe5df1c93a0a530f3e583805cf98b4"
+          _(response["ok"]).must_equal "TEMPLATE_FOUND"
+          _(response["template_id"]).must_equal "76fe5df1c93a0a530f3e583805cf98b4"
         end
       end
     end
 
-    describe 'when updating template' do
-
-      it 'must perform PUT request to templates/[id]' do
-        url = 'api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4'
+    describe "when updating template" do
+      it "must perform PUT request to templates/[id]" do
+        url = "https://api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4"
         stub_request(:put, url)
         @template.update(
-          '76fe5df1c93a0a530f3e583805cf98b4',
-          {:name => 'foo', :template => {:key => 'value'}}
+          "76fe5df1c93a0a530f3e583805cf98b4",
+          {name: "foo", template: {key: "value"}}
         )
 
         assert_requested(:put, url) do |req|
           values = values_from_post_body(req.body)
-          data = MultiJson.load(values['params'])
-          data['name'].must_equal 'foo'
-          data['template']['key'].must_equal 'value'
+          data = MultiJson.load(values["params"])
+          _(data["name"]).must_equal "foo"
+          _(data["template"]["key"]).must_equal "value"
         end
       end
 
-      it 'must update template with specified id' do
-        VCR.use_cassette 'update_template' do
-          response = @template.update '55c965a063a311e6ba2d379ef10b28f7'
+      it "must update template with specified id" do
+        VCR.use_cassette "update_template" do
+          response = @template.update "55c965a063a311e6ba2d379ef10b28f7"
 
-          response['ok'].must_equal 'TEMPLATE_UPDATED'
-          response['template_id'].must_equal '55c965a063a311e6ba2d379ef10b28f7'
+          _(response["ok"]).must_equal "TEMPLATE_UPDATED"
+          _(response["template_id"]).must_equal "55c965a063a311e6ba2d379ef10b28f7"
         end
       end
     end
 
-    describe 'when deleting a template' do
-
-      it 'must perform DELETE request to templates/[id]' do
-        stub = stub_request(:delete, 'api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4')
-        @template.delete '76fe5df1c93a0a530f3e583805cf98b4'
+    describe "when deleting a template" do
+      it "must perform DELETE request to templates/[id]" do
+        stub = stub_request(:delete, "https://api2.transloadit.com/templates/76fe5df1c93a0a530f3e583805cf98b4")
+        @template.delete "76fe5df1c93a0a530f3e583805cf98b4"
 
         assert_requested(stub)
       end
 
-      it 'must delete specified template templates' do
-        VCR.use_cassette 'delete_template' do
-          response = @template.delete '55c965a063a311e6ba2d379ef10b28f7'
+      it "must delete specified template templates" do
+        VCR.use_cassette "delete_template" do
+          response = @template.delete "55c965a063a311e6ba2d379ef10b28f7"
 
-          response['ok'].must_equal 'TEMPLATE_DELETED'
+          _(response["ok"]).must_equal "TEMPLATE_DELETED"
         end
       end
     end

data/transloadit.gemspec

@@ -1,39 +1,38 @@
-$:.unshift File.expand_path('../lib', __FILE__)
+$:.unshift File.expand_path("../lib", __FILE__)
 
-require 'transloadit/version'
+require "transloadit/version"
 
 Gem::Specification.new do |gem|
-  gem.name     = 'transloadit'
-  gem.version  = Transloadit::VERSION
+  gem.name = "transloadit"
+  gem.version = Transloadit::VERSION
   gem.platform = Gem::Platform::RUBY
 
-  gem.authors  = [ "Stephen Touset", "Robin Mehner" ]
-  gem.email    = %w{ stephen@touset.org robin@coding-robin.de }
-  gem.homepage = 'http://github.com/transloadit/ruby-sdk/'
-  gem.license  = 'MIT'
+  gem.authors = ["Stephen Touset", "Robin Mehner"]
+  gem.email = %w[stephen@touset.org robin@coding-robin.de]
+  gem.homepage = "https://github.com/transloadit/ruby-sdk/"
+  gem.license = "MIT"
 
-  gem.summary     = 'Official Ruby gem for Transloadit'
-  gem.description = 'The transloadit gem allows you to automate uploading files through the Transloadit REST API'
+  gem.summary = "Official Ruby gem for Transloadit"
+  gem.description = "The transloadit gem allows you to automate uploading files through the Transloadit REST API"
 
-  gem.required_rubygems_version = '>= 2.2.0'
-  gem.required_ruby_version     = '>= 2.1.0'
+  gem.required_rubygems_version = ">= 2.2.0"
+  gem.required_ruby_version = ">= 3.0.0"
 
-  gem.files         = `git ls-files`.split("\n")
-  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  gem.require_paths = %w{ lib }
+  gem.files = `git ls-files`.split("\n")
+  gem.require_paths = %w[lib]
 
-  gem.add_dependency 'rest-client'
-  gem.add_dependency 'multi_json'
-  gem.add_dependency 'mime-types'
+  gem.add_dependency "rest-client"
+  gem.add_dependency "multi_json"
+  gem.add_dependency "mime-types"
 
-  gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'minitest'
-  gem.add_development_dependency 'simplecov'
+  gem.add_development_dependency "rake"
+  gem.add_development_dependency "minitest"
+  gem.add_development_dependency "simplecov"
+  gem.add_development_dependency "standard"
 
-  gem.add_development_dependency 'vcr'
-  gem.add_development_dependency 'webmock'
-
-  gem.add_development_dependency 'yard'
-  gem.add_development_dependency 'kramdown' # for YARD rdoc formatting
+  gem.add_development_dependency "vcr"
+  gem.add_development_dependency "webmock"
 
+  gem.add_development_dependency "yard"
+  gem.add_development_dependency "kramdown" # for YARD rdoc formatting
 end