translated_attributes 0.5.4 → 0.5.5

data/README.markdown

@@ -7,7 +7,8 @@ Usage
 =====
  - As Rails plugin  `script/plugin install git://github.com/grosser/translated_attributes.git`
  - As gem `sudo gem install translated_attributes`
- - execute MIGRATION
+ - generate migrations: `rails generate translated_attributes`(Rails2: [do it by manually](http://github.com/grosser/translated_attributes/blob/master/lib/generators/translated_attributes/templates/migration.rb))
+ - `rake db:migrate`
 
 Adding attributes:
     class Product < ActiveRecord::Base
@@ -42,8 +43,13 @@ Options
     :table_name => 'user_translations', #default is translations
     :nil_to_blank => true, #return unfound translations as blank strings ('') instead of nil (default false),
     :translatable_name => 'translated' #name of the associated translatable (Product has_many :translations a Translation belongs_to XXX), default is :translatable
+
 Author
 ======
+
+###Contributors
+ - [Stefano Diem Benatti](http://github.com/teonimesic)
+
 [Michael Grosser](http://pragmatig.wordpress.com)  
 grosser.michael@gmail.com  
 Hereby placed under public domain, do what you want, just do not hold me accountable...

data/VERSION

@@ -1 +1 @@
-0.5.4
+0.5.5

data/lib/generators/translated_attributes/USAGE

@@ -0,0 +1,8 @@
+Description:
+    Generates the migration file for TranslatedAttributes.
+
+Example:
+    rails generate translated_attributes
+
+    This will create:
+        db/migration/<migration step>_add_translations.rb

data/lib/generators/translated_attributes/templates/migration.rb

@@ -0,0 +1,18 @@
+class AddTranslations < ActiveRecord::Migration
+  def self.up
+    # you can remove the limit/null constrains
+    # this is simply my recommended way of setting things up (save + limits needed storage space)
+    create_table :translations do |t|
+      t.integer :translatable_id, :null=>false
+      t.string :translatable_type, :limit=>40, :null=>false
+      t.string :language, :limit=>2, :null=>false
+      t.string :attribute, :limit=>40, :null=>false
+      t.text :text, :null=>false
+    end
+    add_index :translations, [:translatable_id, :translatable_type]
+  end
+
+  def self.down
+    drop_table :translations
+  end
+end

data/lib/generators/translated_attributes/translated_attributes_generator.rb

@@ -0,0 +1,14 @@
+require 'rails/generators/migration'
+
+class TranslatedAttributesGenerator < Rails::Generators::Base
+  include Rails::Generators::Migration
+
+  def self.next_migration_number(dirname)
+    Time.now.strftime("%Y%m%d%H%M%S")
+  end
+  
+  def create_migration
+    template = File.expand_path('../templates/migration.rb', __FILE__)
+    migration_template template, 'db/migrate/add_translations.rb'
+  end
+end

data/lib/translated_attributes.rb

@@ -75,7 +75,7 @@ module TranslatedAttributes
 
     def set_translated_attribute(locale, field, value)
       old_value = translated_attributes_for(locale)[field]
-      return if old_value == value
+      return if old_value.to_s == value.to_s
       changed_attributes.merge!("#{field}_in_#{locale}" => old_value)
       translated_attributes_for(locale)[field] = value
       @translated_attributes_changed = true

data/spec/translated_attributes_spec.rb

@@ -67,6 +67,24 @@ describe 'Translated attributes' do
       p.title_in_de = 'abc'
       p.title.should == 'abc'
     end
+
+    it "records a change" do
+      p = Product.new
+      p.title = 'abc'
+      p.send(:changed_attributes).should == {'title_in_en' => nil}
+    end
+
+    it "does not record changes for nil to blank" do
+      p = Product.new
+      p.title = ''
+      p.send(:changed_attributes).should == {}
+    end
+
+    it "does not record changes for unchanged" do
+      p = Product.create!(:title_in_en => 'abc')
+      p.title = 'abc'
+      p.send(:changed_attributes).should == {}
+    end
   end
 
   describe 'storing' do

data/translated_attributes.gemspec

@@ -5,21 +5,23 @@
 
 Gem::Specification.new do |s|
   s.name = %q{translated_attributes}
-  s.version = "0.5.4"
+  s.version = "0.5.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Grosser"]
-  s.date = %q{2010-06-07}
+  s.date = %q{2010-07-15}
   s.email = %q{grosser.michael@gmail.com}
   s.extra_rdoc_files = [
     "README.markdown"
   ]
   s.files = [
-    "MIGRATION",
-     "README.markdown",
+    "README.markdown",
      "Rakefile",
      "VERSION",
      "init.rb",
+     "lib/generators/translated_attributes/USAGE",
+     "lib/generators/translated_attributes/templates/migration.rb",
+     "lib/generators/translated_attributes/translated_attributes_generator.rb",
      "lib/translated_attributes.rb",
      "spec/integration_spec.rb",
      "spec/models.rb",

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 5
-  - 4
-  version: 0.5.4
+  - 5
+  version: 0.5.5
 platform: ruby
 authors: 
 - Michael Grosser
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-07 00:00:00 +02:00
+date: 2010-07-15 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -38,11 +38,13 @@ extensions: []
 extra_rdoc_files: 
 - README.markdown
 files: 
-- MIGRATION
 - README.markdown
 - Rakefile
 - VERSION
 - init.rb
+- lib/generators/translated_attributes/USAGE
+- lib/generators/translated_attributes/templates/migration.rb
+- lib/generators/translated_attributes/translated_attributes_generator.rb
 - lib/translated_attributes.rb
 - spec/integration_spec.rb
 - spec/models.rb

data/MIGRATION

@@ -1,18 +0,0 @@
-class AddTranslations < ActiveRecord::Migration
-  def self.up
-    #you can remove the limit/null constrains
-    #this is simply my recommended way of setting things up (save + limits needed storage space)
-    create_table :translations do |t|
-      t.column :translatable_id, :integer, :null=>false
-      t.column :translatable_type, :string, :limit=>40, :null=>false
-      t.column :language, :string, :limit=>2, :null=>false
-      t.column :attribute, :string, :limit=>40, :null=>false
-      t.column :text, :text, :null=>false
-    end
-    add_index :translations, [:translatable_id, :translatable_type]
-  end
-
-  def self.down
-    drop_table :translations
-  end
-end