transitions 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34d3864fac5bd100f261d06295299b1d9b08acd3
-  data.tar.gz: 41982c65bdea9c3b3aa1160c9ea6bcb2f2232a1d
+  metadata.gz: db4e533a8cede13eb9cbf2e0291f129374d8e59a
+  data.tar.gz: d1131c392f74131b23ce68d0204aebe8c5441b23
 SHA512:
-  metadata.gz: e842c89b94f099b134ffd915b72142cea017338ba209cb4446ad8ebeaea12c7d1a4e3c50feaf1ac16d5fd6ace5073b252a8c09579aca9850db4551311949e6e3
-  data.tar.gz: 7d383004c82e4ea0fad5ea92ac79d28050699774816737c315442532db8ee89437488b074e9b434a4c17bdb23ce4a23c4ec14eb5dac2003555e2d21c37ffddfe
+  metadata.gz: 089e9d32d55496832507a763c7a4dfffb4b0df01489d84828b78637eb66887cb33131856d0e72025088530c932809b52498638d34539d615c1fc62cee94e70cc
+  data.tar.gz: cd7f5928d0d86d90d9f43ccc5d33b1e5003931f20fe12d928572d5922647c74504dbb23b13eaeadbf07a676a9167809184e338d885065b93f78c626b7252fcdc

data/.todo.reek

@@ -4,15 +4,11 @@ DuplicateMethodCall:
   - ActiveModel::Transitions#read_state
   - ActiveModel::Transitions#reload
   - ActiveModel::Transitions#set_initial_state
-  - ActiveModel::Transitions#set_initial_state
   - Transitions::Event#error_message_for_invalid_transitions
   - Transitions::Event#fire
-  - Transitions::Event#fire
-  - Transitions::Event#initialize
   - Transitions::Event#initialize
   - Transitions::Event#update
   - Transitions::Machine#handle_event_success_callback
-  - Transitions::Machine#handle_event_success_callback
   - Transitions::Machine#initial_state
   - Transitions::State#define_state_query_method
 IrresponsibleModule:
@@ -46,6 +42,19 @@ FeatureEnvy:
   - Transitions::Event#can_execute_transition_from_state?
   - Transitions::Event#default_timestamp_name
   - Transitions::Event#error_message_for_invalid_transitions
+InstanceVariableAssumption:
+  exclude:
+  - Transitions::Event
+  - Transitions::Machine
+  - Transitions::State
+ManualDispatch:
+  exclude:
+  - Transitions::Event#default_timestamp_name
+  - Transitions::Machine#fire_event
+  - Transitions::Machine#handle_event_failed_callback
+  - Transitions::Machine#handle_event_fired_callback
+  - Transitions::Machine#include_scopes
+  - Transitions::StateTransition#perform_guard
 NestedIterators:
   exclude:
   - Transitions::Event#build_success_callback
@@ -56,6 +65,7 @@ TooManyInstanceVariables:
   - Transitions::StateTransition
 TooManyStatements:
   exclude:
+  - initialize
   - Transitions::Event#build_success_callback
   - Transitions::Event#fire
   - Transitions::Machine#fire_event

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.2.0
+
+* (atomaka) Allow timestamp to accept an array of timestamps
+
 # 1.1.1
 
 * (beornborn) use instance_exec for defining scope because @klass sometimes is resolved as nil

data/README.md

@@ -300,7 +300,8 @@ corresponding discussion).
 If you'd like to note the time of a state change, Transitions comes with
 timestamps free! To activate them, simply pass the `timestamp` option to the
 event definition with a value of either true or the name of the timestamp
-column. *NOTE - This should be either true, a String or a Symbol*
+column. *NOTE - This should be either true, a String, a Symbol, or an Array of
+these*
 ```ruby
 # This will look for an attribute called exploded_at or exploded_on (in that order)
 # If present, it will be updated

data/lib/transitions/event.rb

@@ -8,6 +8,7 @@ module Transitions
       @machine = machine
       @name = name
       @transitions = []
+      @timestamps = []
       if machine
         machine.klass.send(:define_method, "#{name}!") do |*args|
           machine.fire_event(name, self, true, *args)
@@ -67,29 +68,33 @@ module Transitions
 
     # Has the timestamp option been specified for this event?
     def timestamp_defined?
-      !@timestamp.nil?
+      !@timestamps.nil?
     end
 
     def update(options = {}, &block)
       @success       = build_success_callback(options[:success]) if options.key?(:success)
-      self.timestamp = options[:timestamp] if options[:timestamp]
+      self.timestamp = Array(options[:timestamp]) if options[:timestamp]
       instance_eval(&block) if block
       self
     end
 
     # update the timestamp attribute on obj
     def update_event_timestamp(obj, next_state)
-      obj.send "#{timestamp_attribute_name(obj, next_state)}=", Time.now
+      @timestamps.each do |timestamp|
+        obj.public_send "#{timestamp_attribute_name(obj, next_state, timestamp)}=", Time.now
+      end
     end
 
     # Set the timestamp attribute.
     # @raise [ArgumentError] timestamp should be either a String, Symbol or true
-    def timestamp=(value)
-      case value
-      when String, Symbol, TrueClass
-        @timestamp = value
-      else
-        fail ArgumentError, 'timestamp must be either: true, a String or a Symbol'
+    def timestamp=(values)
+      values.each do |value|
+        case value
+        when String, Symbol, TrueClass
+          @timestamps << value
+        else
+          fail ArgumentError, 'timestamp must be either: true, a String or a Symbol'
+        end
       end
     end
 
@@ -98,8 +103,8 @@ module Transitions
     # Returns the name of the timestamp attribute for this event
     # If the timestamp was simply true it returns the default_timestamp_name
     # otherwise, returns the user-specified timestamp name
-    def timestamp_attribute_name(obj, next_state)
-      timestamp == true ? default_timestamp_name(obj, next_state) : @timestamp
+    def timestamp_attribute_name(obj, next_state, user_timestamp)
+      user_timestamp == true ? default_timestamp_name(obj, next_state) : user_timestamp
     end
 
     # If @timestamp is true, try a default timestamp name

data/lib/transitions/version.rb

@@ -1,3 +1,3 @@
 module Transitions
-  VERSION = '1.1.1'.freeze
+  VERSION = '1.2.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transitions
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Timo Rößner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-02 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -201,4 +201,3 @@ signing_key:
 specification_version: 4
 summary: State machine extracted from ActiveModel
 test_files: []
-has_rdoc: