transitions 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e0eecbbaa7a8c858df9799e370497da5c55691a
-  data.tar.gz: 2aeaec6cb95f64080a9a2a03a19ac1d9885db568
+  metadata.gz: f104d4ab40d3eed0fa80ea8f7478ceda3392e2c0
+  data.tar.gz: 4da942a300e3bfada33284dcc7e2c53c1f3e7dc6
 SHA512:
-  metadata.gz: 14bdc0e63e4cad7f5cf626022738509b61878964b1fd5c86eb8c87b6550ad45e8381af5d15333ca021a5c043edf521e8b4a2360d4d3f82d6587bc2537e756818
-  data.tar.gz: 8e5142a6a0448e8cb29b2b4bdd08cb8ac5bd8776ff9c2f16ae7bf900775cb4768fe70e7bbdf5d82f72ed0a006a95288350c3ba9910c4436d5702b585dbfe4c0e
+  metadata.gz: 944438392a350653aa572612852e475da7d4284cdc2d1a2f28babb2e762ba692da9d6a22c08afaa65df09bf79ac00c254245a813c0906d80fcc780a5bfe4bf3f
+  data.tar.gz: 6fb231329c1fc52f1e8572496ed0fbb1cbb5009ca93ebc66092175edaa5ade0195d5f3130f08a8ba678a6bd5561205a8e2f32dffa93c8183511c07730c6236a6

data/.codeclimate.yml

@@ -0,0 +1,10 @@
+engines:
+  rubocop:
+    enabled: true
+  reek:
+    enabled: true
+ratings:
+  paths:
+  - lib/**/*
+exclude_paths:
+- test/**/*

data/.rubocop.yml

@@ -19,3 +19,5 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/transitions/event.rb'
     - 'lib/transitions/state.rb'
+Style/FrozenStringLiteralComment:
+  Enabled: false

data/.todo.reek

@@ -0,0 +1,85 @@
+---
+DuplicateMethodCall:
+  exclude:
+  - ActiveModel::Transitions#read_state
+  - ActiveModel::Transitions#reload
+  - ActiveModel::Transitions#set_initial_state
+  - ActiveModel::Transitions#set_initial_state
+  - Transitions::Event#error_message_for_invalid_transitions
+  - Transitions::Event#fire
+  - Transitions::Event#fire
+  - Transitions::Event#initialize
+  - Transitions::Event#initialize
+  - Transitions::Event#update
+  - Transitions::Machine#handle_event_success_callback
+  - Transitions::Machine#handle_event_success_callback
+  - Transitions::Machine#initial_state
+  - Transitions::State#define_state_query_method
+IrresponsibleModule:
+  exclude:
+  - ActiveModel::Transitions
+  - Transitions::Machine
+  - Transitions::Presenter
+  - Transitions::State
+  - Transitions::StateTransition
+  - Transitions
+  - Transitions::ClassMethods
+  - Transitions::InvalidMethodOverride
+  - Transitions::InvalidTransition
+NilCheck:
+  exclude:
+  - ActiveModel::Transitions#state_not_set?
+  - Transitions::Event#timestamp_defined?
+  - Transitions::StateTransition#execute
+  - Transitions#current_state
+UncommunicativeVariableName:
+  exclude:
+  - ActiveModel::Transitions#state_included?
+  - Transitions::Event#can_execute_transition_from_state?
+  - Transitions::Event#fire
+  - Transitions::Event#transitions
+  - Transitions::Event#transitions_from_state?
+  - Transitions::Machine#fire_event
+  - Transitions::StateTransition#executable?
+FeatureEnvy:
+  exclude:
+  - Transitions::Event#can_execute_transition_from_state?
+  - Transitions::Event#default_timestamp_name
+  - Transitions::Event#error_message_for_invalid_transitions
+NestedIterators:
+  exclude:
+  - Transitions::Event#build_success_callback
+TooManyInstanceVariables:
+  exclude:
+  - Transitions::Event
+  - Transitions::Machine
+  - Transitions::StateTransition
+TooManyStatements:
+  exclude:
+  - Transitions::Event#build_success_callback
+  - Transitions::Event#fire
+  - Transitions::Machine#fire_event
+  - Transitions#current_state
+Attribute:
+  exclude:
+  - Transitions::Machine#events
+  - Transitions::Machine#initial_state
+  - Transitions::Machine#state_index
+  - Transitions::Machine#states
+DataClump:
+  exclude:
+  - Transitions::Machine
+LongParameterList:
+  exclude:
+  - Transitions::Machine#fire_event
+UtilityFunction:
+  exclude:
+  - Transitions::Machine#handle_event_failed_callback
+  - Transitions::Machine#handle_event_fired_callback
+  - Transitions::StateTransition#perform_guard
+BooleanParameter:
+  exclude:
+  - Transitions#update_current_state
+ControlParameter:
+  exclude:
+  - Transitions#update_current_state

data/.travis.yml

@@ -7,11 +7,13 @@ script:
 rvm:
   - 2.1
   - 2.2
+  - 2.3.0
   - rbx-2
   - jruby
 matrix:
   allow_failures:
     - rvm: rbx-2
+    - rvm: jruby
   fast_finish: true
 notifications:
   email:

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.1.0
+
+* (itkin) `available_states` and `available_events` should list states or events in the order they are defined
+
 # 1.0.1
 
 * (avyy) Fix @state_machine lookup for Presenter's methods

data/Rakefile

@@ -3,6 +3,7 @@ require 'bundler/gem_tasks'
 require 'appraisal'
 require 'rake/testtask'
 require 'rubocop/rake_task'
+require 'reek/rake/task'
 
 Rake::TestTask.new(:test) do |test|
   test.libs = %w(lib test)
@@ -15,5 +16,6 @@ RuboCop::RakeTask.new do |task|
   task.patterns = ['lib/**/*.rb']
 end
 
-task default: :test
-task default: :rubocop
+Reek::Rake::Task.new
+
+task default: [:test, :reek, :rubocop]

data/lib/transitions/event.rb

@@ -3,6 +3,7 @@ module Transitions
   class Event
     attr_reader :name, :success, :timestamp
 
+    # :reek:TooManyStatements: { max_statements: 13 }
     def initialize(machine, name, options = {}, &block)
       @machine = machine
       @name = name

data/lib/transitions/presenter.rb

@@ -1,11 +1,11 @@
 module Transitions
   module Presenter
     def available_states
-      get_state_machine.states.map(&:name).sort_by(&:to_s)
+      get_state_machine.states.map(&:name)
     end
 
     def available_events
-      get_state_machine.events.keys.sort
+      get_state_machine.events.keys
     end
   end
 end

data/lib/transitions/version.rb

@@ -1,3 +1,3 @@
 module Transitions
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.1.0'.freeze
 end

data/transitions.gemspec

@@ -24,5 +24,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'random_data'
   spec.add_development_dependency 'appraisal'
   spec.add_development_dependency 'activerecord', ['>= 3.0', '<= 4.0']
-  spec.add_development_dependency 'rubocop', '~> 0.36'
+  spec.add_development_dependency 'rubocop', '~> 0.36.0'
+  spec.add_development_dependency 'reek'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: transitions
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Timo Rößner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-05 00:00:00.000000000 Z
+date: 2016-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -120,14 +120,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: 0.36.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.36'
+        version: 0.36.0
+- !ruby/object:Gem::Dependency
+  name: reek
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Lightweight state machine extracted from ActiveModel
 email:
 - timo.roessner@googlemail.com
@@ -135,9 +149,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
+- ".todo.reek"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md