transaction_isolation_continued 1.0.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32f804fa89e4072268ea34713263099072269395caf1bca34528d1632ac37a33
-  data.tar.gz: 9fa045df1dd64b0e45fb74eb8e507f7ff0aa2376e61843a203bec64dfaf8a5e2
+  metadata.gz: b85d83da9e7e46096a510a63ebd92c58941515d208e394d5f0633a327d5d2efe
+  data.tar.gz: 4507ff405e9706bcd57e9aa94d203ca19c2e154ded14beb398bd6d9b6dc3f4e6
 SHA512:
-  metadata.gz: 56a421307a4fd2a8c66bfa35e9189b99c160cd8db82fc5103a5d6c7ead76a0a8699cc3f2f089d79c521fa0d8b475129530d7aeaab7c9e4ac77f714f6dc550cdd
-  data.tar.gz: 66f6c3dd3ee7a0fd8ecad4292cfdf13ae563dcd5afdacada47030bbdd93c5c11917f3fac07caa62ec67b466a30677d95b7595d96c5fd384021f9fccc7290458e
+  metadata.gz: e58e5fd934a0a3ab519e43f44cc825f53d46195d9363e189dd62e53f8be9cd671e0d0d308f6bb16bb207bdc69f0fa772d49b7bb2dc1c9d7e7cf63243940c74be
+  data.tar.gz: 26a59f350392c3f46372220caff5f9fc799a84c73b91cf0b01e41cb561dc22710436a476ca9be81aad046f84078f9a11a7c981e1c10fe4ca79cdfac8d6517bf5

data/.dockerignore

@@ -0,0 +1 @@
+Gemfile.*.lock

data/.github/workflows/main.yml

@@ -102,7 +102,7 @@ jobs:
       POSTGRESQL_DB_PASS: database
       POSTGRESQL_DB_NAME: transaction_isolation_continued_test
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -110,6 +110,11 @@ jobs:
           bundler-cache: true
       - name: Run bundle update
         run: bundle update
+      - name: Setup Code Climate test-reporter
+        run: |
+          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+          chmod +x ./cc-test-reporter
+          ./cc-test-reporter before-build
       - name: Start Mysql
         if: matrix.db == 'mysql2'
         run: |
@@ -145,27 +150,37 @@ jobs:
             echo $(( COUNT++ )) > /dev/null
             sleep 2
           done
-      - name: test
-        run: echo $BUNDLE_GEMFILE
       - name: Run tests
         run: db=${{ matrix.db }} bundle exec rake test
       - name: Shutdown database
         if: always() && (matrix.db == 'postgresql' || matrix.db == 'mysql2')
         run: docker stop database
-#      - name: Coveralls Parallel
-#        if: "${{ !env.ACT }}"
-#        uses: coverallsapp/github-action@master
-#        with:
-#          github-token: "${{ secrets.GITHUB_TOKEN }}"
-#          flag-name: run-${{ matrix.ruby }}-${{ matrix.activerecord }}-${{ matrix.db }}-${{ matrix.dbversion }}
-#          parallel: true
-#  finish:
-#    needs: test
-#    runs-on: ubuntu-latest
-#    steps:
-#      - name: Coveralls Finished
-#        if: "${{ !env.ACT }}"
-#        uses: coverallsapp/github-action@master
-#        with:
-#          github-token: "${{ secrets.GITHUB_TOKEN }}"
-#          parallel-finished: true
+      - name: Format coverage
+        run: |
+          ./cc-test-reporter format-coverage -t simplecov -o coverage/cc_resultset.json
+      - name: Upload reports' artifacts
+        if: success() || failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage_artifact_ruby_${{ matrix.ruby }}_ar_${{ matrix.activerecord }}_db_${{ matrix.db }}
+          if-no-files-found: ignore
+          path: coverage
+          retention-days: 1
+  finish:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Download Code Climate test-reporter
+        run: |
+          curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+          chmod +x ./cc-test-reporter
+      - name: Download reports' artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: coverage_reports
+          pattern: coverage_artifact_*
+      - name: sum-coverage
+        run: |
+          ./cc-test-reporter sum-coverage coverage_reports/coverage_artifact_ruby*/cc_resultset.json -o coverage/codeclimate.json
+          ./cc-test-reporter upload-coverage -r ${{secrets.CC_TEST_REPORTER_ID}} -i coverage/codeclimate.json

data/.gitignore

@@ -1,6 +1,9 @@
 *.gem
 .bundle
 Gemfile.lock
+Gemfile.local
 pkg/*
 .idea
 test/log/*.log
+coverage
+gemfiles/*/Gemfile.*lock

data/README.md

@@ -1,104 +1,125 @@
-NO LONGER MAINTAINED - PLEASE FORK OR SEEK OTHER SOLUTIONS
+[![Gem Version](https://badge.fury.io/rb/transaction_isolation_continued.svg)](https://badge.fury.io/rb/transaction_isolation_continued)
+[![Maintainability](https://api.codeclimate.com/v1/badges/01a5d17010b32f041ac3/maintainability)](https://codeclimate.com/github/iagopiimenta/transaction_isolation_continued/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/01a5d17010b32f041ac3/test_coverage)](https://codeclimate.com/github/iagopiimenta/transaction_isolation_continued/test_coverage)
+[![CI PR Builds](https://github.com/iagopiimenta/transaction_isolation_continued/actions/workflows/main.yml/badge.svg)](https://github.com/iagopiimenta/transaction_isolation_continued/actions/workflows/main.yml)
 
-
-# transaction_isolation
+# transaction_isolation_continued
 
 Set transaction isolation level in the ActiveRecord in a database agnostic way.
 Works with MySQL, PostgreSQL and SQLite as long as you are using new adapters mysql2, pg or sqlite3.
-Supports all ANSI SQL isolation levels: :serializable, :repeatable_read, :read_committed, :read_uncommitted.
+Supports all ANSI SQL isolation levels: `:serializable`, `:repeatable_read`, `:read_committed`, `:read_uncommitted`.
 
 See also [transaction_retry](https://github.com/qertoip/transaction_retry) gem for auto-retrying transactions 
 on deadlocks and serialization errors.
 
 ## Example
 
-    ActiveRecord::Base.isolation_level( :serializable ) do
-      # your code
-    end
+```ruby
+ActiveRecord::Base.isolation_level(:serializable) do
+  # your code
+end
+```
+
+## Requirements
+
+- Rails: ActiveRecord 5.2+.
+- Database: MySQL, PostgreSQL, SQLite.
+- Ruby: MRI 2.5+.
 
 ## Installation
 
 Add this to your Gemfile:
 
-    gem 'transaction_isolation'
+```ruby
+gem 'transaction_isolation'
+```
 
 Then run:
 
-    bundle
+```bash
+bundle
+```
 
-__It works out of the box with Ruby on Rails__.
+**It works out of the box with Ruby on Rails**.
 
 If you have a standalone ActiveRecord-based project you'll need to call:
 
-    TransactionIsolation.apply_activerecord_patch     # after connecting to the database
+```ruby
+TransactionIsolation.apply_activerecord_patch # after connecting to the database
+```
 
-__after__ connecting to the database. This is because ActiveRecord loads adapters lazilly and only then they can be patched.
+**after** connecting to the database. This is because ActiveRecord loads adapters lazilly and only then they can be patched.
 
 ## Features
 
- * Setting transaction isolation level: :serializable, :repeatable_read, :read_committed, :read_uncommitted
- * Auto-reverting to the original isolation level after the block
- * Database agnostic
- * MySQL, PostgreSQL and SQLite supported
- * Exception translation. All deadlocks and serialization errors are wrapped in a ActiveRecord::TransactionIsolationConflict exception
- * Use it in your Rails application or a standalone ActiveRecord-based project
-
-## Testimonials
-
-This gem was initially developed for and successfully works in production at [Kontomierz.pl](http://kontomierz.pl) - the finest Polish personal finance app.
+- Setting transaction isolation level: `:serializable`, `:repeatable_read`, `:read_committed`, `:read_uncommitted`
+- Auto-reverting to the original isolation level after the block
+- Database agnostic
+- MySQL, PostgreSQL and SQLite supported
+- Exception translation. All deadlocks and serialization errors are wrapped in a `ActiveRecord::TransactionIsolationConflict` exception
+- Use it in your Rails application or a standalone ActiveRecord-based project
 
 ## Real world example
 
 When implementing a table-based job queue you should ensure that only one worker process can pop a particular job from the queue.
+
 Wrapping your code in a transaction is not enough because by default databases do not isolate transactions to the full extent,
-which leads to occasional phantom reads. It is therefore necessary to manually raise the transaction isolation level.
+which leads to occasional phantom reads.
+
+It is therefore necessary to manually raise the transaction isolation level.
+
 The highest level of transaction isolation is called "serializable" and that's what we need here:
 
-    class QueuedJob < ActiveRecord::Base
-
-      # Job status
-      TODO = 1
-      PROCESSING = 2
-      DONE = 3
-
-      # Returns first job from the queue or nil if the queue is empty
-      def pop
-        QueuedJob.isolation_level( :serializable ) do
-          QueuedJob.transaction do
-            queued_job = find_by_status( TODO )
-            if queud_job
-              queued_job.update_attribute( :status, PROCESSING )
-              return queued_job
-            else
-              return nil
-            end
-          end
+```ruby
+class QueuedJob < ActiveRecord::Base
+  # Job status
+  TODO = 1
+  PROCESSING = 2
+  DONE = 3
+
+  # Returns first job from the queue or nil if the queue is empty
+  def pop
+    QueuedJob.isolation_level(:serializable) do
+      QueuedJob.transaction do
+        queued_job = find_by_status(TODO)
+        if queud_job
+          queued_job.update_attribute(:status, PROCESSING)
+          return queued_job
+        else
+          return nil
         end
-      rescue ActiveRecord::TransactionIsolationConflict => e
-        logger.warn( e.message )
-        retry
       end
-
     end
+  rescue ActiveRecord::TransactionIsolationConflict => e
+    logger.warn(e.message)
+    retry
+  end
+end
+```
 
 [Read more about isolation levels in Wikipedia](http://tinyurl.com/nrqjbb)
 
-## Requirements
-
- * Ruby 1.9.2
- * ActiveRecord 3.0.11+
-
 ## Running tests
 
 Run tests on the selected database (mysql2 by default):
 
-    db=mysql2 bundle exec rake test
-    db=postgresql bundle exec rake test
-    db=sqlite3 bundle exec rake test
+```bash
+# passing desired database, active record version and ruby version
+docker compose run -e db=sqlite3 -e BUNDLE_GEMFILE=gemfiles/activerecord-7.0/Gemfile.sqlite3 ruby_2_5 bash -c ./docker/test-ruby.sh
+
+# db options: mysql2, postgresql, sqlite3
+# active record version options: 5.2, 6.0, 6.1, 7.0
+# ruby version options: 2.5, 2.7, 3.0, 3.1
+```
 
-Run tests on all supported databases:
+Run tests on all supported databases by ruby version:
 
-    ./tests
+```bash
+docker compose up ruby_2_5
+docker compose up ruby_2_7
+docker compose up ruby_3_0
+docker compose up ruby_3_1
+```
 
 Database configuration is hardcoded in test/db/db.rb; feel free to improve this and submit a pull request.
 

data/docker/ruby-2.5/Dockerfile

@@ -0,0 +1,6 @@
+FROM ruby:2.5-slim
+
+RUN apt-get update &&\
+    apt-get install -y build-essential git sqlite3 libsqlite3-dev mariadb-client libmariadb-dev postgresql-client libpq-dev &&\
+    apt-get clean &&\
+    rm -rf /var/lib/apt/lists/*

data/docker/ruby-2.7/Dockerfile

@@ -0,0 +1,6 @@
+FROM ruby:2.7-slim
+
+RUN apt-get update &&\
+    apt-get install -y build-essential git sqlite3 libsqlite3-dev mariadb-client libmariadb-dev postgresql-client libpq-dev &&\
+    apt-get clean &&\
+    rm -rf /var/lib/apt/lists/*

data/docker/ruby-3.0/Dockerfile

@@ -0,0 +1,6 @@
+FROM ruby:3.0-slim
+
+RUN apt-get update &&\
+    apt-get install -y build-essential git sqlite3 libsqlite3-dev mariadb-client libmariadb-dev postgresql-client libpq-dev &&\
+    apt-get clean &&\
+    rm -rf /var/lib/apt/lists/*

data/docker/ruby-3.1/Dockerfile

@@ -0,0 +1,6 @@
+FROM ruby:3.0-slim
+
+RUN apt-get update &&\
+    apt-get install -y build-essential git sqlite3 libsqlite3-dev mariadb-client libmariadb-dev postgresql-client libpq-dev &&\
+    apt-get clean &&\
+    rm -rf /var/lib/apt/lists/*

data/docker/test-ruby-2.5.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# fix conflicts between different ruby versions
+rm -rf gemfiles/**/Gemfile.*.lock
+
+gemfiles=(
+  "gemfiles/activerecord-5.2/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.0/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.1/Gemfile.sqlite3"
+
+  "gemfiles/activerecord-5.2/Gemfile.mysql2"
+  "gemfiles/activerecord-6.0/Gemfile.mysql2"
+  "gemfiles/activerecord-6.1/Gemfile.mysql2"
+
+  "gemfiles/activerecord-5.2/Gemfile.postgresql"
+  "gemfiles/activerecord-6.0/Gemfile.postgresql"
+  "gemfiles/activerecord-6.1/Gemfile.postgresql"
+)
+
+for gemfile in "${gemfiles[@]}"; do
+  database=$(echo $gemfile | cut -d'.' -f3)
+
+  echo BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+  BUNDLE_GEMFILE=$gemfile bundle install
+  BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+done

data/docker/test-ruby-2.7.sh

@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+# fix conflicts between different ruby versions
+rm -rf gemfiles/**/Gemfile.*.lock
+
+gemfiles=(
+  "gemfiles/activerecord-5.2/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.0/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.1/Gemfile.sqlite3"
+  "gemfiles/activerecord-7.0/Gemfile.sqlite3"
+
+  "gemfiles/activerecord-5.2/Gemfile.mysql2"
+  "gemfiles/activerecord-6.0/Gemfile.mysql2"
+  "gemfiles/activerecord-6.1/Gemfile.mysql2"
+  "gemfiles/activerecord-7.0/Gemfile.mysql2"
+
+  "gemfiles/activerecord-5.2/Gemfile.postgresql"
+  "gemfiles/activerecord-6.0/Gemfile.postgresql"
+  "gemfiles/activerecord-6.1/Gemfile.postgresql"
+  "gemfiles/activerecord-7.0/Gemfile.postgresql"
+)
+
+for gemfile in "${gemfiles[@]}"; do
+  database=$(echo $gemfile | cut -d'.' -f3)
+
+  echo BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+  BUNDLE_GEMFILE=$gemfile bundle install
+  BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+done

data/docker/test-ruby-3.0.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# fix conflicts between different ruby versions
+rm -rf gemfiles/**/Gemfile.*.lock
+
+gemfiles=(
+  "gemfiles/activerecord-6.0/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.1/Gemfile.sqlite3"
+  "gemfiles/activerecord-7.0/Gemfile.sqlite3"
+
+  "gemfiles/activerecord-6.0/Gemfile.mysql2"
+  "gemfiles/activerecord-6.1/Gemfile.mysql2"
+  "gemfiles/activerecord-7.0/Gemfile.mysql2"
+
+  "gemfiles/activerecord-6.0/Gemfile.postgresql"
+  "gemfiles/activerecord-6.1/Gemfile.postgresql"
+  "gemfiles/activerecord-7.0/Gemfile.postgresql"
+)
+
+for gemfile in "${gemfiles[@]}"; do
+  database=$(echo $gemfile | cut -d'.' -f3)
+
+  echo BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+  BUNDLE_GEMFILE=$gemfile bundle install
+  BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+done

data/docker/test-ruby-3.1.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# fix conflicts between different ruby versions
+rm -rf gemfiles/**/Gemfile.*.lock
+
+gemfiles=(
+  "gemfiles/activerecord-6.0/Gemfile.sqlite3"
+  "gemfiles/activerecord-6.1/Gemfile.sqlite3"
+  "gemfiles/activerecord-7.0/Gemfile.sqlite3"
+
+  "gemfiles/activerecord-6.0/Gemfile.mysql2"
+  "gemfiles/activerecord-6.1/Gemfile.mysql2"
+  "gemfiles/activerecord-7.0/Gemfile.mysql2"
+
+  "gemfiles/activerecord-6.0/Gemfile.postgresql"
+  "gemfiles/activerecord-6.1/Gemfile.postgresql"
+  "gemfiles/activerecord-7.0/Gemfile.postgresql"
+)
+
+for gemfile in "${gemfiles[@]}"; do
+  database=$(echo $gemfile | cut -d'.' -f3)
+
+  echo BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+  BUNDLE_GEMFILE=$gemfile bundle install
+  BUNDLE_GEMFILE=$gemfile db=$database bundle exec rake test
+done

data/docker/test-ruby.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+# fix conflicts between different ruby versions
+rm -rf gemfiles/**/Gemfile.*.lock
+
+echo BUNDLE_GEMFILE=$BUNDLE_GEMFILE db=$db bundle exec rake test
+     BUNDLE_GEMFILE=$BUNDLE_GEMFILE bundle install
+     BUNDLE_GEMFILE=$BUNDLE_GEMFILE db=$db bundle exec rake test

data/docker-compose.yml

@@ -0,0 +1,60 @@
+services:
+  ruby_2_5: &ruby_2_5
+    working_dir: /app
+    build:
+      context: .
+      dockerfile: docker/ruby-2.5/Dockerfile
+    volumes:
+      - .:/app
+    command: bash -c "bundle install && bundle exec rake test"
+    environment:
+      POSTGRESQL_DB_HOST: postgres
+      POSTGRESQL_DB_USER: transaction_retry_continued
+      POSTGRESQL_DB_PASS: database
+      POSTGRESQL_DB_NAME: transaction_isolation_continued_test
+      MYSQL_DB_HOST: mysql
+      MYSQL_DB_USER: root
+      MYSQL_DB_PASS: database
+      MYSQL_DB_NAME: transaction_isolation_continued_test
+    depends_on:
+      - mysql
+      - postgres
+  ruby_2_7:
+    <<: *ruby_2_5
+    build:
+      context: .
+      dockerfile: docker/ruby-2.7/Dockerfile
+  ruby_3_0:
+    <<: *ruby_2_5
+    command: ./docker/test-ruby-3.0.sh
+    build:
+      context: .
+      dockerfile: docker/ruby-3.0/Dockerfile
+  ruby_3_1:
+    <<: *ruby_2_5
+    command: ./docker/test-ruby-3.1.sh
+    build:
+      context: .
+      dockerfile: docker/ruby-3.1/Dockerfile
+  postgres:
+    image: postgres:9.6
+    environment:
+      POSTGRES_USER: transaction_retry_continued
+      POSTGRES_PASSWORD: database
+      POSTGRES_DB: transaction_isolation_continued_test
+    ports:
+      - "5432:5432"
+    healthcheck:
+      test: [ "CMD-SHELL", "pg_isready -q" ]
+      interval: 5s
+      timeout: 5s
+      retries: 5
+  mysql:
+    image: biarms/mysql:5.7
+    environment:
+      MYSQL_ROOT_PASSWORD: database
+      MYSQL_DATABASE: transaction_isolation_continued_test
+    ports:
+      - "3306:3306"
+    healthcheck:
+      test: "mysqladmin ping --host=0.0.0.0 --password=database --silent"

data/gemfiles/Gemfile.base

@@ -3,4 +3,8 @@ gemspec path: File.expand_path('..', __FILE__)
 
 gem 'ruby2_keywords' if RUBY_VERSION < '2.7'
 
+group :test do
+  gem 'simplecov'
+end
+
 File.exist?(gemfile_local = File.expand_path('../Gemfile.local', __FILE__)) and eval File.read(gemfile_local), binding, gemfile_local

data/gemfiles/activerecord-5.2/Gemfile.sqlite3

@@ -2,7 +2,7 @@ base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
 eval File.read(base_gemfile), binding, base_gemfile
 
 platform :ruby do
-  gem "sqlite3", "~> 1.4"
+  gem "sqlite3", "~> 1.4.0"
 end
 
 platform :jruby do

data/gemfiles/activerecord-6.0/Gemfile.sqlite3

@@ -2,7 +2,7 @@ base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
 eval File.read(base_gemfile), binding, base_gemfile
 
 platform :ruby do
-  gem "sqlite3", "~> 1.4"
+  gem "sqlite3", "~> 1.4.0"
 end
 
 platform :jruby do

data/gemfiles/activerecord-6.1/Gemfile.sqlite3

@@ -2,7 +2,7 @@ base_gemfile = File.expand_path('../Gemfile.base', __FILE__)
 eval File.read(base_gemfile), binding, base_gemfile
 
 platform :ruby do
-  gem "sqlite3", "~> 1.4"
+  gem "sqlite3", "~> 1.4.0"
 end
 
 platform :jruby do

data/gemfiles/activerecord-7.0/Gemfile.sqlite3

@@ -3,7 +3,7 @@ eval File.read(base_gemfile), binding, base_gemfile
 
 platform :ruby do
   # https://github.com/rails/rails/pull/51592
-  gem "sqlite3", "~> 1.4"
+  gem "sqlite3", "~> 1.4.0"
 end
 
 platform :jruby do

data/lib/transaction_isolation/active_record/base.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'active_record/base'
 
 module TransactionIsolation
   module ActiveRecord
     module Base
-      def isolation_level( isolation_level, &block )
-        connection.isolation_level( isolation_level, &block )
+      def isolation_level(isolation_level, &block)
+        connection.isolation_level(isolation_level, &block)
       end
     end
   end
 end
 
-ActiveRecord::Base.extend( TransactionIsolation::ActiveRecord::Base )
+ActiveRecord::Base.extend(TransactionIsolation::ActiveRecord::Base)

data/lib/transaction_isolation/active_record/connection_adapters/abstract_adapter.rb

@@ -1,32 +1,33 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/abstract_adapter'
 
 module TransactionIsolation
   module ActiveRecord
     module ConnectionAdapters # :nodoc:
       module AbstractAdapter
-
-        VALID_ISOLATION_LEVELS = [:read_uncommitted, :read_committed, :repeatable_read, :serializable]
+        VALID_ISOLATION_LEVELS = %i[read_uncommitted read_committed repeatable_read serializable].freeze
 
         # If true, #isolation_level(level) method is available
         def supports_isolation_levels?
           false
         end
 
-        def isolation_level( level )
+        def isolation_level(level)
           raise NotImplementedError
         end
 
         private
 
-          def validate_isolation_level( isolation_level )
-            unless VALID_ISOLATION_LEVELS.include?( isolation_level )
-              raise ArgumentError, "Invalid isolation level '#{isolation_level}'. Supported levels include #{VALID_ISOLATION_LEVELS.join( ', ' )}."
-            end
-          end
+        def validate_isolation_level(isolation_level)
+          return if VALID_ISOLATION_LEVELS.include?(isolation_level)
 
+          raise ArgumentError,
+                "Invalid isolation level '#{isolation_level}'. Supported levels include #{VALID_ISOLATION_LEVELS.join(', ')}."
+        end
       end
     end
   end
 end
 
-ActiveRecord::ConnectionAdapters::AbstractAdapter.send( :include, TransactionIsolation::ActiveRecord::ConnectionAdapters::AbstractAdapter )
+ActiveRecord::ConnectionAdapters::AbstractAdapter.include TransactionIsolation::ActiveRecord::ConnectionAdapters::AbstractAdapter