tramway-core 1.17.4 → 1.17.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6297a0252cf6856f995abf0de3e37b9376453d5df79a40e8ccb0dae8f75e06a
-  data.tar.gz: 7e9ec3266141fa021103ee9f4263c49aeedfad149c8188b635f97653aee258eb
+  metadata.gz: d406acc40d7905296b2257e659b8f5135d8b3caeb3accb877e092a3e1d4b43d6
+  data.tar.gz: 3b08362b8b0e3ab614df712ff887c59202e002ae7d894c6712d5007b4b10bbb2
 SHA512:
-  metadata.gz: 9cbf09a9abc0f90d6cbd59751960cbb40820309857035a5b5ec6412ff02bbfa4d91c15ac625a2bae005de13d8b043f48b10e2e7f48c6bf31bbdf5448b3412cae
-  data.tar.gz: fb4ac5cba33590b6bee01a9e16bc96af19c12157ba103510f3d6761ba1777baf911af1b061ed29614fc97de013345a10d8f78611923fa0fa32b3982d48e8ba36
+  metadata.gz: c680f805536cb1b02f53d8919ef685b3d4d591d2bc68d2679021b72d96fba9c1ffdb9926dc9c108874d73ed5b1de0eb72161d6b7caf5f9972d83dc1a0bb5b5e6
+  data.tar.gz: 51b5f3715c11f83bed392d62f678ed60262cc848d0f4e34941c2693071ffe150821a293cf653195407565aeaf291b844d9086d27771b92a61c77d265e939b261

data/README.md

@@ -132,7 +132,7 @@ end
 
 ### CopyToClipboardHelper
 
-[app/helpers/tramway/core/copy_to_clipboard_helper.rb](https://github.com/ulmic/tramway-dev/blob/develop/tramway-core/app/helpers/tramway/core/copy_to_clipboard_helper.rb)
+[app/helpers/tramway/core/copy_to_clipboard_helper.rb] (https://github.com/ulmic/tramway-dev/blob/develop/tramway-core/app/helpers/tramway/core/copy_to_clipboard_helper.rb)
 
 #### Install
 
@@ -203,10 +203,36 @@ Tramway::Admin.set_singleton_models Organization, project: :organization # now y
 * models - часто используемые в моделях слова
 * state_machines - локализация состояний
 
-## Contributors
+## Contribution
+
+### Contributors
 
 * [Pavel Kalashnikov](https://github.com/kalashnikovisme)
 * [moshinaan](https://github.com/moshinaan)
 
+### Workflow
+
+#### If you don't have access to push gem to rubygems then
+
+Just create PR to develop branch
+
+#### If you have access to push gem to rubygems then
+
+* Create PR to develop branch
+* After merging PR you should create new release via git-flow this way
+
+```shell
+git release start (version which you upgraded in lib/tramway-core/version.rb file)
+git release finish (version which you upgraded in lib/tramway-core/version.rb file)
+git push origin develop
+git push origin master
+```
+
+* Then push new version of the gem
+
+```shell
+rm -rf *.gem && gem build $(basename "$PWD").gemspec && gem push *.gem
+```
+
 ## License
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/app/forms/tramway/core/application_form.rb

@@ -4,6 +4,7 @@ class Tramway::Core::ApplicationForm < ::Reform::Form
   include Tramway::Core::ApplicationForms::AssociationObjectHelpers
   include Tramway::Core::ApplicationForms::ConstantObjectActions
   include Tramway::Core::ApplicationForms::PropertiesObjectHelper
+  include Tramway::Core::ApplicationForms::ObjectHelpers
 
   attr_accessor :submit_message
 
@@ -38,14 +39,6 @@ class Tramway::Core::ApplicationForm < ::Reform::Form
     @@associations
   end
 
-  def to_model
-    self
-  end
-
-  def persisted?
-    model.id.nil?
-  end
-
   class << self
     include Tramway::Core::ApplicationForms::ConstantClassActions
 
@@ -123,8 +116,10 @@ class Tramway::Core::ApplicationForm < ::Reform::Form
 
   def save
     super
+  rescue ArgumentError => e
+    Tramway::Error.raise_error :tramway, :core, :application_form, :save, :argument_error, message: e.message
   rescue StandardError => e
-    Tramway::Error.raise_error :tramway, :core, :application_form, :submit, :looks_like_you_have_method,
+    Tramway::Error.raise_error :tramway, :core, :application_form, :save, :looks_like_you_have_method,
       method_name: e.name.to_s.gsub('=', ''), model_class: @@model_class, class_name: self.class
   end
 end

data/app/forms/tramway/core/application_forms/association_object_helpers.rb

@@ -6,6 +6,7 @@ module Tramway::Core::ApplicationForms::AssociationObjectHelpers
       define_polymorphic_association association, class_name
     else
       self.class.send(:define_method, "#{association}=") do |value|
+        model.send "#{association}_id=", value
         super class_name.find value
       end
     end

data/app/forms/tramway/core/application_forms/object_helpers.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module Tramway::Core::ApplicationForms::ObjectHelpers
+  def to_model
+    self
+  end
+
+  def persisted?
+    model.id.nil?
+  end
+end

data/app/forms/tramway/core/extendable_forms_helpers/class_builder.rb

@@ -22,7 +22,7 @@ module Tramway::Core::ExtendableFormsHelpers::ClassBuilder
         case property[1][:object].field_type
         when 'file'
           field = property[1][:object]
-          define_file_property_assignment_method property field
+          define_file_property_assignment_method property, field
         else
           next unless property[1][:validates].present?
 

data/app/helpers/tramway/core/inputs/associations_helper.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+module Tramway::Core::Inputs::AssociationsHelper
+  def build_collection_for_association(form_object, property)
+    full_class_name_association = form_object.class.full_class_name_association(property)
+    check_valid_association full_class_name_association
+    full_class_name_association.active.send("#{current_user.role}_scope", current_user.id).map do |obj|
+      decorator_class(full_class_name_association).decorate obj
+    end.sort_by(&:name)
+  end
+
+  def build_value_for_association(form_object, property, value)
+    form_object.send(property) || form_object.model.send("#{property}_id") || value
+  end
+
+  def check_valid_association(full_class_name_association)
+    unless full_class_name_association
+      Tramway::Error.raise_error(
+        :tramway, :core, :inputs_helpers, :association_params, :defined_with_property_method, property: property
+      )
+    end
+    return unless full_class_name_association.is_a? Array
+
+    Tramway::Error.raise_error(
+      :tramway, :core, :inputs_helpers, :association_params, :used_polymorphic_association, property: property
+    )
+  end
+end

data/app/helpers/tramway/core/inputs/polymorphic_associations_helper.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Tramway::Core::Inputs::PolymorphicAssociationsHelper
+  def build_collection_for_polymorphic_association(form_object, property)
+    object_names = full_class_names(form_object, property).map do |class_name|
+      class_name.active.send("#{current_user.role}_scope", current_user.id).map do |obj|
+        decorator_class(class_name).decorate obj
+      end
+    end.flatten
+    object_names.sort_by { |obj| obj.name.to_s }
+  end
+
+  def build_value_for_polymorphic_association(form_object, property, value)
+    if form_object.send(property).present?
+      "#{form_object.send(property).class.to_s.underscore}_#{form_object.send(property).id}"
+    else
+      "#{value[:type]&.underscore}_#{value[:id]}"
+    end
+  end
+
+  def full_class_names(form_object, property)
+    form_object.model.class.send("#{property}_type").values.map(&:constantize)
+  end
+end

data/app/helpers/tramway/core/inputs_helper.rb

@@ -1,58 +1,41 @@
 # frozen_string_literal: true
 
 module Tramway::Core::InputsHelper
-  def association_params(form_object:, property:, value:, object:, options: {})
-    full_class_name_association = form_object.class.full_class_name_association(property)
-    unless full_class_name_association
-      raise "It seems you've defined association attributes with `property` method. Please, use `association` method. `association :#{property}`"
-    end
-    if full_class_name_association.is_a? Array
-      raise "It seems you've used `association` input type in the Form. Please, use `polymorphic_association` type. `#{property}: :polymorphic_association`"
-    end
+  include Tramway::Core::Inputs::AssociationsHelper
+  include Tramway::Core::Inputs::PolymorphicAssociationsHelper
 
-    {
-      label: false,
-      input_html: {
-        name: "#{object}[#{property}]",
-        id: "#{object}_#{property}",
-        value: (form_object.send(property) || form_object.model.send("#{property}_id") || value)
-      },
-      selected: (form_object.model.send("#{property}_id") || value),
-      collection: full_class_name_association.active.map do |obj|
-        decorator_class(full_class_name_association).decorate obj
-      end.sort_by(&:name)
-    }.merge options
+  def association_params(form_object:, property:, value:, object:, options: {})
+    build_input_attributes(object: object, property: property, options: options,
+                           value: build_value_for_association(form_object, property, value),
+                           collection: build_collection_for_association(form_object, property),
+                           selected: form_object.model.send("#{property}_id") || value)
   end
 
   def polymorphic_association_params(object:, form_object:, property:, value:, options: {})
-    full_class_names = form_object.model.class.send("#{property}_type").values.map &:constantize
-    collection = full_class_names.map do |class_name|
-      class_name.active.map do |obj|
-        decorator_class(class_name).decorate obj
-      end
-    end.flatten.sort_by { |obj| obj.name.to_s }
-    builded_value = if form_object.send(property).present?
-                      "#{form_object.send(property).class.to_s.underscore}_#{form_object.send(property).id}"
-                    else
-                      "#{value[:type]&.underscore}_#{value[:id]}"
-                    end
+    build_input_attributes object: object, property: property,
+                           selected: build_value_for_polymorphic_association(form_object, property, value),
+                           value: build_value_for_polymorphic_association(form_object, property, value),
+                           collection: build_collection_for_polymorphic_association(form_object, property),
+                           options: options.merge(
+                             as: :select,
+                             label_method: ->(obj) { "#{obj.class.model_name.human} | #{obj.name}" },
+                             value_method: lambda do |obj|
+                               "#{obj.class.to_s.underscore.sub(/_decorator$/, '')}_#{obj.id}"
+                             end
+                           )
+  end
+
+  def build_input_attributes(**options)
     {
-      as: :select,
       label: false,
       input_html: {
-        name: "#{object}[#{property}]",
-        id: "#{object}_#{property}",
-        value: builded_value
+        name: "#{options[:object]}[#{options[:property]}]",
+        id: "#{options[:object]}_#{options[:property]}",
+        value: options[:value]
       },
-      selected: builded_value,
-      collection: collection,
-      label_method: lambda do |obj|
-        "#{obj.class.model_name.human} | #{obj.name}"
-      end,
-      value_method: lambda do |obj|
-        "#{obj.class.to_s.underscore.sub(/_decorator$/, '')}_#{obj.id}"
-      end
-    }.merge options
+      selected: options[:selected],
+      collection: options[:collection]
+    }.merge options[:options]
   end
 
   def value_from_params(model_class:, property:, type:)
@@ -79,15 +62,19 @@ module Tramway::Core::InputsHelper
     }.merge options
   end
 
-  def else_params(property:, object:, type:, form_object:, value:, options: {})
+  def else_params(**options)
     {
-      as: type,
+      as: options[:type],
       label: false,
       input_html: {
-        name: "#{object}[#{property}]",
-        id: "#{object}_#{property}",
-        value: (form_object.send(property) || form_object.model.send(property) || value)
+        name: "#{options[:object]}[#{options[:property]}]",
+        id: "#{options[:object]}_#{options[:property]}",
+        value: build_else_value(options[:form_object], options[:property], options[:value])
       }
-    }.merge options
+    }.merge options[:options] || {}
+  end
+
+  def build_else_value(form_object, property, value)
+    form_object.send(property) ? form_object.model.send(property) : value
   end
 end

data/app/uploaders/photo_uploader.rb

@@ -16,6 +16,10 @@ class PhotoUploader < ApplicationUploader
     end
   end
 
+  def present?
+    super && width.present? && height.present?
+  end
+
   version :medium do
     process resize_to_fill: [400, 400]
   end

data/app/views/tramway/core/shared/input_extended_types/_select.html.haml

@@ -1,4 +1,4 @@
-- parsed_json = field.options.is_a?(Hash) ? field.options : (JSON.parse(field.options) unless field.options == '')
+- parsed_json = field.options&.is_a?(Hash) ? field.options : (JSON.parse(field.options) if field.options.present?)
 - if parsed_json&.dig('collection', 'name')
   - if value.present?
     = f.input field.title.to_sym, as: :select, collection: collection_list_by(name: parsed_json['collection']['name']), input_html: { class: class_name, id: "#{class_name}_#{field.title}", name: "#{class_name}[#{field.title}]" }, selected: value, required: field.required

data/lib/tramway/core/application.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Tramway::Core::Application
-  attr_accessor :name, :url, :model_class, :title, :tagline, :found_date, :phone, :email, :main_image
+  attr_accessor :name, :url, :model_class, :title, :tagline, :found_date, :phone, :email, :main_image, :favicon
 
   def public_name
     name.to_s.gsub('_', ' ').camelize

data/lib/tramway/core/version.rb

@@ -2,6 +2,6 @@
 
 module Tramway
   module Core
-    VERSION = '1.17.4'
+    VERSION = '1.17.6.1'
   end
 end

data/lib/yaml/errors.yml

@@ -4,6 +4,10 @@ tramway:
       collection_list_by:
         there_no_such_collection: "There no such collection named %{name_camelize}. Please create class with self method `list` and extended of `Tramway::Collection`. You should reload your server after creating this collection."
   core:
+    input_helper:
+      association_params:
+        defined_with_property_method: "It seems you've defined association attributes with `property` method. Please, use `association` method. `association :%{property}`"
+        use_polymorphic_association: "It seems you've used `association` input type in the Form. Please, use `polymorphic_association` type. `%{property}: :polymorphic_association`"
     title_helper:
       title:
         you_should_set_tramway_core_application: "You should set Tramway::Core::Application class using `::Tramway::Core.initialize_application model_class: #{model_class_name}` in config/initializers/tramway.rb OR maybe you don't have any records of application model"
@@ -13,8 +17,10 @@ tramway:
       validates:
         you_need_to_set_model_class: 'You need to set `model_class` name while using validations. Just write `self.model_class = YOUR_MODEL_NAME` in the class area.'
       submit:
-        looks_like_you_have_method: "Looks like you have method `%{method_name}` in %{model_class}. You should rename it or rename property in %{class_name}"
         params_should_not_be_nil: "ApplicationForm::Params should not be nil"
+      save:
+        looks_like_you_have_method: "Looks like you have method `%{method_name}` in %{model_class}. You should rename it or rename property in %{class_name}"
+        argument_error: "We have ArgumentError with message: %{message}"
       model_class: 
         there_is_not_model_class: "There is not model class name for %{name}. Should be %{model_class_name} or you can use another class to initialize form object or just initialize form with object."
     concerns:
@@ -32,4 +38,3 @@ tramway:
         please_implement_title: "Please, implement `title` method in a %{class_name} or %{object_class}"
       link:
         method_link_uses_file_attribute: "Method `link` uses `file` attribute of the decorated object. If decorated object doesn't contain `file`, you shouldn't use `link` method."
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tramway-core
 version: !ruby/object:Gem::Version
-  version: 1.17.4
+  version: 1.17.6.1
 platform: ruby
 authors:
 - Pavel Kalashnikov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-28 00:00:00.000000000 Z
+date: 2020-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: audited
@@ -365,6 +365,7 @@ files:
 - app/forms/tramway/core/application_forms/association_object_helpers.rb
 - app/forms/tramway/core/application_forms/constant_class_actions.rb
 - app/forms/tramway/core/application_forms/constant_object_actions.rb
+- app/forms/tramway/core/application_forms/object_helpers.rb
 - app/forms/tramway/core/application_forms/properties_object_helper.rb
 - app/forms/tramway/core/extendable_form.rb
 - app/forms/tramway/core/extendable_forms_helpers/class_builder.rb
@@ -378,6 +379,8 @@ files:
 - app/forms/tramway/core/form_creator.rb
 - app/helpers/tramway/core/application_helper.rb
 - app/helpers/tramway/core/copy_to_clipboard_helper.rb
+- app/helpers/tramway/core/inputs/associations_helper.rb
+- app/helpers/tramway/core/inputs/polymorphic_associations_helper.rb
 - app/helpers/tramway/core/inputs_helper.rb
 - app/helpers/tramway/core/title_helper.rb
 - app/inputs/date_picker_input.rb