trains 0.0.7 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 553d908187ec4b9cc7e3f06616e096e8a341061ec3a345bce5018c6e1578e4ae
-  data.tar.gz: 2201e5acb6d148926f4602a885d3588cb902496b788d8565330c9ed3588e3243
+  metadata.gz: 2862732986e24d80f6fe47f3035e206cc033354767902260e7003c983b30ce3d
+  data.tar.gz: 0fd7fbb15a6e12d2bdc61f8753b0f9c7fbe85f9a2a43639089c166364255a27e
 SHA512:
-  metadata.gz: e4b2ee11d9e1af06232169f886a3695f14e1d2c9418d4449706af4a872932f0efa408a43b3a4f3cd2237a133f3720adc1e94ad6e313facdefe917a401b154134
-  data.tar.gz: dc2e1d251fc0cdc28d2cc340484eeae228039deab55fbca8b1c61988417d01ce5aa921a7a84367fd661f841e839718ea74048fb7738e740328bb0b969e3907a0
+  metadata.gz: 151eeb6f6a3c4a1494d40e8e231c6dcaa2b5f66673e59fbf26623d5054a74e514f3d02385b752f2d1cb20145c3ce06794286de3f34b3b11b002d4991419b7d10
+  data.tar.gz: 555e8794465a0f4ea87e05ebad167d3248e4263cb4a9de02736b3003fb06eb40f8fd20a88cda681e78f1803294d025a815c9fed80c1f00a62a0799b3bfb5d39e

data/lib/trains/version.rb

@@ -1,3 +1,3 @@
 module Trains
-  VERSION = '0.0.7'
+  VERSION = '0.0.9'.freeze
 end

data/lib/trains/visitor/migration.rb

@@ -1,42 +1,41 @@
-require "yaml"
+require 'yaml'
 
 module Trains
   module Visitor
     # Visitor that parses DB migration and associates them with Rails models
     class Migration < Base
-      def_node_matcher :send_node?, "(send nil? ...)"
-      attr_reader :is_migration, :model
-
+      def_node_matcher :send_node?, '(send nil? ...)'
+      attr_reader :is_migration, :model, :result
+
+      ALLOWED_METHOD_NAMES = %i[change up down].freeze
+      ALLOWED_TABLE_MODIFIERS = %i[
+        create_table
+        change_table
+        update_column
+        add_index
+      ].freeze
+      COLUMN_MODIFIERS = %i[
+        add_column
+        change_column
+        remove_column
+      ].freeze
+
+      # skipcq: RB-LI1087
       def initialize
-        @model = nil
-        @table_modifier = nil
-        @table_name = nil
-        @is_class = false
-        @is_migration = false
-        @class_name = nil
-        @fields = []
-
-        @scope = { class: nil, method: nil, send: nil }
+        @result = []
+        @migration_class = nil
+        @migration_version = nil
       end
 
       def on_class(node)
-        unless node.parent_class.source.include? "ActiveRecord::Migration"
+        unless node.parent_class.source.include? 'ActiveRecord::Migration'
           return
         end
 
         @migration_class = node.children.first.source
         @migration_version = extract_version(node.parent_class.source)
 
-        process_node(node.body)
-      end
-
-      def result
-        DTO::Migration.new(
-          table_name: @table_name,
-          modifier: @table_modifier,
-          fields: @fields,
-          version: @migration_version
-        )
+        process_def_node(node.body)
       end
 
       private
@@ -48,73 +47,94 @@ module Trains
         match.to_s.to_f
       end
 
-      def process_node(node)
-        return unless node.def_type?
-
-        process_def_node(node)
-      end
-
       def process_def_node(node)
-        allowed_method_names = %i[change up down]
-        allowed_table_modifiers = %i[
-          create_table
-          change_table
-          update_column
-          add_column
-          remove_column
-          change_column
-        ]
-        block_type_modifier = false
+        return unless node.def_type?
 
         method_name = node.method_name
-        return unless allowed_method_names.include? method_name
+        unless ALLOWED_METHOD_NAMES.include?(method_name) || COLUMN_MODIFIERS.include?(method_name)
+          return
+        end
         return if node.body.nil?
 
-        table_modifier =
-          if node.body.children[0] == nil
-            block_type_modifier = false
-            # if table modifier is a one-liner method call
-            node.body.children[1]
-          elsif node.body.children[0].block_type?
-            block_type_modifier = true
-            # if table modifier is in a block
-            node.body.children[0].method_name
+        case node.body.type
+        when :send
+          @result << parse_one_liner_migration(node.body)
+        when :begin
+          if node.body.children.map(&:type).include?(:block)
+            migration = parse_block_migration(node)
+            @result = [*@result, *migration] if migration
+          else
+            node.body.each_descendant(:send) do |send_node|
+              migration = parse_one_liner_migration(send_node)
+              @result << migration if migration
+            end
           end
-        return unless allowed_table_modifiers.include? table_modifier
+        when :block
+          @result = [*@result, *parse_block_migration(node)]
+        else
+          LOGGER.debug(node)
+        end
+      end
 
-        @table_modifier = table_modifier
+      def parse_one_liner_migration(node)
+        return unless COLUMN_MODIFIERS.include?(node.method_name)
 
-        # Get the name of the table being modified
-        if block_type_modifier
-          raw_table_name =
-            node.body.children[0].children[0].children[2].value.to_s
-          @table_name = raw_table_name.singularize.camelize
+        arguments = node.arguments
+        table_name = arguments[0].value.to_s.singularize.camelize
+        column_name = arguments[1].value
+        type = arguments[2].value unless node.method_name == :remove_column
 
-          node.body.children[0].children[2].each_child_node do |child|
-            process_migration_field(child)
-          end
-        else
-          raw_table_name = node.body.children[2].value.to_s
-          @table_name = raw_table_name.singularize.camelize
+        DTO::Migration.new(
+          table_name,
+          node.method_name,
+          [DTO::Field.new(column_name, type)],
+          @migration_version
+        )
+      end
 
-          field_name = node.body.children[3]&.value
-          field_type = node.body.children[4]&.value
-          @fields.append(DTO::Field.new(field_name, field_type))
+      def parse_block_migration(node)
+        migrations = []
+        # Visit every send_node that performs DDL tasks
+        node.each_descendant do |ddl_node|
+          fields = []
+
+          if ddl_node.block_type?
+            next unless ALLOWED_TABLE_MODIFIERS.include?(ddl_node.method_name)
+
+            table_name = ddl_node.send_node.arguments[0].value.to_s.singularize.camelize
+            ddl_node.body.each_descendant(:send) do |send_node|
+              fields = [*fields, *parse_migration_field(send_node)]
+            end
+
+            migrations << DTO::Migration.new(
+              table_name,
+              ddl_node.method_name,
+              fields,
+              @migration_version
+            )
+          elsif ddl_node.send_type?
+            migrations = [*migrations, *parse_one_liner_migration(ddl_node)]
+          end
         end
-      end
 
-      def process_migration_field(node)
-        return unless node.send_type?
+        migrations
+      end
 
+      def parse_migration_field(node)
+        fields = []
         if node.children[1] == :timestamps
-          @fields.append(DTO::Field.new(:created_at, :datetime))
-          @fields.append(DTO::Field.new(:updated_at, :datetime))
-          return
+          fields << DTO::Field.new(:created_at, :datetime)
+          fields << DTO::Field.new(:updated_at, :datetime)
+          return fields
         end
 
+        return [] if node.arguments.nil? || node.arguments.empty?
+
         type = node.children[1]
         value = node.children[2].value unless node.children[2].hash_type?
-        @fields.append(DTO::Field.new(value, type))
+        fields << DTO::Field.new(value, type)
+
+        fields
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trains
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.9
 platform: ruby
 authors:
 - Syed Faraaz Ahmad
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-22 00:00:00.000000000 Z
+date: 2023-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport