train-tax-calculator 2.2.5 → 2.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a05ebcb7498b2fa7b1152d043f4b07dd42738ab
-  data.tar.gz: 5709aeee64daa1bd1ba57904dd64872a83554766
+  metadata.gz: e5496be38bad6b255da10420e3dbdecaffa3040f
+  data.tar.gz: de7e01ddd593002e62393481379ddb6556fa4f45
 SHA512:
-  metadata.gz: eef56521990386d7d56df369a1fbf04d0f574bf12e4d1cbd1eb27d532fc253a296d33deed94d15ba3f83e5325880951a18e0f05bf0f1c9a3fa9156b9fdd9064c
-  data.tar.gz: 637b5e0b4c6c324063eb444bffa2ce4f7188e58bc1f957daf3d17e0f8c3fc5b0cca584e2b957d63a7da5ed2c348aed6f3f892b7a6142bbe6fa99785d4b99f7c6
+  metadata.gz: e0ae7884e6eed0f4ad5ac9f70a63c5afd425e995c93b4553c88111d884b50516b07fa1355785708d8cbf6f628fba1792ed1817fb12bdd3514847ce78c2838aff
+  data.tar.gz: 27bfce9f6de3e042024dca59b208ced8de9ecb29e7db8c8b77bd49b986c9cc54943adc3496afbe8110e7baad06b19ccce13f6aa94b6fdec70cb667b5f63d006c

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    train-tax-calculator (2.2.4)
+    train-tax-calculator (2.2.5)
 
 GEM
   remote: https://rubygems.org/

data/lib/train/tax/calculator/version.rb

@@ -1,7 +1,7 @@
 module Train
   module Tax
     module Calculator
-      VERSION = "2.2.5"
+      VERSION = "2.2.6"
     end
   end
 end

data/lib/train/tax/calculator/withholding_tax.rb

@@ -13,22 +13,33 @@ module Train::Tax::Calculator
     ]
 
     def self.compute(basic_salary)
-      taxable_income = basic_salary - Deductions.get(basic_salary)
-
-      if basic_salary > 90_000
-        monthly_taxable = ((basic_salary - 90_000) / 12.00)
-        taxable_income  = taxable_income + monthly_taxable
-      end
-
-      tax_bracket = LOOKUP_TABLE.select do |bracket|
-        taxable_income >= bracket[:lowest] &&
-        taxable_income < bracket[:highest]
-      end.first
-
+      taxable_income = compute_taxable_income_for(basic_salary)
+      tax_bracket = get_tax_bracket_for(taxable_income)
       withholding_tax = ((taxable_income - tax_bracket[:lowest]) * tax_bracket[:excess]) + tax_bracket[:base]
+
       withholding_tax.round(2)
     end
 
+    private
+
+      def self.compute_taxable_income_for(basic_salary)
+        initial_net = basic_salary - Deductions.get(basic_salary)
+
+        if basic_salary > 90_000
+          additional_tax = ((basic_salary - 90_000) / 12.00)
+          return initial_net + additional_tax
+        end
+
+        initial_net
+      end
+
+      def self.get_tax_bracket_for(taxable_income)
+        LOOKUP_TABLE.select do |bracket|
+          taxable_income >= bracket[:lowest] &&
+          taxable_income < bracket[:highest]
+        end.first
+      end
+
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: train-tax-calculator
 version: !ruby/object:Gem::Version
-  version: 2.2.5
+  version: 2.2.6
 platform: ruby
 authors:
 - Mark Chavez