trailer_vote-api 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b341c5f1af4fab01aaa581d934e82ca906802831
-  data.tar.gz: 84d7734f7f69b71c192436a6c990926f0849ec5d
+  metadata.gz: 035d07df472d9ab44ddba2e14502be9afda848d7
+  data.tar.gz: dc7b3e5583f5983bf5c91eed6ef50a85699c67ce
 SHA512:
-  metadata.gz: 46a655c726b94de729886ce610e6d0271ec75622a712656a680b5dd410a0519a07ae354cffb40f2b0df62e07561e17a65bf3b14dbeb8ac197897445257776904
-  data.tar.gz: 359f30bbb77df6eaf57617c5cd3007bc6b67156f35099281857f97eab8e5a92f0633e259105511d6dd6a88bb9d50e67dbfc8bba9c028b9710d08e89d96afb91a
+  metadata.gz: 483ea0ce019b10b29b9c8f598d3e5f2822dd0e38efca8e6e16428d4cd2a116442c0f948483c3fbf3ac2762f95715f27112eb5f8df63819b72d30b6dfd043d89d
+  data.tar.gz: 97e6fba14eabe8c3ee27c65cc9bcdcfb6f89e42f97bfd476ecf1cd76461df64664b715cd8e3c5d39aca6610193343f6efc5076c120bc4b6f0748f029867d1b77

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.8.0
+
+- Symbolize all keys to ensure interopt. with TrailerVote ingestion, and Ruby hash defaults
+- Add warning to STDERR when decoding yields a validation error (server response does not match media type)
+
 # 0.7.0
 
 - Guards network errors during all API calls

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    trailer_vote-api (0.7.0)
+    trailer_vote-api (0.8.0)
       http (>= 3.3.0, < 4.x)
       oj (>= 3.6, < 4.x)
       trailer_vote-media_types (>= 0.6.1, < 1)

data/README.md

@@ -1,4 +1,7 @@
 # TrailerVote::Api
+[![Build Status](https://travis-ci.com/TrailerVote/trailervote-api-clients.svg?branch=master)](https://travis-ci.com/TrailerVote/trailervote-api-clients)
+[![Gem Version](https://badge.fury.io/rb/trailer_vote-api.svg)](https://badge.fury.io/rb/trailer_vote-api)
+[![Maintainability](https://api.codeclimate.com/v1/badges/da722ca43c5811db5926/maintainability)](https://codeclimate.com/github/TrailerVote/trailervote-api-clients/maintainability)
 
 The TrailerVote Api gem is the official interface to communicate with the TrailerVote product service. It allows you to
 keep your code simple and not deal with the HTTP suite. 

data/lib/trailer_vote/api/composable/get.rb

@@ -18,7 +18,7 @@ module TrailerVote
         # @return [Links] the links
         def links
           # TODO: or headers
-          @links ||= Links.new(data['_links'])
+          @links ||= Links.new(data[:_links])
         end
 
         # Decode the result via {TypeRegistry}. This also takes care of MediaTypes validation.

data/lib/trailer_vote/api/configuration.rb

@@ -30,7 +30,7 @@ module TrailerVote
       end
 
       def data
-        to_h['configuration']
+        to_h[:configuration]
       end
 
       def call(url: resolve_url)

data/lib/trailer_vote/api/fallback_content_types.rb

@@ -15,7 +15,7 @@ module TrailerVote
       end
 
       def decode(obj)
-        Oj.load(obj, mode: :strict)
+        Oj.load(obj, mode: :strict, symbol_keys: true)
       rescue Oj::Error => err
         raise DecodeError.new(media_type: 'application/json', source: err)
       end

data/lib/trailer_vote/api/links.rb

@@ -8,12 +8,13 @@ module TrailerVote
       end
 
       def respond_to_missing?(method_name, include_private = false)
-        links.key?(String(method_name)) || super
+        links.key?(method_name) || super
       end
 
       def method_missing(method_name, *arguments)
-        if links.key?(String(method_name))
-          return call(String(method_name), *arguments)
+        link_name = method_name
+        if links.key?(link_name)
+          return call(link_name, *arguments)
         end
 
         if /[a-z_]+/.match? method_name
@@ -37,10 +38,10 @@ module TrailerVote
 
       def call(link, **arguments)
         if arguments.length.zero?
-          return self[link]['href']
+          return self[link][:href]
         end
 
-        fill_template(self[link]['href'], **arguments)
+        fill_template(self[link][:href], **arguments)
       end
 
       def fill_template(templated, **arguments)

data/lib/trailer_vote/api/place/find.rb

@@ -46,7 +46,7 @@ module TrailerVote
         end
 
         def data
-          to_h['place']
+          to_h[:place]
         end
 
         def parent

data/lib/trailer_vote/api/product/find.rb

@@ -47,7 +47,7 @@ module TrailerVote
         end
 
         def data
-          to_h['product']
+          to_h[:product]
         end
       end
     end

data/lib/trailer_vote/api/product/image/find.rb

@@ -45,7 +45,7 @@ module TrailerVote
           end
 
           def data
-            to_h['product_image']
+            to_h[:product_image]
           end
         end
       end

data/lib/trailer_vote/api/product/image/urls.rb

@@ -40,7 +40,7 @@ module TrailerVote
           end
 
           def data
-            to_h['product_images']
+            to_h[:product_images]
           end
 
           private

data/lib/trailer_vote/api/product/video/find.rb

@@ -47,7 +47,7 @@ module TrailerVote
           end
 
           def data
-            to_h['product_video']
+            to_h[:product_video]
           end
         end
       end

data/lib/trailer_vote/api/product/video/urls.rb

@@ -40,7 +40,7 @@ module TrailerVote
           end
 
           def data
-            to_h['product_videos']
+            to_h[:product_videos]
           end
 
           private

data/lib/trailer_vote/api/type_registry.rb

@@ -77,10 +77,14 @@ module TrailerVote
         def define_decode(adapter, media_type)
           adapter.define_singleton_method('decode') do |str|
             begin
-              Oj.load(str, mode: :strict).tap do |result|
-                media_type.valid?(result)
+              Oj.load(str, mode: :strict, symbol_keys: true).tap do |result|
+                begin
+                  media_type.validate!(result)
+                rescue ::MediaTypes::Scheme::ValidationError => err
+                  warn format('Decode error! API might now be in an invalid or incomplete state. %<err>s', err: err)
+                end
               end
-            rescue Oj::Error, ::MediaTypes::Scheme::ValidationError => err
+            rescue Oj::Error => err
               raise DecodeError.new(media_type: media_type, source: err)
             end
           end

data/lib/trailer_vote/api/version.rb

@@ -2,6 +2,6 @@
 
 module TrailerVote
   module Api
-    VERSION = '0.7.0'
+    VERSION = '0.8.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trailer_vote-api
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Derk-Jan Karrenbeld