trailblazer-operation 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d01fa1d700a2dd5435e8f166189be31b2da6ec460eec204c6aac8b02887c9ad6
-  data.tar.gz: a0f41c6afd8f2e85ff86ceab11be439b8ea0ef3340b8e33ada6c34bcf2f5bca6
+  metadata.gz: 72f9bed867af38feb73cc3cd6eae06ac1621870649d315d93c17ef2fb2f01c9d
+  data.tar.gz: e4c512de05dd2dda4c670d0322455d9e0e2b8b3e646e237c553e4e49d8db70cd
 SHA512:
-  metadata.gz: c7f95eed76ec2109879d2750636e43d82da24f42af7d58e037538565cd115ff04e9cf2cbeb9d4f2170cb614fb0585d2edbe98ce2a7c94d7d732c8d1ded6e60f8
-  data.tar.gz: efd28f9dff2d79bfea21d2438119d8e619410333a904ba50dcccc13d450ae42efd1d71639068bd40168f2283c9c34f1fb9834f8ae56b866d16b2bc0e1b425526
+  metadata.gz: 808122f1bb28e26261afa083fd9718811d2c578a9e230cc59f091f623b447d17daece7f8caad233b8069bce50e99e45f04670f4037cef01d5e8ee697a795cd44
+  data.tar.gz: 7161f4c1341072a67c9d02fca6b1fb8d8c11befe66f722ab65a455bfbf0a226dc19dce8c1d6adb9beb6a490b753d7722b077e9a7d63b6ae10a3cc6ff01e617a1

data/CHANGES.md

@@ -1,3 +1,7 @@
+## 0.5.1
+
+* Remove Inspect. this now sits in the `developer` gem as `Developer.railway`.
+
 ## 0.5.0
 
 * Minimal API around `Activity::FastTrack` to support the old public call style.

data/Gemfile

@@ -10,7 +10,7 @@ gem "dry-auto_inject"
 gem "benchmark-ips"
 gem "minitest-line"
 
-# gem "trailblazer-developer", path: "../developer"
+gem "trailblazer-developer", path: "../trailblazer-developer"
 # gem "trailblazer-developer", git: "https://github.com/trailblazer/trailblazer-developer"
 # gem "trailblazer-activity", path: "../trailblazer-activity"
 # gem "trailblazer-activity-dsl-linear", path: "../trailblazer-activity-dsl-linear"

data/lib/trailblazer/operation.rb

@@ -62,8 +62,6 @@ module Trailblazer
   end
 end
 
-require "trailblazer/operation/inspect"
-
 require "trailblazer/operation/class_dependencies"
 require "trailblazer/operation/deprecated_macro" # TODO: remove in 2.2.
 

data/lib/trailblazer/operation/version.rb

@@ -1,7 +1,7 @@
 module Trailblazer
   module Version
     module Operation
-      VERSION = "0.5.0"
+      VERSION = "0.5.1"
     end
   end
 end

data/test/docs/wiring_test.rb

@@ -287,119 +287,6 @@ describe all options :pass_fast, :fast_track and emiting signals directly, like
   end
 end
 
-=begin
-:before, :after, :replace, :delete, :group, :id
-=end
-class WiringsDocSeqOptionsTest < Minitest::Spec
-  module Id
-    Memo = Class.new(WiringDocsTest::Memo)
-
-    #:id
-    class Memo::Create < Trailblazer::Operation
-      step :create_model, id: "create_memo"
-      step :validate,     id: "validate_params"
-      step :save
-      #~id-methods
-      def create_model(options, **)
-      end
-
-      def validate(options, **)
-      end
-
-      def save(options, **)
-      end
-      #~id-methods end
-    end
-    #:id end
-
-    #:delete
-    class Memo::Create::Admin < Memo::Create
-      step nil, delete: "validate_params", id: ""
-    end
-    #:delete end
-
-    #:before
-    class Memo::Create::Authorized < Memo::Create
-      step :policy, before: "create_memo"
-      #~before-methods
-      def policy(options, **)
-      end
-      #~before-methods end
-    end
-    #:before end
-
-    #:after
-    class Memo::Create::Logging < Memo::Create
-      step :logger, after: "validate_params"
-      #~after-methods
-      def logger(options, **)
-      end
-      #~after-methods end
-    end
-    #:after end
-
-    #:replace
-    class Memo::Update < Memo::Create
-      step :find_model, replace: "create_memo", id: "update_memo"
-      #~replace-methods
-      def find_model(options, **)
-      end
-      #~replace-methods end
-    end
-    #:replace end
-  end
-
-  it ":id shows up in introspect" do
-    Memo = Id::Memo
-    #:id-inspect
-    Trailblazer::Operation.introspect(Memo::Create)
-    #=> [>create_memo,>validate_params,>save]
-    #:id-inspect end
-
-    Trailblazer::Operation.introspect(Memo::Create).must_equal %{[>create_memo,>validate_params,>save]}
-  end
-
-  it ":delete removes step" do
-    Memo = Id::Memo
-    #:delete-inspect
-    Trailblazer::Operation.introspect(Memo::Create::Admin)
-    #=> [>create_model,>save]
-    #:delete-inspect end
-
-    Trailblazer::Operation.introspect(Memo::Create::Admin).must_equal %{[>create_memo,>save]}
-  end
-
-  it ":before inserts" do
-    Memo = Id::Memo
-    #:before-inspect
-    Trailblazer::Operation.introspect(Memo::Create::Authorized)
-    #=> [>create_model,>save]
-    #:before-inspect end
-
-    Trailblazer::Operation.introspect(Memo::Create::Authorized).must_equal %{[>policy,>create_memo,>validate_params,>save]}
-  end
-
-  it ":after inserts" do
-    Memo = Id::Memo
-    #:after-inspect
-    Trailblazer::Operation.introspect(Memo::Create::Logging)
-    #=> [>create_memo,>validate_params,>logger,>save]
-    #:after-inspect end
-
-    Trailblazer::Operation.introspect(Memo::Create::Logging).must_equal %{[>create_memo,>validate_params,>logger,>save]}
-  end
-
-  it ":replace inserts" do
-    Memo = Id::Memo
-    #:replace-inspect
-    Trailblazer::Operation.introspect(Memo::Update)
-    #=> [>update_memo,>validate_params,>save]
-    #:replace-inspect end
-
-    Trailblazer::Operation.introspect(Memo::Update).must_equal %{[>update_memo,>validate_params,>save]}
-  end
-end
-
 # @see https://github.com/trailblazer/trailblazer/issues/190#issuecomment-326992255
 class WiringsDocRecoverTest < Minitest::Spec
   Memo = WiringDocsTest::Memo

data/test/step_test.rb

@@ -40,7 +40,7 @@ class StepTest < Minitest::Spec
 
   it { Create.(a: 1, b: 2, c: 3, d: 4, e: 5).inspect("a", "b", "c", "d", "e").must_equal "<Result:true [1, 2, 3, 4, 5] >" }
 
-  it { Trailblazer::Operation::Inspect.(Create).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro]} }
+  it { Trailblazer::Developer.railway(Create).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro]} }
 
   #---
   #- :before, :after, :replace, :delete, :override
@@ -61,7 +61,7 @@ class StepTest < Minitest::Spec
     def d!(options, **); options["order"] << "d"; end
   end
 
-  it { Trailblazer::Operation::Inspect.(B).must_equal %{[>b!,>d!,>c!,>a!]} }
+  it { Trailblazer::Developer.railway(B).must_equal %{[>b!,>d!,>c!,>a!]} }
 
   class C < B
     step :e!, replace: :c!
@@ -69,7 +69,7 @@ class StepTest < Minitest::Spec
     def e!(options, **); options["order"] << "e"; end
   end
 
-  it { Trailblazer::Operation::Inspect.(C).must_equal %{[>b!,>e!,>a!]} }
+  it { Trailblazer::Developer.railway(C).must_equal %{[>b!,>e!,>a!]} }
   it { C.("order" => []).inspect("order").must_equal %{<Result:true [["b", "e", "a"]] >} }
 
   #---
@@ -84,7 +84,7 @@ class StepTest < Minitest::Spec
     def add!(options, **); options["a"] << :b; end
   end
 
-  it { Trailblazer::Operation::Inspect.(D).must_equal %{[>a!,>add!,>another_add!]} }
+  it { Trailblazer::Developer.railway(D).must_equal %{[>a!,>add!,>another_add!]} }
   it { D.().inspect("a").must_equal %{<Result:true [[:b, :b]] >} }
 
   class E < Trailblazer::Operation
@@ -97,7 +97,7 @@ class StepTest < Minitest::Spec
     include T.def_steps(:a)
   end
 
-  it { Trailblazer::Operation::Inspect.(E).must_equal %{[>a,>b]} }
+  it { Trailblazer::Developer.railway(E).must_equal %{[>a,>b]} }
   it { E.(seq: []).inspect(:seq).must_equal %{<Result:true [[:a, :b]] >} }
 
   #- with proc
@@ -109,7 +109,7 @@ class StepTest < Minitest::Spec
     def a!(options, **);   options["a"] = []; end
   end
 
-  it { Trailblazer::Operation::Inspect.(F).must_equal %{[>a!,>add!!!]} }
+  it { Trailblazer::Developer.railway(F).must_equal %{[>a!,>add!!!]} }
   it { F.().inspect("a").must_equal %{<Result:true [[:b]] >} }
 
   #- with macro
@@ -126,7 +126,7 @@ class StepTest < Minitest::Spec
     def a!(options, **);   options["a"] = []; end
   end
 
-  it { Trailblazer::Operation::Inspect.(G).must_equal %{[>a!,>add]} }
+  it { Trailblazer::Developer.railway(G).must_equal %{[>a!,>add]} }
   it { G.().inspect("a").must_equal %{<Result:true [[:b]] >} }
 
   # override: true in inherited class with macro
@@ -135,7 +135,7 @@ class StepTest < Minitest::Spec
     step task: MyMacro, override: true, id: "add"
   end
 
-  it { Trailblazer::Operation::Inspect.(Go).must_equal %{[>a!,>add]} }
+  it { Trailblazer::Developer.railway(Go).must_equal %{[>a!,>add]} }
   it { Go.().inspect("a").must_equal %{<Result:true [[:m]] >} }
 
   #- with inheritance
@@ -154,7 +154,7 @@ class StepTest < Minitest::Spec
     def _add!(options, **); options["a"] << :hh; end
   end
 
-  it { Trailblazer::Operation::Inspect.(Hh).must_equal %{[>a!,>_add!]} }
+  it { Trailblazer::Developer.railway(Hh).must_equal %{[>a!,>_add!]} }
   it { Hh.().inspect("a").must_equal %{<Result:true [[:hh]] >} }
 
   #- inheritance unit test
@@ -190,20 +190,20 @@ class StepTest < Minitest::Spec
     step({task: "MyMacro", id: "I win!"}, id: "No, I do!")
   end
 
-  it { Trailblazer::Operation::Inspect.(Index).must_equal %{[>my validate,>persist!,>I win!,>No, I do!]} }
+  it { Trailblazer::Developer.railway(Index).must_equal %{[>my validate,>persist!,>I win!,>No, I do!]} }
 
   #---
   #- inheritance
   class New < Create
   end
 
-  it { Trailblazer::Operation::Inspect.(New).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro]} }
+  it { Trailblazer::Developer.railway(New).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro]} }
 
   class Update < Create
     step :after_save!
   end
 
-  it { Trailblazer::Operation::Inspect.(Update).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro,>after_save!]} }
+  it { Trailblazer::Developer.railway(Update).gsub(/0x.+?step_test.rb/, "").must_equal %{[>#<Proc::30 (lambda)>,>StepTest::Callable,>#<Method: StepTest::Implementation.c>,>d,>MyMacro,>after_save!]} }
 end
 
 #---
@@ -226,7 +226,7 @@ class StepWithDeprecatedMacroTest < Minitest::Spec
     step [AnotherOldMacro, id: :oldie]
   end
 
-  it { skip; Trailblazer::Operation::Inspect.(Create).gsub(/0x.+?step_test.rb/, "").must_equal %{[>outdated,>oldie]} }
+  it { skip; Trailblazer::Developer.railway(Create).gsub(/0x.+?step_test.rb/, "").must_equal %{[>outdated,>oldie]} }
   it { skip; Create.().inspect("x", "y").must_equal %{<Result:true [StepWithDeprecatedMacroTest::Create, StepWithDeprecatedMacroTest::Create] >} }
 end
 

data/test/test_helper.rb

@@ -3,6 +3,7 @@ require "pp"
 require "minitest/autorun"
 require "trailblazer/operation"
 require "trailblazer/activity/testing"
+require "trailblazer/developer/render/linear"
 
 Minitest::Spec.class_eval do
   Activity = Trailblazer::Activity

data/trailblazer-operation.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "trailblazer-developer", ">= 0.0.3"
 
   spec.required_ruby_version = ">= 2.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-operation
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-16 00:00:00.000000000 Z
+date: 2019-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-activity-dsl-linear
@@ -106,6 +106,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: trailblazer-developer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.3
 description: Trailblazer's operation object.
 email:
 - apotonick@gmail.com
@@ -126,7 +140,6 @@ files:
 - lib/trailblazer/operation/class_dependencies.rb
 - lib/trailblazer/operation/container.rb
 - lib/trailblazer/operation/deprecated_macro.rb
-- lib/trailblazer/operation/inspect.rb
 - lib/trailblazer/operation/public_call.rb
 - lib/trailblazer/operation/railway.rb
 - lib/trailblazer/operation/railway/macaroni.rb
@@ -148,7 +161,6 @@ files:
 - test/gemfiles/Gemfile.ruby-2.0.lock
 - test/gemfiles/Gemfile.ruby-2.3
 - test/inheritance_test.rb
-- test/inspect_test.rb
 - test/introspect_test.rb
 - test/operation_test.rb
 - test/result_test.rb
@@ -202,7 +214,6 @@ test_files:
 - test/gemfiles/Gemfile.ruby-2.0.lock
 - test/gemfiles/Gemfile.ruby-2.3
 - test/inheritance_test.rb
-- test/inspect_test.rb
 - test/introspect_test.rb
 - test/operation_test.rb
 - test/result_test.rb

data/lib/trailblazer/operation/inspect.rb

@@ -1,69 +0,0 @@
-module Trailblazer
-  # Operation-specific circuit rendering. This is optimized for a linear railway circuit.
-  #
-  # @private
-  #
-  # NOTE: this is absolutely to be considered as prototyping and acts more like a test helper ATM as
-  # Inspect is not a mission-critical part.
-  class Operation
-    def self.introspect(*args)
-      Operation::Inspect.(*args)
-    end
-  end
-
-  module Operation::Inspect
-    module_function
-
-    def call(operation, options = {style: :line})
-      graph = Activity::Introspect::Graph(operation)
-
-      rows = graph.collect do |node, i|
-        next if node[:data][:stop_event] # DISCUSS: show this?
-
-        created_by = node[:data][:dsl_track] || :pass
-
-        [i, [created_by, node.id]]
-      end.compact
-
-      rows = rows[1..-1] # remove start
-
-      return inspect_line(rows) if options[:style] == :line
-
-      return inspect_rows(rows)
-    end
-
-    def inspect_func(step)
-      @inspect[step]
-    end
-
-    Operator = {fail: "<<", pass: ">>", step: ">"}
-
-    def inspect_line(names)
-      string = names.collect { |i, (end_of_edge, name)| "#{Operator[end_of_edge]}#{name}" }.join(",")
-      "[#{string}]"
-    end
-
-    def inspect_rows(names)
-      string = names.collect do |i, (end_of_edge, name)|
-        operator = Operator[end_of_edge]
-
-        op = "#{operator}#{name}"
-        padding = 38
-
-        proc = if operator == "<<"
-                 sprintf("%- #{padding}s", op)
-               elsif [">", ">>", "&"].include?(operator.to_s)
-                 sprintf("% #{padding}s", op)
-               else
-                 pad = " " * ((padding - op.length) / 2)
-                 "#{pad}#{op}#{pad}"
-               end
-
-        proc = proc.gsub(" ", "=")
-
-        sprintf("%2d %s", i, proc)
-      end.join("\n")
-      "\n#{string}"
-    end
-  end
-end

data/test/inspect_test.rb

@@ -1,42 +0,0 @@
-require "test_helper"
-
-class InspectTest < Minitest::Spec
-  # Test: #to_table
-  class Create < Trailblazer::Operation
-    step :decide!
-    pass :wasnt_ok!
-    pass :was_ok!
-    fail :return_true!
-    fail :return_false!
-    step :finalize!
-  end
-
-  #---
-  #- to_table
-
-  # pp Create.instance_variable_get(:@builder)
-
-  it do
-    Trailblazer::Operation.introspect(Create).must_equal %{[>decide!,>>wasnt_ok!,>>was_ok!,<<return_true!,<<return_false!,>finalize!]}
-  end
-
-  it do
-    Trailblazer::Operation::Inspect.call(Create, style: :rows).must_equal %{
- 1 ==============================>decide!
- 2 ===========================>>wasnt_ok!
- 3 =============================>>was_ok!
- 4 <<return_true!========================
- 5 <<return_false!=======================
- 6 ============================>finalize!}
-  end
-
-  describe "step with only one output (happens with Nested)" do
-    class Present < Trailblazer::Operation
-      pass :ok!, outputs: {:success => Trailblazer::Activity::Output("signal", :success)}
-    end
-
-    it do
-      Trailblazer::Operation.introspect(Present).must_equal %{[>>ok!]}
-    end
-  end
-end