trailblazer-developer 0.0.11 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1bd9598d12d74fcd1dcbe20a50d53642ee2fe9ca8aad9648332630dee4b8fb7a
-  data.tar.gz: bc6b62c30541f118e756d72646da251cdbc2eef1d95dcb806c22aca10c1b64d3
+  metadata.gz: a94a8ac8694a1873372e769d083aa50930d5b5ecac8bfd774fe9416583c0de6f
+  data.tar.gz: af93d4503430bd88878d1797849c6546cf48f3a1b1be3c66096dff7e7dea7763
 SHA512:
-  metadata.gz: ce2bc17462233a132411006e1bcb0d2b992e8e378faef8293d2be1d2916c691aba17def994644d7ae1428f65302d8d6496dc0fe583e484c036015415d9e4349e
-  data.tar.gz: f621040bab0043a71332f8a5ff325aae117612ba105116c527b57b4caacdeb52e067a2d8b5d5f6fadd5d290231fbb1c07ca1a036635d17d13a92d52c3e702629
+  metadata.gz: '08cd8a7b2b2ac54d86454e8c4a497a4462ffae30e05b74d87f557297716918f18dc4b091982f62ef13891cec0bd40ca6cc1edce44af48feb994ef7c94e8623e8'
+  data.tar.gz: b12a63e25446af1e74205c4168684e8ded06de676849638f7180a837690dc5a56c90396d978da0a836995753f3b9b9dfd3366db96e5165cd3462a1009c5cbb01

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 rvm:
-  - 2.6.2
-  - 2.5.5
-  - 2.4.4
+  - 2.6
+  - 2.5
+  - 2.4
 
 cache: bundler

data/{lib/trailblazer/developer/CHANGES.md → CHANGES.md}

@@ -1,3 +1,24 @@
+# 0.0.16
+
+* Remove Declarative warning correctly
+
+# 0.0.15
+
+* Fix `Dev.wtf` circuit interface definition
+
+# 0.0.14
+
+* Revert declarative warning changes
+
+# 0.0.13
+
+* Allow focusing on selected variables for all steps in wtf
+* Fix declarative deprecation warning
+
+# 0.0.12
+
+* Revert Hash#compact usage to support Rubies <= 2.4
+
 # 0.0.11
 
 * Allow injecting custom data collector in Trace API, to collect custom input/output ctx of task nodes.

data/Rakefile

@@ -1,6 +1,5 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
-require "rubocop/rake_task"
 
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
@@ -8,7 +7,5 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
-RuboCop::RakeTask.new(:rubocop)
-
 desc "Running Tests"
 task default: %i[test]

data/lib/trailblazer/developer/client.rb

@@ -31,7 +31,7 @@ module Trailblazer::Developer
       return false unless response.status == 200
 
       # token = CGI::Cookie.parse(response.headers["set-cookie"])["token"][0]
-      token = JSON.parse(response.body)["token"]
+      JSON.parse(response.body)["token"]
     end
 
     def export_diagram(id:, query:, **options)
@@ -60,7 +60,7 @@ module Trailblazer::Developer
     def request(host:, url:, method:, token:, body:, **)
       conn = Faraday.new(url: host)
 
-      response = conn.send(method) do |req|
+      conn.send(method) do |req|
         req.url url
         req.headers["Content-Type"] = "application/json"
         req.body = body

data/lib/trailblazer/developer/generate.rb

@@ -17,7 +17,7 @@ module Trailblazer
           collection :elements, class: Element do
             property :id
             property :type
-            collection :linksTo, class: Arrow, default: [] do
+            collection :linksTo, class: Arrow, default: ::Declarative::Variables::Append([]) do
               property :target
               property :label
               property :message
@@ -31,7 +31,7 @@ module Trailblazer
       end
 
       def call(hash)
-        signal, (ctx, _) = Activity::TaskWrap.invoke(Pipeline, hash: hash)
+        _, (ctx, _) = Activity::TaskWrap.invoke(Pipeline, hash: hash)
         ctx[:intermediate]
       end
 
@@ -51,16 +51,16 @@ module Trailblazer
         wiring = elements.collect { |el|
           data = data_for(el)
 
-          [inter.TaskRef(el.id, data), el.linksTo.collect { |arrow| inter.Out(semantic_for(arrow.to_h), arrow.target) } ] }
+          [inter.TaskRef(el.id, data), el.linksTo.collect { |arrow| inter.Out(semantic_for(**arrow.to_h), arrow.target) } ] }
         wiring = Hash[wiring]
 
         # end events need this stupid special handling
         # DISCUSS: currently, the END-SEMANTIC is read from the event's label.
         wiring = wiring.merge(Hash[
           end_events.collect do |_end|
-            ref, outputs = wiring.find { |ref, _| ref.id == _end.id }
+            ref, = wiring.find { |ref, _| ref.id == _end.id }
 
-            [ref, [inter.Out(semantic_for(_end.to_h)|| raise, nil)]] # TODO: test the raise, happens when the semantic of an End can't be distinguished. # TODO: don't extract semantic from :label but from :data.
+            [ref, [inter.Out(semantic_for(**_end.to_h)|| raise, nil)]] # TODO: test the raise, happens when the semantic of an End can't be distinguished. # TODO: don't extract semantic from :label but from :data.
           end
         ])
         # pp wiring

data/lib/trailblazer/developer/trace.rb

@@ -7,10 +7,10 @@ module Trailblazer::Developer
 
     class << self
       # Public entry point to activate tracing when running {activity}.
-      def call(activity, (ctx, flow_options), circuit_options={})
-        activity, (ctx, flow_options), circuit_options = Trace.arguments_for_call( activity, [ctx, flow_options], circuit_options ) # only run once for the entire circuit!
+      def call(activity, (ctx, flow_options), **circuit_options)
+        activity, (ctx, flow_options), circuit_options = Trace.arguments_for_call( activity, [ctx, flow_options], **circuit_options ) # only run once for the entire circuit!
 
-        signal, (ctx, flow_options) = Activity::TaskWrap.invoke(activity, [ctx, flow_options], circuit_options)
+        signal, (ctx, flow_options) = Activity::TaskWrap.invoke(activity, [ctx, flow_options], **circuit_options)
 
         return flow_options[:stack], signal, [ctx, flow_options]
       end

data/lib/trailblazer/developer/trace/focusable.rb

@@ -30,7 +30,12 @@ module Trailblazer
         #    message: "WTF!"
         #        seq: [:a]
         def tree_nodes_for(level, input:, output:, **options)
-          input_output_nodes = { Input: input, Output: output }.compact.collect do |table_header, entity|
+          # TODO: Reverting `Hash#compact` usage as it is not supported in Ruby <= 2.4
+          # Once the support is droped, revert actual code with below and remove entity check.
+          # input_output_nodes = { Input: input, Output: output }.compact.collect do |table_header, entity|
+
+          input_output_nodes = { Input: input, Output: output }.collect do |table_header, entity|
+            next unless entity
             next unless Array( entity.data[:focused_variables] ).any?
 
             table = vertical_table_for(entity.data[:focused_variables], table_header: table_header)

data/lib/trailblazer/developer/trace/present.rb

@@ -14,7 +14,7 @@ module Trailblazer::Developer
       end
 
       def tree(stack, level, tree:, renderer:, **options)
-        tree_for(stack, level, options.merge(tree: tree))
+        tree_for(stack, level, **options.merge(tree: tree))
 
         nodes = tree.each_with_index.map do |task_node, position|
           renderer.(task_node: task_node, position: position, tree: tree)
@@ -30,7 +30,7 @@ module Trailblazer::Developer
           tree.push(*TreeNodes.for(level, options.merge(input: input, output: output)))
 
           if nested.any? # nesting
-            tree_for(nested, level + 1, options.merge(tree: tree))
+            tree_for(nested, level + 1, **options.merge(tree: tree))
           end
 
           tree

data/lib/trailblazer/developer/version.rb

@@ -1,7 +1,7 @@
 module Trailblazer
   module Version
     module Developer
-      VERSION = "0.0.11"
+      VERSION = "0.0.16"
     end
   end
 end

data/lib/trailblazer/developer/wtf.rb

@@ -14,13 +14,13 @@ module Trailblazer::Developer
 
     # Run {activity} with tracing enabled and inject a mutable {Stack} instance.
     # This allows to display the trace even when an exception happened
-    def invoke(activity, (ctx, flow_options), *circuit_options)
+    def invoke(activity, (ctx, flow_options), **circuit_options)
       activity, (ctx, flow_options), circuit_options = Wtf.arguments_for_trace(
-        activity, [ctx, flow_options], *circuit_options
+        activity, [ctx, flow_options], circuit_options
       )
 
       _returned_stack, signal, (ctx, flow_options) = Trace.invoke(
-        activity, [ctx, flow_options], *circuit_options
+        activity, [ctx, flow_options], circuit_options
       )
 
       return signal, [ctx, flow_options], circuit_options
@@ -57,10 +57,11 @@ module Trailblazer::Developer
 
     # Overring default input and output data collectors to collect/capture
     #   1. inspect of focusable variables for given focusable step
+    #   2. Or inspect of focused variables for all steps
     def trace_input_data_collector(wrap_config, (ctx, flow_options), circuit_options)
       data = Trace.default_input_data_collector(wrap_config, [ctx, flow_options], circuit_options)
 
-      if flow_options[:focus_on][:steps].include?(data[:task_name])
+      if Wtf.caputure_variables?(step_name: data[:task_name], **flow_options)
         data[:focused_variables] = Trace::Focusable.capture_variables_from(ctx, **flow_options)
       end
 
@@ -68,14 +69,21 @@ module Trailblazer::Developer
     end
 
     def trace_output_data_collector(wrap_config, (ctx, flow_options), circuit_options)
-      data = Trace.default_output_data_collector(wrap_config, [ctx, flow_options], circuit_options)
-
+      data  = Trace.default_output_data_collector(wrap_config, [ctx, flow_options], circuit_options)
       input = flow_options[:stack].top
-      if flow_options[:focus_on][:steps].include?(input.data[:task_name])
+
+      if Wtf.caputure_variables?(step_name: input.data[:task_name], **flow_options)
         data[:focused_variables] = Trace::Focusable.capture_variables_from(ctx, **flow_options)
       end
 
       data
     end
+
+    # private
+    def caputure_variables?(step_name:, focus_on:, **)
+      return true if focus_on[:steps].include?(step_name)                 # For given step
+      return true if focus_on[:steps].empty? && focus_on[:variables].any? # For selected vars but all steps
+      return false
+    end
   end
 end

data/trailblazer-developer.gemspec

@@ -22,9 +22,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "minitest-line"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rubocop"
 
-  spec.add_dependency "trailblazer-activity", ">= 0.10.0", "< 1.0.0"
+  spec.add_dependency "trailblazer-activity", ">= 0.11.0", "< 1.0.0"
   spec.add_dependency "trailblazer-activity-dsl-linear"
   spec.add_dependency "representable"
   spec.add_dependency "hirb"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-developer
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.16
 platform: ruby
 authors:
 - Nick Sutterer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-03 00:00:00.000000000 Z
+date: 2020-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,27 +66,13 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: trailblazer-activity
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -96,7 +82,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.10.0
+        version: 0.11.0
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -150,8 +136,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rubocop.yml"
 - ".travis.yml"
+- CHANGES.md
 - Gemfile
 - LICENSE
 - README.md
@@ -160,7 +146,6 @@ files:
 - bin/setup
 - gems.local.rb
 - lib/trailblazer/developer.rb
-- lib/trailblazer/developer/CHANGES.md
 - lib/trailblazer/developer/client.rb
 - lib/trailblazer/developer/generate.rb
 - lib/trailblazer/developer/render/circuit.rb
@@ -178,7 +163,7 @@ homepage: http://trailblazer.to
 licenses:
 - LGPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -193,8 +178,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Developer tools for Trailblazer.
 test_files: []

data/.rubocop.yml

@@ -1,36 +0,0 @@
-inherit_from:
-  - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
-
-AllCops:
-  TargetRubyVersion: 2.5
-  Exclude:
-    - 'test/hash/bla.rb'
-
-Metrics/LineLength:
-  Exclude:
-    - test/diagram_test.rb
-
-Naming/MethodName:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-# DISCUSS: user map instead of collect
-Style/CollectionMethods:
-  Enabled: false
-
-# DISCUSS: Use raise with an explicit exception class and message, rather than just a message
-Style/ImplicitRuntimeError:
-  Enabled: false
-
-Style/Lambda:
-  EnforcedStyle: literal
-
-# DISCUSS: Use fail instead of raise to signal exceptions
-Style/SignalException:
-  Enabled: false
-
-# DISUSS: this could be false because we have if locals blabla
-Bundler/DuplicatedGem:
-  Enabled: false