trailblazer-developer 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41c30437086de2bc9a0148eccf3db59603e484f92c032ff923cd0275fd369db0
-  data.tar.gz: bd45234bd028d5a5ef5348959da4b834ffdc6bf79af3821689718d76055ef4df
+  metadata.gz: c162908350116143c05730ff70ef9336d826214f9a3fca7d159e5487ad4814a3
+  data.tar.gz: 07dc4b9adccc4a6b302f4b1382791a1b7001244b4ecb6e600dd6e67986eb13be
 SHA512:
-  metadata.gz: a66246114d6111e30c76993e18308675544b7623a8afcf732c9e0feab79cdda46dbcc3f789c20ea990c2276f1ef48321802b8f59c40706beab6480aa587bee80
-  data.tar.gz: 4bfdbbb63921aadf36c77c4c96a2da0e2efc0d283140b0263c504743bca92fbbc26a6f31ad7910bae09654e80a58c8d1deb53513fb1866c9e49bb060cc5ad313
+  metadata.gz: 45b8781d48450057467840d4742c9499b7d75bc26cb7ec7afda25ea6b57adfdae01ee93383ac2680203b50f33242c725d298f639f7aac342b018c4364054ba03
+  data.tar.gz: 0343ef1ffdc8b5cdda41991112f968e45b80e25b5fdd30c47ffa259296b4ca56eed7209f05697fa16d91a91286c2f39d0b6ade72122d00b0b3799ac1cd0f668e

data/.gitignore

@@ -1,9 +1,14 @@
+.idea
+.rakeTasks
+.tool-versions
 /.bundle/
 /.yardoc
 /Gemfile.lock
+/gems.local.rb.lock
 /_yardoc/
 /coverage/
 /doc/
 /pkg/
 /spec/reports/
 /tmp/
+.rubocop-https---raw-githubusercontent-com-trailblazer-meta-master-rubocop-yml

data/.rubocop.yml

@@ -2,7 +2,7 @@ inherit_from:
   - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.5
   Exclude:
     - 'test/hash/bla.rb'
 

data/.travis.yml

@@ -1,6 +1,7 @@
-sudo: false
 language: ruby
 rvm:
-  - 2.3.1
-before_install:
-  - gem install bundler
+  - 2.6.2
+  - 2.5.5
+  - 2.4.4
+
+cache: bundler

data/Gemfile

@@ -4,9 +4,8 @@ source "https://rubygems.org"
 gemspec
 
 # gem "trailblazer-activity", ">= 0.7.1"
-gem "trailblazer-activity", path: "../trailblazer-activity"
-gem "trailblazer-activity-dsl-linear", path: "../trailblazer-activity-dsl-linear"
-
-# gem "json"
+# gem "trailblazer-activity", path: "../trailblazer-activity"
+# gem "trailblazer-activity-dsl-linear", path: "../trailblazer-activity-dsl-linear"
+# gem "trailblazer-activity-dsl-linear", github: "trailblazer/trailblazer-activity-dsl-linear"
 
 gem "representable"

data/Rakefile

@@ -11,4 +11,4 @@ end
 RuboCop::RakeTask.new(:rubocop)
 
 desc "Running Tests"
-task default: %i[test rubocop]
+task default: %i[test]

data/gems.local.rb

@@ -0,0 +1,8 @@
+source "https://rubygems.org"
+
+# Specify your gem's dependencies in trailblazer-developer.gemspec
+gemspec
+
+gem "trailblazer-activity", path: "../trailblazer-activity"
+gem "trailblazer-activity-dsl-linear", path: "../trailblazer-activity-dsl-linear"
+gem "representable"

data/lib/trailblazer/developer/CHANGES.md

@@ -0,0 +1,7 @@
+# 0.0.2
+
+* Add `Developer.render` shortcut to `Render::Circuit`.
+
+# 0.0.1
+
+* Initial release into an unsuspecting world.

data/lib/trailblazer/developer/generate.rb

@@ -7,7 +7,7 @@ module Trailblazer
       module_function
 
       Element = Struct.new(:id, :type, :linksTo, :data, :label)
-      Arrow   = Struct.new(:target, :label)
+      Arrow   = Struct.new(:target, :label, :message)
 
       module Representer
         class Activity < Representable::Decorator
@@ -19,18 +19,33 @@ module Trailblazer
             collection :linksTo, class: Arrow, default: [] do
               property :target
               property :label
+              property :message
             end
             property :data, default: {}
+
             property :label
           end
         end
       end
 
       def call(hash)
-        elements = Representer::Activity.new(OpenStruct.new).from_hash(hash).elements
+        elements = transform_from_hash(hash)
+        elements = remap_ids(elements)
+
+        compute_intermediate(elements)
+      end
+
+      def transform_from_hash(hash)
+        Representer::Activity.new(OpenStruct.new).from_hash(hash).elements
+      end
+
+      def find_start_events(elements)
+        elements.find_all { |el| el.type == "Event" }
+      end
 
-        start_events = elements.find_all { |el| el.type == "Event" }
-        end_events   = elements.find_all { |el| el.type == "EndEventTerminate" }# DISCUSS: TERMINATE?
+      def compute_intermediate(elements, find_start_events: method(:find_start_events))
+        start_events = find_start_events.(elements)
+        end_events   = elements.find_all { |el| el.type == "EndEventTerminate" } # DISCUSS: is it really called TERMINATE?
 
         inter = Activity::Schema::Intermediate
 
@@ -38,11 +53,12 @@ module Trailblazer
         wiring = Hash[wiring]
 
         # end events need this stupid special handling
+        # DISCUSS: currently, the END-SEMANTIC is read from the event's label.
         wiring = wiring.merge(Hash[
           end_events.collect do |_end|
             ref, outputs = wiring.find { |ref, _| ref.id == _end.id }
 
-            [ref, [inter.Out(semantic_for(_end.to_h), nil)]]
+            [ref, [inter.Out(semantic_for(_end.to_h)|| raise, nil)]] # TODO: test the raise, happens when the semantic of an End can't be distinguished. # TODO: don't extract semantic from :label but from :data.
           end
         ])
         # pp wiring
@@ -52,14 +68,51 @@ module Trailblazer
 
       # private
 
+
+
       # We currently use the {:label} field of an arrow to encode an output semantic.
       # The {:symbol_style} part will be filtered out as semantic. Defaults to {:success}.
       def semantic_for(label:nil, **)
         return :success unless label
 
-        m = label.match(/:(\w+)/)
+        extract_semantic(label)
+      end
+
+      def extract_semantic(label)
+        m = label.match(/:([^\s][\w\?!]+)/) or return
+        return m[1].to_sym
+      end
+
+      def extract_string_id(label)
+        m = label.match(/"(.+)"/) or return
         return m[1].to_sym
       end
+
+      def extract_id(label)
+        extract_string_id(label) || extract_semantic(label)
+      end
+
+      # remap {id}
+      def remap_ids(elements)
+        map = {}
+
+        elements.collect do |el|
+          id = (el.label && semantic = extract_id(el.label)) ? semantic : el.id.to_sym
+
+          map[el.id] = id
+
+          el.id = id
+        end
+
+        # remap {linksTo}
+        elements.collect do |el|
+          el.linksTo.collect do |link|
+            link.target = map[link.target]
+          end
+        end
+
+        elements
+      end
     end
   end
 end

data/lib/trailblazer/developer/render/circuit.rb

@@ -1,5 +1,11 @@
 module Trailblazer
   module Developer
+    module_function
+
+    def render(activity)
+      Render::Circuit.(activity)
+    end
+
     module Render
       module Circuit
         module_function

data/lib/trailblazer/developer/version.rb

@@ -1,5 +1,7 @@
 module Trailblazer
-  module Developer
-    VERSION = "0.0.1".freeze
+  module Version
+    module Developer
+      VERSION = "0.0.2".freeze
+    end
   end
 end

data/lib/trailblazer/developer/wtf.rb

@@ -1,17 +1,20 @@
 module Trailblazer::Developer
   module_function
 
-  def wtf(activity, args)
-    Wtf.invoke(activity, args)
+  def wtf(activity, *args)
+    Wtf.invoke(activity, *args)
+  end
+
+  class << self
+    alias wtf? wtf
   end
-  alias_method :wtf?, :wtf
 
   module Wtf
     module_function
 
     # Run {activity} with tracing enabled and inject a mutable {Stack} instance.
     # This allows to display the trace even when an exception happened
-    def invoke(activity, (ctx, flow_options))
+    def invoke(activity, (ctx, flow_options), *args)
       flow_options ||= {} # Ruby sucks.
 
       # this instance gets mutated with every step. unfortunately, there is
@@ -19,14 +22,14 @@ module Trailblazer::Developer
       stack = Trailblazer::Activity::Trace::Stack.new
 
       begin
-        returned_stack, _ = Trailblazer::Activity::Trace.invoke( activity,
+        _returned_stack, *returned = Trailblazer::Activity::Trace.invoke( activity,
           [
             ctx,
             flow_options.merge(stack: stack)
-          ]
+          ],
+          *args
         )
       rescue
-
         # DISCUSS: we shouldn't use internal knowledge of the Stack/Level API here.
         closest = stack.to_a
         while closest.is_a?(Trailblazer::Activity::Trace::Level) && closest = closest.last do # FIXME: deep-dive via Stack API.
@@ -36,6 +39,8 @@ module Trailblazer::Developer
 
         handle(stack, $!, closest.task, activity, [ctx, flow_options])
       end
+
+      returned # FIXME: test me
     end
 
     def exception_renderer(stack:, level:, input:, name:, closest_task:)

data/lib/trailblazer/developer.rb

@@ -6,6 +6,7 @@ module Trailblazer
   end
 end
 
+require "trailblazer/developer/wtf"
 require "trailblazer/developer/generate"
 require "trailblazer/developer/render/circuit"
 

data/trailblazer-developer.gemspec

@@ -4,7 +4,7 @@ require "trailblazer/developer/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "trailblazer-developer"
-  spec.version       = Trailblazer::Developer::VERSION
+  spec.version       = Trailblazer::Version::Developer::VERSION
   spec.authors       = ["Nick Sutterer"]
   spec.email         = ["apotonick@gmail.com"]
 
@@ -23,5 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rubocop"
 
   spec.add_dependency "trailblazer-activity", "~> 0.8"
+  spec.add_dependency "trailblazer-activity-dsl-linear"
   spec.add_dependency "representable"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-developer
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-28 00:00:00.000000000 Z
+date: 2019-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: trailblazer-activity-dsl-linear
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: representable
   requirement: !ruby/object:Gem::Requirement
@@ -102,7 +116,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rubocop-https---raw-githubusercontent-com-trailblazer-meta-master-rubocop-yml"
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
@@ -110,7 +123,9 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- gems.local.rb
 - lib/trailblazer/developer.rb
+- lib/trailblazer/developer/CHANGES.md
 - lib/trailblazer/developer/activity.rb
 - lib/trailblazer/developer/client.rb
 - lib/trailblazer/developer/generate.rb

data/.rubocop-https---raw-githubusercontent-com-trailblazer-meta-master-rubocop-yml

@@ -1,115 +0,0 @@
-AllCops:
-  TargetRubyVersion: 2.5.0
-  DisplayCopNames: true
-Layout/CaseIndentation:
-  IndentOneStep: true
-Layout/FirstArrayElementLineBreak:
-  Enabled: true
-Layout/FirstHashElementLineBreak:
-  Enabled: true
-Layout/FirstMethodArgumentLineBreak:
-  Enabled: true
-Layout/FirstMethodParameterLineBreak:
-  Enabled: true
-Layout/MultilineAssignmentLayout:
-  Enabled: true
-  EnforcedStyle: same_line
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Metrics/LineLength:
-  Max: 130
-Metrics/ParameterLists:
-  Max: 5
-Naming/VariableNumber:
-  EnforcedStyle: snake_case
-Style/AndOr:
-  EnforcedStyle: conditionals
-Style/AutoResourceCleanup:
-  Enabled: true
-Style/CollectionMethods:
-  Enabled: true
-Style/Documentation:
-  Enabled: false
-Style/EmptyLiteral:
-  Enabled: false
-Style/EmptyMethod:
-  EnforcedStyle: expanded
-Style/FormatStringToken:
-  EnforcedStyle: template
-Style/ImplicitRuntimeError:
-  Enabled: true
-Style/MethodCalledOnDoEndBlock:
-  Enabled: true
-Style/MethodDefParentheses:
-  EnforcedStyle: require_parentheses
-Style/MissingElse:
-  Enabled: true
-  EnforcedStyle: case
-Style/NumericLiterals:
-  Enabled: false
-Style/OptionHash:
-  Enabled: true
-Style/PercentLiteralDelimiters:
-  PreferredDelimiters:
-    "%w": "[]"
-    "%W": "[]"
-    "%i": "[]"
-    "%I": "[]"
-    "%r": "()"
-Style/ReturnNil:
-  Enabled: true
-Style/SafeNavigation:
-  Enabled: false
-Style/Send:
-  Enabled: true
-Style/SignalException:
-  EnforcedStyle: semantic
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-Style/StringMethods:
-  Enabled: true
-Style/SymbolArray:
-  Enabled: true
-# this allows in rspec to have expect { } with multiple lines
-Style/BlockDelimiters:
-  EnforcedStyle: braces_for_chaining
-Layout/EndOfLine:
-  Enabled: false
-# don't need these checks in test folders
-Metrics/ModuleLength:
-  Exclude:
-    - "spec/**/*"
-    - "test/**/*"
-Metrics/BlockLength:
-  Exclude:
-    - "spec/**/*"
-    - "test/**/*"
-    - "*.gemspec" # definitely not in the gemspec
-Metrics/MethodLength:
-  Max: 20
-Lint/UnreachableCode:
-  Description: 'Unreachable code.'
-  Enabled: false
-Lint/Void:
-  Enabled: false
-Layout/AlignHash:
-  EnforcedLastArgumentHashStyle: ignore_implicit
-Metrics/AbcSize:
-  Max: 25
-Style/LambdaCall:
-  Enabled: false
-Style/Semicolon:
-  Enabled: false
-Naming/UncommunicativeMethodParamName:
-  Enabled: false
-Style/ClassAndModuleChildren:
-  Enabled: false
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'test/docs/**/*'
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-Style/FrozenStringLiteralComment:
-  Enabled: false