trailblazer-context 0.4.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68c328cb817dbf1889d8e4619afa0b950786a839d8685c145ac9cda543b63c5b
-  data.tar.gz: 3bbe468cf341ebb429715983c3ea284b02251eedfe0084b6225252fbf5240e4b
+  metadata.gz: 5c491d5456a100bdb4853e02af240d56039864b7589e576db32f82f1683375e6
+  data.tar.gz: 0f4b8b205289cb71b2cb7bca8e562312bb184e681e501af6741e37a82b7ff298
 SHA512:
-  metadata.gz: 0001ec043007eec13ac0ce4c836f406a4fbfcfee8c759fb85c2059d0fffce774423d8986f504a9b0fc36c31e4d0bd75673a02f2d1e9f92b1229f95af3115f029
-  data.tar.gz: 85848da20e2f7639183f4cefc2095294f183f3217927b8ed573ba307ed122871549f1a5409d3369e767a896f8a64c18af598e30fbf10bc33de3918e546e2c6dd
+  metadata.gz: 022fccd76fa9936a7fd0b80070d703cd2f64f5cf7c96c03831d06e7160cf8d2b2581cfa3debaab6bcb106208f91cb9ff5db2a7e7957aab388cdbdc5ccc1c9f9e
+  data.tar.gz: 1ff63b11983902dbd79630be7535095f62812d7522378fff42944bd291ad5e2b7dce55d4b7e985b9ae575f488d65109dcbac2886c51e548f3061095bb54e9a34

data/.github/workflows/ci.yml

@@ -0,0 +1,17 @@
+name: CI
+on: [push, pull_request]
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
+        ruby: [2.5, 2.6, 2.7, '3.0', head, jruby, jruby-head]
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - run: bundle exec rake

data/CHANGES.md

@@ -1,3 +1,11 @@
+# 0.5.1
+
+* Fix `ctx.delete` to return the value being deleted.
+
+# 0.5.0
+
+* Extracted `Option` into its own repository, `trailblazer-option` ✨
+
 # 0.4.0
 
 * Ready for Ruby 3.0. :heart:

data/Gemfile

@@ -1,4 +1,5 @@
 source "https://rubygems.org"
 gemspec
 
+gem "benchmark-ips"
 gem "minitest-line"

data/README.md

@@ -5,5 +5,4 @@ _Argument-specific data structures for Trailblazer._
 This gem provides data structures needed across `Activity`, `Workflow` and `Operation`, such as the following.
 
 * `Trailblazer::Context` implements the so-called `options` hash that is passed between steps and implements the keyword arguments.
-* `Trailblazer::Option` is often used to wrap an option at compile-time and `call` it at runtime, which allows to have the common `-> ()`, `:method` or `Callable` pattern used for most options.
 * `Trailblazer::ContainerChain` to implement chained lookups of properties and allow including containers such as `Dry::Container` in this chain. This is experimental.

data/lib/trailblazer/context/container.rb

@@ -50,8 +50,8 @@ module Trailblazer
         alias_method :store, :[]=
 
         def delete(key)
-          @replica.delete(key)
           @mutable_options.delete(key)
+          @replica.delete(key)
         end
 
         def merge(other_hash)

data/lib/trailblazer/context/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   module Context
-    VERSION = "0.4.0"
+    VERSION = "0.5.1"
   end
 end

data/lib/trailblazer-context.rb

@@ -1,3 +1,2 @@
 require "trailblazer/context/version"
 require "trailblazer/context"
-require "trailblazer/option"

data/test/context_test.rb

@@ -123,8 +123,9 @@ class ContextWithIndifferentAccessTest < Minitest::Spec
 
 # delete
     ctx[:model] = Object
-    ctx.delete 'model'
+    value = ctx.delete 'model'
 
+    _(value).must_equal Object
     _(ctx.key?(:model)).must_equal false
     _(ctx.key?("model")).must_equal false
 
@@ -202,8 +203,9 @@ class ContextWithIndifferentAccessTest < Minitest::Spec
 
 # delete
     ctx[:result] = Object
-    ctx.delete :result
+    value = ctx.delete :result
 
+    _(value).must_equal Object
     _(ctx.key?(:result)).must_equal false
     _(ctx.key?("result")).must_equal false
 

data/trailblazer-context.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["apotonick@gmail.com"]
 
   spec.summary       = "Argument-specific data structures for Trailblazer."
-  spec.description   = "Argument-specific data structures for Trailblazer such as Context, Option and ContainerChain."
+  spec.description   = "Argument-specific data structures for Trailblazer such as Context and ContainerChain."
   spec.homepage      = "https://trailblazer.to/"
   spec.licenses      = ["MIT"]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-context
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Nick Sutterer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-26 00:00:00.000000000 Z
+date: 2022-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
@@ -66,16 +66,16 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Argument-specific data structures for Trailblazer such as Context, Option
-  and ContainerChain.
+description: Argument-specific data structures for Trailblazer such as Context and
+  ContainerChain.
 email:
 - apotonick@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
 - CHANGES.md
 - Gemfile
 - LICENSE
@@ -88,19 +88,17 @@ files:
 - lib/trailblazer/context/container/with_aliases.rb
 - lib/trailblazer/context/store/indifferent_access.rb
 - lib/trailblazer/context/version.rb
-- lib/trailblazer/option.rb
 - test/benchmark/benchmark_helper.rb
 - test/benchmark/indifferent_access_test.rb
 - test/benchmark/indifferent_access_with_aliasing_test.rb
 - test/context_test.rb
-- test/option_test.rb
 - test/test_helper.rb
 - trailblazer-context.gemspec
 homepage: https://trailblazer.to/
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -115,8 +113,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
-signing_key: 
+rubygems_version: 3.3.18
+signing_key:
 specification_version: 4
 summary: Argument-specific data structures for Trailblazer.
 test_files:
@@ -124,5 +122,4 @@ test_files:
 - test/benchmark/indifferent_access_test.rb
 - test/benchmark/indifferent_access_with_aliasing_test.rb
 - test/context_test.rb
-- test/option_test.rb
 - test/test_helper.rb

data/.travis.yml

@@ -1,13 +0,0 @@
-language: ruby
-before_install: gem install bundler
-cache: bundler
-rvm:
-  - ruby-head
-  - 3.0
-  - 2.7
-  - 2.6
-  - 2.5
-  - 2.4
-jobs:
-  allow_failures:
-    - rvm: ruby-head

data/lib/trailblazer/option.rb

@@ -1,47 +0,0 @@
-module Trailblazer
-  class Option
-    # A call implementation invoking `proc.(*args)` and plainly forwarding all arguments.
-    # Override this for your own step strategy (see KW#call!).
-    # @private
-    def self.call!(proc, *args, keyword_arguments: {}, **, &block)
-      # {**keyword_arguments} gets removed automatically if it's an empty hash.
-      # DISCUSS: is this a good practice?
-      proc.(*args, **keyword_arguments, &block)
-    end
-
-    # Note that both #evaluate_callable and #evaluate_method drop most of the args.
-    # If you need those, override this class.
-    # @private
-    def self.evaluate_callable(proc, *args, **options, &block)
-      call!(proc, *args, **options, &block)
-    end
-
-    # Make the context's instance method a "lambda" and reuse #call!.
-    # @private
-    def self.evaluate_method(proc, *args, exec_context: raise("No :exec_context given."), **options, &block)
-      call!(exec_context.method(proc), *args, **options, &block)
-    end
-
-    # Generic builder for a callable "option".
-    # @param call_implementation [Class, Module] implements the process of calling the proc
-    #   while passing arguments/options to it in a specific style (e.g. kw args, step interface).
-    # @return [Proc] when called, this proc will evaluate its option (at run-time).
-    def self.build(proc)
-      if proc.is_a? Symbol
-        ->(*args, **kws, &block) { Option.evaluate_method(proc, *args, **kws, &block) }
-      else
-        ->(*args, **kws, &block) {
-          Option.evaluate_callable(proc, *args, **kws, &block) }
-      end
-    end
-
-    def self.KW(proc)
-      raise "The `Option::KW()` method has been removed in trailblazer-context-0.4.
-Please use `Option(task, keyword_arguments: {...})` instead. Check https://trailblazer.to/2.1/docs/trailblazer.html#trailblazer-context-option"
-    end
-  end
-  # @note This might go to trailblazer-args along with `Context` at some point.
-  def self.Option(proc)
-    Option.build(proc)
-  end
-end

data/test/option_test.rb

@@ -1,147 +0,0 @@
-require "test_helper"
-
-class OptionTest < Minitest::Spec
-  def assert_result(result, block = nil)
-    _(result).must_equal([{a: 1}, 2, {b: 3}, block])
-
-    _(positional.inspect).must_equal %({:a=>1})
-    _(keywords.inspect).must_equal %({:a=>2, :b=>3})
-  end
-
-  # it "what" do
-  #   ctx = {params: 1}
-  #   tmp_options = {constant: Object, model: Module}
-
-  #   builder = Class.new do
-  #     def builder(ctx, constant:, model:, **)
-  #       raise model.inspect
-  #     end
-  #   end.new
-
-  #   circuit_options = {exec_context: builder}
-
-  #   # Trailblazer::Option(:builder, ).(ctx, tmp_options, **circuit_options.merge(keyword_arguments: tmp_options))  # calls {def default_contract!(options, constant:, model:, **)}
-  #   Trailblazer::Option(:builder, ).(ctx, **circuit_options.merge(keyword_arguments: tmp_options))  # calls {def default_contract!(options, constant:, model:, **)}
-  # end
-
-  describe "positional and kws" do
-    class Step
-      def with_positional_and_keywords(options, a: nil, **more_options, &block)
-        [options, a, more_options, block]
-      end
-    end
-
-    WITH_POSITIONAL_AND_KEYWORDS = ->(options, a: nil, **more_options, &block) do
-      [options, a, more_options, block]
-    end
-
-    class WithPositionalAndKeywords
-      def self.call(options, a: nil, **more_options, &block)
-        [options, a, more_options, block]
-      end
-    end
-
-    let(:positional) { {a: 1} }
-    let(:keywords)   { {a: 2, b: 3} }
-
-    let(:block) { ->(*) { snippet } }
-
-    describe ":method" do
-      let(:option) { Trailblazer::Option(:with_positional_and_keywords) }
-
-      it "passes through all args" do
-        step = Step.new
-
-        # positional = { a: 1 }
-        # keywords   = { a: 2, b: 3 }
-        assert_result option.(positional, keyword_arguments: keywords, exec_context: step)
-      end
-
-      it "allows passing a block, too" do
-        step = Step.new
-
-        assert_result option.(positional, keyword_arguments: keywords, exec_context: step, &block), block
-      end
-    end
-
-    describe "lambda" do
-      let(:option) { Trailblazer::Option(WITH_POSITIONAL_AND_KEYWORDS) }
-
-      it "-> {} lambda" do
-        assert_result option.(positional, **{keyword_arguments: keywords})
-      end
-
-      it "allows passing a block, too" do
-        assert_result option.(positional, **{keyword_arguments: keywords}, &block), block
-      end
-
-      it "doesn't mind :exec_context" do
-        assert_result option.(positional, keyword_arguments: keywords, exec_context: "bogus")
-      end
-    end
-
-    describe "Callable" do
-      let(:option) { Trailblazer::Option(WithPositionalAndKeywords) }
-
-      it "passes through all args" do
-        assert_result option.(positional, keyword_arguments: keywords, exec_context: nil)
-      end
-
-      it "allows passing a block, too" do
-        assert_result option.(positional, keyword_arguments: keywords, exec_context: nil, &block), block
-      end
-    end
-  end
-
-  describe "positionals" do
-    def assert_result_pos(result)
-      if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.7.0")
-        _(result).must_equal([1, 2, [3, 4]])
-        _(positionals).must_equal [1, 2, 3, 4]
-      else
-        _(result).must_equal([1, 2, [3, 4, {}]])
-        _(positionals).must_equal [1, 2, 3, 4]
-      end
-    end
-
-    # In Ruby < 3.0, {*args} will grab both positionals and keyword arguments.
-    class Step
-      def with_positionals(a, b, *args)
-        [a, b, args]
-      end
-    end
-
-    WITH_POSITIONALS = ->(a, b, *args) do
-      [a, b, args]
-    end
-
-    class WithPositionals
-      def self.call(a, b, *args)
-        [a, b, args]
-      end
-    end
-
-    let(:positionals) { [1, 2, 3, 4] }
-
-    it ":method" do
-      step = Step.new
-
-      option = Trailblazer::Option(:with_positionals)
-
-      assert_result_pos option.(*positionals, exec_context: step)
-    end
-
-    it "-> {} lambda" do
-      option = Trailblazer::Option(WITH_POSITIONALS)
-
-      assert_result_pos option.(*positionals, exec_context: "something")
-    end
-
-    it "callable" do
-      option = Trailblazer::Option(WithPositionals)
-
-      assert_result_pos option.(*positionals, exec_context: "something")
-    end
-  end
-
-end