trailblazer-context 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cbed8941980e69f6e3ef14de677024e8c45f4573
-  data.tar.gz: 31c11f6e2a59b45868e0247772bf9eafc692f06e
+  metadata.gz: eb81fa6ece2d3615f46a7b72a066a8316c48065a
+  data.tar.gz: d720c68f9154786ef561e97f67e29ff15e58be6c
 SHA512:
-  metadata.gz: 33020d8f9f10cf5323e3dbe5572da5f8d1fe0b7842d1b2a73199be07a2bba2648ddcc146dea445e06551900152117bbedc19b7a6c5c476c2675d8222fa7fcaac
-  data.tar.gz: 6bf38334cd38dce21da64615860eec450bc180c4457c0b09399d179c376b204a7af1360349edc377054923e8f70354a22b943729d22412659eb80155998cddef
+  metadata.gz: 720a50aab05ec4de810b88227c7405f5bffaef9e2685419849f09cd56159e5e216c0ae5959b4d6502e2edabc7559bdfcbe5a01b61f9a141bfc01508f407e39a6
+  data.tar.gz: 2aa161d5f6de1b93210f3e1f5f9c187f0dd8b44cc0bf2d335dbc36c6479d6891d1a4ac002dd729d3b824a5fd04304fe952b0038fa16e4105ac242ec584905020

data/CHANGES.md

@@ -0,0 +1,7 @@
+# 0.1.1
+
+* `Option.( *args, &block )` now passes through the block to the option call.
+
+# 0.1.0
+
+* Extracted from `trailblazer-activity`, here it comes.

data/lib/trailblazer/context.rb

@@ -3,6 +3,9 @@
 # collects mutable runtime-computed data while providing access to compile-time
 # information.
 # The runtime-data takes precedence over the class data.
+#
+# notes
+# a context is a ContainerChain with two elements (when reading)
 module Trailblazer
   # Holds local options (aka `mutable_options`) and "original" options from the "outer"
   # activity (aka wrapped_options).
@@ -11,13 +14,23 @@ module Trailblazer
   class Context # :data object:
     def initialize(wrapped_options, mutable_options)
       @wrapped_options, @mutable_options = wrapped_options, mutable_options
+      # TODO: wrapped_options should be optimized for lookups here since it could also be a Context instance, but should be a ContainerChain.
     end
 
     def [](name)
-      ContainerChain.find( [@mutable_options, @wrapped_options], name )
+      # ContainerChain.find( [@mutable_options, @wrapped_options], name )
+
+      # in 99.9% or cases @mutable_options will be a Hash, and these are already optimized for lookups.
+      # it's up to the ContainerChain to optimize itself.
+      return @mutable_options[name] if @mutable_options.key?(name)
+      @wrapped_options[name]
     end
 
+    # TODO: use ContainerChain.find here for a generic optimization
+    #
+    # the version here is about 4x faster for now.
     def key?(name)
+      # ContainerChain.find( [@mutable_options, @wrapped_options], name )
       @mutable_options.key?(name) || @wrapped_options.key?(name)
     end
 
@@ -25,6 +38,9 @@ module Trailblazer
       @mutable_options[name] = value
     end
 
+    # @private
+    #
+    # This method might be removed.
     def merge(hash)
       original, mutable_options = decompose
 
@@ -37,11 +53,6 @@ module Trailblazer
       [ @wrapped_options, @mutable_options ]
     end
 
-    def key?(name)
-      ContainerChain.find( [@mutable_options, @wrapped_options], name )
-    end
-
-
     def keys
       @mutable_options.keys + @wrapped_options.keys # FIXME.
     end

data/lib/trailblazer/context/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   class Context
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/lib/trailblazer/option.rb

@@ -11,30 +11,30 @@ module Trailblazer
     # @return [Proc] when called, this proc will evaluate its option (at run-time).
     def self.build(call_implementation, proc)
       if proc.is_a? Symbol
-        ->(*args) { call_implementation.evaluate_method(proc, *args) }
+        ->(*args, &block) { call_implementation.evaluate_method(proc, *args, &block) }
       else
-        ->(*args) { call_implementation.evaluate_callable(proc, *args) }
+        ->(*args, &block) { call_implementation.evaluate_callable(proc, *args, &block) }
       end
     end
 
     # A call implementation invoking `proc.(*args)` and plainly forwarding all arguments.
     # Override this for your own step strategy (see KW#call!).
     # @private
-    def self.call!(proc, *args)
-      proc.(*args)
+    def self.call!(proc, *args, &block)
+      proc.(*args, &block)
     end
 
     # Note that both #evaluate_callable and #evaluate_method drop most of the args.
     # If you need those, override this class.
     # @private
-    def self.evaluate_callable(proc, *args, **flow_options)
-      call!(proc, *args)
+    def self.evaluate_callable(proc, *args, **flow_options, &block)
+      call!(proc, *args, &block)
     end
 
     # Make the context's instance method a "lambda" and reuse #call!.
     # @private
-    def self.evaluate_method(proc, *args, exec_context:raise, **flow_options)
-      call!(exec_context.method(proc), *args)
+    def self.evaluate_method(proc, *args, exec_context:raise, **flow_options, &block)
+      call!(exec_context.method(proc), *args, &block)
     end
 
     # Returns a {Proc} that, when called, invokes the `proc` argument with keyword arguments.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-context
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-05 00:00:00.000000000 Z
+date: 2017-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -61,6 +61,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGES.md
 - Gemfile
 - LICENSE
 - README.md