trailblazer-activity 0.16.3 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d337611d8f737a90f05b16ad72442808bb373351ff81ae908fde441492fe72f2
-  data.tar.gz: 705b4f0de152cf24b0be9dead73aa2cde4f59cce80548a4a44737b061be76e3a
+  metadata.gz: db90b7ac4eda6d6bf8c55d4e3107c8aac6ebfbf8a29e4e7d7e8a2394f0faab4a
+  data.tar.gz: 1b28fade56d479d3c500e571c22247359d767d3e5f427b85f071ab0bd8a642c8
 SHA512:
-  metadata.gz: 77173535922167fbc51c4bcc92909dea8e263313d97ef7ce47716ddbadc0a82ece0d511deccb57badc1adecb61fe2276594cf561642931da9cc243c2960fd9b7
-  data.tar.gz: e2157a80cbfdea6cc573bec8bdbb1933667e17335229aa9690051b3cb34bd0adb4613991621332debde5b34cb00993e9595169d154c8861db8857313deba4d66
+  metadata.gz: 5b23e22e9df457794cc04bb571839dbe703677ffcfe1f137f65282fc520e99b3676a8047a0a0b0909e8ec0397ad696443773fea79a0b2f323c767c1f02330347
+  data.tar.gz: 5610595f825d407f05c74fddc10a44bf030b71d54d1880ae0f27f1fc753be084806c799b6bd402aa4fd27df5fc411a1fefdc88f64c67eb80262275b66b8c17e9

data/CHANGES.md

@@ -1,3 +1,14 @@
+# 0.17.0
+
+* In `Extension#call`, remove the dependency to `Implementation::Task`. The logic only receives the actual circuit task.
+* Remove deprecated `Extension()` interface.
+* Remove `Trailblazer::Activity::Introspect::Graph`.
+
+# 0.16.4
+
+* Revert the static "fix" from 0.16.3 and make the compaction fix optional, as most Ruby versions
+  are solving this problem natively. See here for details: https://dev.to/trailblazer/gc-compaction-behold-your-hash-keys-2ii1#quick-fix
+
 # 0.16.3
 
 * Fix a bug in Ruby 3.2: `NoMethodError: undefined method `[]' for nil`. Thanks @tiagotex for finding the problem

data/Gemfile

@@ -3,3 +3,5 @@ gemspec
 
 # gem "trailblazer-developer",  path: "../trailblazer-developer"
 # gem "benchmark-ips"
+# gem "trailblazer-core-utils",  path: "../trailblazer-core-utils"
+# gem "trailblazer-core-utils",  github: "trailblazer/trailblazer-core-utils"

data/lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb

@@ -0,0 +1,28 @@
+module Trailblazer
+  class Activity
+    # TODO: we can remove this once we drop Ruby <= 3.3.6.
+    class Circuit
+      # This is a hot fix for Ruby versions that haven't fixed the GC compaction bug:
+      #   https://redmine.ruby-lang.org/issues/20853
+      #   https://bugs.ruby-lang.org/issues/20868
+      #
+      # Affected versions might be: 3.1.x, 3.2.?????????, 3.3.0-3.3.6
+      # You don't need this fix in the following versions: 
+      #
+      # If you experience this bug: https://github.com/trailblazer/trailblazer-activity/issues/60
+      #
+      #   NoMethodError: undefined method `[]' for nil
+      #
+      # you need to do 
+      #
+      #   Trailblazer::Activity::Circuit.include(RubyWithUnfixedCompaction)
+      module RubyWithUnfixedCompaction
+        def initialize(wiring, *args, **options)
+          wiring.compare_by_identity
+
+          super(wiring, *args, **options)
+        end
+      end
+    end
+  end
+end

data/lib/trailblazer/activity/introspect.rb

@@ -56,13 +56,6 @@ module Trailblazer
 
         proc.inspect
       end
-
-      # TODO: remove with 0.1.0.
-      def self.Graph(*args)
-        Deprecate.warn caller_locations[0], %(`Trailblazer::Activity::Introspect::Graph` is deprecated. Please use `Trailblazer::Developer::Introspect.Graph`)
-
-        Trailblazer::Developer::Introspect::Graph.new(*args)
-      end
     end # Introspect
   end
 end

data/lib/trailblazer/activity/schema/compiler.rb

@@ -24,7 +24,7 @@ module Trailblazer
 
           # From the intermediate "template" and the actual implementation, compile a {Circuit} instance.
           def schema_components(intermediate, implementation, config)
-            wiring = {}.compare_by_identity # https://ruby-doc.org/3.3.0/Hash.html#class-Hash-label-Modifying+an+Active+Hash+Key
+            wiring = {}
             nodes_attributes  = []
 
             intermediate.wiring.each do |task_ref, outs|
@@ -92,7 +92,7 @@ module Trailblazer
           def invoke_extensions_for(config, impl_task, id)
             impl_task
               .extensions
-              .inject(config) { |cfg, ext| ext.(config: cfg, id: id, task: impl_task) } # {ext} must return new config hash.
+              .inject(config) { |cfg, ext| ext.(config: cfg, id: id, task: impl_task.circuit_task) } # {ext} must return new config hash.
           end
 
           # In an array of {Activity::Output}, find the output matching {semantic}.

data/lib/trailblazer/activity/task_wrap/extension.rb

@@ -17,15 +17,7 @@ module Trailblazer
       #   TaskWrap.Extension([task, id: "my_logger", append: "task_wrap.call_task"], [...])
       #
       # If you want a {wrap_static} extension, wrap it using `Extension.WrapStatic.new`.
-      def self.Extension(*inserts, merge: nil)
-        if merge
-          Deprecate.warn caller_locations[0], "The :merge option for TaskWrap.Extension is deprecated and will be removed in 0.16.
-Please refer to https://trailblazer.to/2.1/docs/activity.html#activity-taskwrap-static and have a great day."
-
-          return Extension::WrapStatic.new(extension: Extension.new(*merge))
-          # TODO: remove me once we drop the pre-friendly interface.
-        end
-
+      def self.Extension(*inserts)
         Extension.build(*inserts)
       end
 
@@ -44,8 +36,6 @@ Please refer to https://trailblazer.to/2.1/docs/activity.html#activity-taskwrap-
         end
 
         def initialize(*extension_rows)
-          extension_rows = deprecated_extension_for(extension_rows) # TODO: remove me soon!
-
           @extension_rows = extension_rows # those rows are simple ADDS instructions.
         end
 
@@ -55,21 +45,6 @@ Please refer to https://trailblazer.to/2.1/docs/activity.html#activity-taskwrap-
           Adds.apply_adds(task_wrap_pipeline, @extension_rows)
         end
 
-        # TODO: remove me once we drop the pre-friendly interface.
-        def deprecated_extension_for(extension_rows)
-          return extension_rows unless extension_rows.find { |ext| ext.is_a?(Array) }
-
-          Deprecate.warn caller_locations[3], "You are using the old API for taskWrap extensions.
-Please update to the new TaskWrap.Extension() API."
-
-          extension_rows.collect do |ary|
-            {
-              insert: ary[0..1],
-              row: Pipeline.Row(*ary[2])
-            }
-          end
-        end
-
         # Create extensions from the friendly interface that can alter the wrap_static
         # of a step in an activity. The returned extensionn can be passed directly via {:extensions}
         # to the compiler, or when using the `#step` DSL.
@@ -86,9 +61,6 @@ Please update to the new TaskWrap.Extension() API."
           end
 
           def call(config:, task:, **)
-            # DISCUSS: does it make sense to test the immutable behavior here? What would be the worst outcome?
-            task = task.circuit_task # Receives {Schema::Implementation::Task}. DISCUSS: why?
-
             # Add the extension's task(s) to the activity's {:wrap_static} taskWrap
             # which is stored in the {:config} field.
             wrap_static = config[:wrap_static]                 # the activity's {wrap_static}.
@@ -97,6 +69,7 @@ Please update to the new TaskWrap.Extension() API."
             # Overwrite the original task_wrap:
             wrap_static = wrap_static.merge(task => @extension.(task_wrap))
 
+            # DISCUSS: does it make sense to test the immutable behavior here? What would be the worst outcome?
             config.merge(wrap_static: wrap_static) # Return new config hash. This needs to be immutable code!
           end
         end # WrapStatic

data/lib/trailblazer/activity/task_wrap/pipeline.rb

@@ -23,21 +23,6 @@ class Trailblazer::Activity
         @sequence
       end
 
-      # TODO: remove me when old tW extension API is deprecated.
-      def self.method(name)
-        new_name = {
-          insert_before: :Prepend,
-          insert_after: :Append,
-          append: :Append,
-          prepend: :Prepend
-        }.fetch(name)
-
-        warn "[Trailblazer] Using `Trailblazer::Activity::TaskWrap::Pipeline.method(:#{name})` is deprecated.
-Please use the new API: #FIXME!!!"
-
-        Trailblazer::Activity::Adds::Insert.method(new_name)
-      end
-
       def self.Row(id, task)
         Row[id, task]
       end
@@ -48,18 +33,6 @@ Please use the new API: #FIXME!!!"
         end
       end
 
-      # TODO: remove {Merge} when old tW extension API is deprecated.
-      class Merge
-        def self.new(*inserts)
-          warn "[Trailblazer] Using `Trailblazer::Activity::TaskWrap::Pipeline::Merge.new` is deprecated.
-Please use the new TaskWrap.Extension() API: #FIXME!!!"
-
-          # We can safely assume that users calling {Merge.new} are using the old tW extension API, not
-          # the "friendly API". That's why we don't go through {Extension.build}.
-          TaskWrap::Extension.new(*inserts)
-        end
-      end # Merge
-
       # Implements adapter for a callable in a Pipeline.
       class TaskAdapter < Circuit::TaskAdapter
         # Returns a {Pipeline::TaskAdapter} instance that can be used directly in a Pipeline.

data/lib/trailblazer/activity/version.rb

@@ -1,7 +1,7 @@
 module Trailblazer
   module Version
     module Activity
-      VERSION = "0.16.3"
+      VERSION = "0.17.0"
     end
   end
 end

data/trailblazer-activity.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["apotonick@gmail.com"]
 
   spec.summary       = %q{Runtime code for Trailblazer activities.}
-  spec.homepage      = "http://trailblazer.to"
+  spec.homepage      = "https://trailblazer.to"
   spec.licenses      = ["LGPL-3.0"]
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "minitest-line"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "trailblazer-core-utils", "0.0.4"
 
   spec.required_ruby_version = '>= 2.1.0'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-activity
 version: !ruby/object:Gem::Version
-  version: 0.16.3
+  version: 0.17.0
 platform: ruby
 authors:
 - Nick Sutterer
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-08 00:00:00.000000000 Z
+date: 2024-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-context
@@ -94,7 +93,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+- !ruby/object:Gem::Dependency
+  name: trailblazer-core-utils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.4
 email:
 - apotonick@gmail.com
 executables: []
@@ -114,6 +126,7 @@ files:
 - lib/trailblazer/activity.rb
 - lib/trailblazer/activity/adds.rb
 - lib/trailblazer/activity/circuit.rb
+- lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb
 - lib/trailblazer/activity/circuit/task_adapter.rb
 - lib/trailblazer/activity/deprecate.rb
 - lib/trailblazer/activity/introspect.rb
@@ -131,11 +144,10 @@ files:
 - lib/trailblazer/activity/testing.rb
 - lib/trailblazer/activity/version.rb
 - trailblazer-activity.gemspec
-homepage: http://trailblazer.to
+homepage: https://trailblazer.to
 licenses:
 - LGPL-3.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -150,8 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
-signing_key: 
+rubygems_version: 3.6.0.dev
 specification_version: 4
 summary: Runtime code for Trailblazer activities.
 test_files: []