trailblazer-activity 0.16.3 → 0.16.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d337611d8f737a90f05b16ad72442808bb373351ff81ae908fde441492fe72f2
-  data.tar.gz: 705b4f0de152cf24b0be9dead73aa2cde4f59cce80548a4a44737b061be76e3a
+  metadata.gz: ba8b06193c7e9d3a488e76880cf82906db733edfa081c8de86f8ae55a3392628
+  data.tar.gz: efa7751c90679572bd39fb1c1ea18c75a996de796cba685819fb256ef6c738d7
 SHA512:
-  metadata.gz: 77173535922167fbc51c4bcc92909dea8e263313d97ef7ce47716ddbadc0a82ece0d511deccb57badc1adecb61fe2276594cf561642931da9cc243c2960fd9b7
-  data.tar.gz: e2157a80cbfdea6cc573bec8bdbb1933667e17335229aa9690051b3cb34bd0adb4613991621332debde5b34cb00993e9595169d154c8861db8857313deba4d66
+  metadata.gz: 0b506af8a0f22329757b03ce8a186e552cae4e747780690cd910555453d1e16ba6c897eb0d5b7266c1ca730e82ab2c0684a4c42700a8f16bdde5927491bb2f6a
+  data.tar.gz: c448cc3fb03f2b6abd5da7d9f54ddebc4a17327923412da8f96d88a698fc0d0e2d72172f510a1d765fa6ff6c770e2f20f9db12db59bc991631882238182bb958

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 0.16.4
+
+* Revert the static "fix" from 0.16.3 and make the compaction fix optional, as most Ruby versions
+  are solving this problem natively. See here for details: https://dev.to/trailblazer/gc-compaction-behold-your-hash-keys-2ii1#quick-fix
+
 # 0.16.3
 
 * Fix a bug in Ruby 3.2: `NoMethodError: undefined method `[]' for nil`. Thanks @tiagotex for finding the problem

data/Gemfile

@@ -3,3 +3,5 @@ gemspec
 
 # gem "trailblazer-developer",  path: "../trailblazer-developer"
 # gem "benchmark-ips"
+# gem "trailblazer-core-utils",  path: "../trailblazer-core-utils"
+# gem "trailblazer-core-utils",  github: "trailblazer/trailblazer-core-utils"

data/lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb

@@ -0,0 +1,28 @@
+module Trailblazer
+  class Activity
+    # TODO: we can remove this once we drop Ruby <= 3.3.6.
+    class Circuit
+      # This is a hot fix for Ruby versions that haven't fixed the GC compaction bug:
+      #   https://redmine.ruby-lang.org/issues/20853
+      #   https://bugs.ruby-lang.org/issues/20868
+      #
+      # Affected versions might be: 3.1.x, 3.2.?????????, 3.3.0-3.3.6
+      # You don't need this fix in the following versions: 
+      #
+      # If you experience this bug: https://github.com/trailblazer/trailblazer-activity/issues/60
+      #
+      #   NoMethodError: undefined method `[]' for nil
+      #
+      # you need to do 
+      #
+      #   Trailblazer::Activity::Circuit.include(RubyWithUnfixedCompaction)
+      module RubyWithUnfixedCompaction
+        def initialize(wiring, *args, **options)
+          wiring.compare_by_identity
+
+          super(wiring, *args, **options)
+        end
+      end
+    end
+  end
+end

data/lib/trailblazer/activity/schema/compiler.rb

@@ -24,7 +24,7 @@ module Trailblazer
 
           # From the intermediate "template" and the actual implementation, compile a {Circuit} instance.
           def schema_components(intermediate, implementation, config)
-            wiring = {}.compare_by_identity # https://ruby-doc.org/3.3.0/Hash.html#class-Hash-label-Modifying+an+Active+Hash+Key
+            wiring = {}
             nodes_attributes  = []
 
             intermediate.wiring.each do |task_ref, outs|

data/lib/trailblazer/activity/version.rb

@@ -1,7 +1,7 @@
 module Trailblazer
   module Version
     module Activity
-      VERSION = "0.16.3"
+      VERSION = "0.16.4"
     end
   end
 end

data/trailblazer-activity.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "minitest-line"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "trailblazer-core-utils", "0.0.3"
 
   spec.required_ruby_version = '>= 2.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-activity
 version: !ruby/object:Gem::Version
-  version: 0.16.3
+  version: 0.16.4
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-08 00:00:00.000000000 Z
+date: 2024-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-context
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: trailblazer-core-utils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.3
 description: 
 email:
 - apotonick@gmail.com
@@ -114,6 +128,7 @@ files:
 - lib/trailblazer/activity.rb
 - lib/trailblazer/activity/adds.rb
 - lib/trailblazer/activity/circuit.rb
+- lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb
 - lib/trailblazer/activity/circuit/task_adapter.rb
 - lib/trailblazer/activity/deprecate.rb
 - lib/trailblazer/activity/introspect.rb