trailblazer-activity 0.16.2 → 0.16.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4a5444cfd580cf5951c7a9162bfb87c1f2cba25bb1784e89fc95abd0e4adc3d
-  data.tar.gz: c10bb8bd651379e99728295c9e396f5ce8cf0c9c73802eadb65aafd6add98816
+  metadata.gz: ba8b06193c7e9d3a488e76880cf82906db733edfa081c8de86f8ae55a3392628
+  data.tar.gz: efa7751c90679572bd39fb1c1ea18c75a996de796cba685819fb256ef6c738d7
 SHA512:
-  metadata.gz: ba411bc9536d33433c619c54edc520985686e88f56f099208fac002a90631faf1d3102861ad886628e4f0b99fc77ee19ad6be4f0cb9564b7222d337d71353db3
-  data.tar.gz: 831c793c0c0515e4672dbc661ba49680dcd101ab1a6b489f88b021a7b9db546dfaf5963458f26340b23c97739e3e65d495f77c10ba3d6a58a7430e01c4d9b3f5
+  metadata.gz: 0b506af8a0f22329757b03ce8a186e552cae4e747780690cd910555453d1e16ba6c897eb0d5b7266c1ca730e82ab2c0684a4c42700a8f16bdde5927491bb2f6a
+  data.tar.gz: c448cc3fb03f2b6abd5da7d9f54ddebc4a17327923412da8f96d88a698fc0d0e2d72172f510a1d765fa6ff6c770e2f20f9db12db59bc991631882238182bb958

data/.github/workflows/ci.yml

@@ -6,10 +6,10 @@ jobs:
       fail-fast: false
       matrix:
         # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
-        ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, head, jruby, jruby-head]
+        ruby: [2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, head, jruby, jruby-head]
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}

data/CHANGES.md

@@ -1,3 +1,13 @@
+# 0.16.4
+
+* Revert the static "fix" from 0.16.3 and make the compaction fix optional, as most Ruby versions
+  are solving this problem natively. See here for details: https://dev.to/trailblazer/gc-compaction-behold-your-hash-keys-2ii1#quick-fix
+
+# 0.16.3
+
+* Fix a bug in Ruby 3.2: `NoMethodError: undefined method `[]' for nil`. Thanks @tiagotex for finding the problem
+  and solution. This bug only occurs when compacting the memory using GC, which is only introduced with Ruby 3.2.
+
 # 0.16.2
 
 * Allow passing custom `:flow_options` to `Testing#assert_invoke`.

data/Gemfile

@@ -3,3 +3,5 @@ gemspec
 
 # gem "trailblazer-developer",  path: "../trailblazer-developer"
 # gem "benchmark-ips"
+# gem "trailblazer-core-utils",  path: "../trailblazer-core-utils"
+# gem "trailblazer-core-utils",  github: "trailblazer/trailblazer-core-utils"

data/lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb

@@ -0,0 +1,28 @@
+module Trailblazer
+  class Activity
+    # TODO: we can remove this once we drop Ruby <= 3.3.6.
+    class Circuit
+      # This is a hot fix for Ruby versions that haven't fixed the GC compaction bug:
+      #   https://redmine.ruby-lang.org/issues/20853
+      #   https://bugs.ruby-lang.org/issues/20868
+      #
+      # Affected versions might be: 3.1.x, 3.2.?????????, 3.3.0-3.3.6
+      # You don't need this fix in the following versions: 
+      #
+      # If you experience this bug: https://github.com/trailblazer/trailblazer-activity/issues/60
+      #
+      #   NoMethodError: undefined method `[]' for nil
+      #
+      # you need to do 
+      #
+      #   Trailblazer::Activity::Circuit.include(RubyWithUnfixedCompaction)
+      module RubyWithUnfixedCompaction
+        def initialize(wiring, *args, **options)
+          wiring.compare_by_identity
+
+          super(wiring, *args, **options)
+        end
+      end
+    end
+  end
+end

data/lib/trailblazer/activity/version.rb

@@ -1,7 +1,7 @@
 module Trailblazer
   module Version
     module Activity
-      VERSION = "0.16.2"
+      VERSION = "0.16.4"
     end
   end
 end

data/lib/trailblazer/activity.rb

@@ -3,8 +3,6 @@ module Trailblazer
   #
   # Developer's docs: https://trailblazer.to/2.1/docs/internals.html#internals-activity
   class Activity
-    # include Activity::Interface # TODO
-
     def initialize(schema)
       @schema = schema
     end

data/trailblazer-activity.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "minitest-line"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "trailblazer-core-utils", "0.0.3"
 
   spec.required_ruby_version = '>= 2.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-activity
 version: !ruby/object:Gem::Version
-  version: 0.16.2
+  version: 0.16.4
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-04 00:00:00.000000000 Z
+date: 2024-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-context
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: trailblazer-core-utils
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.0.3
 description: 
 email:
 - apotonick@gmail.com
@@ -114,6 +128,7 @@ files:
 - lib/trailblazer/activity.rb
 - lib/trailblazer/activity/adds.rb
 - lib/trailblazer/activity/circuit.rb
+- lib/trailblazer/activity/circuit/ruby_with_unfixed_compaction.rb
 - lib/trailblazer/activity/circuit/task_adapter.rb
 - lib/trailblazer/activity/deprecate.rb
 - lib/trailblazer/activity/introspect.rb