traco 3.2.1 → 4.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OTY3M2RiMzgxNzI2YzY5YWQ2Nzg5N2VhMmY0ZDg0YjlhOGQwMzQ1Ng==
-  data.tar.gz: !binary |-
-    MTI3YWIxYmRjNDQ5MmIxNWIyNmI3NGFjMWEwY2FiZWEwMjNiMWFiOA==
+SHA1:
+  metadata.gz: 9060bececc2eb2a4f5bf6fd798f1b6c16523dd21
+  data.tar.gz: a32a98d4c86f84fc94430cf11ab660fe8993c973
 SHA512:
-  metadata.gz: !binary |-
-    MGZjNTUyNzg3NDNiOWQyYjM2ZTE4NmRhOGY5Mzc3ZGJlY2ZkOWZiYzJjMTVm
-    OTA3ZDY1ZWMxZDFmMmFkMGM4NTE4Y2I0ZjM1NTY2ODFmY2UwMzY0ZjYwZTQy
-    YWM1N2U2OTkyNWY3YTM1OTU2NDNlMjNlNjczMTBjYmZjMzU2Yzk=
-  data.tar.gz: !binary |-
-    OTUyOGE2M2E0MTM3ODVhMjg1MTA3MDkzNDU3YmUwOTZhMWM5Yjg0MDJhNDU2
-    YzVjM2JhM2E3ZjBhOWJmZTUzOWI2NWIxZTljZjA4MDUxMWUyMzkyMTUyNmI5
-    NmRiOTdhNzA2NmU3OTVmZmM2N2U3MWQzN2NiMmIyOGUyOTU5MDg=
+  metadata.gz: 23d5789232d16fa41117707e3502027d4d04328adee5bf8853213dd128ed26badb14f3ad03afbe073424c58d39eb98b46be78998f87d1bf000aa0f0f0d6f9bb5
+  data.tar.gz: c9461bd93ed5118f51da0862ee929f93df74964c7c56371ca60d88faba043e535b632fcc504e3351c50958f14f130ca2456ad32a06652e4f3dcf5c4ca5a98b6a

data/.travis.yml

@@ -1,5 +1,10 @@
 language: ruby
 rvm:
-  - 2.1.0
-  - 2.0.0
-  - 1.9.3
+  - 2.5.1
+  - 2.4.4
+  - 2.3.0
+
+# Avoid some errors, and speed things up:
+# https://github.com/bundler/bundler/issues/3558#issuecomment-171347979
+# https://docs.travis-ci.com/user/workers/container-based-infrastructure/
+sudo: false

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 4.0.0
+
+* Drop support for end-of-lifed Ruby 2.1 and 2.2.
+
+## 3.3.0
+
+* Traco now automatically adds query methods, e.g. `Item#title?` when `title` is translated.
+
+## 3.2.2
+
+* Internal cleanup.
+
 ## 3.2.1
 
 * Bugfix: with `fallback: [:sv]`, always look at current locale before any fallbacks.

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://secure.travis-ci.org/barsoom/traco.png)](http://travis-ci.org/barsoom/traco)
 
-Translatable attributes for Rails 3 and 4 (Ruby 1.9+), stored in the model table itself.
+Translatable attributes for Ruby on Rails, stored in the model table itself.
 
 Inspired by Iain Hecker's [translatable_columns](https://github.com/iain/translatable_columns/).
 
@@ -46,6 +46,8 @@ You can still use your accessors like `title_sv` and `title_sv=` in forms, valid
 
 `#title=`: Assigns the title to the column for the current locale, if present. Raises if the column doesn't exist.
 
+`#title?`: Is the title present? Respects the Traco [fallback](#fallbacks) setting.
+
 `.human_attribute_name(:title_sv)`: Extends this standard method to return "Title (Swedish)" if you have a translation key `i18n.languages.sv = "Swedish"` and "Title (SV)" otherwise. Rails uses this method to build validation error messages and form labels.
 
 `.translatable_attributes`: Returns an array like `[:title, :body]`.
@@ -120,7 +122,7 @@ end
 Add this to your `Gemfile`:
 
 ```ruby
-gem 'traco'
+gem "traco"
 ```
 
 Then run

data/lib/traco/attributes.rb

@@ -7,6 +7,7 @@ module Traco
       attributes.each do |attribute|
         define_reader(attribute)
         define_writer(attribute)
+        define_query(attribute)
       end
     end
 
@@ -25,7 +26,7 @@ module Traco
           default_fallback = #{@options.fetch(:fallback, LocaleFallbacks::DEFAULT_FALLBACK).inspect}
           fallback = options.fetch(:fallback, default_fallback)
 
-          columns_to_try = self.class._locale_columns_for_attribute(:#{attribute}, fallback)
+          columns_to_try = self.class._locale_columns_for_attribute(:#{attribute}, fallback: fallback)
           columns_to_try.each do |column|
             value = send(column)
             return value if value.present?
@@ -45,6 +46,14 @@ module Traco
       EOM
     end
 
+    def define_query(attribute)
+      class_eval <<-EOM, __FILE__, __LINE__ + 1
+        def #{attribute}?
+          #{attribute}.present?
+        end
+      EOM
+    end
+
     # Only called once per class or inheritance chain (e.g. once
     # for the superclass, not at all for subclasses). The separation
     # is important if we don't want to overwrite values if running

data/lib/traco/class_methods.rb

@@ -1,18 +1,18 @@
 module Traco
   module ClassMethods
     def locales_for_attribute(attribute)
-      traco_cache(attribute, LocaleFallbacks::DEFAULT_FIRST_FALLBACK).keys
+      traco_cache(attribute, fallback: LocaleFallbacks::DEFAULT_FIRST_FALLBACK).keys
     end
 
     def locale_columns(*attributes)
       attributes.each_with_object([]) do |attribute, columns|
-        columns.concat(_locale_columns_for_attribute(attribute, LocaleFallbacks::DEFAULT_FIRST_FALLBACK))
+        columns.concat(_locale_columns_for_attribute(attribute, fallback: LocaleFallbacks::DEFAULT_FIRST_FALLBACK))
       end
     end
 
     # Consider this method internal.
-    def _locale_columns_for_attribute(attribute, fallback)
-      traco_cache(attribute, fallback).values
+    def _locale_columns_for_attribute(attribute, fallback:)
+      traco_cache(attribute, fallback: fallback).values
     end
 
     def current_locale_column(attribute)
@@ -52,7 +52,7 @@ module Traco
     #         }
     #       }
     #     }
-    def traco_cache(attribute, fallback)
+    def traco_cache(attribute, fallback:)
       cache = @traco_cache ||= {}
       per_locale_cache = cache[I18n.locale] ||= {}
       per_attribute_cache = per_locale_cache[attribute] ||= {}

data/lib/traco/version.rb

@@ -1,3 +1,3 @@
 module Traco
-  VERSION = "3.2.1"
+  VERSION = "4.0.0"
 end

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 require "i18n"
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end

data/spec/spec_helper_models.rb

@@ -19,12 +19,10 @@ require "app/post.rb"
 
 ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"
 
-silence_stream(STDOUT) do
-  ActiveRecord::Schema.define(version: 0) do
-    create_table :posts, force: true do |t|
-      t.string :title_sv, :title_en, :title_pt_br
-      t.string :body_sv, :body_en, :body_pt_br
-    end
+ActiveRecord::Schema.define(version: 0) do
+  create_table :posts, force: true do |t|
+    t.string :title_sv, :title_en, :title_pt_br
+    t.string :body_sv, :body_en, :body_pt_br
   end
 end
 

data/spec/traco_spec.rb

@@ -298,6 +298,23 @@ describe Post, "#title=" do
   end
 end
 
+describe Post, "#title?" do
+  before do
+    Post.translates :title
+    I18n.locale = :sv
+    I18n.default_locale = :en
+  end
+
+  it "is true if the title is present" do
+    post = Post.new(title_sv: "", title_en: " ", title_pt_br: nil)
+    expect(post.title?).to be false
+
+    post.title_en = "Hello"
+
+    expect(post.title?).to be true
+  end
+end
+
 describe Post, ".human_attribute_name" do
   before do
     Post.translates :title

data/traco.gemspec

@@ -16,6 +16,8 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
+  s.required_ruby_version = ">= 2.3.0"
+
   s.add_dependency "activerecord", ">= 3.0"
 
   s.add_development_dependency "sqlite3"

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: traco
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-14 00:00:00.000000000 Z
+date: 2018-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -73,9 +73,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -105,17 +104,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Translatable columns for Rails 3 or better, stored in the model table itself.

data/.rvmrc

@@ -1 +0,0 @@
-rvm ruby-1.9.3-p194-falcon@traco --create