trackman 0.5.7 → 0.5.8

data/Gemfile.lock

@@ -9,7 +9,7 @@ GIT
 PATH
   remote: .
   specs:
-    trackman (0.5.6)
+    trackman (0.5.7)
       heroku (>= 2.26.2)
       json
       nokogiri

data/README.md

@@ -1,5 +1,5 @@
 # Trackman
-Trackman is a Heroku add-on that hosts your maintenance pages and their assets outside your app (S3).
+[Trackman](http://www.trackman-addon.com) is a Heroku add-on that hosts your maintenance pages and their assets outside your app (S3).
 You keep them within your project and Trackman syncs them to S3 when you deploy. 
 
 Works out of the box for Ruby(1.8.7 and 1.9.3) on 
@@ -109,14 +109,13 @@ Executing this task will throw exceptions instead of silently failing like the n
 
 ### Bug reports
 
-Any bug report can be submitted here.
-https://github.com/SynApps/trackman/issues
+Any bug report can be submitted [here](https://github.com/SynApps/trackman/issues).
 
 
 ### Creators / Maintainers
 
-* Jeremy Fabre (https://github.com/jfabre)
-* Emanuel Petre (https://github.com/epetre)
+* [Jeremy Fabre](https://github.com/jfabre)
+* [Emanuel Petre](https://github.com/epetre)
 
 ### Copyright
 
@@ -124,7 +123,7 @@ Copyright © 2012 SynApps
 
 ## License
 
-  Trackman is released under the MIT license:
+  The trackman gem (client) is released under the MIT license:
 
   [LICENSE](https://github.com/jfabre/trackman/blob/master/LICENSE)
 

data/lib/trackman/assets/composite_asset.rb

@@ -24,7 +24,10 @@ module Trackman
       end
       
       def inner_css_paths
-        data.scan(@@import).collect{|x| @@url.match(x)[1]}.select{|x| !x.embedded? }
+        #clean css comments
+        my_data = data.gsub(/\/\*.*\*\//m, '')
+        my_data = my_data.gsub(/\<\!\-\-.*\-\-\>/m, '')
+        my_data.scan(@@import).collect{|x| @@url.match(x)[1]}.select{|x| !x.embedded? }
       end
     end
   end

data/lib/trackman/version.rb

@@ -1,3 +1,3 @@
 module Trackman
-  VERSION = "0.5.7"
+  VERSION = "0.5.8"
 end

data/spec/css_asset_spec.rb

@@ -36,4 +36,12 @@ describe CssAsset do
 
     actual.should == expected
   end
+
+  it "does not return assets in comment" do
+    expected = []
+    asset = Asset.create(:path => 'spec/test_data/css/comments.css')
+    actual = asset.assets
+
+    actual.should == expected
+  end
 end

data/spec/html_asset_spec.rb

@@ -60,4 +60,13 @@ describe Trackman::Assets::HtmlAsset do
     
     actual.should == expected
   end
+
+  it "does not return assets in comments" do
+    asset = Asset.create(:path => 'spec/test_data/html/comments.html')
+    expected = []
+
+    actual = asset.children_paths
+    
+    actual.should == expected
+  end
 end

data/spec/test_data/css/comments.css

@@ -0,0 +1,3 @@
+/* 
+  @import url('imported.css');
+*/

data/spec/test_data/html/comments.html

@@ -0,0 +1,5 @@
+<!-- 
+<style type="text/css"> 
+@import url('css/imported.css');
+</style>
+-->

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: trackman
 version: !ruby/object:Gem::Version
-  version: 0.5.7
+  version: 0.5.8
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-01 00:00:00.000000000 Z
+date: 2012-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -468,6 +468,7 @@ files:
 - spec/test_data/all/all3.html
 - spec/test_data/b.js
 - spec/test_data/c.js
+- spec/test_data/css/comments.css
 - spec/test_data/css/image/riding-you.jpg
 - spec/test_data/css/image/with-image.css
 - spec/test_data/css/imported-loop1.css
@@ -483,6 +484,7 @@ files:
 - spec/test_data/css/with-multiple-assets.css
 - spec/test_data/external_paths/1.css
 - spec/test_data/external_paths/1.html
+- spec/test_data/html/comments.html
 - spec/test_data/sample.html
 - spec/test_data/test1.jpeg
 - spec/test_data/test2.png
@@ -781,6 +783,7 @@ test_files:
 - spec/test_data/all/all3.html
 - spec/test_data/b.js
 - spec/test_data/c.js
+- spec/test_data/css/comments.css
 - spec/test_data/css/image/riding-you.jpg
 - spec/test_data/css/image/with-image.css
 - spec/test_data/css/imported-loop1.css
@@ -796,6 +799,7 @@ test_files:
 - spec/test_data/css/with-multiple-assets.css
 - spec/test_data/external_paths/1.css
 - spec/test_data/external_paths/1.html
+- spec/test_data/html/comments.html
 - spec/test_data/sample.html
 - spec/test_data/test1.jpeg
 - spec/test_data/test2.png