trackler 2.2.1.56 → 2.2.1.57

data/tracks/go/exercises/isbn-verifier/isbn_verifier_test.go

@@ -0,0 +1,35 @@
+package isbn
+
+import (
+	"testing"
+)
+
+var testCases = []struct {
+	isbn        string
+	expected    bool
+	description string
+}{
+	{"3-598-21508-8", true, "valid isbn number"},
+	{"3-598-21508-9", false, "invalid isbn check digit"},
+	{"3-598-21507-X", true, "valid isbn number with a check digit of 10"},
+	{"3-598-21507-A", false, "check digit is a character other than X"},
+	{"3-598-2K507-0", false, "invalid character in isbn"},
+	{"3-598-2X507-0", false, "X is only valid as a check digit"},
+	{"3598215088", true, "valid isbn without separating dashes"},
+	{"359821507X", true, "isbn without separating dashes and X as check digit"},
+	{"359821507", false, "isbn without check digit and dashes"},
+	{"3598215078X", false, "too long isbn and no dashes"},
+	{"3-598-21507", false, "isbn without check digit"},
+	{"3-598-21507-XA", false, "too long isbn"},
+	{"3-598-21515-X", false, "check digit of X should not be used for 0"},
+}
+
+func TestIsValidISBN(t *testing.T) {
+	for _, test := range testCases {
+		observed := IsValidISBN(test.isbn)
+		if observed != test.expected {
+			t.Fatalf("got %t, want %t, %s (%s)",
+				observed, test.expected, test.description, test.isbn)
+		}
+	}
+}

data/tracks/go/exercises/isogram/example.go

@@ -2,8 +2,6 @@ package isogram
 
 import "strings"
 
-const testVersion = 1
-
 func IsIsogram(word string) bool {
 	for i, r := range strings.ToLower(word) {
 		if r != ' ' && r != '-' && i < strings.LastIndex(word, string(r)) {

data/tracks/go/exercises/isogram/isogram_test.go

@@ -2,8 +2,6 @@ package isogram
 
 import "testing"
 
-const targetTestVersion = 1
-
 var testCases = []struct {
 	word     string
 	expected bool
@@ -20,12 +18,6 @@ var testCases = []struct {
 	{"éléphant", false},
 }
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v.", testVersion, targetTestVersion)
-	}
-}
-
 func TestIsIsogram(t *testing.T) {
 	for _, c := range testCases {
 		if IsIsogram(c.word) != c.expected {

data/tracks/go/exercises/kindergarten-garden/example.go

@@ -6,8 +6,6 @@ import (
 	"strings"
 )
 
-const testVersion = 1
-
 type Garden map[string][]string
 
 func (g *Garden) Plants(child string) ([]string, bool) {

data/tracks/go/exercises/kindergarten-garden/kindergarten_garden_test.go

@@ -24,8 +24,6 @@ import (
 	"testing"
 )
 
-const targetTestVersion = 1
-
 type lookup struct {
 	child  string
 	plants []string
@@ -119,12 +117,6 @@ RVGCCGCV`, append([]string{}, test6names...), true, []lookup{
 	}}
 )
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v.", testVersion, targetTestVersion)
-	}
-}
-
 func TestGarden(t *testing.T) {
 	for _, test := range tests {
 		g, err := NewGarden(test.diagram, test.children)

data/tracks/go/exercises/largest-series-product/cases_test.go

@@ -1,8 +1,8 @@
 package lsproduct
 
-// Source: exercism/x-common
+// Source: exercism/problem-specifications
 // Commit: e79b832 largest-series-product: Fix canonical-data.json formatting
-// x-common version: 1.0.0
+// Problem Specifications Version: 1.0.0
 
 var tests = []struct {
 	digits  string

data/tracks/go/exercises/largest-series-product/example.go

@@ -2,8 +2,6 @@ package lsproduct
 
 import "fmt"
 
-const testVersion = 5
-
 func LargestSeriesProduct(digits string, span int) (int64, error) {
 	if span < 0 {
 		return 0, fmt.Errorf("span is negative: %d", span)

data/tracks/go/exercises/largest-series-product/largest_series_product_test.go

@@ -2,14 +2,6 @@ package lsproduct
 
 import "testing"
 
-const targetTestVersion = 5
-
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v", testVersion, targetTestVersion)
-	}
-}
-
 func TestLargestSeriesProduct(t *testing.T) {
 	for _, test := range tests {
 		p, err := LargestSeriesProduct(test.digits, test.span)

data/tracks/go/exercises/leap/.meta/hints.md

@@ -0,0 +1,14 @@
+You will see a `cases_test.go` file in this exercise. This holds the test
+cases used in the `leap_test.go`. You can mostly ignore this file.
+
+However, if you are interested... we sometimes generate the test data from a
+[cross language repository][problem-specifications-leap]. In that repo
+exercises may have a [.json file][problem-specifications-leap-json] that
+contains common test data. Some of our local exercises have an
+[intermediary program][local-leap-gen] that takes the problem specification
+JSON and turns in into Go structs that are fed into the `<exercise>_test.go`
+file. The Go specific transformation of that data lives in the `cases_test.go` file.
+
+[problem-specifications-leap]: https://github.com/exercism/problem-specifications/tree/master/exercises/leap
+[problem-specifications-leap-json]: https://github.com/exercism/problem-specifications/blob/master/exercises/leap/canonical-data.json
+[local-leap-gen]: https://github.com/exercism/go/blob/master/exercises/leap/.meta/gen.go

data/tracks/go/exercises/leap/README.md

@@ -26,6 +26,22 @@ phenomenon, go watch [this youtube video][video].
 
 [video]: http://www.youtube.com/watch?v=xX96xng7sAE
 
+You will see a `cases_test.go` file in this exercise. This holds the test
+cases used in the `leap_test.go`. You can mostly ignore this file.
+
+However, if you are interested... we sometimes generate the test data from a
+[cross language repository][problem-specifications-leap]. In that repo
+exercises may have a [.json file][problem-specifications-leap-json] that
+contains common test data. Some of our local exercises have an
+[intermediary program][local-leap-gen] that takes the problem specification
+JSON and turns in into Go structs that are fed into the `<exercise>_test.go`
+file. The Go specific transformation of that data lives in the `cases_test.go` file.
+
+[problem-specifications-leap]: https://github.com/exercism/problem-specifications/tree/master/exercises/leap
+[problem-specifications-leap-json]: https://github.com/exercism/problem-specifications/blob/master/exercises/leap/canonical-data.json
+[local-leap-gen]: https://github.com/exercism/go/blob/master/exercises/leap/.meta/gen.go
+
+
 ## Running the tests
 
 To run the tests run the command `go test` from within the exercise directory.

data/tracks/go/exercises/leap/cases_test.go

@@ -1,8 +1,8 @@
 package leap
 
-// Source: exercism/x-common
-// Commit: cc65ebe leap: Fix canonical-data.json formatting
-// x-common version: 1.0.0
+// Source: exercism/problem-specifications
+// Commit: 11fbf7e leap: Fix loophole in unit tests (#971)
+// Problem Specifications Version: 1.2.0
 
 var testCases = []struct {
 	year        int
@@ -10,7 +10,7 @@ var testCases = []struct {
 	description string
 }{
 	{2015, false, "year not divisible by 4: common year"},
-	{2016, true, "year divisible by 4, not divisible by 100: leap year"},
+	{1996, true, "year divisible by 4, not divisible by 100: leap year"},
 	{2100, false, "year divisible by 100, not divisible by 400: common year"},
 	{2000, true, "year divisible by 400: leap year"},
 }

data/tracks/go/exercises/leap/example.go

@@ -1,7 +1,5 @@
 package leap
 
-const testVersion = 3
-
 func IsLeapYear(i int) bool {
 	return i%4 == 0 && i%100 != 0 || i%400 == 0
 }

data/tracks/go/exercises/leap/leap.go

@@ -1,6 +1,15 @@
-package leap
+// This is a "stub" file.  It's a little start on your solution.
+// It's not a complete solution though; you have to write some code.
 
-const testVersion = 3
+// Package leap should have a package comment that summarizes what it's about.
+// https://golang.org/doc/effective_go.html#commentary
+package leap
 
+// IsLeapYear should have a comment documenting it.
 func IsLeapYear(int) bool {
+	// Write some code here to pass the test suite.
+	// Then remove all the stock comments.
+	// They're here to help you get started but they only clutter a finished solution.
+	// If you leave them in, reviewers may protest!
+	return false
 }

data/tracks/go/exercises/leap/leap_test.go

@@ -2,21 +2,6 @@ package leap
 
 import "testing"
 
-// targetTestVersion is used to ensure that a solution is only evaluated
-// against the correct version of the test suite.
-const targetTestVersion = 3
-
-// TestTestVersion compares the targetTestVersion defined above with
-// a testVersion value.
-// This is a common convention throughout the Go Exercism track.
-// To make a test like this test pass, define 'testVersion' in your solution.
-// We've done this for you in the ./leap.go file provided.
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v", testVersion, targetTestVersion)
-	}
-}
-
 func TestLeapYears(t *testing.T) {
 	for _, test := range testCases {
 		observed := IsLeapYear(test.year)

data/tracks/go/exercises/ledger/example.go

@@ -8,8 +8,6 @@ import (
 	"time"
 )
 
-const testVersion = 4
-
 type Entry struct {
 	Date        string // "Y-m-d"
 	Description string

data/tracks/go/exercises/ledger/ledger.go

@@ -6,8 +6,6 @@ import (
 	"strings"
 )
 
-const testVersion = 4
-
 type Entry struct {
 	Date        string // "Y-m-d"
 	Description string

data/tracks/go/exercises/ledger/ledger_test.go

@@ -6,8 +6,6 @@ import (
 	"testing"
 )
 
-const targetTestVersion = 4
-
 var successTestCases = []struct {
 	name     string
 	currency string
@@ -250,12 +248,6 @@ var failureTestCases = []struct {
 	},
 }
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v", testVersion, targetTestVersion)
-	}
-}
-
 func TestFormatLedgerSuccess(t *testing.T) {
 	for _, tt := range successTestCases {
 		actual, err := FormatLedger(tt.currency, tt.locale, tt.entries)

data/tracks/go/exercises/luhn/cases_test.go

@@ -1,8 +1,8 @@
 package luhn
 
-// Source: exercism/x-common
+// Source: exercism/problem-specifications
 // Commit: c826372 luhn: Make canonical-data.json compliant
-// x-common version: 1.0.0
+// Problem Specifications Version: 1.0.0
 
 var testCases = []struct {
 	description string

data/tracks/go/exercises/luhn/example.go

@@ -2,8 +2,6 @@ package luhn
 
 import "strings"
 
-const testVersion = 2
-
 func Valid(id string) bool {
 
 	if len(strings.TrimSpace(id)) == 1 {

data/tracks/go/exercises/luhn/luhn_test.go

@@ -2,14 +2,6 @@ package luhn
 
 import "testing"
 
-const targetTestVersion = 2
-
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Errorf("Found testVersion = %v, want %v", testVersion, targetTestVersion)
-	}
-}
-
 func TestValid(t *testing.T) {
 	for _, test := range testCases {
 		if ok := Valid(test.input); ok != test.ok {

data/tracks/go/exercises/matrix/example.go

@@ -9,8 +9,6 @@ import (
 // Maintenance note:  This file exists as both matrix/example.go and
 // saddle-points/matrix_example.go.  When changing one file, copy to the other.
 
-const testVersion = 1
-
 type Matrix [][]int
 
 func New(s string) (*Matrix, error) {

data/tracks/go/exercises/matrix/matrix_test.go

@@ -18,8 +18,6 @@ import (
 	"testing"
 )
 
-const targetTestVersion = 1
-
 var tests = []struct {
 	in   string
 	ok   bool
@@ -142,12 +140,6 @@ var tests = []struct {
 	// {"",     // valid?, 0 rows, 0 columns
 }
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v.", testVersion, targetTestVersion)
-	}
-}
-
 func TestNew(t *testing.T) {
 	for _, test := range tests {
 		m, err := New(test.in)

data/tracks/go/exercises/meetup/cases_test.go

@@ -1,8 +1,8 @@
 package meetup
 
-// Source: exercism/x-common
+// Source: exercism/problem-specifications
 // Commit: fe9630e meetup: Fix canonical-data.json formatting
-// x-common version: 1.0.0
+// Problem Specifications Version: 1.0.0
 
 import "time"
 

data/tracks/go/exercises/meetup/example.go

@@ -2,8 +2,6 @@ package meetup
 
 import "time"
 
-const testVersion = 3
-
 type WeekSchedule int
 
 const (

data/tracks/go/exercises/meetup/meetup_test.go

@@ -14,8 +14,6 @@ WeekSchedule Teenth
 func Day(WeekSchedule, time.Weekday, time.Month, int) int
 */
 
-const targetTestVersion = 3
-
 var weekName = map[WeekSchedule]string{
 	First:  "first",
 	Second: "second",
@@ -25,12 +23,6 @@ var weekName = map[WeekSchedule]string{
 	Last:   "last",
 }
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v", testVersion, targetTestVersion)
-	}
-}
-
 func TestDay(t *testing.T) {
 	for _, test := range testCases {
 		res := Day(test.week, test.weekday, test.month, test.year)

data/tracks/go/exercises/minesweeper/example.go

@@ -5,8 +5,6 @@ import (
 	"errors"
 )
 
-const testVersion = 1
-
 func (b Board) Count() error {
 	if len(b) < 2 {
 		return errors.New("need top and bottom border")

data/tracks/go/exercises/minesweeper/minesweeper_test.go

@@ -5,8 +5,6 @@ import (
 	"testing"
 )
 
-const targetTestVersion = 1
-
 var validBoards = []string{
 	// zero size board
 	`
@@ -151,12 +149,6 @@ func clear(s string) Board {
 	return bytes.Split(b, []byte{'\n'})[1:]
 }
 
-func TestTestVersion(t *testing.T) {
-	if testVersion != targetTestVersion {
-		t.Fatalf("Found testVersion = %v, want %v.", testVersion, targetTestVersion)
-	}
-}
-
 func TestValid(t *testing.T) {
 	for _, ref := range validBoards {
 		b := clear(ref)