trackler 2.2.1.46 → 2.2.1.47

data/tracks/gnu-apl/bin/run-all-tests

@@ -3,10 +3,11 @@
 STATUS=0
 APL=/usr/bin/apl
 APL_OPTS='--silent --Color'
+TMP=tmp
 
-cp --recursive exercises tmp
+cp --recursive exercises $TMP
 
-for exercise in tmp/*; do
+for exercise in ${TMP}/*; do
   pushd $exercise
   for example in *-example.apl; do
     mv $example ${example/-example/}
@@ -17,5 +18,7 @@ for exercise in tmp/*; do
   popd
 done
 
+rm -r $TMP
+
 echo "Exiting with status ${STATUS}."
 exit $STATUS

data/tracks/java/CONTRIBUTING.md

@@ -164,5 +164,13 @@ See [The Problem Submodules](#the-problem-submodules) section for what needs to
 The `build.gradle` file can just be copied from any other exercise submodule.
 See the [POLICIES doc](https://github.com/exercism/java/blob/master/POLICIES.md#starter-implementations) for an explanation of when you need to add a starter implementation.
 
+4. Check if there is canonical data for the exercise you're adding.
+This can be found at `https://github.com/exercism/problem-specifications/tree/master/exercises/EXERCISE-SLUG/canonical-data.json`.
+If there is canonical data for your exercise then you should follow this when making the tests.
+We aim to follow the canonical data as closely as possible in our tests to ensure thorough test coverage.
+If there is canonical data available you also need to create a file at `exercises/exercise-slug/.meta/version` specifying the canonical data version you have implemented (e.g. `1.0.0`).
+The canonical data version can be found at the top of the canonical data file for that exercise.
+See other exercises, e.g. [acronym](https://github.com/exercism/java/tree/master/exercises/acronym/.meta), for an example `version` file.
+
 Hopefully that should be enough information to help you port an exercise to the Java track.
 Feel free to open an issue or post in the [Gitter exercism/java room](https://gitter.im/exercism/java) if you have any questions and we'll try and answer as soon as we can.

data/tracks/java/POLICIES.md

@@ -35,7 +35,7 @@ References: [[1](https://github.com/exercism/java/issues/177#issuecomment-261291
 
 > - Exercises 1-20: provide stubs for all required constructors and methods. Stubs should include the following body:
     `throw new UnsupportedOperationException("Delete this statement and write your own implementation.");`
-> - Exercises 21+: provide no stubs by default, but either (1) add hints to the HINTS.md file (which gets merged into the README.md for the exercise) or (2) provide stubs as in exercises 1-20 for exercises that demand complicated method signatures.
+> - Exercises 21+: provide no stubs by default, but either (1) add hints to the hints.md file (which gets merged into the README.md for the exercise) or (2) provide stubs as in exercises 1-20 for exercises that demand complicated method signatures.
 
 References: [[1](https://github.com/exercism/java/issues/178)], [[2](https://github.com/exercism/java/pull/683#discussion_r125506930)]
 
@@ -56,7 +56,7 @@ References: [[1](https://github.com/exercism/java/issues/101#issuecomment-249349
 
 ### Multiple file submissions
 
-> The first exercise in the track whose test suite mandates multiple solution files should be accompanied by a HINTS.md file reminding the practitioner that the CLI supports multiple file submissions.
+> The first exercise in the track whose test suite mandates multiple solution files should be accompanied by a hints.md file reminding the practitioner that the CLI supports multiple file submissions.
 
 References: [[1](https://github.com/exercism/java/issues/365#issuecomment-292533120)]
 

data/tracks/java/config.json

@@ -432,7 +432,12 @@
       "core": false,
       "difficulty": 5,
       "slug": "run-length-encoding",
-      "topics": null,
+      "topics": [
+        "strings",
+        "integers",
+        "pattern_matching",
+        "transforming"
+      ],
       "unlocked_by": "rotational-cipher",
       "uuid": "4499a3f9-73a7-48bf-8753-d5b6abf588c9"
     },
@@ -548,7 +553,13 @@
       "core": false,
       "difficulty": 6,
       "slug": "spiral-matrix",
-      "topics": null,
+      "topics": [
+        "loops",
+        "arrays",
+        "integers",
+        "mathematics",
+        "matrices"
+      ],
       "unlocked_by": "matrix",
       "uuid": "163fcc6b-c054-4232-a88b-0aded846a6eb"
     },
@@ -917,7 +928,12 @@
       "core": false,
       "difficulty": 8,
       "slug": "rectangles",
-      "topics": null,
+      "topics": [
+        "arrays",
+        "logic",
+        "pattern_recognition",
+        "strings"
+      ],
       "unlocked_by": "robot-name",
       "uuid": "64cda115-919a-4eef-9a45-9ec5d1af98cc"
     },
@@ -966,7 +982,13 @@
       "core": false,
       "difficulty": 8,
       "slug": "list-ops",
-      "topics": null,
+      "topics": [
+        "filtering",
+        "functional_programming",
+        "generics",
+        "lists",
+        "loops"
+      ],
       "unlocked_by": "linked-list",
       "uuid": "a9836565-5c39-4285-b83a-53408be36ccc"
     },

data/tracks/java/exercises/triangle/.meta/.version

@@ -0,0 +1 @@
+1.0.0

data/tracks/java/exercises/triangle/.meta/src/reference/java/Triangle.java

@@ -25,7 +25,7 @@ class Triangle {
     }
 
     boolean isIsosceles() {
-        return uniqueSides == 2;
+        return (uniqueSides == 2 || isEquilateral());
     }
 
     boolean isScalene() {

data/tracks/java/exercises/triangle/src/test/java/TriangleTest.java

@@ -4,6 +4,7 @@ import org.junit.Rule;
 import org.junit.rules.ExpectedException;
 
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
 
 public class TriangleTest {
 
@@ -19,24 +20,39 @@ public class TriangleTest {
 
     @Ignore("Remove to run test")
     @Test
-    public void largerEquilateralTrianglesAlsoHaveEqualSides() throws TriangleException {
-        Triangle triangle = new Triangle(10, 10, 10);
+    public void trianglesWithOneUnequalSideAreNotEquilateral() throws TriangleException {
+        Triangle triangle = new Triangle(2, 3, 2);
 
-        assertTrue(triangle.isEquilateral());
+        assertFalse(triangle.isEquilateral());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void isoscelesTrianglesHaveLastTwoSidesEqual() throws TriangleException {
-        Triangle triangle = new Triangle(3, 4, 4);
+    public void trianglesWithNoEqualSidesAreNotEquilateral() throws TriangleException {
+        Triangle triangle = new Triangle(5, 4, 6);
 
-        assertTrue(triangle.isIsosceles());
+        assertFalse(triangle.isEquilateral());
+    }
+    
+    @Ignore("Remove to run test")
+    @Test
+    public void trianglesWithNoSizeAreIllegal() throws TriangleException {
+        expectedException.expect(TriangleException.class);
+        new Triangle(0, 0, 0);
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void isoscelesTrianglesHaveFirstAndLastSidesEqual() throws TriangleException {
-        Triangle triangle = new Triangle(4, 3, 4);
+    public void verySmallTrianglesCanBeEquilateral() throws TriangleException {
+        Triangle triangle = new Triangle(0.5, 0.5, 0.5);
+
+        assertTrue(triangle.isEquilateral());
+    }
+
+    @Ignore("Remove to run test")
+    @Test
+    public void isoscelesTrianglesHaveLastTwoSidesEqual() throws TriangleException {
+        Triangle triangle = new Triangle(3, 4, 4);
 
         assertTrue(triangle.isIsosceles());
     }
@@ -48,79 +64,82 @@ public class TriangleTest {
 
         assertTrue(triangle.isIsosceles());
     }
-
+    
     @Ignore("Remove to run test")
     @Test
-    public void isoscelesTrianglesHaveInFactExactlyTwoSidesEqual() throws TriangleException {
-        Triangle triangle = new Triangle(10, 10, 2);
+    public void isoscelesTrianglesHaveFirstAndLastSidesEqual() throws TriangleException {
+        Triangle triangle = new Triangle(4, 3, 4);
 
         assertTrue(triangle.isIsosceles());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void scaleneTrianglesHaveNoEqualSides() throws TriangleException {
-        Triangle triangle = new Triangle(3, 4, 5);
+    public void isoscelesTrianglesCanHaveAllSidesEqual() throws TriangleException {
+        Triangle triangle = new Triangle(4, 4, 4);
 
-        assertTrue(triangle.isScalene());
+        assertTrue(triangle.isIsosceles());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void scaleneTrianglesHaveNoEqualSidesAtLargerScaleEither() throws TriangleException {
-        Triangle triangle = new Triangle(10, 11, 12);
+    public void isoscelesTrianglesMustHaveAtLeastTwoEqualSides() throws TriangleException {
+        Triangle triangle = new Triangle(2, 3, 4);
 
-        assertTrue(triangle.isScalene());
+        assertFalse(triangle.isIsosceles());
     }
-
+    
     @Ignore("Remove to run test")
     @Test
-    public void scaleneTrianglesHaveNoEqualSidesInDescendingOrderEither() throws TriangleException {
-        Triangle triangle = new Triangle(5, 4, 2);
-
-        assertTrue(triangle.isScalene());
+    public void testSidesThatViolateTriangleInequalityAreNotIsoscelesEvenIfTwoAreEqual() throws TriangleException {
+        expectedException.expect(TriangleException.class);
+        new Triangle(1, 1, 3);
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void verySmallTrianglesAreLegal() throws TriangleException {
-        Triangle triangle = new Triangle(0.4, 0.6, 0.3);
+    public void verySmallTrianglesCanBeIsosceles() throws TriangleException {
+        Triangle triangle = new Triangle(0.5, 0.4, 0.5);
 
-        assertTrue(triangle.isScalene());
+        assertTrue(triangle.isIsosceles());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void trianglesWithNoSizeAreIllegal() throws TriangleException {
-        expectedException.expect(TriangleException.class);
-        new Triangle(0, 0, 0);
+    public void scaleneTrianglesHaveNoEqualSides() throws TriangleException {
+        Triangle triangle = new Triangle(5, 4, 6);
+
+        assertTrue(triangle.isScalene());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void trianglesWithNegativeSidesAreIllegal() throws TriangleException {
-        expectedException.expect(TriangleException.class);
-        new Triangle(3, 4, -5);
+    public void trianglesWithAllSidesEqualAreNotScalene() throws TriangleException {
+        Triangle triangle = new Triangle(4, 4, 4);
+
+        assertFalse(triangle.isScalene());
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void trianglesViolatingTriangleInequalityAreIllegal() throws TriangleException {
-        expectedException.expect(TriangleException.class);
-        new Triangle(1, 1, 3);
-    }
+    public void trianglesWithOneUnequalSideAreNotScalene() throws TriangleException {
+        Triangle triangle = new Triangle(4, 4, 3);
 
+        assertFalse(triangle.isScalene());
+    }
+    
     @Ignore("Remove to run test")
     @Test
-    public void trianglesViolatingTriangleInequalityAreIllegal2() throws TriangleException {
+    public void testSidesThatViolateTriangleInequalityAreNotScaleneEvenIfTheyAreAllDifferent() throws TriangleException {
         expectedException.expect(TriangleException.class);
-        new Triangle(2, 5, 2);
+        new Triangle(7, 3, 2);
     }
 
     @Ignore("Remove to run test")
     @Test
-    public void trianglesViolatingTriangleInequalityAreIllegal3() throws TriangleException {
-        expectedException.expect(TriangleException.class);
-        new Triangle(7, 3, 2);
+    public void verySmallTrianglesCanBeScalene() throws TriangleException {
+        Triangle triangle = new Triangle(0.5, 0.4, 0.6);
+
+        assertTrue(triangle.isScalene());
     }
 }

data/tracks/javascript/config.json

@@ -1056,6 +1056,21 @@
       "unlocked_by": "prime-factors",
       "uuid" : "910fe904-7e3c-11e7-bb31-be2e44b06b34"
     },
+    {
+      "core" :  false,
+      "difficulty" : 1,
+      "slug" : "collatz-conjecture",
+       "topics": [
+         "Control-flow (loops)",
+         "Control-flow (conditionals)",
+         "Recursion",
+         "Integers",
+         "Algorithms",
+         "Mathematics"
+      ],
+      "unlocked_by": "null",
+      "uuid" : "fd435dad-311a-4c40-9868-70863455831e"
+    },
     {
       "deprecated": true,
       "slug": "nucleotide-count",
@@ -1081,6 +1096,21 @@
         "Regular expressions"
       ]
     },
+    {
+      "core": false,
+      "difficulty": 1,
+      "slug": "transpose",
+      "topics": [
+        "loops",
+        "arrays",
+        "lists",
+        "matrices",
+        "strings",
+        "text_formatting"
+      ],
+      "unlocked_by": "matrix",
+      "uuid": "7c024853-0540-473d-b2d9-cad84953c00f"
+    },
     {
       "uuid": "52c775a4-7ddb-4cba-8a78-8544220bd1b6",
       "slug": "protein-translation",

data/tracks/javascript/config/maintainers.json

@@ -14,22 +14,22 @@
     {
       "alumnus": false,
       "avatar_url": null,
-      "bio": null,
+      "bio": "I'm a Web Developer with a passion for taking code that is hard to maintain and cleaning, refactoring, and bringing it back into a manageable state",
       "github_username": "rchavarria",
-      "link_text": null,
-      "link_url": null,
-      "name": null,
-      "show_on_website": false
+      "link_text": "Here is where I blog",
+      "link_url": "https://rchavarria.github.io/",
+      "name": "Rubén Chavarría",
+      "show_on_website": true
     },
     {
       "alumnus": false,
       "avatar_url": null,
-      "bio": null,
+      "bio": "Brazilian full-stack web developer. Mentor at Thinkful",
       "github_username": "joelwallis",
       "link_text": null,
       "link_url": null,
       "name": null,
-      "show_on_website": false
+      "show_on_website": true
     },
     {
       "alumnus": false,
@@ -82,4 +82,4 @@
       "show_on_website": false
     }
   ]
-}
+}

data/tracks/javascript/exercises/change/example.js

@@ -14,7 +14,7 @@ var Candidate = function () {
   var searched = false;
   var coins = [];
 
-  this.Searched = function () {
+  this.searched = function () {
     searched = true;
   };
 
@@ -52,7 +52,7 @@ Change.prototype.calculate = function (coinArray, target) {
   candidates.fill(0);
 
   // validation checks up front
-  if (target == 0) return [];
+  if (target === 0) return [];
 
   if (target < 0) {
     throw new Error( 'Negative totals are not allowed.');
@@ -64,34 +64,18 @@ Change.prototype.calculate = function (coinArray, target) {
 
 
   initialize();
-  // printAll();
-
 
   // process the arrange until everything is searched
-  while (isDone() == false) {
+  while (isDone() === false) {
     let candidate = getNext();
     branch(candidate);
-    candidate.Searched();
+    candidate.searched();
   }
-  // printAll();
-
 
   // print the result
   if (typeof (candidates[target]) !== 'number') {return candidates[target].getCoins();}
   throw new Error('The total ' + target + ' cannot be represented in the given currency.');
 
-
-  // print the candidate array
-  function printAll() {
-    for (let j = 0; j < candidates.length; j++) {
-      if (typeof (candidates[j]) === 'object') {
-        console.log('index: ' + j + ' ' + candidates[j].getCoins() + ' searched: ' + candidates[j].isSearched());
-      } else {
-        console.log('index: ' + j + ' is empty ' + typeof (candidates[j]));
-      }
-    }
-  }
-
   // initialize the candidate array with the given coins only
   function initialize() {
     for (let j = 0; j < coinArray.length; j++) {
@@ -108,7 +92,7 @@ Change.prototype.calculate = function (coinArray, target) {
     for (let i = 0; i < candidates.length; i++) {
       let temp = candidates[i];
       if (typeof (temp) !== 'number') {
-        if (temp.isSearched() == false) {
+        if (temp.isSearched() === false) {
           done = false;
           break;
         }
@@ -122,7 +106,7 @@ Change.prototype.calculate = function (coinArray, target) {
     for (let i = 0; i < candidates.length; i++) {
       let temp = candidates[i];
       if (typeof (temp) !== 'number' &&
-                temp.isSearched() == false) return temp;
+                temp.isSearched() === false) return temp;
     }
     return null;
   }