trackler 2.2.1.42 → 2.2.1.43

data/tracks/erlang/exercises/bank-account/test/bank_account_tests.erl

@@ -29,10 +29,8 @@ deposit_fail_test() ->
 deposit_many_test() ->
   BankAccount = ?TESTED_MODULE:create(),
   [erlang:spawn( fun () -> ?TESTED_MODULE:deposit(BankAccount, X) end ) || X <- lists:seq(1, 10)],
-  First = ?TESTED_MODULE:balance(BankAccount),
   timer:sleep(100),
   Last = ?TESTED_MODULE:balance(BankAccount),
-  ?assert(First < 55),
   ?assert(Last =:= 55).
 
 withdraw_test() ->
@@ -60,10 +58,8 @@ withdraw_many_test() ->
   BankAccount = ?TESTED_MODULE:create(),
   ?TESTED_MODULE:deposit(BankAccount, 55 ),
   [erlang:spawn( fun () -> ?TESTED_MODULE:withdraw(BankAccount, X) end ) || X <- lists:seq(1, 10)],
-  First = ?TESTED_MODULE:balance(BankAccount),
   timer:sleep(100),
   Last = ?TESTED_MODULE:balance(BankAccount),
-  ?assert(First > 0),
   ?assert(Last =:= 0).
 
 charge_test() ->
@@ -91,8 +87,6 @@ charge_many_test() ->
   BankAccount = ?TESTED_MODULE:create(),
   ?TESTED_MODULE:deposit(BankAccount, 55 ),
   [erlang:spawn( fun () -> ?TESTED_MODULE:charge(BankAccount, 10) end ) || _X <- lists:seq(1, 10)],
-  First = ?TESTED_MODULE:balance(BankAccount),
   timer:sleep(100),
   Last = ?TESTED_MODULE:balance(BankAccount),
-  ?assert(First > 0),
   ?assert(Last =:= 5).

data/tracks/erlang/exercises/luhn/src/example.erl

@@ -1,17 +1,12 @@
 -module(example).
--export([valid/1, create/1, checksum/1, test_version/0]).
+-export([valid/1, test_version/0]).
 
 
 
 checksum(Number) ->
   checksum(
     lists:reverse(
-      lists:filter(
-        fun(C) ->
-            ($0 =< C) andalso (C =< $9)
-        end,
-        Number
-       )
+      filter_input(Number)
      ),
     odd,
     0
@@ -19,6 +14,26 @@ checksum(Number) ->
 
 
 
+is_numeric(Number) ->
+  lists:all(
+  	fun(C) ->
+  		(($0 =< C) andalso (C =< $9)) or (C == $\s)
+  	end,
+  	Number
+  ).
+
+
+
+filter_input(Number) ->
+  lists:filter(
+    fun(C) ->
+      ($0 =< C) andalso (C =< $9)
+    end,
+    Number
+  ).
+
+
+
 checksum([], _, Total) ->
   Total;
 
@@ -34,14 +49,17 @@ checksum([H | ReversedNumber], even, Total) when H >= $5 ->
 
 
 valid(Number) ->
-  checksum(Number) rem 10 == 0.
-
-
-
-create(Number) ->
-  lists:flatten([Number, ($: - (checksum(Number ++ [$0]) rem 10))]).
+  case is_numeric(Number) of
+    true ->
+      case filter_input(Number) of
+        Number2 = [_,_|_] ->
+          checksum(Number2) rem 10 == 0;
+        _ -> false
+      end;
+    _ -> false
+  end.
 
 
 
 test_version() ->
-    1.
+    2.

data/tracks/erlang/exercises/luhn/test/luhn_tests.erl

@@ -1,18 +1,44 @@
 -module(luhn_tests).
 
 -define(TESTED_MODULE, (sut(luhn))).
--define(TEST_VERSION, 1).
+-define(TEST_VERSION, 2).
 -include("exercism.hrl").
 
+single_digit_strings_can_not_be_valid_test() ->
+  ?assertNot(?TESTED_MODULE:valid("1")).
 
-invalid_test() ->
-  ?assertNot(?TESTED_MODULE:valid("1111")),
-  ?assertNot(?TESTED_MODULE:valid("738")).
+a_single_zero_is_invalid_test() ->
+  ?assertNot(?TESTED_MODULE:valid("0")).
 
-valid_test() ->
-  ?assert(?TESTED_MODULE:valid("8739567")),
-  ?assert(?TESTED_MODULE:valid("8763")),
-  ?assert(?TESTED_MODULE:valid("2323 2005 7766 3554")).
+a_simple_valid_sin_that_remains_valid_if_reversed_test() ->
+  ?assert(?TESTED_MODULE:valid("059")).
 
-create_test() ->
-  ?assertEqual("2323 2005 7766 3554", ?TESTED_MODULE:create("2323 2005 7766 355")).
+a_simple_valid_sin_that_becomes_invalid_if_reversed_test() ->
+  ?assert(?TESTED_MODULE:valid("59")).
+
+a_valid_canadian_sin_test() ->
+  ?assert(?TESTED_MODULE:valid("055 444 285")).
+
+invalid_canadian_sin_test() ->
+  ?assertNot(?TESTED_MODULE:valid("055 444 286")).
+
+invalid_credit_card_test() ->
+  ?assertNot(?TESTED_MODULE:valid("8273 1232 7352 0569")).
+
+valid_strings_with_a_non_digit_included_become_invalid_test() ->
+  ?assertNot(?TESTED_MODULE:valid("055a 444 285")).
+
+valid_strings_with_punctuation_included_become_invalid_test() ->
+  ?assertNot(?TESTED_MODULE:valid("055-444-285")).
+
+valid_strings_with_symbols_included_become_invalid_test() ->
+  ?assertNot(?TESTED_MODULE:valid("055£ 444$ 285")).
+
+single_zero_with_space_is_invalid_test() ->
+  ?assertNot(?TESTED_MODULE:valid(" 0")).
+
+more_than_a_single_zero_is_valid_test() ->
+  ?assert(?TESTED_MODULE:valid("0000 0")).
+
+input_digit_9_is_correctly_converted_to_output_digit_9_test() ->
+  ?assert(?TESTED_MODULE:valid("091")).

data/tracks/erlang/exercises/two-fer/README.md

@@ -0,0 +1,19 @@
+`Two-fer` or `2-fer` is short for two for one. One for you and one for me.
+
+```text
+"One for X, one for me."
+```
+
+When X is a name or "you".
+
+If the given name is "Alice", the result should be "One for Alice, one for me."
+If no name is given, the result should be "One for you, one for me."
+
+## Instructions
+
+Submissions are encouraged to be general, within reason. Having said that, it's
+also important not to over-engineer a solution.
+
+It's important to remember that the goal is to make code as expressive and
+readable as we can.
+

data/tracks/erlang/exercises/two-fer/include/exercism.hrl

@@ -0,0 +1,11 @@
+-include_lib("eunit/include/eunit.hrl").
+
+sut(Module) ->
+  {ok, Files} = file:list_dir("./src"),
+  case lists:member("example.erl", Files) of
+    true  -> example;
+    false -> Module
+  end.
+
+version_test() ->
+  ?assertMatch(?TEST_VERSION, ?TESTED_MODULE:test_version()).

data/tracks/erlang/exercises/two-fer/rebar.config

@@ -0,0 +1,30 @@
+%% Erlang compiler options
+{erl_opts, [debug_info]}.
+
+{deps, []}.
+
+{dialyzer, [
+  {warnings, [underspecs, no_return]},
+  {get_warnings, true},
+  {plt_apps, top_level_deps}, % top_level_deps | all_deps
+  {plt_extra_apps, []},
+  {plt_location, local}, % local | "/my/file/name"
+  {plt_prefix, "rebar3"},
+  {base_plt_apps, [stdlib, kernel, crypto]},
+  {base_plt_location, global}, % global | "/my/file/name"
+  {base_plt_prefix, "rebar3"}
+]}.
+
+%% eunit:test(Tests)
+{eunit_tests, []}.
+%% Options for eunit:test(Tests, Opts)
+{eunit_opts, [verbose]}.
+
+%% == xref ==
+
+{xref_warnings, true}.
+
+%% xref checks to run
+{xref_checks, [undefined_function_calls, undefined_functions,
+  locals_not_used, exports_not_used,
+  deprecated_function_calls, deprecated_functions]}.

data/tracks/erlang/exercises/two-fer/src/example.erl

@@ -0,0 +1,11 @@
+-module(example).
+-export([two_fer/1, two_fer/0, test_version/0]).
+
+two_fer() ->
+  "One for you, one for me.".
+
+two_fer(Name) ->
+  lists:flatten(io_lib:format("One for ~s, one for me.", [Name])).
+
+test_version() ->
+  1.

data/tracks/erlang/exercises/two-fer/src/two_fer.app.src

@@ -0,0 +1,9 @@
+{application, two_fer,
+  [{description, "exercism.io - two-fer"},
+    {vsn, "0.0.1"},
+    {modules, []},
+    {registered, []},
+    {applications, [kernel,
+      stdlib]},
+    {env, []}
+  ]}.

data/tracks/erlang/exercises/two-fer/src/two_fer.erl

@@ -0,0 +1,11 @@
+-module(two_fer).
+
+-export([two_fer/1, two_fer/0, test_version/0]).
+
+two_fer() ->
+  undefined.
+
+two_fer(Name) ->
+  undefined.
+
+test_version() -> 1.

data/tracks/erlang/exercises/two-fer/test/two_fer_tests.erl

@@ -0,0 +1,15 @@
+-module(two_fer_tests).
+
+-define(TESTED_MODULE, (sut(two_fer))).
+-define(TEST_VERSION, 1).
+-include("exercism.hrl").
+
+
+say_you_test() ->
+  ?assertEqual("One for you, one for me.", ?TESTED_MODULE:two_fer()).
+
+say_alice_test() ->
+  ?assertEqual("One for Alice, one for me.", ?TESTED_MODULE:two_fer("Alice")).
+
+say_bob_test() ->
+  ?assertEqual("One for Bob, one for me.", ?TESTED_MODULE:two_fer("Bob")).

data/tracks/java/config.json

@@ -156,7 +156,13 @@
       "core": false,
       "difficulty": 3,
       "slug": "perfect-numbers",
-      "topics": null,
+      "topics": [
+        "integers",
+        "mathematics",
+        "exception_handling",
+        "enumerations",
+        "filtering"
+      ],
       "unlocked_by": "difference-of-squares",
       "uuid": "d0dcc898-ec38-4822-9e3c-1a1829c9b2d9"
     },
@@ -252,7 +258,15 @@
       "core": false,
       "difficulty": 4,
       "slug": "kindergarten-garden",
-      "topics": null,
+      "topics": [
+        "loops",
+        "arrays",
+        "strings",
+        "logic",
+        "pattern_recognition",
+        "enumerations",
+        "lists"
+      ],
       "unlocked_by": "matrix",
       "uuid": "0b92ffee-c092-4ab1-ad78-76c8cf80e1b5"
     },
@@ -607,7 +621,16 @@
       "core": false,
       "difficulty": 6,
       "slug": "wordy",
-      "topics": null,
+      "topics": [
+        "strings",
+        "integers",
+        "logic",
+        "parsing",
+        "pattern_matching",
+        "regular_expressions",
+        "transforming",
+        "exception_handling"
+      ],
       "unlocked_by": "secret-handshake",
       "uuid": "3310a3cd-c0cb-45fa-8c51-600178be904a"
     },

data/tracks/java/exercises/list-ops/.meta/hints.md

@@ -1,3 +1,7 @@
 ## Hints
 
+In Java it's considered best practice to use instance methods over class methods. However, there are conditions in which it is absolutely appropriate for a function to be `static`. Since classes in Java are closed for modification (i.e. you cannot add members to a class outside its definition like you can in other languages like Ruby or JavaScript), you cannot add new behavior to the class directly. What to do if you still want to define behavior for a given type? The idiomatic solution in this case is to write a utility method. 
+Collections of these kinds of methods are often referred to as "utility classes". Examples of such classes from within the JRE include [Arrays](https://docs.oracle.com/javase/9/docs/api/java/util/Arrays.html) and [Collections](https://docs.oracle.com/javase/9/docs/api/java/util/Collections.html).
+In this exercise we want a List to have `map()`, `reduce()`, `filter()`, etc. methods. It doesn't, so we're using static methods.
+
 The `foldLeft` and `foldRight` methods are "fold" functions, which is a concept well-known in the functional programming world, but less so in the object-oriented one. See the Wikipedia page on folding for [general background](https://en.wikipedia.org/wiki/Fold_(higher-order_function)) and [signature/implementation hints](https://en.wikipedia.org/wiki/Fold_(higher-order_function)#Linear_folds).

data/tracks/javascript/config.json

@@ -1029,6 +1029,20 @@
       "unlocked_by": "linked-list",
       "uuid": "c21ab6e8-b845-49d0-a2f6-1c89c7a07626"
     },
+    {
+      "uuid": "833bd7c7-d3d8-45fd-a218-12dea646065d",
+      "slug": "diffie-hellman",
+      "core": false,
+      "unlocked_by": "simple-cipher",
+      "difficulty": 3,
+      "topics": [
+        "Control-flow (conditionals)",
+        "Control-flow (loops)",
+        "Algorithms",
+        "Arrays",
+        "Exception handling"
+      ]
+    },
     {
       "core" :  false,
       "difficulty" : 8,

data/tracks/javascript/docs/ABOUT.md

@@ -1,22 +1,29 @@
-Javascript is a scripting language used to provide dynamic and interactive content on webpages. Also, server side JS allows the use of the same language on the server and client. Besides being fast, JavaScript provides benefits like:
+JavaScript is a scripting language used to provide dynamic and interactive content on webpages. 
+Also, server side JS allows the use of the same language on the server and client. 
+
+Besides being fast, JavaScript provides benefits like:
 
 * Reducing server traffic by validating user input in the browser before it is sent to the server.
-* Providing immediate feedback to the site visitors so that they don't have to reload pages just to get error messages on form validations.
+* Providing immediate feedback to the site's visitors so that they don't have to reload pages just to get error messages on form validations.
 * Allowing richer user interfaces with content changes on mouse hover, drag and drop gestures, and animations.
 
-Client-side JavaScript is interpreted in the browser without requiring compilation. This allows interactive content to be included in HTML pages which would otherwise be static.
+Client-side JavaScript is interpreted in the browser without requiring compilation. 
+This allows interactive content to be included in HTML pages which would otherwise be static.
 
-Server-Side JavaScript as run in NodeJS enables back-end access to databases, file systems, and servers. NodeJS is built on Google Chrome's JavaScript V8 Engine. NodeJS uses an event-driven, non-blocking I/O model that makes it lightweight and efficient. Node can be a great solution for applications requiring I/O bound operations, data streaming etc. More details can be found  [here](https://nodejs.org/en/about/).
+Server-Side JavaScript as run in NodeJS enables back-end access to databases, file systems, and servers. 
+NodeJS is built on Google Chrome's JavaScript V8 Engine. 
+NodeJS uses an event-driven, non-blocking I/O model that makes it lightweight and efficient. 
+Node can be a great solution for applications requiring I/O bound operations, data streaming etc. 
+More details can be found [here](https://nodejs.org/en/about/).
 
 You should learn JavaScript because:
 
 * It's easy to learn.
-* It's versatile in the sense that it's multi-paradigm supporting procedural, event based, object oriented and functional programming.
-* It can be used for the frontend and backend.
+* It's versatile in the sense that it's multi-paradigm - supporting procedural, event based, object oriented and functional programming.
+* It can be used for the front-end and back-end.
 * It's Open Source.
 * JavaScript programming skills are in high demand.
 
----
-
-_This track is intended for widely supported JavaScript, for code that could be executed in almost all existing browsers. If you're looking for experimenting with newer features of the language try the [ECMAScript](http://exercism.io/languages/ecmascript) track._
+_This track is intended for widely supported JavaScript, for code that could be executed in almost all existing browsers. 
+If you're looking to experiment with newer features of the language, try the [ECMAScript](http://exercism.io/languages/ecmascript) track._
 

data/tracks/javascript/exercises/diffie-hellman/README.md

@@ -0,0 +1,73 @@
+# Diffie Hellman
+
+Diffie-Hellman key exchange.
+
+Alice and Bob use Diffie-Hellman key exchange to share secrets.  They
+start with prime numbers, pick private keys, generate and share public
+keys, and then generate a shared secret key.
+
+## Step 0
+
+The test program supplies prime numbers p and g.
+
+## Step 1
+
+Alice picks a private key, a, greater than 1 and less than p.  Bob does
+the same to pick a private key b.
+
+## Step 2
+
+Alice calculates a public key A.
+
+    A = g**a mod p
+
+Using the same p and g, Bob similarly calculates a public key B from his
+private key b.
+
+## Step 3
+
+Alice and Bob exchange public keys.  Alice calculates secret key s.
+
+    s = B**a mod p
+
+Bob calculates
+
+    s = A**b mod p
+
+The calculations produce the same result!  Alice and Bob now share
+secret s.
+
+## Setup
+
+Go through the setup instructions for JavaScript to
+install the necessary dependencies:
+
+http://exercism.io/languages/javascript
+
+## Requirements
+
+
+
+## Making the test suite pass
+
+Execute the tests with:
+
+    jasmine <exercise-name>.spec.js
+
+Replace `<exercise-name>` with the name of the current exercise. E.g., to
+test the Hello World exercise:
+
+    jasmine hello-world.spec.js
+
+In many test suites all but the first test have been skipped.
+
+Once you get a test passing, you can unskip the next one by
+changing `xit` to `it`.
+
+
+## Source
+
+Wikipedia, 1024 bit key from www.cryptopp.com/wiki. [http://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange](http://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange)
+
+## Submitting Incomplete Solutions
+It's possible to submit an incomplete solution so you can see how others have completed the exercise.