trackler 2.2.1.13 → 2.2.1.14

data/tracks/csharp/exercises/phone-number/Example.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using System.Text.RegularExpressions;
 
@@ -17,7 +18,7 @@ public static string Clean(string phoneNumber)
         }
         else
         {
-            return null;
+            throw new ArgumentException("invalid phone number");
         }
     }
 }

data/tracks/csharp/exercises/phone-number/PhoneNumberTest.cs

@@ -1,6 +1,7 @@
 // This file was auto-generated based on version 1.2.0 of the canonical data.
 
 using Xunit;
+using System;
 
 public class PhoneNumberTest
 {
@@ -29,14 +30,14 @@ public void Cleans_numbers_with_multiple_spaces()
     public void Invalid_when_9_digits()
     {
         var phrase = "123456789";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Invalid_when_11_digits_does_not_start_with_a_1()
     {
         var phrase = "22234567890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
@@ -57,34 +58,34 @@ public void Valid_when_11_digits_and_starting_with_1_even_with_punctuation()
     public void Invalid_when_more_than_11_digits()
     {
         var phrase = "321234567890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Invalid_with_letters()
     {
         var phrase = "123-abc-7890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Invalid_with_punctuations()
     {
         var phrase = "123-@:!-7890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Invalid_if_area_code_does_not_start_with_2_9()
     {
         var phrase = "(123) 456-7890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Invalid_if_exchange_code_does_not_start_with_2_9()
     {
         var phrase = "(223) 056-7890";
-        Assert.Null(PhoneNumber.Clean(phrase));
+        Assert.Throws<ArgumentException>(() => PhoneNumber.Clean(phrase));
     }
 }

data/tracks/csharp/exercises/rna-transcription/Example.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 
@@ -12,7 +13,7 @@ public static string ToRna(string nucleotide)
     {
         if (nucleotide.Any(x => !DnaToRna.ContainsKey(x)))
         {
-            return null;
+            throw new ArgumentException("invalid nucleotide");
         }
 
         return string.Concat(nucleotide.Select(x => DnaToRna[x]));

data/tracks/csharp/exercises/rna-transcription/RnaTranscriptionTest.cs

@@ -1,6 +1,7 @@
 // This file was auto-generated based on version 1.0.1 of the canonical data.
 
 using Xunit;
+using System;
 
 public class RnaTranscriptionTest
 {
@@ -37,18 +38,18 @@ public void Rna_complement()
     [Fact(Skip = "Remove to run test")]
     public void Correctly_handles_invalid_input_rna_instead_of_dna_()
     {
-        Assert.Null(RnaTranscription.ToRna("U"));
+        Assert.Throws<ArgumentException>(() => RnaTranscription.ToRna("U"));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Correctly_handles_completely_invalid_dna_input()
     {
-        Assert.Null(RnaTranscription.ToRna("XXX"));
+        Assert.Throws<ArgumentException>(() => RnaTranscription.ToRna("XXX"));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Correctly_handles_partially_invalid_dna_input()
     {
-        Assert.Null(RnaTranscription.ToRna("ACGTXXXCTTAA"));
+        Assert.Throws<ArgumentException>(() => RnaTranscription.ToRna("ACGTXXXCTTAA"));
     }
 }

data/tracks/csharp/exercises/say/SayTest.cs

@@ -1,101 +1,97 @@
-using System;
+// This file was auto-generated based on version 1.0.0 of the canonical data.
+
 using Xunit;
+using System;
 
 public class SayTest
 {
     [Fact]
     public void Zero()
     {
-        Assert.Equal("zero", Say.InEnglish(0L));
+        Assert.Equal("zero", Say.InEnglish(0));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One()
     {
-        Assert.Equal("one", Say.InEnglish(1L));
+        Assert.Equal("one", Say.InEnglish(1));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Fourteen()
     {
-        Assert.Equal("fourteen", Say.InEnglish(14L));
+        Assert.Equal("fourteen", Say.InEnglish(14));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Twenty()
     {
-        Assert.Equal("twenty", Say.InEnglish(20L));
+        Assert.Equal("twenty", Say.InEnglish(20));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Twenty_two()
     {
-        Assert.Equal("twenty-two", Say.InEnglish(22L));
+        Assert.Equal("twenty-two", Say.InEnglish(22));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_hundred()
     {
-        Assert.Equal("one hundred", Say.InEnglish(100L));
+        Assert.Equal("one hundred", Say.InEnglish(100));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_hundred_twenty_three()
     {
-        Assert.Equal("one hundred twenty-three", Say.InEnglish(123L));
+        Assert.Equal("one hundred twenty-three", Say.InEnglish(123));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_thousand()
     {
-        Assert.Equal("one thousand", Say.InEnglish(1000L));
+        Assert.Equal("one thousand", Say.InEnglish(1000));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_thousand_two_hundred_thirty_four()
     {
-        Assert.Equal("one thousand two hundred thirty-four", Say.InEnglish(1234L));
+        Assert.Equal("one thousand two hundred thirty-four", Say.InEnglish(1234));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_million()
     {
-        Assert.Equal("one million", Say.InEnglish(1000000L));
-    }
-
-    [Fact(Skip = "Remove to run test")]
-    public void One_million_two()
-    {
-        Assert.Equal("one million two", Say.InEnglish(1000002L));
+        Assert.Equal("one million", Say.InEnglish(1000000));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_million_two_thousand_three_hundred_forty_five()
     {
-        Assert.Equal("one million two thousand three hundred forty-five", Say.InEnglish(1002345L));
+        Assert.Equal("one million two thousand three hundred forty-five", Say.InEnglish(1002345));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void One_billion()
     {
-        Assert.Equal("one billion", Say.InEnglish(1000000000L));
+        Assert.Equal("one billion", Say.InEnglish(1000000000));
     }
 
     [Fact(Skip = "Remove to run test")]
     public void A_big_number()
     {
-        Assert.Equal("nine hundred eighty-seven billion six hundred fifty-four million three hundred twenty-one thousand one hundred twenty-three", Say.InEnglish(987654321123L));
+        Assert.Equal("nine hundred eighty-seven billion six hundred fifty-four million three hundred twenty-one thousand one hundred twenty-three", Say.InEnglish(987654321123));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Lower_bound()
+    public void Numbers_below_zero_are_out_of_range()
     {
-        Assert.Throws<ArgumentOutOfRangeException>(() => Say.InEnglish(-1L));
+        Assert.Throws<ArgumentOutOfRangeException>(() => Say.InEnglish(-1));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Upper_bound()
+    public void Numbers_above_999_999_999_999_are_out_of_range()
     {
-        Assert.Throws<ArgumentOutOfRangeException>(() => Say.InEnglish(1000000000000L));
+        Assert.Throws<ArgumentOutOfRangeException>(() => Say.InEnglish(1000000000000));
     }
 }

data/tracks/csharp/exercises/sieve/Example.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 
@@ -10,6 +11,11 @@ public static int[] Primes(int limit)
 
     private static int[] InitializePrimes(int limit)
     {
+        if (limit < 2)
+        {
+            throw new ArgumentOutOfRangeException(nameof(limit));
+        }
+
         var candidates = new Queue<int>(Enumerable.Range(2, limit - 1));
         var primes = new List<int>();
         do

data/tracks/csharp/exercises/sieve/SieveTest.cs

@@ -1,33 +1,41 @@
+// This file was auto-generated based on version 1.0.0 of the canonical data.
+
 using Xunit;
+using System;
 
 public class SieveTest
 {
     [Fact]
-    public void Finds_first_prime()
+    public void No_primes_under_two()
+    {
+        Assert.Throws<ArgumentOutOfRangeException>(() => Sieve.Primes(1));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Find_first_prime()
+    {
+        var expected = new[] { 2 };
+        Assert.Equal(expected, Sieve.Primes(2));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Find_primes_up_to_10()
     {
-        Assert.Equal(new[] { 2 }, Sieve.Primes(2));
+        var expected = new[] { 2, 3, 5, 7 };
+        Assert.Equal(expected, Sieve.Primes(10));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Finds_primes_up_to_10()
+    public void Limit_is_prime()
     {
-        Assert.Equal(new[] { 2, 3, 5, 7 }, Sieve.Primes(10));
+        var expected = new[] { 2, 3, 5, 7, 11, 13 };
+        Assert.Equal(expected, Sieve.Primes(13));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Finds_primes_up_to_1000()
+    public void Find_primes_up_to_1000()
     {
-        Assert.Equal(new[]
-                {
-                    2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, 59, 61, 67, 71, 73, 79, 83, 89, 97, 101,
-                    103, 107, 109, 113, 127, 131, 137, 139, 149, 151, 157, 163, 167, 173, 179, 181, 191, 193, 197, 199,
-                    211, 223, 227, 229, 233, 239, 241, 251, 257, 263, 269, 271, 277, 281, 283, 293, 307, 311, 313, 317,
-                    331, 337, 347, 349, 353, 359, 367, 373, 379, 383, 389, 397, 401, 409, 419, 421, 431, 433, 439, 443,
-                    449, 457, 461, 463, 467, 479, 487, 491, 499, 503, 509, 521, 523, 541, 547, 557, 563, 569, 571, 577,
-                    587, 593, 599, 601, 607, 613, 617, 619, 631, 641, 643, 647, 653, 659, 661, 673, 677, 683, 691, 701,
-                    709, 719, 727, 733, 739, 743, 751, 757, 761, 769, 773, 787, 797, 809, 811, 821, 823, 827, 829, 839,
-                    853, 857, 859, 863, 877, 881, 883, 887, 907, 911, 919, 929, 937, 941, 947, 953, 967, 971, 977, 983,
-                    991, 997
-                }, Sieve.Primes(1000));
+        var expected = new[] { 2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, 59, 61, 67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131, 137, 139, 149, 151, 157, 163, 167, 173, 179, 181, 191, 193, 197, 199, 211, 223, 227, 229, 233, 239, 241, 251, 257, 263, 269, 271, 277, 281, 283, 293, 307, 311, 313, 317, 331, 337, 347, 349, 353, 359, 367, 373, 379, 383, 389, 397, 401, 409, 419, 421, 431, 433, 439, 443, 449, 457, 461, 463, 467, 479, 487, 491, 499, 503, 509, 521, 523, 541, 547, 557, 563, 569, 571, 577, 587, 593, 599, 601, 607, 613, 617, 619, 631, 641, 643, 647, 653, 659, 661, 673, 677, 683, 691, 701, 709, 719, 727, 733, 739, 743, 751, 757, 761, 769, 773, 787, 797, 809, 811, 821, 823, 827, 829, 839, 853, 857, 859, 863, 877, 881, 883, 887, 907, 911, 919, 929, 937, 941, 947, 953, 967, 971, 977, 983, 991, 997 };
+        Assert.Equal(expected, Sieve.Primes(1000));
     }
 }

data/tracks/csharp/exercises/space-age/SpaceAgeTest.cs

@@ -1,67 +1,62 @@
+// This file was auto-generated based on version 1.0.0 of the canonical data.
+
 using Xunit;
 
 public class SpaceAgeTest
 {
-    [Fact(Skip = "Remove to run test")]
+    [Fact]
     public void Age_on_earth()
     {
-        var age = new SpaceAge(1000000000);
-        Assert.Equal(31.69, age.OnEarth());
+        var sut = new SpaceAge(1000000000);
+        Assert.Equal(31.69, sut.OnEarth());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_mercury()
     {
-        var age = new SpaceAge(2134835688);
-        Assert.Equal(67.65, age.OnEarth());
-        Assert.Equal(280.88, age.OnMercury());
+        var sut = new SpaceAge(2134835688);
+        Assert.Equal(280.88, sut.OnMercury());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_venus()
     {
-        var age = new SpaceAge(189839836);
-        Assert.Equal(6.02, age.OnEarth());
-        Assert.Equal(9.78, age.OnVenus());
+        var sut = new SpaceAge(189839836);
+        Assert.Equal(9.78, sut.OnVenus());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_mars()
     {
-        var age = new SpaceAge(2329871239);
-        Assert.Equal(73.83, age.OnEarth());
-        Assert.Equal(39.25, age.OnMars());
+        var sut = new SpaceAge(2329871239);
+        Assert.Equal(39.25, sut.OnMars());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_jupiter()
     {
-        var age = new SpaceAge(901876382);
-        Assert.Equal(28.58, age.OnEarth());
-        Assert.Equal(2.41, age.OnJupiter());
+        var sut = new SpaceAge(901876382);
+        Assert.Equal(2.41, sut.OnJupiter());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_saturn()
     {
-        var age = new SpaceAge(3000000000);
-        Assert.Equal(95.06, age.OnEarth());
-        Assert.Equal(3.23, age.OnSaturn());
+        var sut = new SpaceAge(3000000000);
+        Assert.Equal(3.23, sut.OnSaturn());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_uranus()
     {
-        var age = new SpaceAge(3210123456);
-        Assert.Equal(101.72, age.OnEarth());
-        Assert.Equal(1.21, age.OnUranus());
+        var sut = new SpaceAge(3210123456);
+        Assert.Equal(1.21, sut.OnUranus());
     }
 
     [Fact(Skip = "Remove to run test")]
     public void Age_on_neptune()
     {
-        var age = new SpaceAge(8210123456);
-        Assert.Equal(260.16, age.OnEarth());
-        Assert.Equal(1.58, age.OnNeptune());
+        var sut = new SpaceAge(8210123456);
+        Assert.Equal(1.58, sut.OnNeptune());
     }
 }

data/tracks/csharp/exercises/sum-of-multiples/Example.cs

@@ -3,7 +3,7 @@
 
 public static class SumOfMultiples
 {
-    public static int To(IEnumerable<int> multiples, int max)
+    public static int Sum(IEnumerable<int> multiples, int max)
     {
         return Enumerable.Range(1, max - 1)
             .Where(i => multiples.Any(m => i % m == 0))

data/tracks/csharp/exercises/sum-of-multiples/SumOfMultiples.cs

@@ -3,7 +3,7 @@
 
 public static class SumOfMultiples
 {
-    public static int To(IEnumerable<int> multiples, int max)
+    public static int Sum(IEnumerable<int> multiples, int max)
     {
         throw new NotImplementedException("You need to implement this function.");
     }

data/tracks/csharp/exercises/sum-of-multiples/SumOfMultiplesTest.cs

@@ -1,46 +1,78 @@
-using Xunit;
+// This file was auto-generated based on version 1.0.0 of the canonical data.
+
+using Xunit;
 
 public class SumOfMultiplesTest
 {
     [Fact]
-    public void Sum_to_1()
+    public void Multiples_of_3_or_5_up_to_1()
+    {
+        Assert.Equal(0, SumOfMultiples.Sum(new[] { 3, 5 }, 1));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Multiples_of_3_or_5_up_to_4()
+    {
+        Assert.Equal(3, SumOfMultiples.Sum(new[] { 3, 5 }, 4));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Multiples_of_3_or_5_up_to_10()
+    {
+        Assert.Equal(23, SumOfMultiples.Sum(new[] { 3, 5 }, 10));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Multiples_of_3_or_5_up_to_100()
+    {
+        Assert.Equal(2318, SumOfMultiples.Sum(new[] { 3, 5 }, 100));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Multiples_of_3_or_5_up_to_1000()
+    {
+        Assert.Equal(233168, SumOfMultiples.Sum(new[] { 3, 5 }, 1000));
+    }
+
+    [Fact(Skip = "Remove to run test")]
+    public void Multiples_of_7_13_or_17_up_to_20()
     {
-        Assert.Equal(0, SumOfMultiples.To(new[] { 3, 5 }, 1));
+        Assert.Equal(51, SumOfMultiples.Sum(new[] { 7, 13, 17 }, 20));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_3()
+    public void Multiples_of_4_or_6_up_to_15()
     {
-        Assert.Equal(3, SumOfMultiples.To(new[] { 3, 5 }, 4));
+        Assert.Equal(30, SumOfMultiples.Sum(new[] { 4, 6 }, 15));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_10()
+    public void Multiples_of_5_6_or_8_up_to_150()
     {
-        Assert.Equal(23, SumOfMultiples.To(new[] { 3, 5 }, 10));
+        Assert.Equal(4419, SumOfMultiples.Sum(new[] { 5, 6, 8 }, 150));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_100()
+    public void Multiples_of_5_or_25_up_to_51()
     {
-       Assert.Equal(2318, SumOfMultiples.To(new[] { 3, 5 }, 100));
+        Assert.Equal(275, SumOfMultiples.Sum(new[] { 5, 25 }, 51));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_1000()
+    public void Multiples_of_43_or_47_up_to_10000()
     {
-        Assert.Equal(233168, SumOfMultiples.To(new[] { 3, 5 }, 1000));
+        Assert.Equal(2203160, SumOfMultiples.Sum(new[] { 43, 47 }, 10000));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_20()
+    public void Multiples_of_1_up_to_100()
     {
-        Assert.Equal(51, SumOfMultiples.To(new [] { 7, 13, 17 }, 20));
+        Assert.Equal(4950, SumOfMultiples.Sum(new[] { 1 }, 100));
     }
 
     [Fact(Skip = "Remove to run test")]
-    public void Sum_to_10000()
+    public void Multiples_of_an_empty_list_up_to_10000()
     {
-        Assert.Equal(2203160, SumOfMultiples.To(new [] { 43, 47 }, 10000));
+        Assert.Equal(0, SumOfMultiples.Sum(new int[0], 10000));
     }
-}
+}