trackler 2.2.1.105 → 2.2.1.106

data/tracks/javascript/exercises/leap/leap.js

@@ -3,10 +3,10 @@
 // convenience to get you started writing code faster.
 //
 
-var Year = function (input) {
+var Year = function () {
 //
 // YOUR CODE GOES HERE
-//  
+//
 };
 
 Year.prototype.isLeap = function () {

data/tracks/javascript/exercises/list-ops/example.js

@@ -56,7 +56,7 @@ List.prototype = {
     return new List(this.foldl(this.cons, []));
   },
 
-  map: function (func, arr) {
+  map: function (func) {
     var applyFuncThenCons = function (x, acc) {
       return this.cons(func(x), acc);
     };

data/tracks/javascript/exercises/luhn/example.js

@@ -1,8 +1,8 @@
 'use strict';
 
 function isValid(number) {
-  number = number.replace(/\s/g, '');
-  const digits = [...number];
+  var numbers = number.replace(/\s/g, '');
+  const digits = [...numbers];
 
   const sum = digits
     // convert to integers

data/tracks/javascript/exercises/pythagorean-triplet/example.js

@@ -35,7 +35,8 @@ Triplets.prototype.isDesired = function (triplet) {
 };
 
 Triplets.prototype.toArray = function () {
-  var triplet, triplets = [];
+  var triplet = [];
+  var triplets = [];
   for (var a = this.min; a < this.max - 1; a++) {
     for (var b = a + 1; b < this.max; b++) {
       for (var c = b + 1; c <= this.max; c++) {

data/tracks/javascript/exercises/roman-numerals/example.js

@@ -2,6 +2,7 @@
 
 module.exports = function (number) {
   var result = '';
+  var numbers = number;
   var mappings = [
     {arabic: 1000, roman: 'M'},
     {arabic: 900, roman: 'CM'},
@@ -20,9 +21,9 @@ module.exports = function (number) {
 
   for (var i = 0; i < mappings.length; i++) {
     var mapping = mappings[i];
-    while (number >= mapping.arabic) {
+    while (numbers >= mapping.arabic) {
       result = result + mapping.roman;
-      number = number - mapping.arabic;
+      numbers = numbers - mapping.arabic;
     }
   }
 

data/tracks/julia/config.json

@@ -404,6 +404,19 @@
       "topics": [
         "exceptions"
       ]
+    },
+    {
+      "uuid": "22b64a2b-7f08-444d-be6e-8b42e5c9207c",
+      "slug": "isbn-verifier",
+      "core": false,
+      "unlocked_by": "luhn",
+      "difficulty": 2,
+      "topics": [
+        "strings",
+        "arithmetics",
+        "control-flow (conditionals)",
+        "metaprogramming"
+      ]
     }
   ],
   "foregone": [

data/tracks/julia/exercises/isbn-verifier/README.md

@@ -0,0 +1,51 @@
+# ISBN Verifier
+
+The [ISBN-10 verification process](https://en.wikipedia.org/wiki/International_Standard_Book_Number) is used to validate book identification
+numbers. These normally contain dashes and look like: `3-598-21508-8`
+
+## ISBN
+
+The ISBN-10 format is 9 digits (0 to 9) plus one check character (either a digit or an X only). In the case the check character is an X, this represents the value '10'. These may be communicated with or without hyphens, and can be checked for their validity by the following formula:
+
+```
+(x1 * 10 + x2 * 9 + x3 * 8 + x4 * 7 + x5 * 6 + x6 * 5 + x7 * 4 + x8 * 3 + x9 * 2 + x10 * 1) mod 11 == 0
+```
+
+If the result is 0, then it is a valid ISBN-10, otherwise it is invalid.
+
+## Example
+
+Let's take the ISBN-10 `3-598-21508-8`. We plug it in to the formula, and get:
+```
+(3 * 10 + 5 * 9 + 9 * 8 + 8 * 7 + 2 * 6 + 1 * 5 + 5 * 4 + 0 * 3 + 8 * 2 + 8 * 1) mod 11 == 0
+```
+
+Since the result is 0, this proves that our ISBN is valid.
+
+## Task
+
+The program should construct a string of type `ISBN <: AbstractString`.
+Given a string the program should check if the provided string is a valid ISBN-10. If the string is invalid, the constructor should throw an appropriate error.
+Putting this into place requires some thinking about preprocessing/parsing of the string prior to calculating the check digit for the ISBN.
+
+The program should be able to verify ISBN-10 both with and without separating dashes.
+
+
+## Caveats
+
+Converting from strings to numbers can be tricky in certain languages.
+Now, it's even trickier since the check digit of an ISBN-10 may be 'X' (representing '10'). For instance `3-598-21507-X` is a valid ISBN-10.
+
+## Bonus tasks
+
+* Implement `show(io::IO, isbn::ISBN)` to print the ISBN in the standard format with dashes.
+
+* Generate a valid ISBN-13 from the input ISBN-10 (and maybe verify it again with a derived verifier).
+
+* Generate valid ISBN, maybe even from a given starting ISBN.## Source
+
+Converting a string into a number and some basic processing utilizing a relatable real world example. [https://en.wikipedia.org/wiki/International_Standard_Book_Number#ISBN-10_check_digit_calculation](https://en.wikipedia.org/wiki/International_Standard_Book_Number#ISBN-10_check_digit_calculation)
+
+
+## Submitting Incomplete Solutions
+It's possible to submit an incomplete solution so you can see how others have completed the exercise.

data/tracks/julia/exercises/isbn-verifier/example.jl

@@ -0,0 +1,26 @@
+macro isbn_str(s)
+    ISBN(s)
+end
+
+struct ISBN <: AbstractString
+    s::AbstractString
+
+    ISBN(s) = verify(s) ? new(replace(s, "-", "")) : throw(ArgumentError("invalid ISBN string: $s"))
+end
+
+function verify(s::AbstractString)
+    s = replace(s, "-", "")
+    chars = split(s, "")
+
+    length(chars) == 10 || return false
+
+    if last(chars) == "X"
+        chars[end] = "10"
+    end
+
+    all(c -> all(isdigit, c), chars) || return false
+
+    sum(parse(Int, c) * i for (c, i) in zip(chars, 10:-1:1)) % 11 == 0
+end
+
+Base.isvalid(::Type{ISBN}, s::AbstractString) = verify(s)

data/tracks/julia/exercises/isbn-verifier/runtests.jl

@@ -0,0 +1,73 @@
+using Base.Test
+
+include("isbn-verifier.jl")
+
+@test ISBN <: AbstractString
+
+@testset "valid ISBN numbers" begin
+    # ISBN number
+    @test isvalid(ISBN, "3-598-21508-8")
+    # ISBN number with a check digit of 10
+    @test isvalid(ISBN, "3-598-21507-X")
+    # ISBN without separating dashes
+    @test isvalid(ISBN, "3598215088")
+    # ISBN without separating dashes and X as check digit
+    @test isvalid(ISBN, "359821507X")
+end
+
+@testset "invalid ISBN numbers" begin
+    # invalid ISBN check digit
+    @test !isvalid(ISBN, "3-598-21508-9")
+    # check digit is a character other than X
+    @test !isvalid(ISBN, "3-598-21507-A")
+    # invalid character in ISBN
+    @test !isvalid(ISBN, "3-598-2K507-0")
+    # X is only valid as a check isdigit
+    @test !isvalid(ISBN, "3-598-2X507-9")
+    # ISBN without check digit and dashes
+    @test !isvalid(ISBN, "359821507")
+    # too long ISBN and no dashes
+    @test !isvalid(ISBN, "3598215078X")
+    # ISBN without check digit
+    @test !isvalid(ISBN, "3-598-21507")
+    # too long ISBN
+    @test !isvalid(ISBN, "3-598-21507-XX")
+    # check digit of X should not be used for 0
+    @test !isvalid(ISBN, "3-598-21515-X")
+    # empty ISBN
+    @test !isvalid(ISBN, "")
+end
+
+@testset "constructing valid ISBN numbers" begin
+    # ISBN number
+    @test isbn"3-598-21508-8".s == "3598215088"
+    # ISBN number with a check digit of 10
+    @test isbn"3-598-21507-X".s == "359821507X"
+    # ISBN without separating dashes
+    @test isbn"3598215088".s == "3598215088"
+    # ISBN without separating dashes and X as check digit
+    @test isbn"359821507X".s == "359821507X"
+end
+
+@testset "constructing invalid ISBN numbers" begin
+    # invalid ISBN check digit
+    @test_throws ArgumentError ISBN("3-598-21508-9")
+    # check digit is a character other than X
+    @test_throws ArgumentError ISBN("3-598-21507-A")
+    # invalid character in ISBN
+    @test_throws ArgumentError ISBN("3-598-2K507-0")
+    # X is only valid as a check isdigit
+    @test_throws ArgumentError ISBN("3-598-2X507-9")
+    # ISBN without check digit and dashes
+    @test_throws ArgumentError ISBN("359821507")
+    # too long ISBN and no dashes
+    @test_throws ArgumentError ISBN("3598215078X")
+    # ISBN without check digit
+    @test_throws ArgumentError ISBN("3-598-21507")
+    # too long ISBN
+    @test_throws ArgumentError ISBN("3-598-21507-XX")
+    # check digit of X should not be used for 0
+    @test_throws ArgumentError ISBN("3-598-21515-X")
+    # empty ISBN
+    @test_throws ArgumentError ISBN("")
+end

data/tracks/perl5/.travis.yml

@@ -8,11 +8,18 @@ perl:
   - '5.18'
   - '5.16'
   - '5.14'
+before_install:
+  - curl -sL --compressed https://git.io/cpm > cpm
+  - chmod +x cpm
+install:
+  - ./cpm install -g
 before_script:
   - git clone https://github.com/exercism/problem-specifications.git
   - bin/fetch-configlet
 script:
   - bin/configlet lint .
-  - prove exercises/
+  - prove exercises/*/.meta/solutions/
     --recurse
     --jobs 2
+  - prove t/
+    --directives

data/tracks/perl5/README.md

@@ -8,35 +8,33 @@ Exercism exercises in Perl 5
 
 The tests depend on the following modules:
 
-    JSON
     DateTime
     Test::Exception
     List::MoreUtils
-    Path::Tiny (for canonical-data tests)
+    Path::Tiny (for generator tests)
+    Template::Mustache (for generator tests)
+    YAML (for generator tests)
 
 ## Testing the Tests
 
-When the tests are run they expect a module with some real name (e.g. Anagram.pm)
-but the Exercism system allows us to have example implementations in the directory
+The Exercism system allows us to have example implementations in the directory
 of each exercise.
 
-If they are called /*example.*/i they won't be copied to the users. (which is a good thing).
-
-So the sample solutions are all called Example.pm.
+If they are in the `.meta` directory they won't be copied to the users. (which is a good thing).
 
 ### Testing All the Exercises
 
 Run the full tests with
 
-    EXERCISM=1 prove -r
+    prove -r exercises/*/.meta/solutions
 
 ### Testing a Single Exercise
 
-Each test file will look for the appropriate module name, but if the test are run as
+If a test is run as
 
-    EXERCISM=1 perl file.t
+    prove exercises/example-exercise/.meta/solutions/example-exercise.t
 
-then they will expect a file called Example.pm
+the test will run using the example in the `.meta/solutions` directory.
 
 ## Contributing Guide
 

data/tracks/perl5/bin/exercise-gen.pl

@@ -2,9 +2,12 @@
 use feature qw(lexical_subs say);
 use YAML 'LoadFile';
 use Path::Tiny qw(:DEFAULT cwd);
-use Template::Mustache 'render';
+use FindBin;
+use lib "$FindBin::Bin/../lib";
+use Exercism::Generator;
+
+my $base_dir = path(__FILE__)->realpath->parent->parent;
 
-my $base_dir = path($0)->realpath->parent->parent;
 my @exercises;
 
 if (@ARGV) {
@@ -15,10 +18,10 @@ if (@ARGV) {
   }
 } else {
   say 'No args given; working in current directory.';
-  if ( path('example.yaml')->is_file ) {
+  if ( path('.meta/exercise-data.yaml')->is_file ) {
     push @exercises, cwd->basename;
   } else {
-    say 'example.yaml not found in current directory; exiting.';
+    say '.meta/exercise-data.yaml not found in current directory; exiting.';
     exit;
   }
 }
@@ -27,7 +30,7 @@ my @dir_not_found;
 my @yaml_not_found;
 for my $exercise (@exercises) {
   my $exercise_dir = $base_dir->child("exercises/$exercise");
-  my $yaml = $exercise_dir->child('example.yaml');
+  my $yaml = $exercise_dir->child('.meta/exercise-data.yaml');
 
   unless ($exercise_dir->is_dir) {
     push @dir_not_found, $exercise;
@@ -40,32 +43,14 @@ for my $exercise (@exercises) {
   print "Generating $exercise... ";
 
   my $data = LoadFile $yaml;
-
-  my $cdata = $base_dir->child("problem-specifications/exercises/$exercise/canonical-data.json");
-  if ($cdata->is_file) {
-    $data->{cdata}{json} = $cdata->slurp;
-    $data->{cdata}{json} =~ s/^\s+|\s+$//g;
-  }
-
-  my sub create_file {
-    my ($filename, $template) = @_;
-    my $file = $exercise_dir->child($filename);
-    $file->spew(Template::Mustache->render(
-      $base_dir->child("templates/$template.mustache")->slurp, $data
-    ));
-    $file->chmod(0755) if $template eq 'test';
-  }
-
-  create_file("$exercise.t", 'test');
-
-  $data->{module_file} = $data->{example};
-  create_file(qw{Example.pm module});
-
-  $data->{module_file} = $data->{stub};
-  create_file($data->{exercise}.'.pm', 'module');
+  my $generator = Exercism::Generator->new({exercise => $exercise, data => $data});
+  $exercise_dir->child("$exercise.t")->spew($generator->test);
+  $exercise_dir->child("$exercise.t")->chmod(0755);
+  $exercise_dir->child('.meta/solutions/'.$data->{exercise}.'.pm')->spew($generator->example);
+  $exercise_dir->child($data->{exercise}.'.pm')->spew($generator->stub);
 
   say 'Generated.';
 }
 
 if (@dir_not_found)  {warn 'exercise directory does not exist for: ' . join ' ', @dir_not_found}
-if (@yaml_not_found) {warn 'example.yaml not found for: ' . join ' ', @yaml_not_found}
+if (@yaml_not_found) {warn '.meta/exercise-data.yaml not found for: ' . join ' ', @yaml_not_found}

data/tracks/perl5/config.json

@@ -2,6 +2,7 @@
   "language": "Perl 5",
   "active": true,
   "test_pattern": ".*\\.t$",
+  "solution_pattern": "\\.meta/solutions/.+\\.pm$",
   "foregone": [
 
   ],

data/tracks/perl5/cpanfile

@@ -1,5 +1,6 @@
-requires 'JSON';
 requires 'DateTime';
 requires 'Test::Exception';
 requires 'List::MoreUtils';
 requires 'Path::Tiny';
+requires 'Template::Mustache';
+requires 'YAML';

data/tracks/perl5/exercises/accumulate/{Example.pm → .meta/solutions/Accumulate.pm}

@@ -1,4 +1,4 @@
-package Example;
+package Accumulate;
 
 use strict;
 use warnings;

data/tracks/perl5/exercises/accumulate/.meta/solutions/accumulate.t

@@ -0,0 +1 @@
+../../accumulate.t

data/tracks/perl5/exercises/accumulate/accumulate.t

@@ -8,7 +8,7 @@ my $dir;
 BEGIN { $dir = $FindBin::Bin . '/' };
 use lib $dir;
 
-my $module = $ENV{EXERCISM} ? 'Example' : 'Accumulate';
+my $module = 'Accumulate';
 
 my @cases = (
     {

data/tracks/perl5/exercises/all-your-base/{Example.pm → .meta/solutions/AllYourBase.pm}

@@ -1,4 +1,4 @@
-package Example;
+package AllYourBase;
 
 use strict;
 use warnings;

data/tracks/perl5/exercises/all-your-base/.meta/solutions/all-your-base.t

@@ -0,0 +1 @@
+../../all-your-base.t

data/tracks/perl5/exercises/all-your-base/all-your-base.t

@@ -8,7 +8,7 @@ my $dir;
 BEGIN { $dir = $FindBin::Bin . '/' };
 use lib $dir;
 
-my $module = $ENV{EXERCISM} ? 'Example' : 'AllYourBase';
+my $module = 'AllYourBase';
 
 my $function = 'convert_base';
 

data/tracks/perl5/exercises/allergies/{Example.pm → .meta/solutions/Allergies.pm}

@@ -1,4 +1,4 @@
-package Example;
+package Allergies;
 
 use strict;
 use warnings;

data/tracks/perl5/exercises/allergies/.meta/solutions/allergies.t

@@ -0,0 +1 @@
+../../allergies.t

data/tracks/perl5/exercises/allergies/allergies.t

@@ -3,22 +3,18 @@ use strict;
 use warnings;
 
 use Test::More;
-use JSON qw(from_json);
+use JSON::PP qw(decode_json);
 use FindBin;
 my $dir;
 BEGIN { $dir = $FindBin::Bin . '/' };
 use lib $dir;
 
-my $module = $ENV{EXERCISM} ? 'Example' : 'Allergies';
+my $module = 'Allergies';
 
-my $cases_file = "${dir}cases.json";
 my $cases;
-
-if (open my $fh, '<', $cases_file) {
+{
     local $/ = undef;
-    $cases = from_json scalar <$fh>;
-} else {
-    die "Could not open '$cases_file' $!";
+    $cases = decode_json scalar <DATA>;
 }
 
 plan tests => 4 + @$cases;
@@ -42,3 +38,74 @@ foreach my $c (@$cases) {
         is_deeply $allergy->list(), $c->{expected}, $c->{name};
     }
 }
+
+__DATA__
+[
+    {
+        "sub"     : "allergic_to",
+        "input"   : [0, "peanuts"],
+        "expected": false,
+        "name"    : "score 0 is not allergic_to peanuts"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [0, "cats"],
+        "expected": false,
+        "name"    : "score 0 is not allergic_to cats"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [0, "strawberries"],
+        "expected": false,
+        "name"    : "score 0 is not allergic_to strawberries"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [1, "eggs"],
+        "expected": true,
+        "name"    : "score 1 is allergic_to eggs"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [5, "eggs"],
+        "expected": true,
+        "name"    : "score 5 is allergic_to eggs"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [5, "shellfish"],
+        "expected": true,
+        "name"    : "score 5 is allergic_to shellfish"
+    },
+    {
+        "sub"     : "allergic_to",
+        "input"   : [5, "strawberries"],
+        "expected": false,
+        "name"    : "score 5 is not allergic_to strawberries"
+    },
+    {
+        "sub"     : "list",
+        "input"   : 0,
+        "expected": [],
+        "name"    : "score 0 has empty allergens"
+    },
+    {
+        "sub"     : "list",
+        "input"   : 2,
+        "expected": ["peanuts"],
+        "name"    : "score 2 has one allergen"
+    },
+    {
+        "sub"     : "list",
+        "input"   : 255,
+        "expected": ["eggs", "peanuts", "shellfish", "strawberries", "tomatoes", "chocolate", "pollen", "cats"],
+        "name"    : "score 255 is allergic to everything"
+    },
+    {
+        "sub"     : "list",
+        "input"   : 509,
+        "expected": ["eggs", "shellfish", "strawberries", "tomatoes", "chocolate", "pollen", "cats"],
+        "name"    : "score 509 ignores non allergen score parts"
+    }
+]
+

data/tracks/perl5/exercises/anagram/{Example.pm → .meta/solutions/Anagram.pm}

@@ -1,4 +1,4 @@
-package Example;
+package Anagram;
 use strict;
 use warnings;
 

data/tracks/perl5/exercises/anagram/.meta/solutions/anagram.t

@@ -0,0 +1 @@
+../../anagram.t

data/tracks/perl5/exercises/anagram/anagram.t

@@ -3,21 +3,18 @@ use strict;
 use warnings;
 
 use Test::More;
-use JSON qw(from_json);
+use JSON::PP qw(decode_json);
 use FindBin;
 my $dir;
 BEGIN { $dir = $FindBin::Bin . '/' };
 use lib $dir;
 
-my $module = $ENV{EXERCISM} ? 'Example' : 'Anagram';
+my $module = 'Anagram';
 
-my $cases_file = "${dir}cases.json";
 my $cases;
-if (open my $fh, '<', $cases_file) {
+{
     local $/ = undef;
-    $cases = from_json scalar <$fh>;
-} else {
-    die "Could not open '$cases_file' $!";
+    $cases = decode_json scalar <DATA>;
 }
 
 plan tests => 3 + @$cases;
@@ -39,4 +36,60 @@ foreach my $c (@$cases) {
     is_deeply $sub->($c->{word}, @{ $c->{words} }), $c->{expected}, $c->{name};
 }
 
-
+__DATA__
+[
+  {
+    "word"     : "diaper",
+    "words"    : ["hello", "world", "zombies", "pants"],
+    "expected" : [],
+    "name"     : "no matches"
+  },
+  {
+    "word"     : "ant",
+    "words"    : ["tan", "stand", "at"],
+    "expected" : ["tan"],
+    "name"     : "detect_simple_anagram"
+  },
+  {
+    "word"     : "master",
+    "words"    : ["stream", "pigeon", "maters"],
+    "expected" : ["stream", "maters"],
+    "name"     : "multiple_anagrams"
+  },
+  {
+    "word"     : "galea",
+    "words"    : ["eagle"],
+    "expected" : [],
+    "name"     : "does_not_confuse_different_duplicates"
+  },
+  {
+    "word"     : "good",
+    "words"    : ["dog", "goody"],
+    "expected" : [],
+    "name"     : "eliminate_anagram_subsets"
+  },
+  {
+    "word"     : "listen",
+    "words"    : ["enlists", "google", "inlets", "banana"],
+    "expected" : ["inlets"],
+    "name"     : "detect_anagram"
+  },
+  {
+    "word"     : "allergy",
+    "words"    : ["gallery", "ballerina", "regally", "clergy", "largely", "leading"],
+    "expected" : ["gallery", "regally", "largely"],
+    "name"     : "multiple_anagrams"
+  },
+  {
+    "word"     : "Orchestra",
+    "words"    : ["cashregister", "Carthorse", "radishes"],
+    "expected" : ["Carthorse"],
+    "name"     : "anagrams_are_case_insensitive"
+  },
+  {
+    "word"     : "banana",
+    "words"    : ["banana"],
+    "expected" : [],
+    "name"     : "same_word_isnt_anagram"
+  }
+]

data/tracks/perl5/exercises/atbash-cipher/{Example.pm → .meta/solutions/Cipher.pm}

@@ -1,4 +1,4 @@
-package Example;
+package Cipher;
 
 use strict;
 use warnings;

data/tracks/perl5/exercises/atbash-cipher/.meta/solutions/cipher.t

@@ -0,0 +1 @@
+../../cipher.t