trackler 2.2.1.101 → 2.2.1.102

data/tracks/bash/CONTRIBUTING.md

@@ -6,6 +6,10 @@ general purpose instructions.
 
 [docs]: (https://github.com/exercism/docs)
 
+Make sure you read the [policies document] and follow the conventions we agreed upon.
+
+[policies document]: (https://github.com/exercism/bash/blob/master/docs/POLICIES.md)
+
 A great way to get started contributing is [porting an exercise] from another
 track!  It helps you get into the repository, learn your way around, and see
 how things are structured.
@@ -146,15 +150,6 @@ You can check to see if your example script works by running `bats`.
 $ bats hello_world_test.sh
 ```
 
-#### Bash Style Guide
-
-When creating the tests, the tests should follow the [bash style guide]
-to avoid having an inconsistent style.  The tests are delivered as a
-product, and should be as idiomatic as possible, and this will help
-maintain a certain level of consistency.
-
-[bash style guide]: https://google.github.io/styleguide/shell.xml
-
 ### Implementing an Example Solution
 
 If you've been following along so far, your tests should fail.  Go ahead and
@@ -297,7 +292,7 @@ $ git rebase upstream/master
 Now you're ready to sync up with Github and open your pull request!
 
 ```bash
-$ git push --force-with-lease origin <your-branch-name>
+$ git push origin <your-branch-name>
 ```
 
 ![Create pull request](img/create-pr.png)

data/tracks/bash/POLICIES.md

@@ -0,0 +1,57 @@
+
+# Track Policies
+
+This document:
+
+- describes all current track-wide policies; and
+- lists all policies that should be reviewed in response to any given track event.
+
+Maintainers should refer to this document each time they review a pull request.
+
+Our policies are not set-in-stone. They represent directions chosen at a point in time with the information/context available at that time. We actively encourage contributors to review and critique them. If you have read through the references that informed an existing policy and still feel it should be improved or removed, please comment and describe:
+
+1. your alternative perspective;
+2. your proposed changes; and
+3. how your proposal balances your own perspective with those already raised during prior discussions.
+
+## Policy Descriptions
+
+### Style Guide
+
+When contributing code to this repository, it should follow the [bash style guide]
+to avoid having an inconsistent style.
+This is most import for the tests, since they are delivered as a product, and should be as idiomatic as possible, and this will help maintain a certain level of consistency.
+
+[bash style guide]: https://google.github.io/styleguide/shell.xml
+
+### Prefer standard Bash over POSIX compliance
+
+When submitting or updated exercises, POSIX compliance is not required. This applies when discussing sumbissions for the exercises.
+You can make POSIX compliance a stretch goal, and that could be a good start for a discussion with users.
+
+References: [[1](https://github.com/exercism/bash/issues/88)]
+
+### Exercise structure
+
+For an exercise "exercise", you should provide the following files:
+- `README.md`, which describes the exercise
+- `exercise_test.sh`, which contains the tests for the implementation
+- `example.sh`, an example implementation that passes the tests
+- `.meta/version`, which contains the exercise version from `https://github.com/exercism/problem-specifications/exercises/exercise/canonical-data.json`
+
+References: [[1](https://github.com/exercism/bash/issues/87#event-1446351332)]
+
+### Exercise Test Structure
+
+The tests will not enforce using a specific function, unless the problems are complex or requires it (ex: https://github.com/exercism/bash/blob/master/exercises/triangle/triangle_test.sh)
+
+```
+run bash exercise.sh "string"
+```
+
+instead of
+```
+run bash exercise.sh exercise "string"
+```
+
+References: [[1](https://github.com/exercism/bash/issues/150#event-1446340584)]

data/tracks/bash/_template/example.sh

@@ -1,3 +1,22 @@
 #!/usr/bin/env bash
 
-# A solution to the exercise, passing all tests, should be here
+# This is a bash script template in order to help you quick start any script.
+# It contains some sensible defaults, you can learn more by visiting:
+# https://google.github.io/styleguide/shell.xml
+
+# This option will make the script exit when there is an error
+set -o errexit
+# This option will make the script exit when are unset variables
+set -o nounset
+
+main() {
+  # A string variable containing only the FIRST argument passed to the script,
+  # you can use input=$@ to get a string with ALL arguments
+  input=$1
+
+  # Add your code here
+}
+
+# Calls the main function passing all the arguments to it via '$@'
+# The argument is in quotes to prevent whitespace issues
+main "$@"

data/tracks/bash/exercises/hello-world/hello_world.sh

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+
+# This is a bash script template in order to help you quick start any script.
+# It contains some sensible defaults, you can learn more by visiting:
+# https://google.github.io/styleguide/shell.xml
+
+# This option will make the script exit when there is an error
+set -o errexit
+# This option will make the script exit when are unset variables
+set -o nounset
+
+main() {
+  # A string variable containing only the FIRST argument passed to the script,
+  # you can use input=$@ to get a string with ALL arguments
+  input=$1
+
+  # Add your code here
+}
+
+# Calls the main function passing all the arguments to it via '$@'
+# The argument is in quotes to prevent whitespace issues
+main "$@"

data/tracks/ceylon/exercises/anagram/source/anagram/AnagramTest.ceylon

@@ -1,13 +1,9 @@
 import ceylon.test { ... }
 
-// Tests adapted from problem-specifications version 1.1.0
+// Tests adapted from problem-specifications version 1.2.0
 {[String, {String*}, {String*}]*} cases => {
   // no matches
   ["diaper", {"hello", "world", "zombies", "pants"}, {}],
-  // detects simple anagram
-  ["ant", {"tan", "stand", "at"}, {"tan"}],
-  // does not detect false positives
-  ["galea", {"eagle"}, {}],
   // detects two anagrams
   ["master", {"stream", "pigeon", "maters"}, {"stream", "maters"}],
   // does not detect anagram subsets
@@ -20,8 +16,6 @@ import ceylon.test { ... }
     {"gallery", "ballerina", "regally", "clergy", "largely", "leading"},
     {"gallery", "regally", "largely"}
   ],
-  // does not detect identical words
-  ["corn", {"corn", "dark", "Corn", "rank", "CORN", "cron", "park"}, {"cron"}],
   // does not detect non-anagrams with identical checksum
   ["mass", {"last"}, {}],
   // detects anagrams case-insensitively
@@ -30,8 +24,6 @@ import ceylon.test { ... }
   ["Orchestra", {"cashregister", "carthorse", "radishes"}, {"carthorse"}],
   // detects anagrams using case-insensitive possible matches
   ["orchestra", {"cashregister", "Carthorse", "radishes"}, {"Carthorse"}],
-  // does not detect a word as its own anagram
-  ["banana", {"Banana"}, {}],
   // does not detect a anagram if the original word is repeated
   ["go", {"go Go GO"}, {}],
   // anagrams must use all letters exactly once

data/tracks/ceylon/exercises/rna-transcription/README.md

@@ -35,7 +35,7 @@ ceylon compile && ceylon test $(basename source/*)
 
 ## Source
 
-Rosalind [http://rosalind.info/problems/rna](http://rosalind.info/problems/rna)
+Hyperphysics [http://hyperphysics.phy-astr.gsu.edu/hbase/Organic/transcription.html](http://hyperphysics.phy-astr.gsu.edu/hbase/Organic/transcription.html)
 
 ## Submitting Incomplete Solutions
 It's possible to submit an incomplete solution so you can see how others have completed the exercise.

data/tracks/fsharp/exercises/matrix/Example.fs

@@ -1,18 +1,21 @@
 module Matrix
 
-type Matrix = { rows: int [][]; cols: int [][] }
+let private parseRow (row: string) =
+    row.Split(' ')
+    |> Seq.map int
+    |> List.ofSeq
 
-let fromString (str: string) =     
-    let parseRow (row: string) = 
-        row.Split(' ') 
-        |> Array.map (string >> int)
-    
-    let rows = str.Split('\n') |> Array.map parseRow
-    let numberOfCols = Array.item 0 rows |> Array.length
-    let cols = [| for col in 0..numberOfCols - 1 ->
-                    [| for row in rows -> Array.item col row |] |]
+let private parseRows (matrix: string) =
+    matrix.Split('\n') 
+    |> Seq.map parseRow
+    |> List.ofSeq
 
-    { rows = rows; cols = cols }
+let row index matrix = 
+    matrix
+    |> parseRows
+    |> List.item index
 
-let rows matrix = matrix.rows
-let cols matrix = matrix.cols
+let column index matrix =
+    matrix
+    |> parseRows
+    |> List.map (List.item index)

data/tracks/fsharp/exercises/matrix/Matrix.fs

@@ -1,7 +1,5 @@
 module Matrix
 
-let fromString str = failwith "You need to implement this function."
+let row index matrix = failwith "You need to implement this function."
 
-let rows matrix = failwith "You need to implement this function."
-
-let cols matrix = failwith "You need to implement this function."
+let col index matrix = failwith "You need to implement this function."

data/tracks/fsharp/exercises/matrix/MatrixTest.fs

@@ -1,82 +1,41 @@
-// This file was created manually and its version is 1.0.0.
+// This file was auto-generated based on version 1.0.0 of the canonical data.
 
 module MatrixTest
 
-open Xunit
 open FsUnit.Xunit
+open Xunit
 
 open Matrix
 
-type MatrixTest() =
-    static member ExtractFirstRowData = 
-        let theoryData = new TheoryData<string, int[]>()
-        theoryData.Add("1", [| 1 |])
-        theoryData.Add("4 7", [| 4; 7 |])
-        theoryData.Add("1 2\n10 20", [| 1; 2 |])
-        theoryData.Add("9 7 6\n8 6 5\n5 3 2", [| 9; 7; 6 |])
-        theoryData
-
-    [<Theory>]
-    [<MemberData("ExtractFirstRowData")>]
-    member this.``Extract first row`` (input: string) expected =    
-        let matrix = fromString input    
-        rows matrix |> Array.head |> should equal expected
+[<Fact>]
+let ``Extract row from one number matrix`` () =
+    row 0 "1" |> should equal [1]
 
-    static member ExtractLastRowData = 
-        let theoryData = new TheoryData<string, int[]>()
-        theoryData.Add("5", [| 5 |])
-        theoryData.Add("9 7", [| 9; 7 |])
-        theoryData.Add("9 8 7\n19 18 17", [| 19; 18; 17 |])
-        theoryData.Add("1 4 9\n16 25 36\n5 6 7", [| 5; 6; 7 |])
-        theoryData
+[<Fact(Skip = "Remove to run test")>]
+let ``Can extract row`` () =
+    row 1 "1 2\n3 4" |> should equal [3; 4]
 
-    [<Theory(Skip = "Remove to run test")>]
-    [<MemberData("ExtractLastRowData")>]
-    member this.``Extract last row`` (input: string) expected =
-        let matrix = fromString input
-        rows matrix |> Array.last |> should equal expected
+[<Fact(Skip = "Remove to run test")>]
+let ``Extract row where numbers have different widths`` () =
+    row 1 "1 2\n10 20" |> should equal [10; 20]
 
-    static member ExtractFirstColumnData = 
-        let theoryData = new TheoryData<string, int[]>()
-        theoryData.Add("55 44", [| 55 |])
-        theoryData.Add("89 1903\n18 3", [| 89; 18 |])
-        theoryData.Add("1 2 3\n4 5 6\n7 8 9\n8 7 6", [| 1; 4; 7; 8 |])
-        theoryData
+[<Fact(Skip = "Remove to run test")>]
+let ``Can extract row from non-square matrix`` () =
+    row 2 "1 2 3\n4 5 6\n7 8 9\n8 7 6" |> should equal [7; 8; 9]
 
-    [<Theory(Skip = "Remove to run test")>]
-    [<MemberData("ExtractFirstColumnData")>]
-    member this.``Extract first column`` (input: string) expected =
-        let matrix = fromString input
-        cols matrix |> Array.head |> should equal expected
+[<Fact(Skip = "Remove to run test")>]
+let ``Extract column from one number matrix`` () =
+    column 0 "1" |> should equal [1]
 
-    static member ExtractLastColumnData = 
-        let theoryData = new TheoryData<string, int[]>()
-        theoryData.Add("28", [| 28 |])
-        theoryData.Add("13\n16\n19", [| 13; 16; 19 |])
-        theoryData.Add("289 21903 23\n218 23 21", [| 23; 21 |])
-        theoryData.Add("11 12 13\n14 15 16\n17 18 19\n18 17 16", [| 13; 16; 19; 16 |])
-        theoryData
+[<Fact(Skip = "Remove to run test")>]
+let ``Can extract column`` () =
+    column 2 "1 2 3\n4 5 6\n7 8 9" |> should equal [3; 6; 9]
 
-    [<Theory(Skip = "Remove to run test")>]
-    [<MemberData("ExtractLastColumnData")>]
-    member this.``Extract last column`` (input: string) expected =
-        let matrix = fromString input
-        cols matrix |> Array.last |> should equal expected
+[<Fact(Skip = "Remove to run test")>]
+let ``Can extract column from non-square matrix`` () =
+    column 2 "1 2 3\n4 5 6\n7 8 9\n8 7 6" |> should equal [3; 6; 9; 6]
 
-    [<Theory(Skip = "Remove to run test")>]
-    [<InlineData("28", 1)>]
-    [<InlineData("13\n16", 2)>]
-    [<InlineData("289 21903\n23 218\n23 21", 3)>]
-    [<InlineData("11 12 13\n14 15 16\n17 18 19\n18 17 16", 4)>]
-    member this.``Number of rows`` (input: string) expected =
-        let matrix = fromString input
-        rows matrix |> Array.length |> should equal expected
+[<Fact(Skip = "Remove to run test")>]
+let ``Extract column where numbers have different widths`` () =
+    column 1 "89 1903 3\n18 3 1\n9 4 800" |> should equal [1903; 3; 4]
 
-    [<Theory(Skip = "Remove to run test")>]
-    [<InlineData("28", 1)>]
-    [<InlineData("13 2\n16 3\n19 4", 2)>]
-    [<InlineData("289 21903\n23 218\n23 21", 2)>]
-    [<InlineData("11 12 13\n14 15 16\n17 18 19\n18 17 16", 3)>]
-    member this.``Number of columns`` (input: string) expected =
-        let matrix = fromString input
-        cols matrix |> Array.length |> should equal expected

data/tracks/fsharp/exercises/saddle-points/Example.fs

@@ -1,23 +1,27 @@
 module SaddlePoints
 
 let saddlePoints (matrix: int list list) = 
-    let rec transpose = function
-        | (_::_)::_ as M -> List.map List.head M :: transpose (List.map List.tail M)
-        | _ -> []
+    match matrix with
+    | []   -> []
+    | [[]] -> []
+    | _ ->
+        let rec transpose = function
+            | (_::_)::_ as m -> List.map List.head m :: transpose (List.map List.tail m)
+            | _ -> []
 
-    let rows = matrix |> List.length
-    let cols = matrix |> List.head |> List.length
+        let rows = matrix |> List.length
+        let cols = matrix |> List.head |> List.length
 
-    let rowsMax = matrix |> List.map List.max
-    let colsMin = matrix |> transpose |> List.map List.min
+        let rowsMax = matrix |> List.map List.max
+        let colsMin = matrix |> transpose |> List.map List.min
 
-    let rowMax x = rowsMax |> List.item x
-    let colMin y = colsMin |> List.item y
+        let rowMax x = rowsMax |> List.item x
+        let colMin y = colsMin |> List.item y
 
-    let element x y = matrix |> List.item x |> List.item y
-    let isSaddlePoint x y = element x y = rowMax x && element x y = colMin y
+        let element x y = matrix |> List.item x |> List.item y
+        let isSaddlePoint x y = element x y = rowMax x && element x y = colMin y
 
-    [for x in 0 .. (rows - 1) do
-        for y in 0 .. (cols - 1) do            
-            if isSaddlePoint x y then
-                yield (x, y)]
+        [for x in 0 .. (rows - 1) do
+            for y in 0 .. (cols - 1) do            
+                if isSaddlePoint x y then
+                    yield (x, y)]

data/tracks/fsharp/exercises/saddle-points/SaddlePointsTest.fs

@@ -1,46 +1,46 @@
-// This file was created manually and its version is 1.0.0.
+// This file was auto-generated based on version 1.1.0 of the canonical data.
 
-module SaddlePointTest
+module SaddlePointsTest
 
-open Xunit
 open FsUnit.Xunit
+open Xunit
 
 open SaddlePoints
 
 [<Fact>]
-let ``Readme example`` () =
-    let values = [ [ 9; 8; 7 ]; 
-                   [ 5; 3; 2 ]; 
-                   [ 6; 6; 7 ] ]
-    let actual = saddlePoints values
-    actual |> should equal [(1, 0)]
+let ``Can identify single saddle point`` () =
+    let matrix = 
+        [ [9; 8; 7];
+          [5; 3; 2];
+          [6; 6; 7] ]
+    saddlePoints matrix |> should equal [(1, 0)]
 
 [<Fact(Skip = "Remove to run test")>]
-let ``No saddle point`` () =
-    let values = [ [ 2; 1 ]; 
-                   [ 1; 2 ] ]
-    let actual = saddlePoints values
-    actual |> should be Empty
+let ``Can identify that empty matrix has no saddle points`` () =
+    let matrix = [[]]
+    saddlePoints matrix |> should be Empty
 
 [<Fact(Skip = "Remove to run test")>]
-let ``Saddle point`` () =
-    let values = [ [ 1; 2 ]; 
-                   [ 3; 4 ] ]
-    let actual = saddlePoints values
-    actual |> should equal [(0, 1)]
+let ``Can identify lack of saddle points when there are none`` () =
+    let matrix = 
+        [ [1; 2; 3];
+          [3; 1; 2];
+          [2; 3; 1] ]
+    saddlePoints matrix |> should be Empty
 
 [<Fact(Skip = "Remove to run test")>]
-let ``Another saddle point`` () =
-    let values = [ [ 18;  3; 39; 19;  91 ]; 
-                   [ 38; 10;  8; 77; 320 ]; 
-                   [  3;  4;  8;  6;   7 ] ]
-    let actual = saddlePoints values
-    actual |> should equal [(2, 2)]
+let ``Can identify multiple saddle points`` () =
+    let matrix = 
+        [ [4; 5; 4];
+          [3; 5; 5];
+          [1; 5; 4] ]
+    saddlePoints matrix |> should equal [(0, 1); (1, 1); (2, 1)]
 
 [<Fact(Skip = "Remove to run test")>]
-let ``Multiple saddle points`` () =
-    let values = [ [ 4; 5; 4 ];
-                   [ 3; 5; 5 ];
-                   [ 1; 5; 4 ] ]
-    let actual = saddlePoints values
-    actual |> should equal [(0, 1); (1, 1); (2, 1)]   
+let ``Can identify saddle point in bottom right corner`` () =
+    let matrix = 
+        [ [8; 7; 9];
+          [6; 7; 6];
+          [3; 2; 5] ]
+    saddlePoints matrix |> should equal [(2, 2)]
+