trackler 2.1.0.7 → 2.1.0.8

data/tracks/ruby/exercises/etl/etl_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'etl'
 
-# Common test data version: ca9ed58
+# Common test data version: 1.0.0 ca9ed58
 class EtlTest < Minitest::Test
   def test_a_single_letter
     # skip

data/tracks/ruby/exercises/flatten-array/flatten_array_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'flatten_array'
 

data/tracks/ruby/exercises/food-chain/food_chain_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 
 require_relative 'food_chain'

data/tracks/ruby/exercises/gigasecond/.meta/generator/gigasecond_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 require 'time'
 
 class GigasecondCase < Generator::ExerciseCase

data/tracks/ruby/exercises/gigasecond/gigasecond_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'gigasecond'
 
-# Common test data version: 61e7d70
+# Common test data version: 1.0.0 61e7d70
 class GigasecondTest < Minitest::Test
   def test_date_only_specification_of_time
     # skip

data/tracks/ruby/exercises/grade-school/grade_school_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'grade_school'
 

data/tracks/ruby/exercises/grains/.meta/generator/grains_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class GrainsCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/grains/grains_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'grains'
 
-# Common test data version: 2e0e77e
+# Common test data version: 1.0.0 2e0e77e
 class GrainsTest < Minitest::Test
   def test_1
     # skip

data/tracks/ruby/exercises/hamming/.meta/generator/hamming_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class HammingCase < Generator::ExerciseCase
   def workload

data/tracks/ruby/exercises/hamming/hamming_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'hamming'
 
-# Common test data version: bb56dc7
+# Common test data version: 1.0.0 bb56dc7
 class HammingTest < Minitest::Test
   def test_identical_strands
     # skip

data/tracks/ruby/exercises/hello-world/.meta/generator/hello_world_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class HelloWorldCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/hello-world/.meta/generator/test_template.erb

@@ -12,7 +12,7 @@ rescue LoadError => e
   exit 1
 end
 
-# Common test data version: <%= abbreviated_commit_hash %>
+# Common test data version: <%= canonical_data_version %> <%= abbreviated_commit_hash %>
 class HelloWorldTest < Minitest::Test
 <% test_cases.each do |test_case| %>
   def <%= test_case.name %>

data/tracks/ruby/exercises/hello-world/hello_world_test.rb

@@ -12,7 +12,7 @@ rescue LoadError => e
   exit 1
 end
 
-# Common test data version: 4b9ae53
+# Common test data version: 1.0.0 4b9ae53
 class HelloWorldTest < Minitest::Test
   def test_say_hi
     # skip

data/tracks/ruby/exercises/hexadecimal/hexadecimal_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'hexadecimal'
 

data/tracks/ruby/exercises/house/house_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'house'
 

data/tracks/ruby/exercises/isogram/.meta/generator/isogram_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class IsogramCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/isogram/isogram_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'isogram'
 
-# Common test data version: 857c40d
+# Common test data version: 1.1.0 857c40d
 class IsogramTest < Minitest::Test
   def test_empty_string
     # skip

data/tracks/ruby/exercises/kindergarten-garden/kindergarten_garden_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'kindergarten_garden'
 

data/tracks/ruby/exercises/largest-series-product/.meta/generator/largest_series_product_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class LargestSeriesProductCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/largest-series-product/largest_series_product_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'largest_series_product'
 
-# Common test data version: e79b832
+# Common test data version: 1.0.0 e79b832
 class LargestSeriesProductTest < Minitest::Test
   def test_finds_the_largest_product_if_span_equals_length
     # skip

data/tracks/ruby/exercises/leap/.meta/generator/leap_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class LeapCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/leap/.meta/generator/test_template.erb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'leap'
 
-# Common test data version: <%= abbreviated_commit_hash %>
+# Common test data version: <%= canonical_data_version %> <%= abbreviated_commit_hash %>
 class Date
   def leap?
     raise RuntimeError, "Implement this yourself instead of using Ruby's implementation."

data/tracks/ruby/exercises/leap/leap_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'leap'
 
-# Common test data version: cc65ebe
+# Common test data version: 1.0.0 cc65ebe
 class Date
   def leap?
     raise RuntimeError, "Implement this yourself instead of using Ruby's implementation."

data/tracks/ruby/exercises/linked-list/linked_list_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'linked_list'
 

data/tracks/ruby/exercises/list-ops/list_ops_test.rb

@@ -1,4 +1,3 @@
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'list_ops'
 

data/tracks/ruby/exercises/luhn/.meta/generator/luhn_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class LuhnCase < Generator::ExerciseCase
   def workload

data/tracks/ruby/exercises/luhn/luhn_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'luhn'
 
-# Common test data version: c826372
+# Common test data version: 1.0.0 c826372
 class LuhnTest < Minitest::Test
   def test_single_digit_strings_can_not_be_valid
     # skip

data/tracks/ruby/exercises/matrix/matrix_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'matrix'
 

data/tracks/ruby/exercises/meetup/meetup_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require 'date'
 require_relative 'meetup'

data/tracks/ruby/exercises/minesweeper/minesweeper_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'minesweeper'
 

data/tracks/ruby/exercises/nth-prime/.meta/generator/nth_prime_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class NthPrimeCase < Generator::ExerciseCase
 

data/tracks/ruby/exercises/nth-prime/nth_prime_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'nth_prime'
 
-# Common test data version: 016d65b
+# Common test data version: 1.0.0 016d65b
 class NthPrimeTest < Minitest::Test
   def test_first_prime
     # skip

data/tracks/ruby/exercises/nucleotide-count/nucleotide_count_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'nucleotide_count'
 

data/tracks/ruby/exercises/ocr-numbers/.meta/generator/ocr_numbers_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class OcrNumbersCase < Generator::ExerciseCase
   def workload

data/tracks/ruby/exercises/ocr-numbers/ocr_numbers_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'ocr_numbers'
 
-# Common test data version: 80782b6
+# Common test data version: 1.0.0 80782b6
 class OcrNumbersTest < Minitest::Test
   def test_recognizes_0
     # skip

data/tracks/ruby/exercises/octal/octal_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'octal'
 

data/tracks/ruby/exercises/palindrome-products/palindrome_products_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'palindrome_products'
 

data/tracks/ruby/exercises/pangram/.meta/generator/pangram_cases.rb

@@ -1,4 +1,4 @@
-require 'generator/exercise_cases'
+require 'generator/exercise_case'
 
 class PangramCase < Generator::ExerciseCase
   def workload

data/tracks/ruby/exercises/pangram/pangram_test.rb

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'pangram'
 
-# Common test data version: f375051
+# Common test data version: 1.0.0 f375051
 class PangramTest < Minitest::Test
   def test_sentence_empty
     # skip

data/tracks/ruby/exercises/pascals-triangle/pascals_triangle_test.rb

@@ -1,5 +1,4 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'pascals_triangle'
 

data/tracks/ruby/exercises/perfect-numbers/perfect_numbers_test.rb

@@ -1,4 +1,3 @@
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'perfect_numbers'
 

data/tracks/ruby/exercises/phone-number/.meta/.version

@@ -0,0 +1 @@
+1

data/tracks/ruby/exercises/phone-number/.meta/generator/phone_number_cases.rb

@@ -0,0 +1,7 @@
+require 'generator/exercise_case'
+
+class PhoneNumberCase < Generator::ExerciseCase
+  def workload
+     assert_equal { "PhoneNumber.clean(#{phrase.inspect})" }
+  end
+end

data/tracks/ruby/exercises/phone-number/example.rb

@@ -1,45 +1,29 @@
-class PhoneNumber
-  attr_reader :number
-  def initialize(number)
-    @number = clean(number)
-  end
-
-  def area_code
-    number[0..2]
-  end
-
-  # technically, the central office (exchange) code
-  def exchange_code
-    number[3..5]
-  end
+module PhoneNumber
+  NANP_PROTOCOL = %r{
+    \A
+    (?<international_code>1?)
+    (?<area_code>[2-9]{1}[0-9]{2})
+    (?<exchange_code>[2-9]{1}[0-9]{2})
+    (?<subscriber>[0-9]{4})
+    \z
+  }x
 
-  def subscriber_number
-    number[6..9]
+  def self.clean(number)
+    sanitized = digits_only(number)
+    sections = nanp_parse(sanitized)
+    format '%<area_code>s%<exchange_code>s%<subscriber>s', sections if sections
   end
 
-  def to_s
-    "(#{area_code}) #{exchange_code}-#{subscriber_number}"
+  def self.digits_only(number)
+    number.gsub(/\D/, '')
   end
 
-  private
-
-  def clean(number)
-    return '0' * 10 if number.match(/[a-zA-Z]/)
-    number = number.gsub(/[^0-9]/, '')
-    normalize(number)
-  end
-
-  def normalize(number)
-    if valid?(number)
-      number[/(\d{10})\z/, 1]
-    else
-      '0' * 10
-    end
+  def self.nanp_parse(number)
+    matches = number.match(NANP_PROTOCOL)
+    matches.names.map(&:to_sym).zip(matches.captures).to_h if matches
   end
+end
 
-  def valid?(number)
-    return true if number.length == 10
-    return true if number.length == 11 && number.start_with?('1')
-    false
-  end
+module BookKeeping
+  VERSION = 1
 end

data/tracks/ruby/exercises/phone-number/phone_number_test.rb

@@ -1,89 +1,93 @@
 #!/usr/bin/env ruby
-gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'phone_number'
 
+# Common test data version: 51d2475
 class PhoneNumberTest < Minitest::Test
-  def test_cleans_number
-    number = PhoneNumber.new('(123) 456-7890').number
-    assert_equal '1234567890', number
+  def test_cleans_the_number
+    # skip
+    assert_equal "2234567890", PhoneNumber.clean("(223) 456-7890")
   end
 
-  def test_cleans_a_different_number
+  def test_cleans_numbers_with_dots
     skip
-    number = PhoneNumber.new('(987) 654-3210').number
-    assert_equal '9876543210', number
+    assert_equal "2234567890", PhoneNumber.clean("223.456.7890")
   end
 
-  def test_cleans_number_with_dots
+  def test_cleans_numbers_with_multiple_spaces
     skip
-    number = PhoneNumber.new('456.123.7890').number
-    assert_equal '4561237890', number
+    assert_equal "2234567890", PhoneNumber.clean("223 456   7890   ")
   end
 
-  def test_invalid_with_letters_in_place_of_numbers
+  def test_invalid_when_9_digits
     skip
-    number = PhoneNumber.new('123-abc-1234').number
-    assert_equal '0000000000', number
+    assert_nil PhoneNumber.clean("123456789")
   end
 
-  def test_invalid_when_9_digits
+  def test_invalid_when_11_digits_does_not_start_with_a_1
     skip
-    number = PhoneNumber.new('123456789').number
-    assert_equal '0000000000', number
+    assert_nil PhoneNumber.clean("22234567890")
   end
 
-  def test_valid_when_11_digits_and_first_is_1
+  def test_valid_when_11_digits_and_starting_with_1
     skip
-    number = PhoneNumber.new('19876543210').number
-    assert_equal '9876543210', number
+    assert_equal "2234567890", PhoneNumber.clean("12234567890")
   end
 
-  def test_valid_when_10_digits_and_area_code_starts_with_1
+  def test_valid_when_11_digits_and_starting_with_1_even_with_punctuation
     skip
-    number = PhoneNumber.new('1234567890').number
-    assert_equal '1234567890', number
+    assert_equal "2234567890", PhoneNumber.clean("+1 (223) 456-7890")
   end
 
-  def test_invalid_when_11_digits
+  def test_invalid_when_more_than_11_digits
     skip
-    number = PhoneNumber.new('21234567890').number
-    assert_equal '0000000000', number
+    assert_nil PhoneNumber.clean("321234567890")
   end
 
-  def test_invalid_when_12_digits_and_first_is_1
+  def test_invalid_with_letters
     skip
-    number = PhoneNumber.new('112345678901').number
-    assert_equal '0000000000', number
+    assert_nil PhoneNumber.clean("123-abc-7890")
   end
 
-  def test_invalid_when_10_digits_with_extra_letters
+  def test_invalid_with_punctuations
     skip
-    number = PhoneNumber.new('1a2a3a4a5a6a7a8a9a0a').number
-    assert_equal '0000000000', number
+    assert_nil PhoneNumber.clean("123-@:!-7890")
   end
 
-  def test_area_code
+  def test_invalid_with_right_number_of_digits_but_letters_mixed_in
     skip
-    number = PhoneNumber.new('1234567890')
-    assert_equal '123', number.area_code
+    assert_nil PhoneNumber.clean("1a2b3c4d5e6f7g8h9i0j")
   end
 
-  def test_different_area_code
+  def test_invalid_if_area_code_does_not_start_with_2_9
     skip
-    number = PhoneNumber.new('9876543210')
-    assert_equal '987', number.area_code
+    assert_nil PhoneNumber.clean("(123) 456-7890")
   end
 
-  def test_pretty_print
+  def test_invalid_if_exchange_code_does_not_start_with_2_9
     skip
-    number = PhoneNumber.new('5551234567')
-    assert_equal '(555) 123-4567', number.to_s
+    assert_nil PhoneNumber.clean("(223) 056-7890")
   end
 
-  def test_pretty_print_with_full_us_phone_number
+  # Problems in exercism evolve over time, as we find better ways to ask
+  # questions.
+  # The version number refers to the version of the problem you solved,
+  # not your solution.
+  #
+  # Define a constant named VERSION inside of the top level BookKeeping
+  # module, which may be placed near the end of your file.
+  #
+  # In your file, it will look like this:
+  #
+  # module BookKeeping
+  #   VERSION = 1 # Where the version number matches the one in the test.
+  # end
+  #
+  # If you are curious, read more about constants on RubyDoc:
+  # http://ruby-doc.org/docs/ruby-doc-bundle/UsersGuide/rg/constants.html
+
+  def test_bookkeeping
     skip
-    number = PhoneNumber.new('11234567890')
-    assert_equal '(123) 456-7890', number.to_s
+    assert_equal 1, BookKeeping::VERSION
   end
 end