trackler 2.1.0.21 → 2.1.0.22

data/tracks/ocaml/tools/test-generator/templates/binary-search/template.ml

@@ -1,6 +1,6 @@
-open Core.Std
 open OUnit2
 open Binary_search
+open Core
 
 let option_to_string f = function
   | None   -> "None"

data/tracks/ocaml/tools/test-generator/templates/bob/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Bob
 

data/tracks/ocaml/tools/test-generator/templates/bowling/template.ml

@@ -1,4 +1,4 @@
-open! Core.Std
+open! Core
 open OUnit2
 open Bowling
 

data/tracks/ocaml/tools/test-generator/templates/bracket-push/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Bracket_push
 

data/tracks/ocaml/tools/test-generator/templates/change/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Change
 

data/tracks/ocaml/tools/test-generator/templates/connect/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Connect
 

data/tracks/ocaml/tools/test-generator/templates/difference-of-squares/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Difference_of_squares
 

data/tracks/ocaml/tools/test-generator/templates/dominoes/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Dominoes
 

data/tracks/ocaml/tools/test-generator/templates/etl/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Etl
 

data/tracks/ocaml/tools/test-generator/templates/hamming/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 
 let printer n =

data/tracks/ocaml/tools/test-generator/templates/hello-world/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Hello_world
 

data/tracks/ocaml/tools/test-generator/templates/leap/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Leap
 

data/tracks/ocaml/tools/test-generator/templates/luhn/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Luhn
 

data/tracks/ocaml/tools/test-generator/templates/minesweeper/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Minesweeper
 

data/tracks/ocaml/tools/test-generator/templates/pangram/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Pangram
 

data/tracks/ocaml/tools/test-generator/templates/phone-number/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Phone_number
 

data/tracks/ocaml/tools/test-generator/templates/prime-factors/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Prime_factors
 

data/tracks/ocaml/tools/test-generator/templates/raindrops/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Raindrops
 

data/tracks/ocaml/tools/test-generator/templates/roman-numerals/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Roman_numerals
 

data/tracks/ocaml/tools/test-generator/templates/run-length-encoding/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Run_length_encoding
 

data/tracks/ocaml/tools/test-generator/templates/say/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Say
 

data/tracks/ocaml/tools/test-generator/templates/space-age/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Space_age
 

data/tracks/ocaml/tools/test-generator/templates/triangle/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Triangle
 

data/tracks/ocaml/tools/test-generator/templates/word-count/template.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Word_count
 

data/tracks/ocaml/tools/test-generator/test/all_tests.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Codegen_test
 open Model_test

data/tracks/ocaml/tools/test-generator/test/codegen_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Codegen
 open Model

data/tracks/ocaml/tools/test-generator/test/model_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Codegen
 open Model

data/tracks/ocaml/tools/test-generator/test/parser_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Parser
 open Model

data/tracks/ocaml/tools/test-generator/test/special_cases_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Model
 open Codegen

data/tracks/ocaml/tools/test-generator/test/template_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Codegen
 open Template

data/tracks/ocaml/tools/test-generator/test/utils_test.ml

@@ -1,4 +1,4 @@
-open Core.Std
+open Core
 open OUnit2
 open Codegen
 open Utils

data/tracks/r/.travis.yml

@@ -1,6 +1,17 @@
 ---
-language: bash
+language: R
+cache: packages
+r:
+  - oldrel
+  - release
+  - devel
+install:
+- R -e "install.packages('testthat')"
+- R -e "install.packages('jsonlite')"
+- R -e "install.packages('lintr')"
+- R -e "install.packages('magrittr')"
 script:
 - bin/fetch-configlet
 - bin/configlet .
-sudo: false
+- R -e "source('bin/run_tests.R')"
+- R -e "source('bin/run_lints.R')"

data/tracks/r/README.md

@@ -1,5 +1,8 @@
 # xR
 
+[![Build Status](https://travis-ci.org/exercism/xr.svg?branch=master)](https://travis-ci.org/exercism/xr)
+[![Gitter](https://badges.gitter.im/exercism/dev.svg)](https://gitter.im/exercism/dev?utm_source=share-link&utm_medium=link&utm_campaign=share-link)
+
 Exercism problems in R
 
 ## Contributing Guide
@@ -52,8 +55,19 @@ A general description of all the files and directories can be found [here](https
 
 #### Directory structure
 ```bash
+├── .gitignore
+├── .travis.yml
+├── .github
+│ └── stale.yml
+├── config.json
+├── README.md
+└── LICENSE
+├── img
+│ └── icon.png
 ├── bin
-│ └── fetch‐configlet
+│ ├── fetch‐configlet
+│ ├── run_lints.R
+│ └── run_tests.R
 ├── docs
 │ ├── ABOUT.md
 │ ├── INSTALLATION.md
@@ -62,31 +76,24 @@ A general description of all the files and directories can be found [here](https
 │ └── TESTS.md
 └── exercises
   ├── TRACK_HINTS.md
-  └── <exercise-name>
+  ├── <exercise-name>
   │ ├── <exercise-name>.R
-  │ └── example.R
+  │ ├── example.R
   │ └── test_<exercise-name>.R
-  └── <exercise-name>
+  ├── <exercise-name>
   │ ├── <exercise-name>.R
-  │ └── example.R
+  │ ├── example.R
   │ └── test_<exercise-name>.R
   └── ...
-└── img
-  └── icon.png
-├── .gitignore
-├── .travis.yml
-├── LICENSE
-├── README.md
-└── config.json
 ```
 - `config.json`: Note that every exercise has to be registered here, with a unique name and a difficulty. The sequence order in this file determines the default order in which the exercises are fetched.
 
 #### Exercise structure
 Each exercise has the following structure:
-- `HINTS.md` is an optional file containing instructions and/or hints. It is used together with the respective `description.md` for the exercise from [x-common](https://github.com/exercism/x-common) to build the `README.md` file.
 - `<exercise-name>.R` usually contains an empty function declaration, as a starting point for the required solution.
 - `example.R` is the source code of the sample solution.
 - `test_<exercise-name>.R` is the [test suite](#test-suite).
+- `HINTS.md` is an optional file containing instructions and/or hints. It is used together with the respective `description.md` for the exercise from [x-common](https://github.com/exercism/x-common) to build the `README.md` file.
 
 ### Writing an issue
 To report a bug you should [create an issue](https://help.github.com/articles/creating-an-issue/) [here](https://github.com/exercism/xr/issues).
@@ -104,17 +111,29 @@ The example solution doesn't have to be perfect, but should pass all of the test
 The test suite should be derived from the respective `x-common/exercises/<exercise-name>/canonical-data.json` and comply to some formatting and coding standards (to get an idea you can look at some of the existing tests).
 
 ### Running tests
-To run the tests for an exercise, simply run `source('test_<exercise-name>.R')` from within the exercise's directory. Note that when testing locally you'll need to (temporarily) replace the first line of `test_<exercise-name>.R` (which sources `<exercise-name>.R`) with `source('example.R')`.
+To run the tests for just a single exercise, run `source('test_<exercise-name>.R')` from within the exercise's directory. Note that when testing locally you'll need to replace the first line of `test_<exercise-name>.R` (which sources `<exercise-name>.R`) with `source('example.R')`. If you do this, remember to change it back before submitting any pull requests.
+
+Alternatively, to run tests for all exercises at once, simply run `source("bin/run_tests.R")`.
 
 The example solutions must pass the tests without failures. Additionally the tests should not run longer than a few seconds.
 
-In order to be accepted by Travis-CI, every exercise must be registered in `config.json`.
+In order to be accepted by Travis-CI, each exercise must be registered in `config.json`.
 
 ### Style guide
-Given that there are a variety of R style guides in circulation, at this stage we don't enforce a particular style guide, but our preference is to have R code in this repository follow Hadley Wickham's [R style guide](http://adv-r.had.co.nz/Style.html).
+There are a variety of R style guides in circulation and opinions on the topic can vary widely which does make it hard to settle on specific standards. Our preference is to have R code in this repository follow Hadley Wickham's [R style guide](http://adv-r.had.co.nz/Style.html).
 
 You are thus encouraged to run [`lintr`](https://github.com/jimhester/lintr) on your R scripts before opening a [pull request](#writing-a-pull-request) in order to check that your code adheres to this style guide before submitting it for review.
 
+Note however that at the moment only the following linting rules are strictly enforced:
+
+- line length should be less than 80 characters
+- objects should not be in camelCase, snake_case is preferred
+- the assignment operator <- should be used
+- all commas should be followed by a space (but not preceded by one)
+- no absolute paths should be used
+
+To perform these specific checks locally, run `source("bin/run_lints.R")`.
+
 ## License
 
 The MIT License (MIT)

data/tracks/r/bin/run_lints.R

@@ -0,0 +1,30 @@
+library(lintr)
+
+linters <- list(
+  a = line_length_linter(80),
+  b = camel_case_linter,
+  c = assignment_linter,
+  d = commas_linter,
+  e = absolute_paths_linter
+)
+
+files <- list.files(path = "exercises", pattern = ".+\\.R$", recursive = TRUE, full.names = TRUE)
+lints <- lintr:::flatten_lints(lapply(files, function(file) {
+  if (interactive()) {
+    message(".", appendLF = FALSE)
+  }
+  lint(file, linters, parse_settings = FALSE)
+}))
+if (interactive()) {
+  message()
+}
+lints <- lintr:::reorder_lints(lints)
+class(lints) <- "lints"
+
+has_lints <- length(lints) > 0
+lint_output <- NULL
+if (has_lints) {
+  lint_output <- paste(collapse = "\n", capture.output(print(lints)))
+}
+
+testthat::expect(!has_lints, paste(sep = "\n", "Not lint free", lint_output))

data/tracks/r/bin/run_tests.R

@@ -0,0 +1,35 @@
+library(jsonlite)
+library(testthat)
+library(magrittr)
+
+test_exercise <- function(exercise) {
+  
+  solution_file <- paste0(exercise, ".R")
+  test_file <- paste0("test_", exercise, ".R")
+  
+  file.copy(
+    file.path("..", "exercises", exercise, "example.R"), 
+    solution_file
+  )
+  file.copy(
+    file.path("..", "exercises", exercise, test_file), 
+    test_file
+  )
+  
+  source(test_file)
+  rm(list = ls())
+  
+}
+
+# create temp directory for testing purposes
+temp_dir <- "temp" 
+dir.create(temp_dir)
+setwd(temp_dir)
+
+# read config and test all exercises
+config <- fromJSON(file.path("..", "config.json"))
+lapply(config$exercises$slug, test_exercise)
+
+# clean up
+setwd(dir = "../")
+unlink("temp", recursive = TRUE)

data/tracks/r/exercises/anagram/anagram.R

@@ -1,3 +1,3 @@
-anagram <- function() {
+anagram <- function(subject, candidates) {
 
 }

data/tracks/r/exercises/anagram/example.R

@@ -1,18 +1,18 @@
-anagram <- function(subject,candidates) {
+anagram <- function(subject, candidates) {
   # subject is a string
   # candidates is a character vector
   # break subject into vector of characters
   subject <- tolower(subject)
   test_candidates <- tolower(candidates)
-  l <- strsplit(subject,"")[[1]]
+  l <- strsplit(subject, "")[[1]]
   # sub out each character from l in candidates
   for (i in l) {
-    test_candidates <- sub(i,"",test_candidates)
+    test_candidates <- sub(i, "", test_candidates)
   }
-  result <- candidates[test_candidates=="" &
+  result <- candidates[test_candidates == "" &
                          tolower(candidates) != subject &
                          nchar(candidates) == length(l)]
-  if (length(result)==0) {
+  if (length(result) == 0) {
     return(c())
   }
   return(result)