trackler 2.1.0.11 → 2.1.0.12

data/tracks/ocaml/config.json

@@ -81,6 +81,11 @@
       "difficulty": 3,
       "topics": ["Strings"]
     },
+    {
+      "slug": "acronym",
+      "difficulty": 3,
+      "topics": ["Strings"]
+    },
     {
       "slug": "all-your-base",
       "difficulty": 4,
@@ -91,11 +96,6 @@
       "difficulty": 4,
       "topics": ["Stacks"]
     },
-    {
-      "slug": "bowling",
-      "difficulty": 4,
-      "topics": []
-    },
     {
       "slug": "luhn",
       "difficulty": 4,
@@ -161,6 +161,11 @@
       "difficulty": 7,
       "topics": []
     },
+    {
+      "slug": "bowling",
+      "difficulty": 7,
+      "topics": []
+    },
     {
       "slug": "dominoes",
       "difficulty": 7,

data/tracks/ocaml/exercises/acronym/.merlin

@@ -0,0 +1,5 @@
+PKG findlib
+PKG core
+PKG ounit
+S *
+B *

data/tracks/ocaml/exercises/acronym/Makefile

@@ -0,0 +1,11 @@
+test: test.native
+	@./test.native
+
+test.native: *.ml *.ml
+	@corebuild -r -quiet -pkg oUnit test.native
+
+clean:
+	rm -rf _build
+	rm -f test.native
+
+.PHONY: clean

data/tracks/ocaml/exercises/acronym/acronym.mli

@@ -0,0 +1,2 @@
+(* Creates an acronym from a string. *)
+val acronym : string -> string

data/tracks/ocaml/exercises/acronym/example.ml

@@ -0,0 +1,12 @@
+open Core.Std
+
+let (>|>) f g x = f (g x)
+
+let acronym = 
+  let acronymChar = function 
+  | "" -> ""
+  | s when String.uppercase s = s -> Char.to_string s.[0]
+  | s -> Char.to_string (Char.uppercase s.[0]) ^ String.filter ~f:Char.is_uppercase (String.drop_prefix s 1) in
+  String.concat ~sep:""
+  >|> List.map ~f:acronymChar
+  >|> String.split_on_chars ~on:[' ';'-']

data/tracks/ocaml/exercises/acronym/test.ml

@@ -0,0 +1,26 @@
+open Core.Std
+open OUnit2
+open Acronym
+
+let ae exp got _test_ctxt =
+  assert_equal exp got ~printer:Fn.id
+
+let tests = [
+  "basic" >::
+    ae "PNG" (acronym "Portable Network Graphics");
+  "lowercase words" >::
+    ae "ROR" (acronym "Ruby on Rails");
+  "camelcase" >::
+    ae "HTML" (acronym "HyperText Markup Language");
+  "punctuation" >::
+    ae "FIFO" (acronym "First In, First Out");
+  "all caps words" >::
+    ae "PHP" (acronym "PHP: Hypertext Preprocessor");
+  "non-acronym all caps word" >::
+    ae "GIMP" (acronym "GNU Image Manipulation Program");
+  "hyphenated" >::
+    ae "CMOS" (acronym "Complementary metal-oxide semiconductor");
+]
+
+let () =
+  run_test_tt_main ("acronym tests" >::: tests)

data/tracks/ocaml/exercises/bowling/bowling.mli

@@ -1,3 +1,5 @@
+open Core.Std
+
 (** Abstract type for the bowling game. *)
 type t
 
@@ -6,7 +8,7 @@ val new_game: t
 
 (** This is called each time the player rolls a ball, with input the number
 of pins knocked down. The return value is the updated state of the game. *)
-val roll : int -> t -> t
+val roll : int -> t -> (t, string) Result.t
 
 (** This is called at the end of a game to retrieve the final score. *)
-val score : t -> int
+val score : t -> (int, string) Result.t

data/tracks/ocaml/exercises/bowling/example.ml

@@ -1,19 +1,59 @@
-open Core.Std
+open! Core.Std
 
-type t = int list
+type t = (int * int list)
 
-(* Calculates a list of the frame scores. t1 is the score for throw 1. *)
-let frame_scores =
-  let is_spare t1 t2 = t1 + t2 = 10 in
-  let rec go acc = function
-    | [t1; t2] -> (t1 + t2) :: acc
-    | [t1; t2; t3] -> (t1 + t2 + t3) :: acc
-    | t1 :: t2 :: t3 :: ts when t1 = 10 -> go (10 + t2 + t3 :: acc) (t2 :: t3 :: ts)
-    | t1 :: t2 :: t3 :: ts when is_spare t1 t2 -> go (10 + t3 :: acc) (t3 :: ts)
-    | t1 :: t2 :: t3 :: ts -> go (t1 + t2 :: acc) (t3 :: ts)
-    | _ -> failwith "this is expected to be unreachable code"
-  in go []
+let numberOfFrames = 10
+let maximumFrameScore = 10
+let minimumFrameScore = 0
 
-let new_game = []
-let roll pins g = pins :: g
-let score g = frame_scores (List.rev g) |> List.fold ~init:0 ~f:(+)
+let new_game = (0, [])
+
+let validatePins pins = match pins with
+| _ when pins < minimumFrameScore -> Error "Negative roll is invalid"
+| _ when pins > maximumFrameScore -> Error "Pin count exceeds pins on the lane"
+| _ -> Ok pins
+
+let isStrike pins = pins = maximumFrameScore
+let isSpare pins1 pins2 = pins1 + pins2 = maximumFrameScore
+
+let rec scoreRolls (totalScore: int) (frame: int) (rolls: int list): (int * ((int, string) Result.t)) = 
+  let isLastFrame = frame = numberOfFrames in
+  let gameFinished = frame = numberOfFrames + 1 in
+  let scoreStrike remainder = 
+    match remainder with
+    | x::y::zs when isLastFrame ->
+      if x + y > 10 && x <> 10 then (frame, Error "Should have a test for this error!")
+      else scoreRolls (totalScore + 10 + x + y) (frame + 1) zs
+    | x::y::zs -> scoreRolls (totalScore + 10 + x + y) (frame + 1) (x::y::zs)
+    | _ -> (frame, Error "Score cannot be taken until the end of the game") in
+  let scoreSpare x y remainder = 
+      match remainder with 
+      | z::zs -> scoreRolls (totalScore + x + y + z) (frame + 1) (if isLastFrame then zs else z::zs)
+      | _ -> (frame, Error "Score cannot be taken until the end of the game") in
+  let scoreNormal x y remainder =
+      match validatePins (x + y) with
+      | Ok z -> scoreRolls (totalScore + z) (frame + 1) remainder
+      | Error e -> (frame, Error e) in
+  match rolls with
+  | [] -> (frame, if gameFinished then Ok totalScore else Error "Score cannot be taken until the end of the game")
+  | x::xs when isStrike x -> scoreStrike xs        
+  | x::y::ys when isSpare x y -> scoreSpare x y ys        
+  | x::y::zs -> scoreNormal x y zs       
+  | _ -> (frame, Error "Score cannot be taken until the end of the game")
+    
+let roll pins (frames, rolls) =
+  if frames >= 10
+  then Error "Cannot roll after game is over"
+  else  
+    match validatePins pins with
+    | Error e -> Error e
+    | Ok _ -> 
+        let rolls = rolls @ [pins] in
+        match scoreRolls 0 0 rolls with
+        | (frames', Error "Score cannot be taken until the end of the game") -> Ok (frames', rolls)
+        | (_, Error e) -> Error e
+        | (frames', Ok _) -> Ok (frames', rolls)
+
+let score (_, frames) = 
+  let (_, score) = scoreRolls 0 1 frames
+  in score

data/tracks/ocaml/exercises/bowling/test.ml

@@ -1,36 +1,141 @@
-open Core.Std
+open! Core.Std
 open OUnit2
-module B = Bowling
+open Bowling
 
-let (>>) = Fn.flip Fn.compose
+type game = Bowling.t
 
-let assert_score e g _test_context =
-  assert_equal ~printer:Int.to_string e (B.new_game |> g |> B.score)
+let to_ok (r: (t, string) Result.t): t = match r with
+| Ok g -> g
+| Error e -> failwith ("should be OK but got Error " ^ e)
 
-let replicate count n =
-  let rec go acc count =
-    if count = 0 then acc
-    else go (n :: acc) (count - 1) in
-  go [] count
-let roll = B.roll
-let roll_many scores game = List.fold ~init:game ~f:(Fn.flip roll) (List.rev scores)
-let roll_spare = roll_many [5;5]
-let roll_strike = roll 10
-let roll_repeatedly (count: int) (score: int) (game: B.t): B.t =
-  roll_many (replicate count score) game
+let set_previous_frames (frames : int list): game =
+  List.fold frames ~init:new_game ~f:(fun g f -> roll f g |> to_ok)
+
+let score_printer = function
+| Ok n -> Int.to_string n
+| Error e -> e
+let assert_score exp game = assert_equal ~printer:score_printer exp (score game)
+
+let roll_printer = function
+| Ok _ -> "Ok <some game>"
+| Error e -> e
+let assert_roll (exp: (t, string) Result.t) (frame: int) (game: game) = 
+  assert_equal ~printer:roll_printer exp (roll frame game)
 
 let tests = [
-  "gutter every frame gives a score of 0" >::
-    assert_score 0 (roll_repeatedly 20 0);
-  "1 pin every frame gives a score of 20" >::
-    assert_score 20 (roll_repeatedly 20 1);
-  "frame score for a spare is 10 plus the number of pins knocked down in the next throw" >::
-    assert_score 16 (roll_spare >> roll 3 >> roll_repeatedly 17 0);
-  "frame score for a strike is 10 plus the number of pins knocked down in the next 2 throws" >::
-    assert_score 24 (roll_strike >> roll_many [3;4] >> roll_repeatedly 16 0);
-  "perfect game" >::
-    assert_score 300 (roll_repeatedly 12 10);
+   "should be able to score a game with all zeros" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 0) g
+   );
+   "should be able to score a game with no strikes or spares" >:: (fun _ ->
+      let g = set_previous_frames [3; 6; 3; 6; 3; 6; 3; 6; 3; 6; 3; 6; 3; 6; 3; 6; 3; 6; 3; 6] in
+      assert_score (Ok 90) g
+   );
+   "a spare followed by zeros is worth ten points" >:: (fun _ ->
+      let g = set_previous_frames [6; 4; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 10) g
+   );
+   "points scored in the roll after a spare are counted twice" >:: (fun _ ->
+      let g = set_previous_frames [6; 4; 3; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 16) g
+   );
+   "consecutive spares each get a one roll bonus" >:: (fun _ ->
+      let g = set_previous_frames [5; 5; 3; 7; 4; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 31) g
+   );
+   "a spare in the last frame gets a one roll bonus that is counted once" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 7; 3; 7] in
+      assert_score (Ok 17) g
+   );
+   "a strike earns ten points in a frame with a single roll" >:: (fun _ ->
+      let g = set_previous_frames [10; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 10) g
+   );
+   "points scored in the two rolls after a strike are counted twice as a bonus" >:: (fun _ ->
+      let g = set_previous_frames [10; 5; 3; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 26) g
+   );
+   "consecutive strikes each get the two roll bonus" >:: (fun _ ->
+      let g = set_previous_frames [10; 10; 10; 5; 3; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_score (Ok 81) g
+   );
+   "a strike in the last frame gets a two roll bonus that is counted once" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 7; 1] in
+      assert_score (Ok 18) g
+   );
+   "rolling a spare with the two roll bonus does not get a bonus roll" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 7; 3] in
+      assert_score (Ok 20) g
+   );
+   "strikes with the two roll bonus do not get bonus rolls" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 10; 10] in
+      assert_score (Ok 30) g
+   );
+   "a strike with the one roll bonus after a spare in the last frame does not get a bonus" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 7; 3; 10] in
+      assert_score (Ok 20) g
+   );
+   "all strikes is a perfect game" >:: (fun _ ->
+      let g = set_previous_frames [10; 10; 10; 10; 10; 10; 10; 10; 10; 10; 10; 10] in
+      assert_score (Ok 300) g
+   );
+   "rolls can not score negative points" >:: (fun _ ->
+      let g = set_previous_frames [] in
+      assert_roll (Error "Negative roll is invalid") (-1) g
+   );
+   "a roll can not score more than 10 points" >:: (fun _ ->
+      let g = set_previous_frames [] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 11 g
+   );
+   "two rolls in a frame can not score more than 10 points" >:: (fun _ ->
+      let g = set_previous_frames [5] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 6 g
+   );
+   "bonus roll after a strike in the last frame can not score more than 10 points" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 11 g
+   );
+   "two bonus rolls after a strike in the last frame can not score more than 10 points" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 5] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 6 g
+   );
+   "two bonus rolls after a strike in the last frame can score more than 10 points if one is a strike" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 10; 6] in
+      assert_score (Ok 26) g
+   );
+   "the second bonus rolls after a strike in the last frame can not be a strike if the first one is not a strike" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 6] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 10 g
+   );
+   "second bonus roll after a strike in the last frame can not score than 10 points" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 10] in
+      assert_roll (Error "Pin count exceeds pins on the lane") 11 g
+   );
+   "an unstarted game can not be scored" >:: (fun _ ->
+      let g = set_previous_frames [] in
+      assert_score (Error "Score cannot be taken until the end of the game") g
+   );
+   "an incomplete game can not be scored" >:: (fun _ ->
+      let g = set_previous_frames [0; 0] in
+      assert_score (Error "Score cannot be taken until the end of the game") g
+   );
+   "cannot roll if game already has ten frames" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0] in
+      assert_roll (Error "Cannot roll after game is over") 0 g
+   );
+   "bonus rolls for a strike in the last frame must be rolled before score can be calculated" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10] in
+      assert_score (Error "Score cannot be taken until the end of the game") g
+   );
+   "both bonus rolls for a strike in the last frame must be rolled before score can be calculated" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 10; 10] in
+      assert_score (Error "Score cannot be taken until the end of the game") g
+   );
+   "bonus roll for a spare in the last frame must be rolled before score can be calculated" >:: (fun _ ->
+      let g = set_previous_frames [0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 0; 7; 3] in
+      assert_score (Error "Score cannot be taken until the end of the game") g
+   );
 ]
 
 let () =
-  run_test_tt_main ("bowling tests" >::: tests)
+  run_test_tt_main ("bowling tests" >::: tests)

data/tracks/ocaml/exercises/dominoes/test.ml

@@ -58,7 +58,7 @@ let tests = [
     assert_chain [(1,2); (2,3); (3,1); (2,4); (2,4)] true;
   "separate loops" >::
     assert_chain [(1,2); (2,3); (3,1); (1,1); (2,2); (3,3)] true;
-  "ten elements" >::
+  "nine elements" >::
     assert_chain [(1,2); (5,3); (3,1); (1,2); (2,4); (1,6); (2,3); (3,4); (5,6)] true;
 ]
 

data/tracks/ocaml/exercises/phone-number/test.ml

@@ -30,8 +30,6 @@ let tests = [
     ae None (number "123-abc-7890");
   "invalid with punctuations" >::
     ae None (number "123-@:!-7890");
-  "invalid with right number of digits but letters mixed in" >::
-    ae None (number "1a2b3c4d5e6f7g8h9i0j");
   "invalid if area code does not start with 2-9" >::
     ae None (number "(123) 456-7890");
   "invalid if exchange code does not start with 2-9" >::

data/tracks/ocaml/tools/test-generator/src/special_cases.ml

@@ -53,6 +53,12 @@ let edit_change_expected (value: json) = match value with
 | `Int (-1) -> "None"
 | _ -> failwith "Bad json value in change"
 
+let edit_bowling_expected (value: json) = match value with
+| `Int n -> "(Ok " ^ (Int.to_string n) ^ ")"
+| `Assoc [(k, v)] -> 
+    if k = "error" then "(Error " ^ json_to_string v ^ ")" else failwith ("Can only handle error value but got " ^ k)
+| _ -> failwith "Bad json value in bowling"
+
 let edit_expected ~(stringify: json -> string) ~(slug: string) ~(value: json) = match slug with
 | "hamming" -> optional_int ~none:(-1) value
 | "all-your-base" -> optional_int_list value
@@ -60,6 +66,7 @@ let edit_expected ~(stringify: json -> string) ~(slug: string) ~(value: json) =
 | "phone-number" -> option_of_null value
 | "connect" -> edit_connect_expected value
 | "change" -> edit_change_expected value
+| "bowling" -> edit_bowling_expected value
 | _ -> stringify value
 
 let edit_say (ps: (string * json) list) =
@@ -91,12 +98,21 @@ let edit_space_age (ps: (string * json) list): (string * string) list =
   | (k, v) -> (k, json_to_string v) in
   List.map ps ~f:edit
   
+let edit_bowling (ps: (string * json) list): (string * string) list =
+  let strip_quotes s = String.drop_prefix s 1 |> Fn.flip String.drop_suffix 1 in
+  let edit = function
+  | ("property", v) -> ("property", json_to_string v |> strip_quotes) 
+  | ("roll", `Int n) -> ("roll", let s = Int.to_string n in if n < 0 then ("(" ^ s ^ ")") else s)
+  | (k, v) -> (k, json_to_string v) in
+  List.map ps ~f:edit
+
 let edit_parameters ~(slug: string) (parameters: (string * json) list) = match (slug, parameters) with
 | ("hello-world", ps) -> default_value ~key:"name" ~value:"None" (optional_strings ~f:(fun _x -> true) parameters)
 | ("say", ps) -> edit_say ps
 | ("all-your-base", ps) -> edit_all_your_base ps
 | ("dominoes", ps) -> edit_dominoes ps
 | ("space-age", ps) -> edit_space_age ps
+| ("bowling", ps) -> edit_bowling ps
 | (_, ps) -> map_elements json_to_string ps
 
 let expected_key_name slug = match slug with

data/tracks/ocaml/tools/test-generator/templates/acronym/template.ml

@@ -0,0 +1,16 @@
+open Core.Std
+open OUnit2
+open Acronym
+
+let ae exp got _test_ctxt =
+  assert_equal exp got ~printer:Fn.id
+
+let tests = [
+(* TEST
+  "$description" >::
+    ae $expected (acronym $phrase);
+   END TEST *)
+]
+
+let () =
+  run_test_tt_main ("acronym tests" >::: tests)

data/tracks/ocaml/tools/test-generator/templates/bowling/template.ml

@@ -0,0 +1,34 @@
+open! Core.Std
+open OUnit2
+open Bowling
+
+type game = Bowling.t
+
+let to_ok = function
+| Ok x -> x
+| Error _ -> failwith "should be OK"
+
+let set_previous_frames (frames : int list): game =
+  List.fold frames ~init:new_game ~f:(fun g f -> roll f g |> to_ok)
+
+let score_printer = function
+| Ok n -> Int.to_string n
+| Error e -> e
+let assert_score exp game = assert_equal ~printer:score_printer exp (score game)
+
+let roll_printer = function
+| Ok _ -> "Ok <some game>"
+| Error e -> e
+let assert_roll exp frame game = assert_equal ~printer:roll_printer exp (roll frame game)
+
+let tests = [
+(* TEST
+   "$description" >:: (fun _ ->
+      let g = set_previous_frames $previous_rolls in
+      assert_$property $expected $roll g
+   );
+   END TEST *)
+]
+
+let () =
+  run_test_tt_main ("bowling tests" >::: tests)