trackler 2.0.8.28 → 2.0.8.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88860310ccc044c6401cd6578337ddc2b13bcbf1
-  data.tar.gz: 2b09ed02e5926183697dafc3d13f8402cf7ee95f
+  metadata.gz: 1e21f79cd25d4f3e7897f3fba2b92b97d5421c2c
+  data.tar.gz: 5d736d15895b6996ba58b26507cb0d25235977bd
 SHA512:
-  metadata.gz: 778a87faf57b3b14f0260da2c758dbb284d88e6b7d4e0befc81426e6724f6147129c19037398b21d85824efe1ab4d7aaa8d8f071695b8f29fda71f8c0a3d99f4
-  data.tar.gz: 0d89dad5d10d0087386d7704eaf9e80255642b039aa0590ac9d61de0e4aca0674f5aecaa2c3934fab785012bdda26fde53bb11eb94ce9d21d02b4c950f9979c1
+  metadata.gz: 94d0844a039d14c39e3da56990983b777c1cecf1a6c1473a3fa64f1b36ccf8ad35afbd5319446b3bd5d3fe13591d74fa6c23bb2ced918f7c0605e2d09bb8d62c
+  data.tar.gz: b86d66e2f9a4ef93b28fe065e69b2e143867bffc3b3fd290712ae1bf22725f83d69697e636475300879f47724e125e0e86d16e82ad03f3cb2397941dd651713f

data/common/CONTRIBUTING.md

@@ -198,7 +198,10 @@ needs to be made in the [exercism/x-common repository](https://github.com/exerci
 not directly to the test suite itself.
 
 Find the JSON file for the problem in question. For example, if you want to change
-the Clock problem, then look for `exercises/clock/canonical-data.json`.
+the Clock problem, then look for `exercises/clock/canonical-data.json`. Each 
+change should also bump the version of the test data. For more information,
+see the [test data versioning](README.md#test-data-versioning) section of the 
+README.
 
 Submit a pull request with the change.
 

data/common/README.md

@@ -111,6 +111,58 @@ There are also some convention about `expected` that you must follow:
     - The string should explain why the error would occur.
     - A particular track's implementation of the exercise **need not** necessarily check that the error includes that exact string as the cause, depending on what is idiomatic in the language (it may not be idiomatic to check strings for error messages).
 
+### Test Data Versioning
+
+Test data should be versioned according to [Semantic Version 2.0](http://semver.org/), which is defined as follows:
+
+> Given a version number MAJOR.MINOR.PATCH, increment the:
+>
+> MAJOR version when you make incompatible API changes,
+> MINOR version when you add functionality in a backwards-compatible manner, and
+> PATCH version when you make backwards-compatible bug fixes.
+> Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.
+
+#### MAJOR version changes
+
+The MAJOR version should be changed when the test suite is modified in a 
+fundamentally incompatible way. 
+
+There are examples of changes requiring a MAJOR version change:
+
+- A new "property" (test type).
+- Renaming a "property".
+- Insertion, deletion or renaming of keys in the test data object.
+- Changing the type of one of the test data keys.
+
+MAJOR changes should be expected to break even well-behaved test generators.
+
+#### MINOR version changes
+
+The MINOR version should change when you add functionality in a backwards-compatible manner, make 
+non-breaking changes that alter the meaning of the test suite, make previously
+passing solutions possibly fail, or failing solutions fail at a different spot.
+
+There are examples of changes requiring a MINOR version change:
+
+- Adding or deleting test cases.
+- Changing the test cases inputs and/or outputs.
+- Changing the test cases ordering.
+
+MINOR changes would never break well-designed test generators, because the test-generation logic remains exactly the same.
+
+#### PATCH version changes
+
+The PATCH version should change when you make backwards-compatible bug fixes or
+ whenever the meaning of the tests does not change.
+
+There are examples of changes requiring a PATCH version change:
+
+- Regrouping/"Renesting" test cases without changing test case ordering.
+- Changing descriptions or comments.
+- Changing keys' ordering or formatting (would result in an equivalent JSON file).    
+
+PATCH changes would never break well-designed test generators, because the test data remains exactly the same.
+
 ## Automated Tests
 
 `canonical-data.json` for each exercise is checked for compliancy against the [canonical-schema.json](canonical-schema.json).

data/lib/trackler/version.rb

@@ -1,3 +1,3 @@
 module Trackler
-  VERSION = "2.0.8.28"
+  VERSION = "2.0.8.29"
 end

data/tracks/ecmascript/config.json

@@ -11,6 +11,7 @@
     "rna-transcription",
     "bob",
     "gigasecond",
+		"perfect-numbers",
     "word-count",
     "pangram",
     "beer-song",
@@ -103,6 +104,12 @@
       "difficulty": 1,
       "topics": [
       ]
+    },
+		{
+      "slug": "perfect-numbers",
+      "difficulty": 1,
+      "topics": [
+      ]
     },
     {
       "slug": "word-count",

data/tracks/ecmascript/exercises/perfect-numbers/example.js

@@ -0,0 +1,68 @@
+
+export default class PerfectNumbers {
+
+  /**
+   * Calculate all the divisors for a given number.
+   * @param {number} number - natural number.
+   * @returns {array} array that contains the divisors for a given number NOT including the number itself.
+   */
+  getDivisors(number) {
+
+    let i;
+    let divs = new Array();
+
+    // Accepts only natural numbers greater than 1.
+    if (number <= 1) {
+      return divs;
+  	}
+
+    // 1 always divides everyone!
+    divs.push(1);
+
+    // Calculate the divisors up the the half of the number + 1
+    for (i = 2; i <= number / 2; i++) {
+
+      if (number % i === 0) {
+        divs.push(i);
+  		}
+    }
+
+    return divs;
+  }
+
+  /**
+   * Classify a given number as perfect, abundant or deficient.
+   * @param {number} number - number to be classified. Note: if the number is equal or smaller than 0,
+   * then returns an error: Classification is only possible for natural numbers.
+   * @returns {string} - string that contains the number classification (perfect, abundant or deficient).
+   */
+  classify(number) {
+
+    let i, sum, result;
+
+    // Check if the input is valid
+    if (number <= 0) {
+      return 'Classification is only possible for natural numbers.';
+    }
+
+    // Factorize the current number.
+    const divsArray = this.getDivisors(number);
+
+    // Sum the factors.
+    sum = divsArray.reduce((sum, div) => sum += div, 0);
+
+    // Check if the number is perfect.
+    if (sum === number) {
+      result = 'perfect';
+    }
+    else if (sum > number) {
+      result = 'abundant';
+    }
+    else {
+      result = 'deficient';
+    }
+
+    return result;
+  }
+
+}

data/tracks/ecmascript/exercises/perfect-numbers/gulpfile.js

@@ -0,0 +1,89 @@
+function getInputDirectory(argv) {
+  if (argv.input) {
+    return argv.input;
+  }
+  return '.';
+}
+
+function getOutputDirectory(argv) {
+  if (argv.output) {
+    return argv.output;
+  }
+  return 'babel-output';
+}
+
+const gulp = require('gulp'),
+  eslint = require('gulp-eslint'),
+  jasmine = require('gulp-jasmine'),
+  babel = require('gulp-babel'),
+  polyfill = require('babel/polyfill'),
+  del = require('del'),
+  argv  = require('yargs').argv,
+  inputDir = getInputDirectory(argv),
+  outputDir = getOutputDirectory(argv);
+
+// Gulp tasks definition
+
+gulp.task('default', [ 'test' ]);
+
+gulp.task('test', [ 'babel' ], function () {
+  return gulp.src([ outputDir + '/*.spec.js' ])
+    .pipe(jasmine());
+});
+
+gulp.task('babel', function () {
+  return gulp.src([ inputDir + '/*.js', inputDir + '/lib/*.js' ])
+    .pipe(babel())
+    .pipe(gulp.dest(outputDir));
+});
+
+gulp.task('lint', function () {
+  return gulp.src([ inputDir + '/*.js' ])
+    .pipe(eslint({
+      envs: [
+        'es6'  //turns on all es6 features except modules
+      ],
+      rules: {
+        // full documentation here : http://eslint.org/docs/rules
+
+        // Possible errors
+        'comma-dangle': [2, 'never'], // don't let a comma at the end of object properties or array element
+        'no-cond-assign': [2, 'always'], // no assignments in conditional statements
+        'no-console': 2,  // no console.log() statements in production code
+        'no-constant-condition': 2, // no constants in conditional statements
+        'no-control-regex': 2,  // no control characters in regex's
+        'no-debugger': 2, // no debugger in productin code
+        'no-dupe-args': 2, // no duplicated arguments in functions
+        'no-dupe-keys': 2, // no duplicated keys when creating object literals
+        'no-duplicate-case': 2, // no duplicated `case` in `switch` statements
+        'no-empty-character-class': 2, // disallow the use of empty character classes in regular expressions
+        'no-empty': 2, // no empty blocks
+        'no-ex-assign': 2, // do not assign any value to an Exception raised
+        'no-extra-boolean-cast': 2, // do not use !!falseExpression to cast to boolean
+        'no-extra-parens': 2,  // do not use extra parenthesis
+        'no-extra-semi': 2,  // do not use extra semicolons
+        'no-func-assign': 2, // do not overwrite variables declared as functions
+        'no-inner-declarations': [2, 'both'], // only declare var's and funct's on function scope
+        'no-invalid-regexp': 2,  // validates string arguments passed to RegExp constructor
+        'no-irregular-whitespace': 2, // detects special characters used as spaces
+        'no-negated-in-lhs': 2,  // do not use negation in the left operand in an `in` expression
+        'no-obj-calls': 2, // prevent calling global objects as if they were functions
+        'no-regex-spaces': 2, // do not use multiple spaces in regex's
+        'no-sparse-arrays': 2, // do not use sparse arrays (empty elements)
+        'no-unexpected-multiline': 2, // Avoid code that looks like two expressions but is actually one
+        'no-unreachable': 2, // detects unreachable statements (after return, throw,...)
+        'use-isnan': 2, // do not compare with `NaN` value, use isNan() instead
+        'valid-jsdoc': 2, // ensure JSDoc comments are valid
+        'valid-typeof': 2 // ensure that the results of typeof are compared against a valid string
+      },
+      ecmaFeatures: {
+        'modules': true  //this gives us modules :)
+      }
+    }))
+    .pipe(eslint.format())
+    .pipe(eslint.failAfterError());
+});
+
+gulp.task('clean', function (cb) {
+  del([ outputDir ], cb);
+});

data/tracks/ecmascript/exercises/perfect-numbers/package.json

@@ -0,0 +1,28 @@
+{
+  "name": "xecmascript",
+  "version": "0.0.0",
+  "description": "Exercism exercises in ECMAScript 6.",
+  "author": "Katrina Owen",
+  "private": true,
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/exercism/xecmascript"
+  },
+  "devDependencies": {
+    "babel": "~5.8.29",
+    "del": "~2.0.2",
+    "gulp": "~3.9.0",
+    "gulp-babel": "~5.3.0",
+    "gulp-eslint": "^1.1.0",
+    "gulp-jasmine": "~2.4.2",
+    "yargs": "~3.27.0"
+  },
+  "scripts": {
+    "test": "gulp test",
+    "lint-test": "gulp lint test"
+  },
+  "licenses": [
+    "MIT"
+  ],
+  "dependencies": {}
+}

data/tracks/ecmascript/exercises/perfect-numbers/perfect-numbers.spec.js

@@ -0,0 +1,75 @@
+import PerfectNumbers from './perfect-numbers';
+
+describe('Exercise - Perfect Numbers', () => {
+
+  const perfectNumbers = new PerfectNumbers();
+
+  describe('Perfect Numbers', () => {
+
+    it('Smallest perfect number is classified correctly', () => {
+      expect(perfectNumbers.classify(6)).toEqual('perfect');
+    });
+
+    it('Medium perfect number is classified correctly', () => {
+      expect(perfectNumbers.classify(28)).toEqual('perfect');
+    });
+
+    it('Large perfect number is classified correctly', () => {
+      expect(perfectNumbers.classify(33550336)).toEqual('perfect');
+    });
+
+  });
+
+  describe('Abundant Numbers', () => {
+
+    it('Smallest abundant number is classified correctly', () => {
+      expect(perfectNumbers.classify(12)).toEqual('abundant');
+    });
+
+    it('Medium abundant number is classified correctly', () => {
+      expect(perfectNumbers.classify(30)).toEqual('abundant');
+    });
+
+    it('Large abundant number is classified correctly', () => {
+      expect(perfectNumbers.classify(33550335)).toEqual('abundant');
+    });
+
+  });
+
+  describe('Deficient Numbers', () => {
+
+    it('Smallest prime deficient number is classified correctly', () => {
+      expect(perfectNumbers.classify(2)).toEqual('deficient');
+    });
+
+    it('Smallest non-prime deficient number is classified correctly', () => {
+      expect(perfectNumbers.classify(4)).toEqual('deficient');
+    });
+
+    it('Medium deficient number is classified correctly', () => {
+      expect(perfectNumbers.classify(32)).toEqual('deficient');
+    });
+
+    it('Large deficient number is classified correctly', () => {
+      expect(perfectNumbers.classify(33550337)).toEqual('deficient');
+    });
+
+    it('Edge case (no factors other than itself) is classified correctly', () => {
+      expect(perfectNumbers.classify(1)).toEqual('deficient');
+    });
+
+  });
+
+  describe('Invalid Inputs', () => {
+
+    it('Zero is rejected (not a natural number)', () => {
+      expect(perfectNumbers.classify(0)).toEqual('Classification is only possible for natural numbers.');
+    });
+
+    it('Negative integer is rejected (not a natural number)', () => {
+      expect(perfectNumbers.classify(-1)).toEqual('Classification is only possible for natural numbers.');
+    });
+
+  });
+
+});

data/tracks/erlang/exercises/accumulate/src/accumulate.app.src

@@ -1,6 +1,6 @@
 {application, accumulate,
   [{description, "exercism.io - accumulate"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/all-your-base/src/all_your_base.app.src

@@ -1,6 +1,6 @@
 {application, all_your_base,
   [{description, "exercism.io - all-your-base"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/allergies/src/allergies.app.src

@@ -1,6 +1,6 @@
 {application, allergies,
   [{description, "exercism.io - allergies"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/anagram/src/anagram.app.src

@@ -1,6 +1,6 @@
 {application, anagram,
   [{description, "exercism.io - anagram"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/atbash-cipher/src/atbash_cipher.app.src

@@ -1,6 +1,6 @@
 {application, atbash_cipher,
   [{description, "exercism.io - atbash-cipher"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/bank-account/src/bank_account.app.src

@@ -1,6 +1,6 @@
 {application, bank_account,
   [{description, "exercism.io - bank-account"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/beer-song/src/beer_song.app.src

@@ -1,6 +1,6 @@
 {application, beer_song,
   [{description, "exercism.io - beer-song"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,

data/tracks/erlang/exercises/bob/src/bob.app.src

@@ -1,6 +1,6 @@
 {application, bob,
   [{description, "exercism.io - bob"},
-    {vsn, "git"},
+    {vsn, "0.0.1"},
     {modules, []},
     {registered, []},
     {applications, [kernel,