trackler 2.0.3.0 → 2.0.3.1

data/tracks/python/exercises/raindrops/raindrops_test.py

@@ -52,5 +52,6 @@ class RaindropsTest(unittest.TestCase):
     def test_12121(self):
         self.assertEqual("12121", raindrops(12121))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/rectangles/rectangles_count_test.py

@@ -68,5 +68,6 @@ class WordTest(unittest.TestCase):
                  ]
         assert 2 == count(lines)
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/robot-simulator/robot_simulator_test.py

@@ -69,5 +69,6 @@ class RobotTests(unittest.TestCase):
         self.assertEqual((11, 5), robot.coordinates)
         self.assertEqual(NORTH, robot.bearing)
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/roman-numerals/roman_numerals_test.py

@@ -29,5 +29,6 @@ class RomanTest(unittest.TestCase):
         for arabic, numeral in self.numerals.items():
             self.assertEqual(numeral, roman_numerals.numeral(arabic))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/run-length-encoding/run_length_test.py

@@ -33,5 +33,6 @@ class WordCountTests(unittest.TestCase):
     def test_decode_unicode(self):
         self.assertMultiLineEqual('⏰⚽⚽⚽⭐⭐⏰', decode('⏰3⚽2⭐⏰'))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/say/say_test.py

@@ -65,5 +65,6 @@ class SayTest(unittest.TestCase):
                          "one hundred and twenty-three",
                          say(987654321123))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/scrabble-score/scrabble_score_test.py

@@ -25,5 +25,6 @@ class WordTest(unittest.TestCase):
     def test_scores_are_case_insensitive(self):
         self.assertEqual(41, score("OxyphenButazone"))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/sieve/sieve_test.py

@@ -29,5 +29,6 @@ class SieveTest(unittest.TestCase):
                     953, 967, 971, 977, 983, 991, 997]
         self.assertEqual(expected, sieve(1000))
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/space-age/space_age_test.py

@@ -47,5 +47,6 @@ class SpaceAgeTest(unittest.TestCase):
         self.assertEqual(260.16, age.on_earth())
         self.assertEqual(1.58, age.on_neptune())
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/triangle/triangle_test.py

@@ -63,5 +63,6 @@ class TriangleTests(unittest.TestCase):
             Triangle, 7, 3, 2
         )
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/exercises/word-count/word_count_test.py

@@ -84,5 +84,6 @@ class WordCountTests(unittest.TestCase):
             word_count('до🖖свидания!')
         )
 
+
 if __name__ == '__main__':
     unittest.main()

data/tracks/python/requirements-travis.txt

@@ -1,3 +1,3 @@
-flake8>=3.0,<3.0.99
+flake8>=3.2,<3.2.99
 pep8>=1.7,<1.7.99
 pyflakes>=1.3,<1.3.99

data/tracks/ruby/docs/24pullrequests.md

@@ -0,0 +1,21 @@
+## 24 Pull Requests for Exercism - Ruby Edition!
+
+We are welcoming contributors to the project.
+
+Look for the following labels in our issue list:
+
+* first-timers only
+* good first patch
+* bug
+* enhancement
+
+Or notice something to contribute?  Documentation not quite up to par?
+Something missing?  Submitting and reviewing exercises on Exercism and
+notice something you don't like?  Create a pull request!
+
+Or notice something to contribute?  Documentation not quite up to par?
+Something missing?  Create a pull request!
+
+Check out the [Getting Involved in a Track](https://github.com/exercism/exercism.io/blob/master/docs/getting-involved-in-a-track.md) documentation, and some [ideas for things we are looking for](http://exercism.io/languages/ruby/todo) for exercises that are needed to be implemented.
+
+We are available to answer questions in the  [![Join the chat at https://gitter.im/exercism/xruby](https://badges.gitter.im/exercism/xruby.svg)](https://gitter.im/exercism/xruby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge).

data/tracks/ruby/exercises/bowling/.version

@@ -1 +1 @@
-2
+3

data/tracks/ruby/exercises/bowling/bowling_test.rb

@@ -3,8 +3,8 @@ gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'bowling'
 
-# Test data version:
-# 0a51cfc
+# Test data version: c59c2c4
+#
 class BowlingTest < Minitest::Test
   def setup
     @game = Game.new
@@ -50,7 +50,7 @@ class BowlingTest < Minitest::Test
     assert_equal 17, @game.score
   end
 
-  def test_a_strike_earns_ten_points_in_frame_with_a_single_roll
+  def test_a_strike_earns_ten_points_in_a_frame_with_a_single_roll
     skip
     roll([10, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
     assert_equal 10, @game.score
@@ -100,7 +100,7 @@ class BowlingTest < Minitest::Test
 
   def test_rolls_can_not_score_negative_points
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([-1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
       @game.score
     end
@@ -108,7 +108,7 @@ class BowlingTest < Minitest::Test
 
   def test_a_roll_can_not_score_more_than_10_points
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([11, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
       @game.score
     end
@@ -116,23 +116,53 @@ class BowlingTest < Minitest::Test
 
   def test_two_rolls_in_a_frame_can_not_score_more_than_10_points
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([5, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
       @game.score
     end
   end
 
+  def test_bonus_roll_after_a_strike_in_the_last_frame_can_not_score_more_than_10_points
+    skip
+    assert_raises Game::BowlingError do
+      roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 11])
+      @game.score
+    end
+  end
+
   def test_two_bonus_rolls_after_a_strike_in_the_last_frame_can_not_score_more_than_10_points
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 5, 6])
       @game.score
     end
   end
 
+  def test_two_bonus_rolls_after_a_strike_in_the_last_frame_can_score_more_than_10_points_if_one_is_a_strike
+    skip
+    roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 10, 6])
+    assert_equal 26, @game.score
+  end
+
+  def test_the_second_bonus_rolls_after_a_strike_in_the_last_frame_can_not_be_a_strike_if_the_first_one_is_not_a_strike
+    skip
+    assert_raises Game::BowlingError do
+      roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 6, 10])
+      @game.score
+    end
+  end
+
+  def test_second_bonus_roll_after_a_strike_in_the_last_frame_can_not_score_than_10_points
+    skip
+    assert_raises Game::BowlingError do
+      roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 10, 11])
+      @game.score
+    end
+  end
+
   def test_an_unstarted_game_can_not_be_scored
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([])
       @game.score
     end
@@ -140,7 +170,7 @@ class BowlingTest < Minitest::Test
 
   def test_an_incomplete_game_can_not_be_scored
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0])
       @game.score
     end
@@ -148,7 +178,7 @@ class BowlingTest < Minitest::Test
 
   def test_a_game_with_more_than_ten_frames_can_not_be_scored
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
       @game.score
     end
@@ -156,7 +186,7 @@ class BowlingTest < Minitest::Test
 
   def test_bonus_rolls_for_a_strike_in_the_last_frame_must_be_rolled_before_score_can_be_calculated
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10])
       @game.score
     end
@@ -164,7 +194,7 @@ class BowlingTest < Minitest::Test
 
   def test_both_bonus_rolls_for_a_strike_in_the_last_frame_must_be_rolled_before_score_can_be_calculated
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 10, 10])
       @game.score
     end
@@ -172,7 +202,7 @@ class BowlingTest < Minitest::Test
 
   def test_bonus_roll_for_a_spare_in_the_last_frame_must_be_rolled_before_score_can_be_calculated
     skip
-    assert_raises StandardError do
+    assert_raises Game::BowlingError do
       roll([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 7, 3])
       @game.score
     end
@@ -194,9 +224,8 @@ class BowlingTest < Minitest::Test
   #
   # If you are curious, read more about constants on RubyDoc:
   # http://ruby-doc.org/docs/ruby-doc-bundle/UsersGuide/rg/constants.html
-
   def test_bookkeeping
     skip
-    assert_equal 2, BookKeeping::VERSION
+    assert_equal 3, BookKeeping::VERSION
   end
 end

data/tracks/ruby/exercises/bowling/example.rb

@@ -1,11 +1,16 @@
 module BookKeeping
-  VERSION = 2
+  VERSION = 3
 end
 
 class Game
   PINS = { MIN: 0, MAX: 10 }.freeze
   at_exit { public :roll, :score }
 
+
+  class BowlingError < StandardError; end
+  class RollError < BowlingError; end
+  class GameError < BowlingError; end
+
   private
 
   def initialize
@@ -20,9 +25,9 @@ class Game
   end
 
   def validate(pins)
-    raise StandardError, 'Invalid number of pins' unless (PINS[:MIN]..PINS[:MAX]).cover?(pins)
-    raise StandardError, 'Too many pins in frame' unless valid_frame?(pins)
-    raise StandardError, 'Game is over, no rolls allowed' if game_complete?
+    raise RollError, 'Invalid number of pins' unless (PINS[:MIN]..PINS[:MAX]).cover?(pins)
+    raise RollError, 'Too many pins in frame' unless valid_frame?(pins)
+    raise GameError, 'Game is over, no rolls allowed' if game_complete?
   end
 
   def valid_frame?(pins)
@@ -33,7 +38,7 @@ class Game
   end
 
   def score
-    raise StandardError, 'Score unavailable until end of the game' unless game_complete?
+    raise GameError, 'Score unavailable until end of the game' unless game_complete?
     @score_card.values.map.with_index(1) do |f, i|
       score_frame(f, i)
     end.reduce(:+)

data/tracks/ruby/exercises/bowling/example.tt

@@ -3,8 +3,8 @@ gem 'minitest', '>= 5.0.0'
 require 'minitest/autorun'
 require_relative 'bowling'
 
-# Test data version:
-# <%= sha1 %>
+# Test data version: <%= sha1 %>
+#
 class BowlingTest < Minitest::Test
   def setup
     @game = Game.new
@@ -13,11 +13,13 @@ class BowlingTest < Minitest::Test
   def roll(rolls)
     rolls.each { |pins| @game.roll(pins) }
   end
+
 <% test_cases.each do |test_case| %>
   def <%= test_case.test_name %>
     <%= test_case.skipped %>
     <%= test_case.work_load %>
   end
+
 <% end %>
 <%= IO.read(XRUBY_LIB + '/bookkeeping.md') %>
   def test_bookkeeping

data/tracks/ruby/lib/bowling_cases.rb

@@ -20,7 +20,7 @@ class BowlingCase < OpenStruct
   def assert
     if assert_error?
       [
-        'assert_raises StandardError do',
+        'assert_raises Game::BowlingError do',
         "  #{roll}",
         '  @game.score',
         'end'

data/tracks/scala/exercises/bank-account/HINTS.md

@@ -0,0 +1,11 @@
+## Hints
+
+This exercise is testing mutable state that can be accessed saftely from multiple threads. Scala provides a variety of ways to protect 
+mutable state. For developers familiar with Java concurrency, Scala can utilize the Java concurrency support such as the Java synchronized block.
+
+### Common Pitfalls
+
+In Scala there are two ways to achieve mutable state: Use a "var" or a mutable object.
+Two common mistakes here are:
+- Do not use a "var" that is also a mutable object. One is enough, but not both together.
+- Don't expose the "var" or mutable object to the outside world. So make them "private" and change the mutable object into immutable before you return it as a value.

data/tracks/scala/exercises/bank-account/example.scala

@@ -23,8 +23,6 @@ protected case class Account(var balance: Option[Int] = Some(0)) extends BankAcc
   }
 }
 
-object BankAccount {
-  def apply(): BankAccount = Account()
+object Bank {
+  def openAccount(): BankAccount = Account()
 }
-
-

data/tracks/scala/exercises/bank-account/src/main/scala/BankAccount.scala

@@ -0,0 +1,13 @@
+trait BankAccount {
+
+  def closeAccount(): Unit
+
+  def getBalance: Option[Int]
+
+  def incrementBalance(increment: Int): Option[Int]
+}
+
+object Bank {
+  def openAccount(): BankAccount = ???
+}
+

data/tracks/scala/exercises/bank-account/src/test/scala/BankAccountTest.scala

@@ -3,12 +3,12 @@ import org.scalatest.{Matchers, FunSuite}
 
 class BankAccountTest extends FunSuite with Matchers with Conductors with IntegrationPatience {
   test("open account") {
-    BankAccount().getBalance should be (Some(0))
+    Bank.openAccount().getBalance should be (Some(0))
   }
 
   test("incrementing and checking balance") {
     pending
-    val acct = BankAccount()
+    val acct = Bank.openAccount()
     acct.getBalance should be (Some(0))
     acct.incrementBalance(10) should be (Some(10))
     acct.getBalance should be (Some(10))
@@ -18,7 +18,7 @@ class BankAccountTest extends FunSuite with Matchers with Conductors with Integr
 
   test("closed account should hold no balance") {
     pending
-    val acct = BankAccount()
+    val acct = Bank.openAccount()
     acct.closeAccount()
     acct.incrementBalance(10)
     acct.incrementBalance(10)
@@ -30,7 +30,7 @@ class BankAccountTest extends FunSuite with Matchers with Conductors with Integr
     val conductor = new Conductor
     import conductor._
 
-    val acct = BankAccount()
+    val acct = Bank.openAccount()
 
     thread("t1") {
       acct.incrementBalance(10)
@@ -54,7 +54,7 @@ class BankAccountTest extends FunSuite with Matchers with Conductors with Integr
     val conductor = new Conductor
     import conductor._
 
-    val acct = BankAccount()
+    val acct = Bank.openAccount()
 
     thread("t1") {
       for (a <- 1 to 10)

data/tracks/scala/exercises/hamming/HINTS.md

@@ -0,0 +1,57 @@
+## Hints
+`Option` is used to indicate a computation that may possibly have no useful result
+(for example due to an error or invalid input).
+If you are unfamiliar with `Option` you may read [this tutorial](http://danielwestheide.com/blog/2012/12/19/the-neophytes-guide-to-scala-part-5-the-option-type.html).
+`Option` is a so-called [Monad](https://en.wikipedia.org/wiki/Monad_(functional_programming)) which covers a "computational aspect", in this case possible absence of a value.
+Proper use of Monads can result in very concise yet elegant
+and readable code. Improper use can easily result in the contrary.
+Watch [this video](https://www.youtube.com/watch?v=Mw_Jnn_Y5iA) to learn more.
+#### Common pitfalls that you should avoid
+There are a few rules of thumbs for `Option`:
+1. If you don't need it don't use it. Instead of
+```scala
+def add1(x: Int): Option[Int] = Some(x + 1)
+```
+better have
+```scala
+def add1(x: Int): Int = x + 1
+```
+(there is `Option.map` to apply such simple functions,
+so you don't have to clutter them with `Option`).
+2. Don't "unwrap" if you don't really need to.
+Often there are built-in functions for your purpose. Indicators of premature
+unwrapping are `isDefined/isEmpty` or pattern matching. Instead of
+```scala
+val x: Option[Int] = ...
+
+if (x.isDefined) x.get + 1 else 0
+// or
+x match {
+  case Some(n) => n + 1
+  case None => 0
+}
+```
+better have
+```scala
+x map (_ + 1) getOrElse 0
+```
+3. Monads can be used inside a for-comprehension FTW.
+This is advisable when you want to "compose" several `Option` instances. Instead of
+```scala
+val xo: Option[Int] = ...
+val yo: Option[Int] = ...
+val zo: Option[Int] = ...
+
+xo.flatMap(x =>
+  yo.flatMap(y =>
+    zo.map(z =>
+	  x + y + z)))
+```
+better have
+```scala
+for {
+  x <- xo
+  y <- yo
+  z <- zo
+} yield x + y + z
+```