tracco 0.0.11 → 0.0.12

data/CHANGELOG

@@ -1,3 +1,7 @@
+0.0.12
+  - Adding a TrackedCard#trello_notifications to fetch all the notifications belonging to the card
+  - Introducing FactoryGirl as a factory gem to simplify specs
+
 0.0.11
   - Adding a TrackedCard.all_tracked_cards method to fetch all cards with a valid tracking. Moreover, sorting_options can be passed to sort using a method e.g. TrackedCard.all_tracked_cards(:method => :name, :order => :desc)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    tracco (0.0.11)
+    tracco (0.0.12)
       bson_ext
       chronic
       google_drive
@@ -35,6 +35,8 @@ GEM
       debugger-ruby_core_source (>= 1.1.1)
     debugger-ruby_core_source (1.1.8)
     diff-lcs (1.1.3)
+    factory_girl (4.2.0)
+      activesupport (>= 3.0.0)
     faraday (0.8.5)
       multipart-post (~> 1.1)
     google_drive (0.3.3)
@@ -102,6 +104,7 @@ PLATFORMS
 DEPENDENCIES
   database_cleaner
   debugger
+  factory_girl
   mongoid-rspec
   rake
   rspec

data/lib/tracco/tracked_card.rb

@@ -41,6 +41,12 @@ class TrackedCard
     sorting_options[:order] == :desc ? cards.reverse : cards
   end
 
+  def self.build_from(trello_card)
+    trello_card_id = trello_card.id
+    trello_card.attributes.delete(:id)
+    new(trello_card.attributes.merge(trello_id: trello_card_id))
+  end
+
   def status
     if done?
       :done
@@ -51,12 +57,6 @@ class TrackedCard
     end
   end
 
-  def self.build_from(trello_card)
-    trello_card_id = trello_card.id
-    trello_card.attributes.delete(:id)
-    new(trello_card.attributes.merge(trello_id: trello_card_id))
-  end
-
   def add(tracking)
     tracking.add_to(self)
   end
@@ -116,6 +116,11 @@ class TrackedCard
     estimate_errors
   end
 
+  def trello_notifications
+    notification_ids = efforts.map(&:tracking_notification_id) | estimates.map(&:tracking_notification_id)
+    notification_ids.map { |each_id| Trello::Notification.find(each_id) }.sort_by(&:date)
+  end
+
   def to_s
     "[#{name}]. Total effort: #{total_effort}h. Estimates #{estimates.map(&:to_s)}. Efforts: #{efforts.map(&:to_s)}"
   end

data/lib/tracco/version.rb

@@ -1,3 +1,3 @@
 class TrelloEffortTracker
-  VERSION = '0.0.11'
+  VERSION = '0.0.12'
 end

data/spec/factories/tracked_card_factory.rb

@@ -0,0 +1,13 @@
+FactoryGirl.define do
+  factory :tracked_card do
+    sequence(:name) { |n| "any_card_#{n}" }
+    description "any description"
+    sequence(:short_id, 1000) { |n| n }
+    sequence(:trello_id, 100000) { |n| "xyz#{n}" }
+    done false
+    closed false
+
+    # embeds_many :estimates
+    # embeds_many :efforts
+  end
+end

data/spec/spec_helper.rb

@@ -18,12 +18,16 @@ Bundler.require(:spec)
 
 require 'tracco'
 
+require 'factory_girl'
+FactoryGirl.find_definitions
+
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |configuration|
   configuration.include Mongoid::Matchers
+  configuration.include FactoryGirl::Syntax::Methods # Repeating "FactoryGirl" is too verbose for me...
 end
 
 # force test env for the mongodb configuration

data/spec/tracked_card_spec.rb

@@ -6,7 +6,7 @@ describe TrackedCard do
     Date.stub(:today).and_return(Date.parse("2012-11-05"))
   end
 
-  subject(:card) { TrackedCard.new(name: "any", short_id: 1234, trello_id: "123123") }
+  subject(:card) { build(:tracked_card) }
 
   %w{piero tommaso michele}.each do |username|
     let(username.to_sym) { Member.new(username: username) }
@@ -32,8 +32,8 @@ describe TrackedCard do
 
   describe ".find_by_trello_id" do
     it "finds a card given its Trello id" do
-      card = TrackedCard.create(name: "any card", short_id: 1234, trello_id: "1")
-      another_card = TrackedCard.create(name: "another card", short_id: 3456, trello_id: "2")
+      card = create(:tracked_card, trello_id: "1")
+      another_card = create(:tracked_card, trello_id: "2")
 
       TrackedCard.find_by_trello_id("1").should == card
       TrackedCard.find_by_trello_id("3").should == nil
@@ -42,57 +42,53 @@ describe TrackedCard do
 
   describe ".all_tracked_cards" do
     it "finds all tracked cards with a valid tracking" do
-      card = TrackedCard.create(name: "any card", short_id: 1234, trello_id: "1")
-      card.estimates << Estimate.new(amount: 5, date: Date.today)
-      card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
-
-      card_without_tracking = TrackedCard.create(name: "another card", short_id: 3456, trello_id: "2")
+      # TODO introduce a factory on estimate and effort
+      card = create(:tracked_card, :estimates => [Estimate.new(amount: 5, date: Date.today)],
+                                   :efforts => [Effort.new(amount: 3, date: Date.today, members: [piero])])
+      card_without_tracking = create(:tracked_card)
 
 
       TrackedCard.all_tracked_cards.should == [card]
     end
 
     it "optionally sorts the cards using a given sorting method" do
-      # TODO introduce a factory (fabricator?)
-      card = TrackedCard.create(name: "AAA", short_id: 1234, trello_id: "1")
+      card = create(:tracked_card, name: "AAA")
       card.estimates << Estimate.new(amount: 5, date: Date.today)
       card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      another_card = TrackedCard.create(name: "ZZZ", short_id: 1235, trello_id: "2")
+      another_card = create(:tracked_card, name: "ZZZ")
       another_card.estimates << Estimate.new(amount: 5, date: Date.today)
       another_card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      card_without_tracking = TrackedCard.create(name: "another card", short_id: 3456, trello_id: "2")
+      card_without_tracking = create(:tracked_card)
 
       TrackedCard.all_tracked_cards(:method => :name).should == [card, another_card]
     end
 
     it "applies an optional sorting order" do
-      # TODO introduce a factory (fabricator?)
-      card = TrackedCard.create(name: "AAA", short_id: 1234, trello_id: "1")
+      card = create(:tracked_card, name: "AAA")
       card.estimates << Estimate.new(amount: 5, date: Date.today)
       card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      another_card = TrackedCard.create(name: "ZZZ", short_id: 1235, trello_id: "2")
+      another_card = create(:tracked_card, name: "ZZZ")
       another_card.estimates << Estimate.new(amount: 5, date: Date.today)
       another_card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      card_without_tracking = TrackedCard.create(name: "another card", short_id: 3456, trello_id: "2")
+      card_without_tracking = create(:tracked_card)
 
       TrackedCard.all_tracked_cards(:method => :name, :order => :desc).should == [another_card, card]
     end
 
     it "uses the ascending order as default sorting order option" do
-      # TODO introduce a factory (fabricator?)
-      card = TrackedCard.create(name: "AAA", short_id: 44, trello_id: "100")
+      card = create(:tracked_card, name: "AAA", short_id: 44)
       card.estimates << Estimate.new(amount: 5, date: Date.today)
       card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      another_card = TrackedCard.create(name: "ZZZ", short_id: 12, trello_id: "200")
+      another_card = create(:tracked_card, name: "ZZZ", short_id: 12)
       another_card.estimates << Estimate.new(amount: 5, date: Date.today)
       another_card.efforts << Effort.new(amount: 3, date: Date.today, members: [piero])
 
-      card_without_tracking = TrackedCard.create(name: "another card", short_id: 3456, trello_id: "2")
+      card_without_tracking = create(:tracked_card, short_id: 3456)
 
       TrackedCard.all_tracked_cards(:method => :short_id).should == [another_card, card]
     end
@@ -116,7 +112,7 @@ describe TrackedCard do
     end
 
     it "updates an existing tracked card on a given trello card" do
-      existing_card = TrackedCard.create(name: "an old name", short_id: 1234, trello_id: trello_card.id)
+      existing_card = create(:tracked_card, name: "an old name", trello_id: trello_card.id)
 
       updated_card = TrackedCard.update_or_create_with(trello_card)
 
@@ -185,6 +181,20 @@ describe TrackedCard do
     card.efforts.should have(2).efforts
   end
 
+  describe "#trello_notifications" do
+    let(:first_notification)   { stub("notification1", date: Date.yesterday) }
+    let(:second_notification)  { stub("notification1", date: Date.today)     }
+
+    it "fetch all the card notifications from trello" do
+      card.estimates << Estimate.new(tracking_notification_id: "xyz987", amount: 5, date: Date.yesterday)
+      card.efforts << Effort.new(tracking_notification_id: "abc123", amount: 3, date: Date.today, members: [piero])
+
+      Trello::Notification.should_receive(:find).with("xyz987").and_return(second_notification)
+      Trello::Notification.should_receive(:find).with("abc123").and_return(first_notification)
+      card.trello_notifications.should == [first_notification, second_notification]
+    end
+  end
+
   describe "equality" do
     it "is equal to another TrelloCard when the trello id is the same" do
       card          = TrackedCard.new(name: "a name", trello_id: "123456789")

data/tracco.gemspec

@@ -37,5 +37,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec-mocks'
   gem.add_development_dependency 'mongoid-rspec'
   gem.add_development_dependency 'database_cleaner'
+  gem.add_development_dependency 'factory_girl'
   gem.add_development_dependency 'debugger'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tracco
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-19 00:00:00.000000000 Z
+date: 2013-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
@@ -203,6 +203,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: factory_girl
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: debugger
   requirement: !ruby/object:Gem::Requirement
@@ -268,6 +284,7 @@ files:
 - script/mate.sh
 - spec/effort_spec.rb
 - spec/estimate_spec.rb
+- spec/factories/tracked_card_factory.rb
 - spec/integration/trello_authorization_spec.rb
 - spec/integration/trello_tracker_spec.rb
 - spec/member_spec.rb
@@ -298,7 +315,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 961343114344696159
+      hash: 2200448488814002736
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: