tp_record_optimistic 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18b8156926d15c46a8ffdc916f1b093cf50c9aeb
-  data.tar.gz: 46322a6464c78088d2aff604926e12d7307f6f7e
+  metadata.gz: 8e3a91e2f76f9fc5def099fb8a6112397ec969d0
+  data.tar.gz: 65c9294bc994f082bbc58e1e53eed20f39193486
 SHA512:
-  metadata.gz: 8e76fbe00a06098a7117b18dc78b1119cbe37ba50baa8ae706e2baf498db5ff958aa6876ad8dcb19c9e1527fa483168afca19f9bebc34308ad5c0618793a4abd
-  data.tar.gz: e10d80cad8300d6e21836d4ab1b9288cc05bc6b6fe18358749322db748b0bb2953c1f42239ac04b6b7f33545e04c448d3987bd2af0207a9311db02512ac05be3
+  metadata.gz: 023f3eb1706c52918c8e5dd257d216c7f280756cf1002ba4d7d29b3da633f81a5bc6d6aa234e2b3b176f296b624b6d08f345d94c260d3b064d3643a66d048e52
+  data.tar.gz: 8b78f5bc293a870caeb1b9c166e3f528c7358799376e113789d76698c6a74a4536e583e4e7fca14ba82c3d9bf0132f60583c4512e1f118ebb90e7060c324d184

data/README.rdoc

@@ -1,20 +1,33 @@
-= TPOptimistic
+= TP optimistic lock
 
-This gem improve the ActiveRecord to trate ActiveRecord::RecordNotUnique with optimistic behavior
+This gem extends ActiveRecord to handle ActiveRecord::RecordNotUnique with an optimistic behavior.
+If a uniqueness violation is triggered by the database, it will be returned through the `errors` method.
+
+The purpose is to be more performative and assertive than `validates_uniqueness_of`, a Rails pessimistic instruction for handling uniqueness.
+
+`validates_uniqueness_of` performs a select query for each new insert to check unicity.
+`validates_uniqueness_of` doesn't work very well in an environment with high concurrency. The select and insert are atomic operations, so some attempts of insert the same record twice happens witha  high frequency.
+
+
+example:
+```
+  class Foo < ActiveRecord::Base
+    acts_as_unique #
+  end
 
-exemplo:
 
   def sample
     Bar.create(uuid: '5ea880de-e4ce-4770-8d10-c89bac181e40', other: 'bla bla')
     bar = Bar.create(uuid: '5ea880de-e4ce-4770-8d10-c89bac181e40', other: 'bla bla')
     
-    #UNIQUE constraint failed
+    #error returned: UNIQUE constraint failed
     bar.errors
   end
 
 
   def other_sample
     Bar.create!(uuid: '5ea880de-e4ce-4770-8d10-c89bac181e40', other: 'bla bla')
-    #ActiveRecord::RecordInvalid UNIQUE constraint failed
+    
+    #error raised: ActiveRecord::RecordInvalid UNIQUE constraint failed
     Bar.create!(uuid: '5ea880de-e4ce-4770-8d10-c89bac181e40', other: 'bla bla')
   end

data/config/initializers/inflections.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
 ActiveSupport::Inflector.inflections(:en) do |inflect|
   inflect.acronym 'TP'
+  inflect.acronym 'SQL'
 end

data/lib/tp_record_optimistic/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module TPRecordOptimistic
-  VERSION = '0.2.0'
+  VERSION = '0.2.2'
 end

data/lib/tp_record_optimistic.rb

@@ -1,9 +1,21 @@
 # frozen_string_literal: true
 require 'active_record' unless defined? ActiveRecord
-# require 'active_model' unless defined? ActiveModel
+
+module SQLErrorParse
+  def unique_errors(error)
+    table = self.class.table_name
+    split_key = /(INSERT|UPDATE)/
+    especific_key = %w(UNIQUE constraint failed: SQLite3::ConstraintException:)
+    error.split(split_key)[0].split
+         .reject { |e| especific_key.include? e }
+         .map { |e| e.sub("#{table}.", '').delete(':') }
+         .map(&:to_sym)
+  end
+end
 
 module TPRecordOptimistic
   extend ActiveSupport::Concern
+  include SQLErrorParse
 
   def save(*args)
     super(*args)
@@ -14,7 +26,9 @@ module TPRecordOptimistic
   def save_optimistic(*args)
     old_save(*args)
   rescue ActiveRecord::RecordNotUnique => e
-    errors.add('all', e.to_s)
+    unique_errors(e.to_s).each do |field|
+      errors.add(field, :Unique, message: "UNIQUE constraint failed #{field}")
+    end
     return false
   end
 
@@ -30,10 +44,6 @@ module TPRecordOptimistic
     errors.add('all', e.to_s)
     raise ActiveRecord::RecordInvalid, self
   end
-
-  # def optimistic_unique
-  #   alias_method :save, :save_optimistic
-  # end
 end
 
 ActiveSupport.on_load(:active_record) do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tp_record_optimistic
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Fabricio Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-16 00:00:00.000000000 Z
+date: 2023-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -180,7 +180,7 @@ dependencies:
         version: '2.7'
 description: 
 email:
-- fabricio.oliveira@m4u.com.br
+- fabricioque@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -194,7 +194,7 @@ files:
 - lib/tp_record_optimistic.rb
 - lib/tp_record_optimistic/engine.rb
 - lib/tp_record_optimistic/version.rb
-homepage: https://github.com/fabricio-oliveira/tp_optimistic-uuid
+homepage: https://github.com/fabricio-oliveira/tp_optimistic_lock
 licenses:
 - MIT
 metadata: {}
@@ -217,5 +217,5 @@ rubyforge_project:
 rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
-summary: gem thas implement optimistic uuid
+summary: gem that implement optimistic lock using unicity restriction from database
 test_files: []