tork 17.0.0 → 17.0.1

data/HISTORY.markdown

@@ -1,8 +1,28 @@
+------------------------------------------------------------------------------
+Version 17.0.1 (2012-01-29)
+------------------------------------------------------------------------------
+
+Corrections:
+
+  * tork-herald(1) *sometimes* reported changed test files twice.
+
+  * tork/driver: only whole test file runs should qualify as pass.
+
+  * tork/config/cucumber: only set ARGV for `*.feature` test files.
+
+  * Tork::Client::Transceiver needs to stop both TX & RX loops.
+
+Housekeeping:
+
+  * tork/driver: store test file lists in Set, not Array.
+
+  * HISTORY: use single-word change-set descriptions.
+
 ------------------------------------------------------------------------------
 Version 17.0.0 (2012-01-27)
 ------------------------------------------------------------------------------
 
-Breaking changes:
+Divergences:
 
   * tork-herald(1) now emits batches of single-line JSON arrays instead of
     printing one (raw) path per line.  This makes IPC uniform across Tork.
@@ -16,11 +36,13 @@ Breaking changes:
 
     * The new order is:  test_file, line_numbers, log_file, worker_number.
 
-New features:
+Improvements:
 
   * GH-24: add `tork/config/dotlog` configuration helper to "hide" log files.
+    (Nicolas Fouché)
 
   * GH-25: add `tork/config/logdir` configuration helper to isolate log files.
+    (Jose Pablo Barrantes)
 
   * tork(1) now strips all whitespace from your input, in case you pressed
     spacebar or tab a few times, by accident, before entering your command.
@@ -48,7 +70,7 @@ Housekeeping:
 Version 16.0.0 (2012-01-25)
 ------------------------------------------------------------------------------
 
-Breaking changes:
+Divergences:
 
   * Drop the `Tork::Config.test_name_extractor` configuration option.
 
@@ -56,7 +78,7 @@ Breaking changes:
 
   * Pass $~ (MatchData) to `Tork::Config::test_file_globbers` functions.
 
-New features:
+Improvements:
 
   * tork/config/cucumber: only run changed scenarios in changed features.
 
@@ -68,11 +90,11 @@ Housekeeping:
 Version 15.1.0 (2012-01-25)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * GH-19: add `tork cucumber` for running cucumber features.
 
-Bug fixes:
+Corrections:
 
   * tork/config/rails: support Rails 2 and don't assume AR is used.  (Benjamin
     Quorning)
@@ -90,7 +112,7 @@ Bug fixes:
 Version 15.0.1 (2012-01-24)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * GH-21: Ruby 1.9 class_eval() is smarter than 1.8.
 
@@ -116,7 +138,7 @@ Housekeeping:
 Version 15.0.0 (2012-01-23)
 ------------------------------------------------------------------------------
 
-Breaking changes:
+Divergences:
 
   * This project has been renamed from TestR to Tork (test with fork) in order
     to better compete with rival projects, namely Spork! >:-)  Credit goes to
@@ -129,7 +151,7 @@ Breaking changes:
 Version 14.3.0 (2012-01-20)
 ------------------------------------------------------------------------------
 
-External changes:
+Improvements:
 
   * testr(1): notify user while dispatching their commands. This is especially
     useful when the "rerun_passed_test_files" command has been dispatched but
@@ -146,7 +168,7 @@ External changes:
 
   * testr-driver(1): document the "over" status message in manual page.
 
-Internal changes:
+Housekeeping:
 
   * testr-driver(1): keep same herald; only replace master.
 
@@ -164,7 +186,7 @@ Internal changes:
 Version 14.2.0 (2012-01-16)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Add ability to run `testr rails` without needing a `.testr.rb` file.
 
@@ -172,7 +194,7 @@ New features:
 
   * testr(1) now notifies you before absorbing overhead at startup.
 
-Bug fixes:
+Corrections:
 
   * testr(1) now accepts death silently when Control-C is pressed.
 
@@ -180,11 +202,13 @@ Bug fixes:
 Version 14.1.3 (2012-01-13)
 ------------------------------------------------------------------------------
 
-Internal changes:
+Corrections:
 
   * Add support Guard v0.9.0 and newer in `testr-herald`.  (Jose Pablo
     Barrantes)
 
+Housekeeping:
+
   * Tighten version constraints for gem dependencies to avoid future
     breakages.
 
@@ -192,11 +216,11 @@ Internal changes:
 Version 14.1.2 (2012-01-09)
 ------------------------------------------------------------------------------
 
-External changes:
+Improvements:
 
   * Don't consider partial test file pass as full pass.
 
-Internal changes:
+Housekeeping:
 
   * Upgrade to binman 3 for better bundler support.
 
@@ -204,7 +228,7 @@ Internal changes:
 Version 14.1.1 (2011-12-07)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Do not fail when given test file no longer exists.
 
@@ -235,7 +259,7 @@ Housekeeping:
 Version 14.1.0 (2011-11-03)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Make servers responsive to quit request (SIGTERM) from upstream.
 
@@ -252,7 +276,7 @@ New features:
     documented in their manual pages, so you should have everything you
     need to create *your own custom user interface to TestR* if you wish! :-)
 
-Bug fixes:
+Corrections:
 
   * SIGCHLD does not awaken main thread in Ruby 1.9.3p0.
 
@@ -268,7 +292,7 @@ Housekeeping:
 Version 14.0.3 (2011-10-11)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Forgot to migrate the `testr/config/rails` configuration helper to use the
     new TestR configuration parameter names.
@@ -277,7 +301,7 @@ Bug fixes:
 Version 14.0.2 (2011-10-11)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Fix updating passed/failed test files bookkeeping.  Once a test file
     failed, it was (incorrectly) always considered failed, even if it passed
@@ -293,7 +317,7 @@ Housekeeping:
 Version 14.0.1 (2011-10-10)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Use blue/red for pass/fail instead of green/red to accommodate the color
     blind.
@@ -309,7 +333,7 @@ Housekeeping:
 Version 14.0.0 (2011-10-09)
 ------------------------------------------------------------------------------
 
-Incompatible changes:
+Divergences:
 
   * Renamed this project and its resources from test-loop to TestR.
 
@@ -333,7 +357,7 @@ Incompatible changes:
 
   * Removed the `test/loop/notify` and `test-loop/coco` libraries.
 
-New features:
+Improvements:
 
   * The file system is no longer polled to detect modified files.  Instead, it
     is monitored for file modification events in a portable and efficient
@@ -369,12 +393,12 @@ Housekeeping:
 Version 13.0.0 (2011-08-24)
 ------------------------------------------------------------------------------
 
-Incompatible changes:
+Divergences:
 
   * Pass worker sequence number as the last argument to lambda functions in
     `Test::Loop.before_each_test` and `Test::Loop.after_each_test` arrays.
 
-New features:
+Improvements:
 
   * In the `test/loop/rails` configuration preset:
 
@@ -404,7 +428,7 @@ Housekeeping:
 Version 12.3.1 (2011-07-19)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Binary data could not be stored in environment variable values.
 
@@ -416,7 +440,7 @@ Housekeeping:
 Version 12.3.0 (2011-07-19)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Add `Test::Loop::max_concurrent_tests` configuration parameter to limit
     the number of test files run concurrently (default 4).  Otherwise, with
@@ -449,7 +473,7 @@ Version 12.2.0 (2011-06-01)
 Version 12.1.0 (2011-04-29)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Add `Test::Loop.delay_per_iteration` parameter to control the number of
     seconds (or fractions thereof) to sleep in between test-loop iterations.
@@ -458,7 +482,7 @@ New features:
 Version 12.0.4 (2011-04-29)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Reabsorb overhead when user's configuration file changes.  (Brian D. Burns
     and Daniel Pittman)
@@ -471,7 +495,7 @@ Bug fixes:
 Version 12.0.3 (2011-04-25)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Fix SIGCHLD handling and test completion reporting (Daniel Pittman).
 
@@ -529,7 +553,7 @@ Bug fixes:
 Version 12.0.2 (2011-04-21)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Consider DB schema dump file as overhead in Rails.
 
@@ -555,7 +579,7 @@ Documentation:
 Version 12.0.1 (2011-04-20)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Restore support for Ruby 1.8.7.
 
@@ -577,7 +601,7 @@ Documentation:
 Version 12.0.0 (2011-04-19)
 ------------------------------------------------------------------------------
 
-Incompatible changes:
+Divergences:
 
   * You must now explicitly `require 'test/loop/rails'` for Rails support
     because we can only *automatically* apply our Railtie (to disable class
@@ -587,7 +611,7 @@ Incompatible changes:
   * Your tests can no longer read from the user's terminal (master's STDIN);
     instead they will read from an empty stream (the reading end of IO.popen).
 
-Bug fixes:
+Corrections:
 
   * Replace threads with SIGCHLD for reporting test results.
 
@@ -630,7 +654,7 @@ Documentation:
 Version 11.0.1 (2011-04-14)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Only attempt to define Railtie if the current Rails version supports it.
 
@@ -638,18 +662,18 @@ Bug fixes:
 Version 11.0.0 (2011-04-14)
 ------------------------------------------------------------------------------
 
-Incompatible changes:
+Divergences:
 
   * The `test/loop/rails` preset has been internalized and is now applied
     automatically if your test execution overhead includes Ruby on Rails.
 
-New features:
+Improvements:
 
   * If you are using Rails 3, test-loop will automatically set
     `config.cache_classes = false` for your test environment.  (Brian D.
     Burns)
 
-Bug fixes:
+Corrections:
 
   * Avoid deadlock errors when printing output from Test::Unit and MiniTest.
     (Brian D. Burns)
@@ -665,7 +689,7 @@ Bug fixes:
 Version 10.0.1 (2011-04-08)
 ------------------------------------------------------------------------------
 
-Bug fixes:
+Corrections:
 
   * Workers must ignore SIGTSTP, otherwise master waits forever before
     exiting.
@@ -681,7 +705,7 @@ Bug fixes:
 Version 10.0.0 (2011-04-06)
 ------------------------------------------------------------------------------
 
-Incompatible changes:
+Divergences:
 
   * The `Test::Loop.before_each_test` and `Test::Loop.after_each_test`
     parameters are arrays now.
@@ -690,7 +714,7 @@ Incompatible changes:
 Version 9.4.0 (2011-04-06)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Allow lambda functions in `Test::Loop.test_file_matchers` to return `nil`
     so that you can exclude certain tests from being executed.  (Brian D.
@@ -702,7 +726,7 @@ New features:
 
         watch 'ps xf | grep test-loop | sed 1,3d'
 
-Bug fixes:
+Corrections:
 
   * Skip `at_exit()` when exiting master process.  This prevents an empty test
     from being run when exiting the loop after having processed a test/spec
@@ -722,7 +746,7 @@ Housekeeping:
 Version 9.3.0 (2011-04-01)
 ------------------------------------------------------------------------------
 
-New features:
+Improvements:
 
   * Resume currently running tests--as well as those currently needing to be
     run--after reabsorbing test execution overhead.  (Brian D. Burns)
@@ -739,7 +763,7 @@ New features:
   * Use ANSI clear line command to erase control-key combinations outputted by
     shells such as BASH and ZSH in test-loop's output.  (Brian D. Burns)
 
-Bug fixes:
+Corrections:
 
   * `@last_ran_at` was being set during every iteration of the loop.  This is
     problematic when Ruby's `Time.now` is more precise than your filesystem's
@@ -795,7 +819,7 @@ Version 9.0.1 (2011-02-18)
   * Do not print worker PID in status messages because every test file has
     exactly one worker anyway.
 
-  * Reabsorb on any `*.{rb,yml}` changes beneath the config/ directory.
+  * Reabsorb on any `*.{rb,yml}` changes beneath the `config/` directory.
 
   * Do not reabsorb overhead when the configuration file changes.
 
@@ -984,7 +1008,7 @@ Version 3.0.1 (2011-01-05)
 Version 3.0.0 (2011-01-04)
 ------------------------------------------------------------------------------
 
-  * Replace Rake #pathmap usage with lambda functions
+  * Replace Rake pathmap usage with lambda functions
     in the `@source_file_to_test_file_mapping` hash.
 
   * Be resilient to syntax errors from loaded files.
@@ -1028,14 +1052,14 @@ Version 1.2.0 (2010-11-23)
 
   * Notify user when absorbing overhead initially.
 
-  * DRY up the repetiton of Time.at(0) calculation.
+  * DRY up the repetition of Time.at(0) calculation.
 
 ------------------------------------------------------------------------------
 Version 1.1.0 (2010-11-22)
 ------------------------------------------------------------------------------
 
-  * All *_{test,spec}_helper.rb files inside test/ and
-    spec/ are now considered to be absorable overhead.
+  * All `*_{test,spec}_helper.rb` files inside `test/` and
+    `spec/` are now considered to be absorable overhead.
 
 ------------------------------------------------------------------------------
 Version 1.0.2 (2010-10-16)
@@ -1057,9 +1081,9 @@ Version 1.0.0 (2010-10-15)
 
   * Remove ability to install as a Rails plugin.
 
-  * Move logic from lib/ into bin/ to keep it simple.
+  * Move logic from `lib/` into `bin/` to keep it simple.
 
-  * Rely on $LOAD_PATH in bin/ instead of relative paths.
+  * Rely on $LOAD_PATH in `bin/` instead of relative paths.
 
   * Display status messages for better user interactivity.
 
@@ -1067,7 +1091,7 @@ Version 1.0.0 (2010-10-15)
 Version 0.0.2 (2010-10-11)
 ------------------------------------------------------------------------------
 
-  * Forgot to register bin/test-loop as gem executable.
+  * Forgot to register `bin/test-loop` as gem executable.
 
   * Revise Usage section into Invocation and Operation.
 

data/bin/tork

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 =begin
 
-TORK 1 2012-01-27 17.0.0
+TORK 1 2012-01-29 17.0.1
 ==============================================================================
 
 NAME

data/bin/tork-driver

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 =begin
 
-TORK-DRIVER 1 2012-01-27 17.0.0
+TORK-DRIVER 1 2012-01-29 17.0.1
 ==============================================================================
 
 NAME

data/bin/tork-herald

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 =begin
 
-TORK-HERALD 1 2012-01-27 17.0.0
+TORK-HERALD 1 2012-01-29 17.0.1
 ==============================================================================
 
 NAME
@@ -43,7 +43,7 @@ require 'guard'
 require 'guard/listener'
 require 'json'
 
-listener = Guard::Listener.select_and_init(:watch_all_modifications => true)
+listener = Guard::Listener.select_and_init({})
 listener.on_change {|files| puts JSON.dump(files) }
 STDOUT.sync = true # don't buffer puts()
 listener.start

data/bin/tork-master

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 =begin
 
-TORK-MASTER 1 2012-01-27 17.0.0
+TORK-MASTER 1 2012-01-29 17.0.1
 ==============================================================================
 
 NAME

data/lib/tork/client.rb

@@ -41,7 +41,8 @@ module Client
     end
 
     def quit
-      kill # stop receive loop
+      kill # stop transmit loop
+      @receiver.kill # stop receive loop
       Process.kill :SIGTERM, @popen_io.pid
       Process.wait @popen_io.pid # reap zombie
       @popen_io.close # prevent further I/O

data/lib/tork/config/cucumber.rb

@@ -15,15 +15,17 @@ Tork::Config.test_file_globbers.update(
 Tork::Config.after_fork_hooks.push lambda {
   |test_file, line_numbers, log_file, worker_number|
 
-  # pass test_file in ARGV to cucumber(1) for running
-  ARGV << [test_file, *line_numbers].join(':')
-  require 'cucumber'
-  require 'rubygems'
-  cucumber_bin = Gem.bin_path('cucumber', 'cucumber')
-  at_exit { load cucumber_bin unless $! }
+  if File.extname(test_file) == '.feature'
+    # pass test_file in ARGV to cucumber(1) for running
+    ARGV << [test_file, *line_numbers].join(':')
+    require 'cucumber'
+    require 'rubygems'
+    cucumber_bin = Gem.bin_path('cucumber', 'cucumber')
+    at_exit { load cucumber_bin unless $! }
 
-  # noopify loading of test_file in Tork::Master#test()
-  # because cucumber feature files are not Ruby scripts
-  require 'tempfile'
-  test_file.replace Tempfile.new('tork-cucumber').path
+    # noopify loading of test_file in Tork::Master#test()
+    # because cucumber feature files are not Ruby scripts
+    require 'tempfile'
+    test_file.replace Tempfile.new('tork-cucumber').path
+  end
 }

data/lib/tork/driver.rb

@@ -1,3 +1,4 @@
+require 'set'
 require 'diff/lcs'
 require 'tork/client'
 require 'tork/server'
@@ -30,24 +31,26 @@ module Driver
     @master.quit if defined? @master
 
     @master = Client::Transceiver.new('tork-master') do |message|
-      event, file, tests = message
+      event, file, line_numbers = message
 
       case event.to_sym
       when :test
         @waiting_test_files.delete file
-        @running_test_files.push file
+        @running_test_files.add file
 
       when :pass
         @running_test_files.delete file
-        @failed_test_files.delete file
-        if tests.empty? and not @passed_test_files.include? file
-          @passed_test_files.push file
+
+        # only whole test file runs qualify as pass
+        if line_numbers.empty?
+          @failed_test_files.delete file
+          @passed_test_files.add file
         end
 
       when :fail
         @running_test_files.delete file
+        @failed_test_files.add file
         @passed_test_files.delete file
-        @failed_test_files.push file unless @failed_test_files.include? file
       end
 
       @client.send message
@@ -91,10 +94,10 @@ module Driver
 
 private
 
-  @waiting_test_files = []
-  @running_test_files = []
-  @passed_test_files = []
-  @failed_test_files = []
+  @waiting_test_files = Set.new
+  @running_test_files = Set.new
+  @passed_test_files = Set.new
+  @failed_test_files = Set.new
 
   def rerun_running_test_files
     run_test_files @running_test_files
@@ -105,8 +108,7 @@ private
   end
 
   def run_test_file file
-    if File.exist? file and not @waiting_test_files.include? file
-      @waiting_test_files.push file
+    if File.exist? file and @waiting_test_files.add? file
       @master.send [:test, file, find_changed_line_numbers(file)]
     end
   end

data/lib/tork/version.rb

@@ -1,3 +1,3 @@
 module Tork
-  VERSION = "17.0.0"
+  VERSION = "17.0.1"
 end

data/man/man1/tork-driver.1

@@ -1,4 +1,4 @@
-.TH TORK\-DRIVER 1 2012\-01\-27 17.0.0
+.TH TORK\-DRIVER 1 2012\-01\-29 17.0.1
 .SH NAME
 .PP
 tork\-driver \- drives 

data/man/man1/tork-herald.1

@@ -1,4 +1,4 @@
-.TH TORK\-HERALD 1 2012\-01\-27 17.0.0
+.TH TORK\-HERALD 1 2012\-01\-29 17.0.1
 .SH NAME
 .PP
 tork\-herald \- reports modified files

data/man/man1/tork-master.1

@@ -1,4 +1,4 @@
-.TH TORK\-MASTER 1 2012\-01\-27 17.0.0
+.TH TORK\-MASTER 1 2012\-01\-29 17.0.1
 .SH NAME
 .PP
 tork\-master \- absorbs overhead and runs tests

data/man/man1/tork.1

@@ -1,4 +1,4 @@
-.TH TORK 1 2012\-01\-27 17.0.0
+.TH TORK 1 2012\-01\-29 17.0.1
 .SH NAME
 .PP
 tork \- Continuous testing tool for Ruby

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tork
 version: !ruby/object:Gem::Version
-  version: 17.0.0
+  version: 17.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-27 00:00:00.000000000 Z
+date: 2012-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: binman
-  requirement: &17780080 !ruby/object:Gem::Requirement
+  requirement: &13745920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *17780080
+  version_requirements: *13745920
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &17779540 !ruby/object:Gem::Requirement
+  requirement: &13745380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -36,10 +36,10 @@ dependencies:
         version: '2'
   type: :runtime
   prerelease: false
-  version_requirements: *17779540
+  version_requirements: *13745380
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &17778800 !ruby/object:Gem::Requirement
+  requirement: &13744640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -50,10 +50,10 @@ dependencies:
         version: '1'
   type: :runtime
   prerelease: false
-  version_requirements: *17778800
+  version_requirements: *13744640
 - !ruby/object:Gem::Dependency
   name: diff-lcs
-  requirement: &17778060 !ruby/object:Gem::Requirement
+  requirement: &13743900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -64,10 +64,10 @@ dependencies:
         version: '2'
   type: :runtime
   prerelease: false
-  version_requirements: *17778060
+  version_requirements: *13743900
 - !ruby/object:Gem::Dependency
   name: md2man
-  requirement: &17777300 !ruby/object:Gem::Requirement
+  requirement: &13743120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -75,10 +75,10 @@ dependencies:
         version: '1'
   type: :development
   prerelease: false
-  version_requirements: *17777300
+  version_requirements: *13743120
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &17776800 !ruby/object:Gem::Requirement
+  requirement: &13742600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,7 +89,7 @@ dependencies:
         version: '1'
   type: :development
   prerelease: false
-  version_requirements: *17776800
+  version_requirements: *13742600
 description: Continuous testing tool for Ruby.
 email:
 - sunaku@gmail.com