tops_connect 0.4.2.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '08f80c8803c286add456860a40240dfd806a13bf'
-  data.tar.gz: 5a220f3ebe9ccd09576f315204d285e1d50d8d7c
+  metadata.gz: 013f848e5f60161529ada485d46c4bd65c2bc206
+  data.tar.gz: 33169982d13dbbbfd3f939b76ab4fd939864a628
 SHA512:
-  metadata.gz: 3631d6116ffe750e9361bce393cf09da2c5628ae6536f553cc020b21245a1391c202fb8c57874a1cec9acc8665e503cb3ed5853d5dba852345c92a7b30b33f2b
-  data.tar.gz: 596f51edf022810a38117a80f6f7e371c3a6b71552188ee375423dbb22a549f41379bf710d8dbdd84b8191d80e93f23e3a5eea3ab1f5c66ab249774d92d217ce
+  metadata.gz: be35e62c4e0d288a7384f0e9ca237175c6cb886364bd9590eff4bbcdb2a60f2efbc430b5eb48b4c42f8dcf2406b8a865a6fe9600c49f7de4277a6a5ec6afc3e8
+  data.tar.gz: c24da508faa7388ac874ee043832b8896044b43d188f18e1b3f551b01303f6781cd3225e16e772dd88f57b2800f36dfbe6df39262fd18793d621761f662e7d9a

data/lib/tops_connect/client.rb

@@ -2,6 +2,7 @@
 module TopsConnect
   class Client
     include HTTParty
+    include TopsConnect::Errors
     include TopsConnect::Communities
     include TopsConnect::Owners
     include TopsConnect::Properties
@@ -47,6 +48,11 @@ module TopsConnect
       when 400..499
         raise TopsConnect::ClientError, response
       when 500..599
+        message = response.parsed_response&.dig('Message') || ''
+
+        # These errors can largely be ignored - it's not our fault
+        raise TopsConnect::TimeoutError, response if message['Timeout expired']
+
         raise TopsConnect::InternalError, response
       else
         # As far as I'm aware, Tops does not return 100 - 199 or 201 - 399.
@@ -54,28 +60,4 @@ module TopsConnect
       end
     end
   end
-
-  class ApiError < ::RuntimeError
-    def initialize(response)
-      @response = response
-    end
-
-    def to_s
-      format(
-        '%{code}: %{message} (%{uri})',
-        code: @response.code,
-        message: @response.parsed_response&.dig('Message'),
-        uri: @response.request.last_uri.to_s
-      )
-    end
-  end
-
-  class ClientError < ApiError
-  end
-
-  class NotFoundError < ClientError
-  end
-
-  class InternalError < ApiError
-  end
 end

data/lib/tops_connect/errors.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+module TopsConnect
+  class ApiError < ::RuntimeError
+    def initialize(response)
+      @response = response
+    end
+
+    def to_s
+      format(
+        '%{code}: %{message} (%{uri})',
+        code: @response.code,
+        message: @response.parsed_response&.dig('Message'),
+        uri: @response.request.last_uri.to_s
+      )
+    end
+  end
+
+  # The client submitted invalid information.
+  class ClientError < ApiError
+  end
+
+  # A request was made for a key/query that doesn't exist.
+  class NotFoundError < ClientError
+  end
+
+  # Something happened but we don't know what and it's probably not our fault.
+  class InternalError < ApiError
+  end
+
+  # The API took too long to respond, but everything might be fine later.
+  class TimeoutError < InternalError
+  end
+end

data/lib/tops_connect/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module TopsConnect
-  VERSION = '0.4.2.1'
+  VERSION = '0.4.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tops_connect
 version: !ruby/object:Gem::Version
-  version: 0.4.2.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Steven Hoffman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-28 00:00:00.000000000 Z
+date: 2017-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -102,6 +102,7 @@ files:
 - lib/tops_connect/communities.rb
 - lib/tops_connect/community.rb
 - lib/tops_connect/configuration.rb
+- lib/tops_connect/errors.rb
 - lib/tops_connect/owner.rb
 - lib/tops_connect/owners.rb
 - lib/tops_connect/properties.rb