tolq-parsers-xliff 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54e8257412582072e447ab41106b4354254a25a8
-  data.tar.gz: 0a17033cc0e99e8b53a0fae54681c7e1992f4c86
+  metadata.gz: 31536f271f89a7333c67950065ce2a4347600f0f
+  data.tar.gz: 025b219b7a2232b029f0abcdaa5ec028c9943912
 SHA512:
-  metadata.gz: 823ef5c99d158ab0a2cf3e62360e06298c1e5d61369955cdf9f15205f25b247c00970e265f02237702022db41c9873301678b08c2e5de1c927a5ec1a8806b7fe
-  data.tar.gz: 22df13c0a2a35bbca71e69ec5a359d5527b0ab03ced6cbeccbea35975b832c83a9530e26f54f534cf366ce25c44faa125f05bd1ce75f8b51fff5053e9e3b191b
+  metadata.gz: 9dee89cc6c7de47ba31d6772def5b7af58e0d96c72ac085eff2aef4e029533a945391aef017f1419061a2bd1747d9af8a02115007f5a1f1272d31b37e739b24b
+  data.tar.gz: 19ecc354b22d575eb5cd3012fe45b5303e47202bb14ee45664923dbaec05f0a200a892b11924bcb35555dad1c40cb5501cdd2bd15bcdb30ff435be46147a96a9

data/lib/xliff/parser.rb

@@ -1,5 +1,19 @@
 module Tolq::Parsers::Xliff
+  class ParseError < StandardError; end;
+
   class Parser
+    # Helper method to convert a xliff into an annotated hash. Format is
+    # different from Tolq api
+    #
+    # @param xliff_text [String] String of file
+    # @param parse_opts [Hash] Noop
+    # @return [Hash] Hash representation of xliff
+    def self.to_hash(xliff_text, **parse_opts)
+      xliff = XLIFFer::XLIFF.new(xliff_text)
+      validate_xliff!(xliff)
+      extract_request_data_from_files(xliff.files, text_node: false)
+    end
+
 
     # Creates a new Xliff parser
     #
@@ -17,34 +31,51 @@ module Tolq::Parsers::Xliff
     # @return [Hash] A hash suitable to be converted to json for the Tolq Api
     def parse(xliff_text)
       xliff = XLIFFer::XLIFF.new(xliff_text)
-      file = xliff.files.first
-      request_data = extract_request_data_from_file(file)
+      self.class.validate_xliff!(xliff)
+      request_data = self.class.extract_request_data_from_files(xliff.files)
 
       {
         "request" => request_data,
-        "source_language_code" => @source_language_code || strip_region_language(file.source_language),
-        "target_language_code" => @target_language_code || strip_region_language(file.target_language),
+        "source_language_code" => @source_language_code || strip_region_language(xliff.files.first.source_language),
+        "target_language_code" => @target_language_code || strip_region_language(xliff.files.first.target_language),
         "quality" => @quality.to_s
       }
     end
 
     private
 
-    def extract_request_data_from_file(xliff_file)
-      xliff_file.strings.inject({}) do |acc, string|
-        unless string.source && string.source.strip.length > 0
-          next acc
+    def self.extract_request_data_from_files(xliff_files, text_node: true)
+      acc = {}
+      xliff_files.each.with_index do |file, file_idx|
+        file.strings.each do |string|
+          unless string.source && string.source.strip.length > 0
+            next acc
+          end
+          id = "#{file_idx}-#{string.id}"
+          if text_node
+            acc[id] = {"text" => string.source }
+          else
+            acc[id] = string.source
+          end
+          if string.note.length > 0 && text_node # xliffs so far use this for bogus anyway
+            acc[id].merge!("translator_message" => string.note)
+          end
         end
-        acc[string.id] = {"text" => string.source }
-        if string.note.length > 0
-          acc[string.id].merge!("translator_message" => string.note)
-        end
-        acc
       end
+      acc
     end
 
     def strip_region_language(language)
       language[0..1]
     end
+
+    def self.validate_xliff!(xliff)
+      if xliff.files.map(&:source_language).compact.uniq.length != 1
+        raise ParseError.new("More than one source language, cannot parse file")
+      end
+      if xliff.files.any? { |file| file.strings.map(&:id).any?(&:nil?) }
+        raise ParseError.new("Missing mandatory ID for one or more 'trans-unit'")
+      end
+    end
   end
 end

data/lib/xliff/unparser.rb

@@ -25,10 +25,12 @@ module Tolq::Parsers::Xliff
 
     def translate_xliff(translations, xliff_text, target_language_code)
       xliff = XLIFFer::XLIFF.new(xliff_text)
-      xliff.files.first.target_language = target_language_code
-      xliff.files.first.strings.each do |string|
-        if translation = translations[string.id]
-          string.target = translation
+      xliff.files.each.with_index do |file, file_idx|
+        file.target_language = target_language_code
+        file.strings.each do |string|
+          if translation = translations["#{file_idx}-#{string.id}"]
+            string.target = translation
+          end
         end
       end
       xliff

data/lib/xliff/version.rb

@@ -1,7 +1,7 @@
 module Tolq
   module Parsers
     module Xliff
-      VERSION = "0.1.5"
+      VERSION = "0.1.6"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tolq-parsers-xliff
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Timon Vonk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-16 00:00:00.000000000 Z
+date: 2017-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xliffer