toggles 0.1.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3fc507d16102054690297319ce1e47e61c1ef408
-  data.tar.gz: 482eb06c1c41bd52afd536d0aad227e57ac7deab
+SHA256:
+  metadata.gz: ece49487f49d27e3a10944d318e3b2c1b9a0e9a8a3c231581ebf5341e7abc4f2
+  data.tar.gz: d278a07f9e9e5e379936e02fa27e4a4cd7270ef2e7933181e5948c30d88bb4fd
 SHA512:
-  metadata.gz: 97b6de15c5f8abff3dc5fac12dd1429163ebe7208a1b68c4666af82d130cb6aa2ca3a44c20a87e959ee6df3bf42964b046658a0355816d3b799aa1292bd340bd
-  data.tar.gz: 85553a0544a5c6cb9f8929fe9f9c66d540451d6df8e2996af56af9bb3a16ea28ff9495f39dcb250e6396c8cf74bc48a30d18979a7e41c9ea9dc532cefc607321
+  metadata.gz: 2e80d24bb41c699217fa865e8ac2c346c4fbdc411d93eec98dc0d4ff11953f1c757a778606d62de664602a4320788b63389beca5f831431d7bc90bbee24eea0d
+  data.tar.gz: 4c4f3ea7f4d06f1a465f53e3114e5a456eed9c7de889e940910a01ed300823852e2b2cb823c89152685ed489800cf406d51efc876179feda4ad204077305ba72

data/.github/workflows/ci.yml

@@ -0,0 +1,24 @@
+name: 'CI'
+
+on:
+  push:
+    branches: [ master ]
+  pull_request: ~
+  schedule:
+    - cron: "0 16 * * 1"
+
+jobs:
+  run-tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        rubyversion: ['2.7', '3.0', '3.1']
+    steps:
+      - uses: actions/checkout@v2
+      - name: set up ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.rubyversion }}
+          bundler-cache: true
+      - name: run tests
+        run: bundle exec rspec

data/CHANGELOG.md

@@ -0,0 +1,83 @@
+# Changelog
+
+## [v0.4.0](https://github.com/EasyPost/toggles/tree/v0.4.0)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.3.0...v0.4.0)
+
+**Merged pull requests:**
+
+- refactor: remove Feature::Base, just use Feature::Permissions [\#13](https://github.com/EasyPost/toggles/pull/13) ([lanej](https://github.com/lanej))
+- refactor: collapse some hierarchies, model operations as functions [\#12](https://github.com/EasyPost/toggles/pull/12) ([lanej](https://github.com/lanej))
+- fix: handle abbreviations and numbers in feature name [\#11](https://github.com/EasyPost/toggles/pull/11) ([lanej](https://github.com/lanej))
+- Deprecate constant lookups via .const\_missing [\#10](https://github.com/EasyPost/toggles/pull/10) ([lanej](https://github.com/lanej))
+
+## [v0.3.0](https://github.com/EasyPost/toggles/tree/v0.3.0) (2021-08-16)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.1.2...v0.3.0)
+
+**Merged pull requests:**
+
+- add github actions integration [\#9](https://github.com/EasyPost/toggles/pull/9) ([Roguelazer](https://github.com/Roguelazer))
+- point build status link at travis-ci.com instead of travis-ci.org [\#8](https://github.com/EasyPost/toggles/pull/8) ([Roguelazer](https://github.com/Roguelazer))
+- fix tests [\#7](https://github.com/EasyPost/toggles/pull/7) ([Roguelazer](https://github.com/Roguelazer))
+- run tests on travis [\#6](https://github.com/EasyPost/toggles/pull/6) ([Roguelazer](https://github.com/Roguelazer))
+
+## [v0.1.2](https://github.com/EasyPost/toggles/tree/v0.1.2) (2016-11-08)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.1.1...v0.1.2)
+
+**Merged pull requests:**
+
+- store the actual feature configuration in a variable instead of in real constants under the Feature module [\#4](https://github.com/EasyPost/toggles/pull/4) ([Roguelazer](https://github.com/Roguelazer))
+
+## [v0.1.1](https://github.com/EasyPost/toggles/tree/v0.1.1) (2015-08-24)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.1.0...v0.1.1)
+
+## [v0.1.0](https://github.com/EasyPost/toggles/tree/v0.1.0) (2015-08-24)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.8...v0.1.0)
+
+**Closed issues:**
+
+- Handle when properties are nil [\#2](https://github.com/EasyPost/toggles/issues/2)
+
+## [v0.0.8](https://github.com/EasyPost/toggles/tree/v0.0.8) (2015-02-25)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.7...v0.0.8)
+
+**Merged pull requests:**
+
+- Features automatically disabled\_for nil input [\#3](https://github.com/EasyPost/toggles/pull/3) ([victoryftw](https://github.com/victoryftw))
+
+## [v0.0.7](https://github.com/EasyPost/toggles/tree/v0.0.7) (2014-12-24)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.6...v0.0.7)
+
+**Closed issues:**
+
+- Allow Fixnums etc. as top-level subjects [\#1](https://github.com/EasyPost/toggles/issues/1)
+
+## [v0.0.6](https://github.com/EasyPost/toggles/tree/v0.0.6) (2014-12-22)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.5...v0.0.6)
+
+## [v0.0.5](https://github.com/EasyPost/toggles/tree/v0.0.5) (2014-12-17)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.4...v0.0.5)
+
+## [v0.0.4](https://github.com/EasyPost/toggles/tree/v0.0.4) (2014-12-10)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.3...v0.0.4)
+
+## [v0.0.3](https://github.com/EasyPost/toggles/tree/v0.0.3) (2014-12-10)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/v0.0.2...v0.0.3)
+
+## [v0.0.2](https://github.com/EasyPost/toggles/tree/v0.0.2) (2014-12-10)
+
+[Full Changelog](https://github.com/EasyPost/toggles/compare/b19564d6ef5eb5d9c3b44d4eafe2fbac9d8a8938...v0.0.2)
+
+
+
+\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*

data/Gemfile

@@ -1,3 +1,8 @@
 source 'https://rubygems.org'
 
 gemspec
+
+group :test do
+  gem "pry"
+  gem "pry-nav"
+end

data/README.md

@@ -1,7 +1,7 @@
 # Toggles
 
 [![Gem Version](https://badge.fury.io/rb/toggles.svg)](https://badge.fury.io/rb/toggles)
-[![CircleCI](https://circleci.com/gh/EasyPost/toggles.svg?style=svg)](https://circleci.com/gh/EasyPost/toggles)
+[![CI](https://github.com/EasyPost/toggles/workflows/CI/badge.svg)](https://github.com/EasyPost/toggles/actions?query=workflow%3ACI)
 
 YAML backed feature toggles
 
@@ -41,9 +41,6 @@ features
 └── test.yml
 ```
 
-The classes `Feature::Test`, `Feature::Thing::One` and `Feature::Thing::Two` will be available for use within
-your application.
-
 You can call the `Toggles.init` method to force re-parsing the configuration and re-initializing all Features
 structures at any time. The `Toggles.reinit_if_necessary` method is a convenience helper which will only
 re-initialize of the top-level features directory has changed. Note that, in general, this will only detect
@@ -65,13 +62,13 @@ user:
 Check if the feature is enabled or disabled:
 
 ```ruby
-Feature::NewFeature::AvailableForPresentation.enabled_for?(user: OpenStruct.new(id: 12345)) # true
-Feature::NewFeature::AvailableForPresentation.enabled_for?(user: OpenStruct.new(id: 54321)) # true
-Feature::NewFeature::AvailableForPresentation.enabled_for?(user: OpenStruct.new(id: 7)) # false
+Feature.enabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 12345)) # true
+Feature.enabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 54321)) # true
+Feature.enabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 7)) # false
 
-Feature::NewFeature::AvailableForPresentation.disabled_for?(user: OpenStruct.new(id: 12345)) # false
-Feature::NewFeature::AvailableForPresentation.disabled_for?(user: OpenStruct.new(id: 54321)) # false
-Feature::NewFeature::AvailableForPresentation.disabled_for?(user: OpenStruct.new(id: 7)) # true
+Feature.disabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 12345)) # false
+Feature.disabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 54321)) # false
+Feature.disabled?(:new_feature, :available_for_presentation, user: OpenStruct.new(id: 7)) # true
 ```
 
 ## License

data/features/abbreviations_cn22.yml

@@ -0,0 +1,3 @@
+---
+user:
+  id: 1

data/features/file_s3.yml

@@ -0,0 +1,3 @@
+---
+user:
+  id: 1

data/features/nested_foo/bar_baz.yml

@@ -0,0 +1,3 @@
+id:
+  lt:
+    5

data/features/s3_file.yml

@@ -0,0 +1,3 @@
+---
+user:
+  id: 1

data/lib/toggles/constant_lookup.rb

@@ -0,0 +1,50 @@
+class Feature::ConstantLookup
+  Error = Class.new(NameError) do
+    attr_reader :sym
+
+    def initialize(sym)
+      @sym = sym
+      super(sym.join('::'))
+    end
+  end
+
+  # Return a tree walker that translates Module#const_missing(sym) into the next child node
+  #
+  # So Features::Cat::BearDog walks as:
+  # * next_features = Feature.features # root
+  # * const_missing(:Cat) => next_features = next_features['cat']
+  # * const_missing(:BearDog) => next_features['bear_dog']
+  # * const_missing(:CN22) => next_features['c_n_22']
+  #
+  # Defined at Toggles.features_dir + "/cat/bear_dog.yaml"
+  #
+  # @raise [Error] if constant cannot be resolved
+  def self.from(features, path)
+    Class.new {
+      class << self
+        attr_accessor :features, :path
+
+        def const_missing(sym)
+          # translate class name into path part i.e :BearDog #=> 'bear_dog'
+          key = sym.to_s
+          key.gsub!(/([A-Z\d]+)([A-Z][a-z])/, '\1_\2'.freeze)
+          key.gsub!(/([a-z\d])([A-Z])/, '\1_\2'.freeze)
+          key.downcase!
+
+          subtree_or_feature = features.fetch(key.to_sym)
+
+          if subtree_or_feature.is_a?(Hash)
+            Feature::ConstantLookup.from(subtree_or_feature, path + [sym])
+          else
+            subtree_or_feature
+          end
+        rescue KeyError
+          raise Error, path + [sym]
+        end
+      end
+    }.tap do |resolver|
+      resolver.features = features
+      resolver.path = path
+    end
+  end
+end

data/lib/toggles/feature/attribute.rb

@@ -0,0 +1,15 @@
+class Feature::Attribute
+  def self.call(entity, attr_name, expected)
+    if expected.kind_of? Hash
+      expected.all? do |operation, rules|
+        if Feature.operations.include? operation.to_sym
+          Feature.operations[operation.to_sym].call(entity, attr_name, rules)
+        else
+          call(entity.send(attr_name), operation, rules)
+        end
+      end
+    else
+      entity.send(attr_name) == expected
+    end
+  end
+end

data/lib/toggles/feature/operation/and.rb

@@ -1,15 +0,0 @@
-module Feature
-  module Operation
-    class And
-      def self.call(entity, attr_name, expected)
-        expected.all? do |operation, value|
-          if OPERATIONS.include? operation.to_sym
-            OPERATIONS[operation.to_sym].call(entity, attr_name, value)
-          else
-            Operation::Attribute.call(entity, operation, value)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/toggles/feature/operation/in.rb

@@ -4,7 +4,7 @@ module Feature
       def self.call(entity, attr_name, expected)
         if expected.kind_of? Hash
           expected = expected.reduce([]) do |list, (operation, args)|
-            OPERATIONS[operation.to_sym].call(args)
+            Feature.operations[operation.to_sym].call(args)
           end
         end
 

data/lib/toggles/feature/operation/range.rb

@@ -2,8 +2,6 @@ module Feature
   module Operation
     class Range
       def self.call(args)
-        raise StandardError, "Invalid range operation" if args.size != 2
-        (args.first..args.last)
       end
     end
   end

data/lib/toggles/feature/permissions.rb

@@ -1,43 +1,48 @@
-require "ostruct"
-require "forwardable"
+require 'ostruct'
+require 'forwardable'
+require 'yaml'
 
-module Feature
-  class Permissions
-    extend Forwardable
+Feature::Permissions = Struct.new(:rules) do
+  extend Forwardable
 
-    attr_reader :rules
+  def_delegators :rules, :all?, :keys
 
-    def_delegators :rules, :all?, :keys
+  def self.from_yaml(path)
+    new(
+      YAML.safe_load(File.read(path), permitted_classes: [Symbol])
+    )
+  end
 
-    def initialize(path)
-      @rules = YAML.load(File.read(path))
-    end
+  def subjects
+    @subjects ||= keys.map(&:to_sym)
+  end
 
-    def subjects
-      @subjects ||= keys.map(&:to_sym)
+  def valid_for?(entities)
+    unless subjects == entities.keys
+      raise Feature::Subject::Invalid, Feature::Subject.difference(subjects, entities.keys)
     end
 
-    def valid_for?(entities)
-      unless subjects == entities.keys
-        raise Subject::Invalid, Subject.difference(subjects, entities.keys)
-      end
-
-      rules.all? do |name, rule|
-        entity = entities[name.to_sym]
+    rules.all? do |name, rule|
+      entity = entities[name.to_sym]
 
-        if entity.nil?
-          return false
-        end
+      return false if entity.nil?
 
-        if entity.class.ancestors.find { |ancestor| ancestor == Comparable }
-          entity = OpenStruct.new(name => entity)
-          rule   = {name => rule}
-        end
+      if entity.class.ancestors.find { |ancestor| ancestor == Comparable }
+        entity = OpenStruct.new(name => entity)
+        rule   = { name => rule }
+      end
 
-        rule.all? do |key, value|
-          OPERATIONS.fetch(key.to_sym, Operation::Attribute).call(entity, key, value)
-        end
+      rule.all? do |key, value|
+        Feature.operations.fetch(key.to_sym, Feature::Attribute).call(entity, key, value)
       end
     end
   end
+
+  def enabled_for?(subjects = {})
+    valid_for?(subjects)
+  end
+
+  def disabled_for?(subjects = {})
+    !valid_for?(subjects)
+  end
 end

data/lib/toggles/feature.rb

@@ -1,24 +1,84 @@
-require "toggles/feature/base"
-require "toggles/feature/operation"
-require "toggles/feature/permissions"
-require "toggles/feature/subject"
-
+# frozen_string_literal: true
+ 
 module Feature
-  OPERATIONS = {and:   Operation::And,
-                gt:    Operation::GreaterThan,
-                in:    Operation::In,
-                lt:    Operation::LessThan,
-                not:   Operation::Not,
-                or:    Operation::Or,
-                range: Operation::Range}
+  Error = Class.new(StandardError)
+  Unknown = Class.new(Error)
 
-  @@tree = Module.new
+  def self.features
+    @features ||= {}
+  end
 
-  def self.set_tree(tree)
-    @@tree = tree
+  def self.operations
+    @operations ||= {}
   end
 
+  # @deprecated This is an abuse of lazy dispatch that creates cryptic errors
   def self.const_missing(sym)
-    @@tree.const_get(sym, inherit: false)
+    ConstantLookup.from(features, [:Feature]).const_missing(sym)
+  end
+
+  def self.enabled?(*sym, **criteria)
+    sym
+      .inject(features) { |a, e| a.fetch(e) }
+      .enabled_for?(criteria)
+  rescue KeyError
+    raise Unknown, sym.inspect
+  end
+
+  def self.disabled?(*sym, **criteria)
+    !enabled?(*sym, **criteria)
   end
 end
+
+require 'toggles/constant_lookup'
+require "toggles/feature/attribute"
+require "toggles/feature/permissions"
+require "toggles/feature/subject"
+
+Feature.operations[:and] = lambda { |entity, attr_name, expected|
+  expected.all? do |operation, value|
+    if Feature.operations.include? operation.to_sym
+      Feature.operations[operation.to_sym].call(entity, attr_name, value)
+    else
+      Feature::Attribute.call(entity, operation, value)
+    end
+  end
+}
+
+Feature.operations[:in] = lambda { |entity, attr_name, expected|
+  if expected.is_a? Hash
+    expected = expected.reduce([]) do |_list, (operation, args)|
+      Feature.operations[operation.to_sym].call(args)
+    end
+  end
+
+  expected.include? entity.send(attr_name.to_sym)
+}
+
+Feature.operations[:not] = lambda { |entity, attr_name, expected|
+  if expected.is_a? Hash
+    expected.none? do |operation, value|
+      Feature.operations[operation.to_sym].call(entity, attr_name, value)
+    end
+  else
+    entity.send(attr_name) != expected
+  end
+}
+
+Feature.operations[:or] = lambda { |entity, attr_name, expected|
+  expected.any? do |operation, value|
+    if Feature.operations.include? operation.to_sym
+      Feature.operations[operation.to_sym].call(entity, attr_name, value)
+    else
+      Feature::Attribute.call(entity, operation, value)
+    end
+  end
+}
+
+Feature.operations[:gt] = ->(entity, attr_name, expected) { entity.send(attr_name) > expected }
+Feature.operations[:lt] = ->(entity, attr_name, expected) { entity.send(attr_name) < expected }
+Feature.operations[:range] = lambda { |args|
+  raise StandardError, 'Invalid range operation' if args.size != 2
+
+  (args.first..args.last)
+}

data/lib/toggles/version.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module Toggles
+  VERSION = '0.4.0'
+end

data/lib/toggles.rb

@@ -1,8 +1,11 @@
-require "find"
-require "pathname"
+require 'find'
+require 'pathname'
+require 'set'
 
-require "toggles/configuration"
-require "toggles/feature"
+require 'toggles/version'
+
+require 'toggles/configuration'
+require 'toggles/feature'
 
 module Toggles
   extend self
@@ -19,76 +22,35 @@ module Toggles
     @configuration ||= Configuration.new
   end
 
-  # Dynamically create modules and classes within the `Feature` module based on
-  # the directory structure of `features`.
-  #
-  # For example if the `features` directory has the structure:
-  #
-  # features
-  # ├── thing
-  # |   ├── one.yml
-  # |   └── two.yml
-  # └── test.yml
-  #
-  # `Feature::Test`, `Feature::Thing::One`, `Feature::Thing::Two` would be
-  # available by default.
-  #
   def init
-    return unless Dir.exists? configuration.features_dir
-
-    new_tree = Module.new
+    return unless Dir.exist? configuration.features_dir
 
     top_level = File.realpath(configuration.features_dir)
     top_level_p = Pathname.new(top_level)
 
-    Find.find(top_level) do |path|
-      previous = new_tree
-      abspath = path
-      path = Pathname.new(path).relative_path_from(top_level_p).to_s
-      if path.match(/\.ya?ml\Z/)
-        base = path.chomp(File.extname(path)).split("/")
-        if base.size > 1
-          directories = base[0...-1]
-          filename = base[-1]
-        else
-          directories = []
-          filename = base[0]
-        end
-
-        directories.each do |directory|
-          module_name = directory.split("_").map(&:capitalize).join.to_sym
-          previous    = if previous.constants.include? module_name
-                          previous.const_get(module_name)
-                        else
-                          previous.const_set(module_name, Module.new)
-                        end
-        end
-
-        cls = Class.new(Feature::Base) do |c|
-          c.const_set(:PERMISSIONS, Feature::Permissions.new(abspath))
-        end
+    Feature.features.clear
 
-        previous.const_set(filename.split("_").map(&:capitalize).join.to_sym, cls)
-      end
+    Dir[File.join(top_level, '**/*.{yaml,yml}')].each do |abspath|
+      path = Pathname.new(abspath).relative_path_from(top_level_p).to_s
+      features = path.split('/')[0..-2].inject(Feature.features) { |a, e| a[e.to_sym] ||= {} }
+      feature_key = File.basename(path, File.extname(path)).to_sym
+      features[feature_key] = Feature::Permissions.from_yaml(abspath)
     end
 
     stbuf = File.stat(top_level)
     @stat_tuple = StatResult.new(stbuf.ino, stbuf.mtime)
-
-    Feature.set_tree(new_tree)
   end
 
   def reinit_if_changed
     # Reload the configuration if the top-level directory has changed.
     # Does not detect changes to files inside that directory unless your
     # filesystem propagates mtimes.
-    return unless Dir.exists? configuration.features_dir
+    return unless Dir.exist? configuration.features_dir
+
     top_level = File.realpath(configuration.features_dir)
     stbuf = File.stat(top_level)
     stat_tuple = StatResult.new(stbuf.ino, stbuf.mtime)
 
-    if @stat_tuple != stat_tuple
-      init
-    end
+    init if @stat_tuple != stat_tuple
   end
 end

data/spec/spec_helper.rb

@@ -3,6 +3,8 @@ require 'rspec/temp_dir'
 
 require "toggles"
 
+Bundler.require(:test)
+
 RSpec.configure do |config|
   config.order = "random"
 

data/spec/toggles/feature/acceptance/type_spec.rb

@@ -1,7 +1,23 @@
 describe "Feature::Type" do
+  specify 'deprecated' do
+    aggregate_failures do
+      expect(Feature::Type.enabled_for?(user_id: 1)).to eq true
+      expect(Feature::Type.enabled_for?(user_id: 25)).to eq false
+      expect(Feature::Type.enabled_for?(user_id: nil)).to eq false
+    end
+  end
+
   specify do
-    expect(Feature::Type.enabled_for?(user_id: 1)).to eq true
-    expect(Feature::Type.enabled_for?(user_id: 25)).to eq false
-    expect(Feature::Type.enabled_for?(user_id: nil)).to eq false
+    aggregate_failures do
+      expect(Feature.enabled?(:type, user_id: 1)).to eq(true)
+      expect(Feature.disabled?(:type, user_id: 1)).to eq(false)
+      expect(Feature.enabled?(:type, user_id: 25)).to eq(false)
+      expect(Feature.enabled?(:nested_foo, :bar_baz, id: 25)).to eq(false)
+      expect(Feature.enabled?(:nested_foo, :bar_baz, id: 1)).to eq(true)
+      expect(Feature.disabled?(:type, user_id: 25)).to eq(true)
+      expect(Feature.disabled?(:nested_foo, :bar_baz, id: 25)).to eq(true)
+      expect(Feature.disabled?(:nested_foo, :bar_baz, id: 1)).to eq(false)
+      expect { Feature.disabled?(:nested_foo, :bar_boz, id: 1) }.to raise_error(Feature::Unknown)
+    end
   end
 end

data/spec/toggles/feature/attribute_spec.rb

@@ -0,0 +1,9 @@
+RSpec.describe Feature::Attribute do
+  specify do
+    expect(described_class.call(double(id: 50), :id, 50)).to eq true
+    expect(described_class.call(double(id: 50), :id, 51)).to eq false
+
+    expect(described_class.call(double(id: 50), :id, { 'in' => (0..50), 'not' => 49 })).to eq true
+    expect(described_class.call(double(id: 49), :id, { 'in' => (0..50), 'not' => 49 })).to eq false
+  end
+end

data/spec/toggles/feature/operation_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+ 
+RSpec.describe 'operations' do
+  context 'and' do
+    subject { Feature.operations[:and] }
+
+    specify do
+    [[60, true], [40, false], [80, false]].each do |(id, expected)|
+        expect(
+          subject.call(double(id: id), :id, {"gt" => 50, "lt" => 70})
+        ).to eq expected
+      end
+    end
+  end
+
+  context 'gt' do
+    subject { Feature.operations[:gt] }
+
+    specify do
+      expect(subject.call(double(id: 50), :id, 40)).to eq true
+      expect(subject.call(double(id: 50), :id, 60)).to eq false
+    end
+  end
+
+  context 'in' do
+    subject { Feature.operations[:in] }
+
+    specify do
+      expect(subject.call(double(id: 50), :id, {"range" => [40, 60]})).to eq true
+      expect(subject.call(double(id: 50), :id, [1])).to eq false
+      expect(subject.call(double(id: nil), :id, [1])).to eq false
+    end
+  end
+
+  context 'lt' do
+    subject { Feature.operations[:lt] }
+
+    specify do
+      expect(subject.call(double(id: 50), :id, 60)).to eq true
+      expect(subject.call(double(id: 50), :id, 40)).to eq false
+    end
+  end
+
+  context 'not' do
+    subject { Feature.operations[:not] }
+
+    specify do
+      expect(subject.call(double(id: 50), :id, {"in" => (10..20)})).to eq true
+      expect(subject.call(double(id: 50), :id, 50)).to eq false
+    end
+  end
+
+  context 'or' do
+    subject { Feature.operations[:or] }
+
+    specify do
+      expect(subject.call(double(id: 16), :id, {"in" => (10..20), "not" => 15})).to eq true
+      expect(subject.call(double(id: 15), :id, {"in" => (10..20), "not" => 15})).to eq true
+    end
+  end
+
+  context 'range' do
+    subject { Feature.operations[:range] }
+
+    specify do
+      expect(subject.call([10, 20])).to eq((10..20))
+    end
+  end
+end

data/spec/toggles/feature/permissions_spec.rb

@@ -1,7 +1,7 @@
 describe Feature::Permissions do
   let(:path) { "features/multiple_subjects.yml" }
 
-  subject { Feature::Permissions.new(path) }
+  subject { Feature::Permissions.from_yaml(path) }
 
   its(:rules)    { is_expected.to eq({"user"=>{"id"=>1, "logged_in?"=>true},
                                       "widget"=>{"id"=>2}}) }

data/spec/toggles/feature_spec.rb

@@ -0,0 +1,37 @@
+describe 'features' do
+  let(:user)   { double(id: 1, logged_in?: true) }
+  let(:widget) { double(id: 2) }
+
+  context 'multiple subjects' do
+    specify { expect(Feature).to be_enabled(:multiple_subjects, user: user, widget: widget) }
+    specify { expect(Feature::MultipleSubjects).to be_enabled_for(user: user, widget: widget) }
+    specify { expect(Feature).not_to be_disabled(:multiple_subjects, user: user, widget: widget) }
+    specify { expect(Feature::MultipleSubjects).not_to be_disabled_for(user: user, widget: widget) }
+  end
+
+  context 'abbreviation with numbers' do
+    subject { Feature::AbbreviationsCN22.new(user: user) }
+
+    specify { expect(Feature).to be_enabled(:abbreviations_cn22, user: user) }
+    specify { expect(Feature::AbbreviationsCN22).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:abbreviations_cn22, user: user) }
+    specify { expect(Feature::AbbreviationsCN22).not_to be_disabled_for(user: user) }
+  end
+
+  context 'irregular capitalization' do
+    specify { expect(Feature).to be_enabled(:s3_file, user: user) }
+    specify { expect(Feature::S3File).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:s3_file, user: user) }
+    specify { expect(Feature).to be_disabled(:s3_file, user: widget) }
+    specify { expect(Feature::S3File).not_to be_disabled_for(user: user) }
+    specify { expect(Feature::S3File).to be_disabled_for(user: widget) }
+  end
+
+  context 'irregular capitalization' do
+    specify { expect(Feature).to be_enabled(:file_s3, user: user) }
+    specify { expect(Feature::FileS3).to be_enabled_for(user: user) }
+    specify { expect(Feature).not_to be_disabled(:file_s3, user: user) }
+    specify { expect(Feature::FileS3).not_to be_disabled_for(user: user) }
+    specify { expect(Feature).to be_disabled(:file_s3, user: widget) }
+  end
+end

data/spec/toggles/init_spec.rb

@@ -17,7 +17,7 @@ describe Toggles do
       Toggles.configure do |c|
         c.features_dir = temp_dir
       end
-      
+
       expect(Feature::Foo::Users.enabled_for?(id: 1)).to eq(true)
       expect(Feature::Bar::Users.enabled_for?(id: 3)).to eq(true)
     end
@@ -36,7 +36,7 @@ describe Toggles do
       Toggles.configure do |c|
         c.features_dir = temp_dir
       end
-      
+
       expect(Feature::Foo::Users.enabled_for?(id: 1)).to eq(true)
       expect(Feature::Foo::Children.enabled_for?(id: 1)).to eq(true)
 
@@ -49,7 +49,10 @@ describe Toggles do
       Toggles.init
 
       expect(Feature::Foo::Users.enabled_for?(id: 1)).to eq(false)
-      expect { Feature::Foo::Children.enabled_for?(id: 1) }.to raise_error(NameError)
+      expect { Feature::Bar::Children.enabled_for?(id: 1) }
+        .to raise_error(Feature::ConstantLookup::Error, 'Feature::Bar')
+      expect { Feature::Foo::Children.enabled_for?(id: 1) }
+        .to raise_error(Feature::ConstantLookup::Error, 'Feature::Foo::Children')
     end
   end
 
@@ -63,8 +66,10 @@ describe Toggles do
         c.features_dir = "#{temp_dir}/features"
       end
 
+      # the OS might reuse the inode if we do this in the obvious order
+      Dir.mkdir("#{temp_dir}/features2")
       Dir.delete("#{temp_dir}/features")
-      Dir.mkdir("#{temp_dir}/features")
+      File.rename("#{temp_dir}/features2", "#{temp_dir}/features")
 
       expect(Toggles).to receive("init")
       Toggles.reinit_if_changed

data/toggles.gemspec

@@ -1,13 +1,19 @@
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'toggles/version'
+
 Gem::Specification.new do |s|
-  s.name = "toggles"
-  s.version = "0.1.2"
-  s.authors = ["Andrew Tribone", "James Brown"]
-  s.summary = "YAML backed feature toggles"
-  s.email = "oss@easypost.com"
-  s.homepage = "https://github.com/EasyPost/toggles"
-  s.license = "ISC"
+  s.name = 'toggles'
+  s.version = Toggles::VERSION
+  s.authors = ['Andrew Tribone', 'James Brown', 'Josh Lane']
+  s.summary = 'YAML backed feature toggles'
+  s.email = 'oss@easypost.com'
+  s.homepage = 'https://github.com/EasyPost/toggles'
+  s.license = 'ISC'
   s.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
-  s.test_files = s.files.grep(/^(spec)\//)
+  s.test_files = s.files.grep(%r{^(spec)/})
   s.description = <<-EOF
     YAML-backed implementation of the feature flags pattern. Build a
     hierarchy of features in YAML files in the filesystem, apply various
@@ -15,12 +21,9 @@ Gem::Specification.new do |s|
     check whether a given feature should be applied.
   EOF
 
-  s.add_development_dependency "bundler"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "pry-nav"
-  s.add_development_dependency "pry-remote"
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "rspec-its"
-  s.add_development_dependency "rspec-temp_dir"
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rspec-its'
+  s.add_development_dependency 'rspec-temp_dir'
 end

metadata

@@ -1,126 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: toggles
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Andrew Tribone
 - James Brown
-autorequire: 
+- Josh Lane
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-11-08 00:00:00.000000000 Z
+date: 2023-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-nav
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry-remote
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-temp_dir
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: |2
@@ -133,33 +92,36 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".github/workflows/ci.yml"
+- ".gitignore"
+- ".rspec"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- features/abbreviations_cn22.yml
 - features/collection.yml
 - features/complex_and.yml
+- features/file_s3.yml
 - features/multiple_subjects.yml
 - features/nested_attributes.yml
+- features/nested_foo/bar_baz.yml
 - features/or_attributes.yml
+- features/s3_file.yml
 - features/type.yml
 - lib/toggles.rb
 - lib/toggles/configuration.rb
+- lib/toggles/constant_lookup.rb
 - lib/toggles/feature.rb
-- lib/toggles/feature/base.rb
-- lib/toggles/feature/operation.rb
+- lib/toggles/feature/attribute.rb
 - lib/toggles/feature/operation/and.rb
-- lib/toggles/feature/operation/attribute.rb
 - lib/toggles/feature/operation/gt.rb
 - lib/toggles/feature/operation/in.rb
-- lib/toggles/feature/operation/lt.rb
-- lib/toggles/feature/operation/not.rb
-- lib/toggles/feature/operation/or.rb
 - lib/toggles/feature/operation/range.rb
 - lib/toggles/feature/permissions.rb
 - lib/toggles/feature/subject.rb
+- lib/toggles/version.rb
 - spec/spec_helper.rb
 - spec/toggles/configuration_spec.rb
 - spec/toggles/feature/acceptance/collection_spec.rb
@@ -168,41 +130,34 @@ files:
 - spec/toggles/feature/acceptance/nested_attributes_spec.rb
 - spec/toggles/feature/acceptance/or_attributes_spec.rb
 - spec/toggles/feature/acceptance/type_spec.rb
-- spec/toggles/feature/base_spec.rb
-- spec/toggles/feature/operation/and_spec.rb
-- spec/toggles/feature/operation/attribute_spec.rb
-- spec/toggles/feature/operation/gt_spec.rb
-- spec/toggles/feature/operation/in_spec.rb
-- spec/toggles/feature/operation/lt_spec.rb
-- spec/toggles/feature/operation/not_spec.rb
-- spec/toggles/feature/operation/or_spec.rb
-- spec/toggles/feature/operation/range_spec.rb
+- spec/toggles/feature/attribute_spec.rb
+- spec/toggles/feature/operation_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
+- spec/toggles/feature_spec.rb
 - spec/toggles/init_spec.rb
 - toggles.gemspec
 homepage: https://github.com/EasyPost/toggles
 licenses:
 - ISC
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.0.14.1
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: YAML backed feature toggles
 test_files:
@@ -214,15 +169,9 @@ test_files:
 - spec/toggles/feature/acceptance/nested_attributes_spec.rb
 - spec/toggles/feature/acceptance/or_attributes_spec.rb
 - spec/toggles/feature/acceptance/type_spec.rb
-- spec/toggles/feature/base_spec.rb
-- spec/toggles/feature/operation/and_spec.rb
-- spec/toggles/feature/operation/attribute_spec.rb
-- spec/toggles/feature/operation/gt_spec.rb
-- spec/toggles/feature/operation/in_spec.rb
-- spec/toggles/feature/operation/lt_spec.rb
-- spec/toggles/feature/operation/not_spec.rb
-- spec/toggles/feature/operation/or_spec.rb
-- spec/toggles/feature/operation/range_spec.rb
+- spec/toggles/feature/attribute_spec.rb
+- spec/toggles/feature/operation_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
+- spec/toggles/feature_spec.rb
 - spec/toggles/init_spec.rb

data/lib/toggles/feature/base.rb

@@ -1,27 +0,0 @@
-require "yaml"
-
-module Feature
-  class Base
-    attr_reader :subjects
-
-    def self.enabled_for?(subjects = {})
-      new(subjects).enabled?
-    end
-
-    def self.disabled_for?(subjects = {})
-      !enabled_for? subjects
-    end
-
-    def initialize(subjects)
-      @subjects = subjects
-    end
-
-    def permissions
-      @permissions ||= self.class::PERMISSIONS
-    end
-
-    def enabled?
-      permissions.valid_for? subjects
-    end
-  end
-end

data/lib/toggles/feature/operation/attribute.rb

@@ -1,19 +0,0 @@
-module Feature
-  module Operation
-    class Attribute
-      def self.call(entity, attr_name, expected)
-        if expected.kind_of? Hash
-          expected.all? do |operation, rules|
-            if OPERATIONS.include? operation.to_sym
-              OPERATIONS[operation.to_sym].call(entity, attr_name, rules)
-            else
-              Operation::Attribute.call(entity.send(attr_name), operation, rules)
-            end
-          end
-        else
-          entity.send(attr_name) == expected
-        end
-      end
-    end
-  end
-end

data/lib/toggles/feature/operation/lt.rb

@@ -1,9 +0,0 @@
-module Feature
-  module Operation
-    class LessThan
-      def self.call(entity, attr_name, expected)
-        entity.send(attr_name) < expected
-      end
-    end
-  end
-end

data/lib/toggles/feature/operation/not.rb

@@ -1,15 +0,0 @@
-module Feature
-  module Operation
-    class Not
-      def self.call(entity, attr_name, expected)
-        if expected.kind_of? Hash
-          expected.none? do |operation, value|
-            OPERATIONS[operation.to_sym].call(entity, attr_name, value)
-          end
-        else
-          entity.send(attr_name) != expected
-        end
-      end
-    end
-  end
-end

data/lib/toggles/feature/operation/or.rb

@@ -1,15 +0,0 @@
-module Feature
-  module Operation
-    class Or
-      def self.call(entity, attr_name, expected)
-        expected.any? do |operation, value|
-          if OPERATIONS.include? operation.to_sym
-            OPERATIONS[operation.to_sym].call(entity, attr_name, value)
-          else
-            Operation::Attribute.call(entity, operation, value)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/toggles/feature/operation.rb

@@ -1,8 +0,0 @@
-require "toggles/feature/operation/and"
-require "toggles/feature/operation/attribute"
-require "toggles/feature/operation/gt"
-require "toggles/feature/operation/in"
-require "toggles/feature/operation/lt"
-require "toggles/feature/operation/not"
-require "toggles/feature/operation/or"
-require "toggles/feature/operation/range"

data/spec/toggles/feature/base_spec.rb

@@ -1,10 +0,0 @@
-describe Feature::Base do
-  let(:user)   { double(id: 1, logged_in?: true) }
-  let(:widget) { double(id: 2) }
-
-  subject { Feature::MultipleSubjects.new(user: user, widget: widget) }
-
-  its(:enabled?)              { is_expected.to eq true }
-  its(:subjects)              { is_expected.to eq user: user, widget: widget }
-  its("permissions.subjects") { is_expected.to eq [:user, :widget] }
-end

data/spec/toggles/feature/operation/and_spec.rb

@@ -1,9 +0,0 @@
-describe Feature::Operation::And do
-  specify do
-    [[60, true], [40, false], [80, false]].each do |(id, expected)|
-      expect(
-        described_class.call(double(id: id), :id, {"gt" => 50, "lt" => 70})
-      ).to eq expected
-    end
-  end
-end

data/spec/toggles/feature/operation/attribute_spec.rb

@@ -1,9 +0,0 @@
-describe Feature::Operation::Attribute do
-  specify do
-    expect(described_class.call(double(id: 50), :id, 50)).to eq true
-    expect(described_class.call(double(id: 50), :id, 51)).to eq false
-
-    expect(described_class.call(double(id: 50), :id, {"in" => (0..50), "not" => 49})).to eq true
-    expect(described_class.call(double(id: 49), :id, {"in" => (0..50), "not" => 49})).to eq false
-  end
-end

data/spec/toggles/feature/operation/gt_spec.rb

@@ -1,6 +0,0 @@
-describe Feature::Operation::GreaterThan do
-  specify do
-    expect(described_class.call(double(id: 50), :id, 40)).to eq true
-    expect(described_class.call(double(id: 50), :id, 60)).to eq false
-  end
-end

data/spec/toggles/feature/operation/in_spec.rb

@@ -1,7 +0,0 @@
-describe Feature::Operation::In do
-  specify do
-    expect(described_class.call(double(id: 50), :id, {"range" => [40, 60]})).to eq true
-    expect(described_class.call(double(id: 50), :id, [1])).to eq false
-    expect(described_class.call(double(id: nil), :id, [1])).to eq false
-  end
-end

data/spec/toggles/feature/operation/lt_spec.rb

@@ -1,6 +0,0 @@
-describe Feature::Operation::LessThan do
-  specify do
-    expect(described_class.call(double(id: 50), :id, 60)).to eq true
-    expect(described_class.call(double(id: 50), :id, 40)).to eq false
-  end
-end

data/spec/toggles/feature/operation/not_spec.rb

@@ -1,6 +0,0 @@
-describe Feature::Operation::Not do
-  specify do
-    expect(described_class.call(double(id: 50), :id, {"in" => (10..20)})).to eq true
-    expect(described_class.call(double(id: 50), :id, 50)).to eq false
-  end
-end

data/spec/toggles/feature/operation/or_spec.rb

@@ -1,6 +0,0 @@
-describe Feature::Operation::Or do
-  specify do
-    expect(described_class.call(double(id: 16), :id, {"in" => (10..20), "not" => 15})).to eq true
-    expect(described_class.call(double(id: 15), :id, {"in" => (10..20), "not" => 15})).to eq true
-  end
-end

data/spec/toggles/feature/operation/range_spec.rb

@@ -1,5 +0,0 @@
-describe Feature::Operation::Range do
-  specify do
-    expect(described_class.call([10, 20])).to eq (10..20)
-  end
-end