toggles 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 51bb6e97c911c1565aeb75d196617d10e71d9903
-  data.tar.gz: dd23e2efe0e2d7973efecc74692e2c87630c799a
+  metadata.gz: 667d45b0572c3986b8f26a65f9d875c29418fb5f
+  data.tar.gz: dcf2a50e338291a73cb2ce901a1eed0d5b12cdec
 SHA512:
-  metadata.gz: 2020f4c3044bec0802bc2dc168f1fa2e7f5053e5b90185272cbcf57e968453c4b49968ec948867505bf10b2d8ad75944cc2e78fbe8cac52d47d9e05648488294
-  data.tar.gz: abe63515e325397441f189c63e4261e23769127ed1a8d2994af7b9d0cd34323854edf989e2aad44de28b538da2a0747ba7a01fb996b4c3ef80a4fbcbaaf17e90
+  metadata.gz: 6b40d286dd30e05530d36cab7fde5cb9a1ac78fafb152130bd58428f0648099b44567d8b8b3ab23bcb2122142d819d5c08e251a3135c7d9e74671b217725ec5e
+  data.tar.gz: 7d8fb44ef3432bafbfe5a7e47eb75e59c7498f210bbca9ff092164654aba4e07dbce2aa411b1adc742c035c0022a5a8538e79b8751bf1eae02146b9cc2d00e7d

data/features/nested_attributes.yml

@@ -0,0 +1,12 @@
+foo:
+  bar:
+    not:
+      in:
+        - :one
+        - two
+  baz:
+    id:
+      or:
+        gt: 50
+        in:
+          - 10

data/lib/toggles/feature/permissions/operation/attribute.rb

@@ -4,8 +4,12 @@ module Feature
       class Attribute
         def self.call(entity, attr_name, expected)
           if expected.kind_of? Hash
-            expected.all? do |operation, value|
-              OPERATIONS[operation.to_sym].call(entity, attr_name, value)
+            expected.all? do |operation, rules|
+              if OPERATIONS.include? operation.to_sym
+                OPERATIONS[operation.to_sym].call(entity, attr_name, rules)
+              else
+                Operation::Attribute.call(entity.send(attr_name), operation, rules)
+              end
             end
           else
             entity.send(attr_name) == expected

data/lib/toggles/feature/permissions.rb

@@ -4,16 +4,12 @@ module Feature
   class Permissions
     extend Forwardable
 
-    attr_reader :path
+    attr_reader :rules
 
     def_delegators :rules, :all?, :keys
 
     def initialize(path)
-      @path = path
-    end
-
-    def rules
-      @rules ||= YAML.load(File.read(path))
+      @rules = YAML.load(File.read(path))
     end
 
     def subjects

data/lib/toggles/feature/subject.rb

@@ -2,7 +2,7 @@ module Feature
   module Subject
     class Invalid < StandardError
       def initialize(args)
-        super("Invalid subjects for permissions: #{args}")
+        super("Invalid or missing subjects for permissions: #{args}")
       end
     end
 

data/spec/toggles/feature/base_spec.rb

@@ -18,7 +18,8 @@ describe Feature::Base do
 
     specify "invalid permissions" do
       expect { Feature::Test.enabled_for?(widget: double) }.
-        to raise_error Feature::Subject::Invalid, "Invalid subjects for permissions: [:user]"
+        to raise_error Feature::Subject::Invalid,
+          "Invalid or missing subjects for permissions: [:user]"
     end
 
     specify "collection" do

data/spec/toggles/feature/nested_attributes_spec.rb

@@ -0,0 +1,25 @@
+describe "nested_attributes.yml" do
+  specify do
+    expect(
+      Feature::NestedAttributes.enabled_for?(
+        foo: double(bar: :two, baz: double(id: 51))
+      )
+    ).to eq true
+    expect(
+      Feature::NestedAttributes.enabled_for?(
+        foo: double(bar: :two, baz: double(id: 10))
+      )
+    ).to eq true
+
+    expect(
+      Feature::NestedAttributes.enabled_for?(
+        foo: double(bar: :one, baz: double(id: 51))
+      )
+    ).to eq false
+    expect(
+      Feature::NestedAttributes.enabled_for?(
+        foo: double(bar: :two, baz: double(id: 50))
+      )
+    ).to eq false
+  end
+end

data/spec/toggles/feature/permissions_spec.rb

@@ -3,7 +3,6 @@ describe Feature::Permissions do
 
   subject { Feature::Permissions.new(path) }
 
-  its(:path)     { is_expected.to eq path }
   its(:rules)    { is_expected.to eq({"user"=>{"id"=>1, "logged_in?"=>true},
                                       "widget"=>{"id"=>2}}) }
   its(:subjects) { [:user, :widget] }
@@ -18,7 +17,8 @@ describe Feature::Permissions do
 
     specify "invalid subjects" do
       expect { subject.valid_for?(user: double) }.
-        to raise_error Feature::Subject::Invalid, "Invalid subjects for permissions: [:widget]"
+        to raise_error Feature::Subject::Invalid,
+          "Invalid or missing subjects for permissions: [:widget]"
     end
   end
 end

data/spec/toggles/feature/subject_spec.rb

@@ -2,7 +2,7 @@ describe Feature::Subject do
   describe Feature::Subject::Invalid do
     subject { Feature::Subject::Invalid.new([:user]) }
 
-    its(:message) { is_expected.to eq "Invalid subjects for permissions: [:user]" }
+    its(:message) { is_expected.to eq "Invalid or missing subjects for permissions: [:user]" }
   end
 
   describe "#difference" do

data/toggles.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "toggles"
-  s.version = "0.0.4"
+  s.version = "0.0.5"
   s.authors = ["Andrew Tribone"]
   s.summary = "YAML backed feature toggles"
   s.email = "tribone@easypost.com"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: toggles
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Andrew Tribone
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-10 00:00:00.000000000 Z
+date: 2014-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -119,6 +119,7 @@ files:
 - Gemfile
 - Rakefile
 - features/collection.yml
+- features/nested_attributes.yml
 - features/test.yml
 - lib/toggles.rb
 - lib/toggles/feature.rb
@@ -136,6 +137,7 @@ files:
 - lib/toggles/feature/subject.rb
 - spec/spec_helper.rb
 - spec/toggles/feature/base_spec.rb
+- spec/toggles/feature/nested_attributes_spec.rb
 - spec/toggles/feature/permissions/operation/and_spec.rb
 - spec/toggles/feature/permissions/operation/attribute_spec.rb
 - spec/toggles/feature/permissions/operation/gt_spec.rb
@@ -146,7 +148,6 @@ files:
 - spec/toggles/feature/permissions/operation/range_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
-- spec/toggles_spec.rb
 - toggles.gemspec
 homepage: ''
 licenses:
@@ -175,6 +176,7 @@ summary: YAML backed feature toggles
 test_files:
 - spec/spec_helper.rb
 - spec/toggles/feature/base_spec.rb
+- spec/toggles/feature/nested_attributes_spec.rb
 - spec/toggles/feature/permissions/operation/and_spec.rb
 - spec/toggles/feature/permissions/operation/attribute_spec.rb
 - spec/toggles/feature/permissions/operation/gt_spec.rb
@@ -185,4 +187,3 @@ test_files:
 - spec/toggles/feature/permissions/operation/range_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
-- spec/toggles_spec.rb