toggles 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a4ae066034b92038bdbffd7082fdaefb09108ecb
-  data.tar.gz: 3296e6281f6ab89e6e3e75454ebfca6ec72f2d1d
+  metadata.gz: 51bb6e97c911c1565aeb75d196617d10e71d9903
+  data.tar.gz: dd23e2efe0e2d7973efecc74692e2c87630c799a
 SHA512:
-  metadata.gz: a1eefd9031d02acf595957bc6f7fd3254d3dd31d7f1c840490b645d425d4d01d407bb02d0b73f6f55c29dcdfde7d9440d29d7e5a7ae06615e28e836a7563fe92
-  data.tar.gz: eba16fc60170e6b3a43d8422d5ac8b93911a68f466cbed5469ee9315c7f05ba0cf0a6cb75a9103b32d40ecdd5c2908b3a70d0b1f57deccb054a87eeed8e82fc2
+  metadata.gz: 2020f4c3044bec0802bc2dc168f1fa2e7f5053e5b90185272cbcf57e968453c4b49968ec948867505bf10b2d8ad75944cc2e78fbe8cac52d47d9e05648488294
+  data.tar.gz: abe63515e325397441f189c63e4261e23769127ed1a8d2994af7b9d0cd34323854edf989e2aad44de28b538da2a0747ba7a01fb996b4c3ef80a4fbcbaaf17e90

data/lib/toggles/feature.rb

@@ -10,6 +10,7 @@ module Feature
                 gt:    Permissions::Operation::GreaterThan,
                 in:    Permissions::Operation::In,
                 lt:    Permissions::Operation::LessThan,
+                not:   Permissions::Operation::Not,
                 or:    Permissions::Operation::Or,
                 range: Permissions::Operation::Range}
 end

data/lib/toggles/feature/permissions/operation.rb

@@ -1,7 +1,8 @@
 require "toggles/feature/permissions/operation/and"
+require "toggles/feature/permissions/operation/attribute"
 require "toggles/feature/permissions/operation/gt"
 require "toggles/feature/permissions/operation/in"
 require "toggles/feature/permissions/operation/lt"
+require "toggles/feature/permissions/operation/not"
 require "toggles/feature/permissions/operation/or"
-require "toggles/feature/permissions/operation/property"
 require "toggles/feature/permissions/operation/range"

data/lib/toggles/feature/permissions/operation/and.rb

@@ -4,9 +4,7 @@ module Feature
       class And
         def self.call(entity, attr_name, expected)
           expected.all? do |operation, value|
-            OPERATIONS.fetch(operation.to_sym, Attribute).call(
-              entity, attr_name, value
-            )
+            OPERATIONS[operation.to_sym].call(entity, attr_name, value)
           end
         end
       end

data/lib/toggles/feature/permissions/operation/{property.rb → attribute.rb}

@@ -5,9 +5,7 @@ module Feature
         def self.call(entity, attr_name, expected)
           if expected.kind_of? Hash
             expected.all? do |operation, value|
-              OPERATIONS.fetch(operation.to_sym, Operation::Attribute).call(
-                entity, attr_name, value
-              )
+              OPERATIONS[operation.to_sym].call(entity, attr_name, value)
             end
           else
             entity.send(attr_name) == expected

data/lib/toggles/feature/permissions/operation/not.rb

@@ -0,0 +1,17 @@
+module Feature
+  class Permissions
+    module Operation
+      class Not
+        def self.call(entity, attr_name, expected)
+          if expected.kind_of? Hash
+            expected.none? do |operation, value|
+              OPERATIONS[operation.to_sym].call(entity, attr_name, value)
+            end
+          else
+            entity.send(attr_name) != expected
+          end
+        end
+      end
+    end
+  end
+end

data/lib/toggles/feature/permissions/operation/or.rb

@@ -4,9 +4,7 @@ module Feature
       class Or
         def self.call(entity, attr_name, expected)
           expected.any? do |operation, value|
-            OPERATIONS.fetch(operation.to_sym, Attribute).call(
-              entity, attr_name, value
-            )
+            OPERATIONS[operation.to_sym].call(entity, attr_name, value)
           end
         end
       end

data/spec/toggles/feature/permissions/operation/and_spec.rb

@@ -0,0 +1,9 @@
+describe Feature::Permissions::Operation::And do
+  specify do
+    [[60, true], [40, false], [80, false]].each do |(id, expected)|
+      expect(
+        described_class.call(double(id: id), :id, {"gt" => 50, "lt" => 70})
+      ).to eq expected
+    end
+  end
+end

data/spec/toggles/feature/permissions/operation/attribute_spec.rb

@@ -0,0 +1,9 @@
+describe Feature::Permissions::Operation::Attribute do
+  specify do
+    expect(described_class.call(double(id: 50), :id, 50)).to eq true
+    expect(described_class.call(double(id: 50), :id, 51)).to eq false
+
+    expect(described_class.call(double(id: 50), :id, {"in" => (0..50), "not" => 49})).to eq true
+    expect(described_class.call(double(id: 49), :id, {"in" => (0..50), "not" => 49})).to eq false
+  end
+end

data/spec/toggles/feature/permissions/operation/gt_spec.rb

@@ -0,0 +1,6 @@
+describe Feature::Permissions::Operation::GreaterThan do
+  specify do
+    expect(described_class.call(double(id: 50), :id, 40)).to eq true
+    expect(described_class.call(double(id: 50), :id, 60)).to eq false
+  end
+end

data/spec/toggles/feature/permissions/operation/in_spec.rb

@@ -0,0 +1,6 @@
+describe Feature::Permissions::Operation::In do
+  specify do
+    expect(described_class.call(double(id: 50), :id, {"range" => [40, 60]})).to eq true
+    expect(described_class.call(double(id: 50), :id, [1])).to eq false
+  end
+end

data/spec/toggles/feature/permissions/operation/lt_spec.rb

@@ -0,0 +1,6 @@
+describe Feature::Permissions::Operation::LessThan do
+  specify do
+    expect(described_class.call(double(id: 50), :id, 60)).to eq true
+    expect(described_class.call(double(id: 50), :id, 40)).to eq false
+  end
+end

data/spec/toggles/feature/permissions/operation/not_spec.rb

@@ -0,0 +1,6 @@
+describe Feature::Permissions::Operation::Not do
+  specify do
+    expect(described_class.call(double(id: 50), :id, {"in" => (10..20)})).to eq true
+    expect(described_class.call(double(id: 50), :id, 50)).to eq false
+  end
+end

data/spec/toggles/feature/permissions/operation/or_spec.rb

@@ -0,0 +1,6 @@
+describe Feature::Permissions::Operation::Or do
+  specify do
+    expect(described_class.call(double(id: 16), :id, {"in" => (10..20), "not" => 15})).to eq true
+    expect(described_class.call(double(id: 15), :id, {"in" => (10..20), "not" => 15})).to eq true
+  end
+end

data/spec/toggles/feature/permissions/operation/range_spec.rb

@@ -0,0 +1,5 @@
+describe Feature::Permissions::Operation::Range do
+  specify do
+    expect(described_class.call([10, 20])).to eq (10..20)
+  end
+end

data/toggles.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "toggles"
-  s.version = "0.0.3"
+  s.version = "0.0.4"
   s.authors = ["Andrew Tribone"]
   s.summary = "YAML backed feature toggles"
   s.email = "tribone@easypost.com"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: toggles
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Andrew Tribone
@@ -126,15 +126,24 @@ files:
 - lib/toggles/feature/permissions.rb
 - lib/toggles/feature/permissions/operation.rb
 - lib/toggles/feature/permissions/operation/and.rb
+- lib/toggles/feature/permissions/operation/attribute.rb
 - lib/toggles/feature/permissions/operation/gt.rb
 - lib/toggles/feature/permissions/operation/in.rb
 - lib/toggles/feature/permissions/operation/lt.rb
+- lib/toggles/feature/permissions/operation/not.rb
 - lib/toggles/feature/permissions/operation/or.rb
-- lib/toggles/feature/permissions/operation/property.rb
 - lib/toggles/feature/permissions/operation/range.rb
 - lib/toggles/feature/subject.rb
 - spec/spec_helper.rb
 - spec/toggles/feature/base_spec.rb
+- spec/toggles/feature/permissions/operation/and_spec.rb
+- spec/toggles/feature/permissions/operation/attribute_spec.rb
+- spec/toggles/feature/permissions/operation/gt_spec.rb
+- spec/toggles/feature/permissions/operation/in_spec.rb
+- spec/toggles/feature/permissions/operation/lt_spec.rb
+- spec/toggles/feature/permissions/operation/not_spec.rb
+- spec/toggles/feature/permissions/operation/or_spec.rb
+- spec/toggles/feature/permissions/operation/range_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
 - spec/toggles_spec.rb
@@ -166,6 +175,14 @@ summary: YAML backed feature toggles
 test_files:
 - spec/spec_helper.rb
 - spec/toggles/feature/base_spec.rb
+- spec/toggles/feature/permissions/operation/and_spec.rb
+- spec/toggles/feature/permissions/operation/attribute_spec.rb
+- spec/toggles/feature/permissions/operation/gt_spec.rb
+- spec/toggles/feature/permissions/operation/in_spec.rb
+- spec/toggles/feature/permissions/operation/lt_spec.rb
+- spec/toggles/feature/permissions/operation/not_spec.rb
+- spec/toggles/feature/permissions/operation/or_spec.rb
+- spec/toggles/feature/permissions/operation/range_spec.rb
 - spec/toggles/feature/permissions_spec.rb
 - spec/toggles/feature/subject_spec.rb
 - spec/toggles_spec.rb