todorb 0.2.1 → 1.0.0

data/lib/todorb.rb

@@ -10,23 +10,56 @@
 require 'rubygems'
 #require 'csv'
 require 'common/colorconstants'
-include ColorConstants
 require 'common/sed'
+require 'common/cmdapp'
+include ColorConstants
 include Sed
+include Cmdapp
 
 PRI_A = YELLOW + BOLD
 PRI_B = WHITE  + BOLD
 PRI_C = GREEN  + BOLD
 PRI_D = CYAN  + BOLD
-VERSION = "1.0"
+VERSION = "2.0"
 DATE = "2010-06-10"
-APPNAME = $0
+APPNAME = File.basename($0)
 AUTHOR = "rkumar"
+TABSTOP = 4 # indentation of subtasks
 
 class Todo
+  # This class is responsible for all todo task related functionality.
+  #
+  # == Create a file
+  # Adding a task is the first operation.
+  #     $ todorb add "Create a project in rubyforge"
+  #     $ todorb add "Update Rakefile with project name"
+  # The above creates a TODO2.txt file and a serial_number file.
+  #
+  # == List tasks
+  # To list open/unstarted tasks:
+  #     $ todorb 
+  # To list closed tasks also:
+  #     $ todorb --show-all
+  #
+  # If you are located elsewhere, give directory name:
+  #     $ todorb -d ~/
+  #
+  # == Close a task (mark as done)
+  #     $ todorb status close 1
+  # 
+  # == Add priority
+  #     $ todorb pri A 2
+  #
+  # For more:
+  #     $ todorb --help
+  #     $ todorb --show-actions
+  #
+  # == TODO:
+  #
   def initialize options, argv
  
     @options = options
+    @aliases = {}
     @argv = argv
     @file = options[:file]
     ## data is a 2 dim array: rows and fields. It contains each row of the file
@@ -35,62 +68,59 @@ class Todo
     init_vars
   end
   def init_vars
-    @todo_default_action = "list"
-    @todo_file_path = @options[:file] || "TODO2.txt"
-    #@todo_serial_path = File.expand_path("~/serial_numbers")
-    @todo_serial_path = "serial_numbers"
-    @archive_path = "todo_archive.txt" # should take path of todo and put there TODO:
+    @app_default_action = "list"
+    @app_file_path = @options[:file] || "TODO2.txt"
+    #@app_serial_path = File.expand_path("~/serial_numbers")
+    @app_serial_path = "serial_numbers"
+    @archive_path = "todo_archive.txt" 
+    @deleted_path = "todo_deleted.txt"
     @todo_delim = "\t"
     @appname = File.basename( Dir.getwd ) #+ ".#{$0}"
+    # in order to support the testing framework
     t = Time.now
+    ut = ENV["TODO_TEST_TIME"]
+    t = Time.at(ut.to_i) if ut
     @now = t.strftime("%Y-%m-%d %H:%M:%S")
     @today = t.strftime("%Y-%m-%d")
     @verbose = @options[:verbose]
+    $valid_array = false
+    # menu MENU
     #@actions = %w[ list add pri priority depri tag del delete status redo note archive help]
     @actions = {}
     @actions["list"] = "List all tasks.\n\t --hide-numbering --renumber"
-    @actions["add"] = "Add a task. \n\t #{$0} add <TEXT>\n\t --component C --project P --priority X add <TEXT>"
-    @actions["pri"] = "Add priority to task. \n\t #{$0} pri <ITEM> [A-Z]"
+    @actions["listsub"] = "List all tasks.\n\t --hide-numbering --renumber"
+    @actions["add"] = "Add a task. \n\t #{$APPNAME} add <TEXT>\n\t --component C --project P --priority X add <TEXT>"
+    @actions["pri"] = "Add priority to task. \n\t #{$APPNAME} pri <ITEM> [A-Z]"
     @actions["priority"] = "Same as pri"
-    @actions["depri"] = "Remove priority of task. \n\t #{$0} depri <ITEM>"
-    @actions["delete"] = "Delete a task. \n\t #{$0} delete <ITEM>"
+    @actions["depri"] = "Remove priority of task. \n\t #{$APPNAME} depri <ITEM>"
+    @actions["delete"] = "Delete a task. \n\t #{$APPNAME} delete <ITEM>"
     @actions["del"] = "Same as delete"
-    @actions["status"] = "Change the status of a task. \n\t #{$0} status <STAT> <ITEM>\n\t<STAT> are closed started pending unstarted hold next"
+    @actions["status"] = "Change the status of a task. \n\t #{$APPNAME} status <STAT> <ITEM>\n\t<STAT> are open closed started pending hold next"
     @actions["redo"] = "Renumbers the todo file starting 1"
-    @actions["note"] = "Add a note to an item. \n\t #{$0} note <ITEM> <TEXT>"
+    @actions["note"] = "Add a note to an item. \n\t #{$APPNAME} note <ITEM> <TEXT>"
+    @actions["tag"] = "Add a tag to an item/s. \n\t #{$APPNAME} tag <ITEMS> <TEXT>"
     @actions["archive"] = "archive closed tasks to archive.txt"
+    @actions["copyunder"] = "Move first item under second (as a subtask). aka cu"
+
     @actions["help"] = "Display help"
+    @actions["addsub"] = "Add a task under another . \n\t #{$APPNAME} add <TEXT>\n\t --component C --project P --priority X add <TEXT>"
 
+    # adding some sort of aliases so shortcuts can be defined
+    @aliases["open"] = ["status","open"]
+    @aliases["close"] = ["status","closed"]
+    @aliases["cu"] = ["copyunder"]
 
-    # TODO config
+    @copying = false # used by copyunder when it calls addsub
+    # TODO: config
     # we need to read up from config file and update
   end
-  # menu MENU
-  def run
-    @action = @argv[0] || @todo_default_action
-    @action = @action.downcase
-    @action.sub!('priority', 'pri')
-    @action.sub!(/^del$/, 'delete')
-
-
-    @argv.shift
-    if @actions.include? @action
-      send(@action, @argv)
-    else
-      help @argv
-    end
-  end
-  def help args
-    #puts "Actions are #{@actions.join(", ")} "
-    @actions.each_pair { |name, val| puts "#{name}\t#{val}" }
-  end
   def add args
     if args.empty?
       print "Enter todo: "
       STDOUT.flush
       text = gets.chomp
       if text.empty?
-        exit 1
+        exit ERRCODE
       end
       Kernel.print("You gave me '#{text}'") if @verbose
     else
@@ -101,70 +131,103 @@ class Todo
     text.tr! "\n", '
'
     Kernel.print("Got '#{text}'\n") if @verbose
     item = _get_serial_number
+    die "Could not get a new item number" if item.nil?
     paditem = _paditem(item)
-    print "item no is:#{paditem}:\n" if @verbose
+    verbose "item no is:#{paditem}:\n" 
     priority = @options[:priority] ? " (#{@options[:priority]})" : ""
     project  = @options[:project]  ? " +#{@options[:project]}"   : ""
     component  = @options[:component]  ? " @#{@options[:component]}"   : ""
     newtext="#{paditem}#{@todo_delim}[ ]#{priority}#{project}#{component} #{text} (#{@today})"
+    File.open(@app_file_path, "a") { | file| file.puts newtext }
     puts "Adding:"
     puts newtext
-    File.open(@todo_file_path, "a") { | file| file.puts newtext }
 
+    0
   end
   ##
-  # reads serial_number file, returns serialno for this app
-  # and increments the serial number and writes back.
-  def _get_serial_number
-    require 'fileutils'
-    appname = @appname
-    filename = @todo_serial_path
-    h = {}
-    if File.exists?(filename)
-      File.open(filename).each { |line|
-        #sn = $1 if line.match regex
-        x = line.split ":"
-        h[x[0]] = x[1].chomp
-      }
+  # add a subtask
+  # @param [Array] 1. item under which to place, 2. text
+  # @return 
+  # @example:
+  #    addsub 1 "A task"   
+  #       => will get added as 1.1 or 1.2 etc
+  #    addsub 1.3 "a task"
+  #       => will get added as 1.3.x
+  def addsub args
+    under = args.shift
+    text = args.join " "
+    exit unless text
+    #puts "under #{under} text: #{text} "
+    lastlinect = nil
+    lastlinetext = nil
+    # look for last item below given task (if there is)
+    Sed::egrep( [@app_file_path], Regexp.new("#{under}\.[0-9]+	")) do |fn,ln,line|
+      lastlinect = ln
+      lastlinetext = line
+      puts line if @verbose 
     end
-    sn = h[appname] || 1
-    # update the sn in file
-    nsn = sn.to_i + 1
-    # this will create if not exists in addition to storing if it does
-    h[appname] = nsn
-    # write back to file
-    File.open(filename, "w") do |f|
-      h.each_pair {|k,v| f.print "#{k}:#{v}\n"}
+    if lastlinect
+      verbose "Last line found #{lastlinetext} " 
+      m = lastlinetext.match(/\.([0-9]+)	/)
+      lastindex = m[1].to_i
+      # check if it has subitems, find last one only for linecount
+      Sed::egrep( [@app_file_path], Regexp.new("#{under}\.#{lastindex}\.[0-9]+	")) do |fn,ln,line|
+        lastlinect = ln
+      end
+      lastindex += 1
+      item = "#{under}.#{lastindex}"
+    else
+      # no subitem found, so this is first
+      item = "#{under}.1"
+      # get line of parent
+      found = nil
+      Sed::egrep( [@app_file_path], Regexp.new("#{under}	")) do |fn,ln,line|
+        lastlinect = ln
+        found = true
+      end
+      die "Task #{under} not found" unless found
     end
-    return sn
+    die "Could not determine which line to insert under" unless lastlinect
+    verbose "item is #{item} ::: line #{lastlinect} " 
+
+    # convert actual newline to C-a. slash n's are escapes so echo -e does not muck up.
+    text.tr! "\n", '
'
+    Kernel.print("Got '#{text}'\n") if @verbose
+    paditem = _paditem(item)
+    print "item no is:#{paditem}:\n" if @verbose
+    priority = @options[:priority] ? " (#{@options[:priority]})" : ""
+    project  = @options[:project]  ? " +#{@options[:project]}"   : ""
+    component  = @options[:component]  ? " @#{@options[:component]}"   : ""
+    level = (item.split '.').length
+    indent = " " * (TABSTOP * (level-1))
+    newtext=nil
+    if @copying
+      newtext="#{indent}#{item}#{@todo_delim}#{text}"
+    else
+      newtext="#{indent}#{paditem}#{@todo_delim}[ ]#{priority}#{project}#{component} #{text} (#{@today})"
+    end
+    raise "Cannot insert blank text. Programmer error!" unless newtext
+    #_backup
+    puts "Adding:"
+    puts newtext
+    Sed::insert_row(@app_file_path, lastlinect, newtext)
+    return 0
   end
-  ##
-  # After doing a redo of the numbering, we need to reset the numbers for that app
-  def _set_serial_number number
-    appname = @appname
-    pattern = Regexp.new "^#{appname}:.*$"
-    filename = @todo_serial_path
-    _backup filename
-    change_row filename, pattern, "#{appname}:#{number}"
-  end
-  def _backup filename=@todo_file_path
-    require 'fileutils'
-    FileUtils.cp filename, "#{filename}.org"
-  end
-  def check_file filename=@todo_file_path
+  def check_file filename=@app_file_path
     File.exists?(filename) or die "#{filename} does not exist in this dir. Use 'add' to create an item first."
   end
-  def die text
-    $stderr.puts text
-    exit 1
-  end
   ##
   # for historical reasons, I pad item to 3 spaces in text file.
   # It used to help me in printing straight off without any formatting in unix shell
   def _paditem item
     return sprintf("%3s", item)
   end
+  ##
+  # populates array with open tasks (or all if --show-all)
+  # DO NOT USE in conjunction with save_array since this is only open tasks
+  # Use load_array with save_array
   def populate
+    $valid_array = false # this array object should not be saved
     check_file
     @ctr = 0
     @total = 0
@@ -209,9 +272,9 @@ class Todo
     sort if @options[:sort]
     renumber if @options[:renumber]
     colorize # << currently this is where I print !! Since i colorize the whole line
-    puts 
-    puts " #{@data.length} of #{@total} rows displayed from #{@todo_file_path} "
-
+    puts " " 
+    puts " #{@data.length} of #{@total} rows displayed from #{@app_file_path} "
+    return 0
   end
   def print_todo
     @ctr = 0
@@ -285,198 +348,208 @@ class Todo
   #
   # @param [Array] priority, single char A-Z, item or items
   # @return 
-  # @ example:
+  # @example:
   # pri A 5 6 7
   # pri 5 6 7 A
-  # pri A 5 6 7 B 1 2 3
-  # pri 5 6 7 A 1 2 3 B
+  # -- NO LONGER this complicated system  pri A 5 6 7 B 1 2 3
+  # -- NO LONGER this complicated system  pri 5 6 7 A 1 2 3 B
 
+  # 2010-06-19 15:21 total rewrite, so we fetch item from array and warn if absent.
   def pri args
-    populate
-    changeon = nil
-    items = []
-    prior = nil
-    item = nil
+    errors = 0
+    ctr = 0
+    #populate # populate removed closed task so later saving will lose tasks
+    load_array
     ## if the first arg is priority then following items all have that priority
     ## if the first arg is item/s then wait for priority and use that
-    if args[0] =~ /^[A-Z]$/ 
-      changeon = :ITEM
-    elsif args[0] =~ /^[0-9]+$/
-      changeon = :PRI
-    else
-      puts "ERROR! "
-      exit 1
-    end
-    puts "args 0 is #{args[0]} "
-    args.each do |arg| 
-      if arg =~ /^[A-Z]$/ 
-        prior = arg #$1
-        if changeon == :PRI
-          puts " changing previous items #{items} to #{prior} "
-          items.each { |i| _pri(i, prior) }
-          items = []
+    prior, items = _separate args, /^[A-Z]$/ 
+    total = items.count
+    die "#{@action}: priority expected [A-Z]" unless prior
+    die "#{@action}: items expected" unless items
+    verbose "args 0 is #{args[0]}. pri #{prior} items #{items} "
+    items.each do |item| 
+      row = get_item(item)
+      if row
+        puts " #{row[0]} : #{row[1]} "
+        # remove existing priority if there
+        if row[1] =~ /\] (\([A-Z]\) )/
+          row[1].sub!(/\([A-Z]\) /,"")
         end
-      elsif arg =~ /^[0-9]+$/
-        item = arg #$1
-        if changeon == :ITEM
-          puts " changing #{item} to #{prior} "
-          _pri(item, prior)
+        ret = row[1].sub!(/\] /,"] (#{prior}) ")
+        if ret
+          puts " #{GREEN}#{row[0]} : #{row[1]} #{CLEAR}"
+          ctr += 1
         else
-          items << item
+          die "Error in sub(): #{row}.\nNothing saved. "
         end
       else
-        puts "ERROR in arg :#{arg}:"
+        errors += 1
+        warning "#{item} not found."
       end
     end
-    save_array
+
+    message "#{errors} error/s" if errors > 0
+    if ctr > 0
+      puts "Changed priority of #{ctr} task/s"
+      save_array 
+      return 0 
+    end
+    return ERRCODE
   end
   ##
-  # Reove the priority of a task
+  # Remove the priority of a task
   #
   # @param [Array] items to deprioritize
   # @return 
-  public
   def depri(args)
-    populate
-    puts "depri got #{args} "
-    each do |row|
-      item = row[0].sub(/^[ -]*/,'')
-      if args.include? item
-        if row[1] =~ /\] (\([A-Z]\) )/
-          puts row[1]
-          row[1].sub!(/\([A-Z]\) /,"")
-          puts "#{RED}#{row[1]}#{CLEAR}"
-        end
-      end
-    end
-  end
-  ## 
-  # saves the task array to disk
-  def save_array
-    File.open(@todo_file_path, "w") do |file| 
-      @data.each { |row| file.puts "#{row[0]}\t#{row[1]}" }
-    end
-  end
-  ## 
-  # change priority of given item to priority in array
-  private
-  def _pri item, pri
-    paditem = _paditem(item)
-    @data.each { |row| 
-      if row[0] == paditem
-        puts " #{row[0]} : #{row[1]} "
-        if row[1] =~ /\] (\([A-Z]\) )/
-          row[1].sub!(/\([A-Z]\) /,"")
-        end
-        row[1].sub!(/\] /,"] (#{pri}) ")
-        puts " #{RED}#{row[0]} : #{row[1]} #{CLEAR}"
-        return true
-      end
-    }
-    puts " #{RED} no such item #{item}  #{CLEAR} "
-    return false
-
+    change_items args, /\([A-Z]\) /,""
   end
   ##
   # Appends a tag to task
+  # FIXME: check with subtasks
   #
   # @param [Array] items and tag, or tag and items
   # @return 
-  public
   def tag(args)
-    puts "tags args #{args} "
-    items_first = items_first? args
-    items = []
-    tag = nil
-    args.each do |arg| 
-      if arg =~ /^[a-zA-Z]/ 
-        tag = arg
-      elsif arg =~ /^[0-9]+$/
-        items << arg
-      end
-    end
-    #items.each { |i| change_row }
-    change_file @todo_file_path do |line|
-      item = line.match(/^ *([0-9]+)/)
-      if items.include? item[1]
-        puts "#{line}" if @verbose
-        line.sub!(/$/, " @#{tag}")
-        puts "#{RED}#{line}#{CLEAR} " if @verbose
-      end
-    end
+    tag, items = _separate args
+    #change_items items do |item, row|
+      #ret = row[1].sub!(/ (\([0-9]{4})/, " @#{tag} "+'\1')
+      #ret
+    #end
+    change_items(items, / (\([0-9]{4})/, " @#{tag} "+'\1')
   end
   ##
   # deletes one or more items
   #
   # @param [Array, #include?] items to delete
   # @return 
+  # FIXME: if invalid item passed I have no way of giving error 
   public
   def delete(args)
-    puts "delete with #{args} "
-    delete_row @todo_file_path do |line|
-      #puts "line #{line} "
-      item = line.match(/^ *([0-9]+)/)
-      #puts "item #{item} "
-      if args.include? item[1]
-        if @options[:force]
-          true
+    ctr = errors = 0
+    items = args
+    die "#{@action}: items expected" unless items
+    total = items.count
+    totalitems = []
+    load_array
+    items.each do |item| 
+      if @options[:recursive]
+        a = get_item_subs item
+        if a
+          a.each { |e| 
+            totalitems << e; #e[0].strip
+          }
+        else
+          errors += 1
+          warning "#{item} not found."
+        end
+      else
+        row = get_item(item)
+        if row
+          totalitems << row
         else
-          puts line
-          print "Do you wish to delete (Y/N): "
-          STDOUT.flush
-          ans = STDIN.gets.chomp
-          ans =~ /[Yy]/
+          errors += 1
+          warning "#{item} not found."
         end
       end
     end
+    totalitems.each { |item| 
+      puts "#{item[0]} #{item[1]}"
+      print "Do you wish to delete (Y/N): "
+      STDOUT.flush
+      ans = STDIN.gets.chomp
+      if ans =~ /[Yy]/
+        @data.delete item
+        # put deleted row into deleted file, so one can undo
+        File.open(@deleted_path, "a") { | file| file.puts "#{item[0]}#{@todo_delim}#{item[1]}" }
+        ctr += 1
+      else
+        puts "Delete canceled #{item[0]}"
+      end
+    }
+    message "#{errors} error/s" if errors > 0
+    if ctr > 0
+      puts "Deleted #{ctr} task/s"
+      save_array 
+      return 0 
+    end
+    return ERRCODE
   end
   ##
   # Change status of given items
   #
-  # @param [Array, #include?] items to delete
+  # @param [Array, #include?] items to change status of
   # @return [true, false] success or fail
   public
   def status(args)
-    stat, items = _separate args
+    stat, items = _separate args #, /^[a-zA-Z]/ 
+    verbose "Items: #{items} : stat #{stat} "
     status, newstatus = _resolve_status stat
     if status.nil?
-      print_red "Status #{stat} is invalid!"
-      exit 1
+      die "Status #{stat} is invalid!"
     end
-    ctr = change_items(items, /(\[.\])/, "[#{newstatus}]")
-    puts "Changed status of #{ctr} items"
-    #change_items items do |item, line|
-      #puts line if @verbose
-      #line.sub!(/(\[.\])/, "[#{newstatus}]")
-      #puts "#{RED}#{line}#{CLEAR}" if @verbose
-    #end
+    # this worked fine for single items, but not for recursive changes 
+    #ctr = change_items(items, /(\[.\])/, "[#{newstatus}]")
+    totalitems = []
+    #ret = line.sub!(/(\[.\])/, "[#{newstatus}]")
+    load_array
+    items.each { |item| 
+      a = get_item_subs item
+      if a
+        a.each { |e| 
+          totalitems << e[0].strip
+        }
+      else
+        # perhaps I should pass item into total and let c_i handle error message
+        warning "No tasks found for #{item}"
+      end
+    }
+    change_items(totalitems, /(\[.\])/, "[#{newstatus}]")
+    0
   end
   ##
   # separates args into tag or subcommand and items
   # This allows user to pass e.g. a priority first and then item list
   # or item list first and then priority. 
   # This can only be used if the tag or pri or status is non-numeric and the item is numeric.
-  def _separate args
+  def _separate args, pattern=nil #/^[a-zA-Z]/ 
     tag = nil
     items = []
     args.each do |arg| 
-      if arg =~ /^[a-zA-Z]/ 
-        tag = arg
-      elsif arg =~ /^[0-9]+$/
+      if arg =~ /^[0-9\.]+$/
         items << arg
+      else
+        tag = arg
+        if pattern
+          die "#{@action}: #{arg} appears invalid." if arg !~ pattern
+        end
       end
     end
+    items = nil if items.empty?
     return tag, items
   end
   ##
   # Renumber while displaying
-  #
   # @return [true, false] success or fail
   private
   def renumber
+    ## this did not account for subtasks
+    #@data.each_with_index { |row, i| 
+      #paditem = _paditem(i+1)  
+      #row[0] = paditem
+    #}
+    ## this accounts for subtasks
+    ctr = 0
     @data.each_with_index { |row, i| 
-      paditem = _paditem(i+1)  
-      row[0] = paditem
+      # main task, increment counter
+      if row[0] =~ /^ *[0-9]+$/
+        ctr += 1
+        paditem = _paditem(ctr)  
+        row[0] = paditem
+      else
+        # assume its a subtask, just change the outer number
+        row[0].sub!(/[0-9]+\./, "#{ctr}.")
+      end
     }
   end
   ##
@@ -488,14 +561,11 @@ class Todo
   def note(args)
     _backup
     text = args.pop
-    change_items args do |item, line|
-      m = line.match(/^ */)
+    change_items args do |item, row|
+      m = row[0].match(/^ */)
       indent = m[0]
-      puts line if @verbose
-      # we place the text before the date, adding a C-a and indent
-      # At printing the C-a is replaced with a newline and some spaces
-      ret = line.sub!(/ (\([0-9]{4})/," 
#{indent}* #{text} "+'\1')
-      print_red line if @verbose
+      ret = row[1].sub!(/ (\([0-9]{4})/," 
#{indent}* #{text} "+'\1')
+      ret
     end
   end
   ##
@@ -508,7 +578,7 @@ class Todo
     filename = @archive_path
     file = File.open(filename, "a") 
     ctr = 0
-    delete_row @todo_file_path do |line|
+    Sed::delete_row @app_file_path do |line|
       if line =~ /\[x\]/
         file.puts line
         ctr += 1
@@ -519,60 +589,192 @@ class Todo
     file.close
     puts "Archived #{ctr} tasks."
   end
+  # Copy given item under second item
+  #
+  # @param [Array] 2 items, move first under second
+  # @return [Boolean] success or fail
+  public
+  def copyunder(args)
+    if args.nil? or args.count != 2
+      die "copyunder expects only 2 args: from and to item, both existing"
+    end
+    from = args[0]
+    to = args[1]
+    # extract item from
+    lastlinetext = nil
+    rx = regexp_item from
+    Sed::egrep( [@app_file_path], rx) do |fn,ln,line|
+      lastlinect = ln
+      lastlinetext = line
+      puts line
+    end
+    # removing everything from start to status inclusive
+    lastlinetext.sub!(/^.*\[/,'[').chomp!
+    puts lastlinetext
+    @copying = true
+    addsub [to, lastlinetext]
+    # remove item number and status ? 
+    # give to addsub to add.
+    # delete from
+    delete_item from
+    # take care of data in addsub (if existing, and also /
+  end
   ##
-  # For given items, ...
+  # Get row for given item or nil.
   #
-  # @param [Array, #include?] items to delete
-  # @return [true, false] success or fail
+  # @param [String] item to retrieve
+  # @return [Array, nil] success or fail
+  # Returns row from @data as String[2] comprising item and rest of line.
   public
-  def CHANGEME(args)
+  def get_item(item)
+    raise "Please load array first!" if @data.empty?
+    puts "get_item got #{item}." if @verbose
+    #rx = regexp_item(item)
+    rx = Regexp.new("^ +#{item}$")
+    @data.each { |row|
+      puts "    get_item read #{row[0]}." if @verbose 
+      return row if row[0] =~ rx
+    }
+    # not found
+    return nil
+  end
+  ## 
+  # list task and its subtasks
+  #  just testing this out
+  def listsub(args)
+    load_array
+    args.each { |item|  
+      a = get_item_subs item
+      puts "for #{item} "
+      a.each { |e| puts " #{e[0]} #{e[1]} " }
+    }
+    0
+  end
+  # get item and its subtasks
+  # (in an attempt to make recursive changes cleaner)
+  # @param item (taken from command line)
+  # @return [Array, nil] row[] objects
+  def get_item_subs(item)
+    raise "Please load array first!" if @data.empty?
+    verbose "get_item got #{item}."
+    #rx = regexp_item(item)
+    rx = Regexp.new("^ +#{item}$")
+    rx2 = Regexp.new("^ +#{item}\.")
+    rows = []
+    @data.each { |row|
+      verbose "    get_item read #{row[0]}."
+      if row[0] =~ rx
+        rows << row 
+        rx = rx2
+      end
+    }
+    return nil if rows.empty?
+    return rows
   end
   ##
-  # yields lines from file that match the given item
-  # We do not need to now parse and match the item in each method
-  def change_items args, pattern=nil, replacement=nil
-    changed_ctr = 0
-    change_file @todo_file_path do |line|
-      item = line.match(/^ *([0-9]+)/)
-      if args.include? item[1]
+  # For given items, search replace or yield item and row[]
+  # (earlier started as new_change_items)
+  #
+  # @param [Array, #each] items to change
+  # @yield item, row[] - split of line on tab.
+  # @return [0, ERRCODE] success or fail
+  public
+  def change_items items, pattern=nil, replacement=nil
+    ctr = errors = 0
+    #tag, items = _separate args
+    # or items = args
+    die "#{@action}: items expected" unless items
+    total = items.count
+    load_array
+    items.each do |item| 
+      row = get_item(item)
+      if row
         if pattern
-          puts line if @verbose
-          ret = line.sub!(pattern, replacement)
-          changed_ctr += 1 if ret
-          print_red line if @verbose
+          puts " #{row[0]} : #{row[1]} " if @verbose 
+          ret = row[1].sub!(pattern, replacement)
+          if ret
+            puts " #{GREEN}#{row[0]} : #{row[1]} #{CLEAR}"
+            ctr += 1
+          else
+            # this is since there could be a programmer error.
+            die "Possible error in sub() - No replacement: #{row[0]} : #{row[1]}.\nNothing saved. "
+          end
         else
-          yield item[1], line
+          puts " #{row[0]} : #{row[1]} " if @verbose 
+          ret = yield item, row
+          if ret
+            ctr += 1 
+            puts " #{GREEN}#{row[0]} : #{row[1]} #{CLEAR}"
+          end
         end
+      else
+        errors += 1
+        warning "#{item} not found."
       end
     end
-    return changed_ctr
+    message "#{errors} error/s" if errors > 0
+    if ctr > 0
+      puts "Changed #{ctr} task/s"
+      save_array 
+      return 0 
+    end
+    return ERRCODE
+  end
+  ## does a straight delete of an item, no questions asked
+  # internal use only.
+  def delete_item item
+    filename=@app_file_path
+    d = Sed::_read filename
+    d.delete_if { |row| line_contains_item?(row, item) }
+    Sed::_write filename, d
+  end
+  def line_contains_item? line, item
+    rx = regexp_item item
+    return line.match rx
+  end
+  def row_contains_item? row, item
+    rx = Regexp.new("^ +#{item}")
+    return row[0].match rx
+  end
+  # return a regexp for an item to do matches on - WARNING INCLUDES TAB
+  def regexp_item item
+    Regexp.new("^ +#{item}#{@todo_delim}")
+  end
+  # @unused - wrote so i could use it refactoring -  i should be using this TODO:
+  def extract_item line
+      item = line.match(/^ *([0-9\.]+)/)
+      return nil if item.nil?
+      return item[1]
   end
   ##
   # Redoes the numbering in the file.
   # Useful if the numbers have gone high and you want to start over.
   def redo args
-    ctr = 1
-    require 'fileutils'
-    FileUtils.cp @todo_file_path, "#{@todo_file_path}.org"
-    puts "Saved #{@todo_file_path} as #{@todo_file_path}.org"
-    change_file @todo_file_path do |line|
-      paditem = _paditem ctr
-      line.sub!(/^ *[0-9]+/, paditem)
-      ctr += 1
+    #require 'fileutils'
+    #FileUtils.cp @app_file_path, "#{@app_file_path}.org"
+    _backup
+    puts "Saved #{@app_file_path} as #{@app_file_path}.org"
+    #ctr = 1
+    #change_file @app_file_path do |line|
+      #paditem = _paditem ctr
+      #line.sub!(/^ *[0-9]+/, paditem)
+      #ctr += 1
+    #end
+    ctr = 0
+    Sed::change_file @app_file_path do |line|
+      if line =~ /^ *[0-9]+\t/
+        ctr += 1
+        paditem = _paditem ctr
+        line.sub!(/^ *[0-9]+\t/, "#{paditem}#{@todo_delim}")
+      else
+        # assume its a subtask, just change the outer number
+        line.sub!(/[0-9]+\./, "#{ctr}.")
+      end
     end
     _set_serial_number ctr
     puts "Redone numbering"
   end
   ##
-  # does this command start with items or something else
-  private
-  def items_first?(args)
-    return true if args[0] =~ /^[0-9]+$/
-    return false
-  end
-  def print_red line
-    puts "#{RED}#{line}#{CLEAR}"
-  end
   private
   def _resolve_status stat
     status = nil
@@ -601,28 +803,45 @@ class Todo
     #newstatus=$( echo $status | sed 's/^start/@/;s/^pend/P/;s/^close/x/;s/hold/H/;s/next/1/;s/^unstarted/ /' )
     return status, newstatus
   end
+  ##
+  # given some items, checks given line to see if it contains subtasks of given items
+  # if item is 3.1, does line contain 3.1.x 3.1.x.x etc or not
+  # @example
+  #     [1, 2, 3, 3.1, 3.1.1, 3.2, 3.3 ... ], "3.1.1"
+  def item_matches_subtask? items, item
+    items.each { |e| 
+      rx = Regexp.new "#{e}\."
+      m = item.match rx
+      return true if m
+    }
+    return false
+  end
+  ##     [1, 2, 3, 3.1, 3.1.1, 3.2, 3.3 ... ], " 3.1.1\t[ ] some task"
 
   def self.main args
+    ret = nil
     begin
       # http://www.ruby-doc.org/stdlib/libdoc/optparse/rdoc/classes/OptionParser.html
       require 'optparse'
       options = {}
       options[:verbose] = false
       options[:colorize] = true
+      # adding some env variable pickups, so you don't have to keep passing.
+      showall = ENV["TODO_SHOW_ALL"]
+      if showall
+        options[:show_all] = (showall == "0") ? false:true
+      end
+      plain = ENV["TODO_PLAIN"]
+      if plain
+        options[:colorize] = (plain == "0") ? false:true
+      end
 
       OptionParser.new do |opts|
-        opts.banner = "Usage: #{$0} [options] action"
+        opts.banner = "Usage: #{$APPNAME} [options] action"
 
         opts.separator ""
-        opts.separator "Specific options:"
-
+        opts.separator "Options for list and add:"
 
-        opts.on("-v", "--[no-]verbose", "Run verbosely") do |v|
-          options[:verbose] = v
-        end
-        opts.on("-f", "--file FILENAME", "CSV filename") do |v|
-          options[:file] = v
-        end
         opts.on("-P", "--project PROJECTNAME", "name of project for add or list") { |v|
           options[:project] = v
           options[:filter] = true
@@ -635,9 +854,14 @@ class Todo
           options[:component] = v
           options[:filter] = true
         }
+        opts.separator ""
+        opts.separator "Specific options:"
         opts.on("--force", "force delete or add without prompting") do |v|
           options[:force] = v
         end
+        opts.on("--recursive", "operate on subtasks also for delete, status") do |v|
+          options[:recursive] = v
+        end
         opts.separator ""
         opts.separator "List options:"
 
@@ -657,42 +881,57 @@ class Todo
         opts.on("--hide-numbering", "hide-numbering while listing ") do |v|
           options[:hide_numbering] = v
         end
-        opts.on("--show-all", "show all tasks (incl closed)") do |v|
+        opts.on("--[no-]show-all", "show all tasks (incl closed)") do |v|
           options[:show_all] = v
         end
 
         opts.separator ""
         opts.separator "Common options:"
 
-        opts.on_tail("-d DIR", "--dir DIR", "Use TODO file in this directory") do |v|
+        opts.on("-v", "--[no-]verbose", "Run verbosely") do |v|
+          options[:verbose] = v
+        end
+        opts.on("-f", "--file FILENAME", "CSV filename") do |v|
+          options[:file] = v
+        end
+        opts.on("-d DIR", "--dir DIR", "Use TODO file in this directory") do |v|
           require 'FileUtils'
           dir = File.expand_path v
           if File.directory? dir
             options[:dir] = dir
+            # changing dir is important so that serial_number file is the current one.
             FileUtils.cd dir
           else
-            puts "#{RED}#{v}: no such directory #{CLEAR}"
-            exit 1
+            die "#{RED}#{v}: no such directory #{CLEAR}"
           end
         end
         # No argument, shows at tail.  This will print an options summary.
         # Try it and see!
-        opts.on_tail("-h", "--help", "Show this message") do
+        opts.on("-h", "--help", "Show this message") do
           puts opts
-          exit
+          exit 0
         end
 
-        opts.on_tail("--show-actions", "show actions ") do |v|
+        opts.on("--show-actions", "show actions ") do |v|
           todo = Todo.new(options, ARGV)
           todo.help nil
           exit 0
         end
 
-        opts.on_tail("--version", "Show version") do
+        opts.on("--version", "Show version") do
           puts "#{APPNAME} version #{VERSION}, #{DATE}"
           puts "by #{AUTHOR}. This software is under the GPL License."
           exit 0
         end
+        opts.separator ""
+        opts.separator "Common Usage:"
+        opts.separator <<TEXT
+        #{APPNAME} list
+        #{APPNAME} add "TEXT ...."
+        #{APPNAME} pri 1 A
+        #{APPNAME} close 1 
+TEXT
+        
       end.parse!(args)
 
       options[:file] ||= "TODO2.txt"
@@ -704,10 +943,13 @@ class Todo
       #raise "-f FILENAME is mandatory" unless options[:file]
 
       todo = Todo.new(options, args)
-      todo.run
+      ret = todo.run
     ensure
     end
+  return ret
   end # main
 end # class Todo
 
-Todo.main(ARGV) if __FILE__ == $0
+if __FILE__ == $0
+  exit Todo.main(ARGV) 
+end