toadhopper 1.0.2 → 1.0.3

data/lib/toadhopper.rb

@@ -4,7 +4,8 @@ require 'ostruct'
 
 # Posts errors to the Hoptoad API
 class Toadhopper
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
+  FILTER_REPLACEMENT = "[FILTERED]"
 
   # Hoptoad API response
   class Response < Struct.new(:status, :body, :errors); end
@@ -123,7 +124,7 @@ class Toadhopper
 
   def filtered_value(key, value)
     if filters.any? {|f| key.to_s =~ Regexp.new(f)}
-      "[FILTERED]"
+      FILTER_REPLACEMENT
     else
       value
     end

data/test/helper.rb

@@ -2,8 +2,7 @@ Bundler.setup(:test)
 Bundler.require(:test)
 
 require 'test/unit'
-
-require File.expand_path("../../lib/toadhopper", __FILE__)
+require "toadhopper"
 
 def toadhopper
   @toadhopper ||= Toadhopper.new(ENV['HOPTOAD_API_KEY'] || "test api key")

data/test/test_convenience_constructor.rb

@@ -0,0 +1,7 @@
+require 'helper'
+
+class Toadhopper::TestConvenienceConstructor < Test::Unit::TestCase
+  def test_convenience_constructor
+    assert_kind_of Toadhopper, Toadhopper.new('somekey')
+  end
+end

data/test/test_filtering.rb

@@ -0,0 +1,25 @@
+require 'helper'
+
+class Toadhopper::TestFiltering < Test::Unit::TestCase
+  def test_filtering
+    assert_not_filtered "safe", "sensitive"
+    assert_not_filtered "safe", /sensitive/
+    assert_filtered "sensitive", "sensitive"
+    assert_filtered "sensitive", /sensitive/
+    assert_filtered "sensitive", /sit/
+  end
+
+  def assert_not_filtered(key, filter)
+    assert_false filtered_document(key, "value", filter).include?(Toadhopper::FILTER_REPLACEMENT)
+  end
+  
+  def assert_filtered(key, filter)
+    assert_false filtered_document(key, "value", filter).include?("value")
+  end
+
+  def filtered_document(key, value, filter)
+    toadhopper.filters = filter
+    hash = {"nested" => {key => value}, key => value}
+    toadhopper.__send__(:document_for, error, {:params => hash, :session => hash, :environment => hash})
+  end
+end

data/test/test_posting.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
+require 'helper'
 
 class Toadhopper::TestPosting < Test::Unit::TestCase
   def test_posting

metadata

@@ -1,12 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: toadhopper
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 1
-  - 0
-  - 2
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors: 
 - Tim Lucas
@@ -17,7 +12,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-24 00:00:00 -07:00
+date: 2010-04-01 00:00:00 +11:00
 default_executable: 
 dependencies: []
 
@@ -40,8 +35,8 @@ files:
 - lib/notice.erb
 - lib/toadhopper.rb
 - test/helper.rb
-- test/test_filters.rb
-- test/test_notice_document_data.rb
+- test/test_convenience_constructor.rb
+- test/test_filtering.rb
 - test/test_posting.rb
 has_rdoc: true
 homepage: http://github.com/toolmantim/toadhopper
@@ -56,25 +51,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Post error notifications to Hoptoad
 test_files: 
 - test/helper.rb
-- test/test_filters.rb
-- test/test_notice_document_data.rb
+- test/test_convenience_constructor.rb
+- test/test_filtering.rb
 - test/test_posting.rb

data/test/test_filters.rb

@@ -1,26 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
-
-class Toadhopper::TestFilters < Test::Unit::TestCase
-  def test_no_filters
-    assert_equal(                {:id => "myid", :password => "mypassword"},
-                 toadhopper.clean(:id => "myid", :password => "mypassword"))
-  end
-
-  def test_string_filter
-    toadhopper.filters = "pass"
-    assert_equal(                {:id => "myid", :password => "[FILTERED]"},
-                 toadhopper.clean(:id => "myid", :password => "mypassword"))
-  end
-
-  def test_regex_filter
-    toadhopper.filters = /pas{2}/
-    assert_equal(                {:id => "myid", :password => "[FILTERED]"},
-                 toadhopper.clean(:id => "myid", :password => "mypassword"))
-  end
-
-  def test_multiple_filters
-    toadhopper.filters = "email", /pas{2}/
-    assert_equal(                 {:id => "myid", :email => "[FILTERED]", :password => "[FILTERED]"},
-                 toadhopper.clean(:id => "myid", :email => "myemail", :password => "mypassword"))
-  end
-end

data/test/test_notice_document_data.rb

@@ -1,14 +0,0 @@
-require File.expand_path(File.join(File.dirname(__FILE__), 'helper'))
-
-class Toadhopper::TestNoticeDocument < Test::Unit::TestCase
-  def test_filtering
-    toadhopper.filters = "password"
-    sensitive_options = {
-      :params      => {"password" => "sensitive"},
-      :session     => {"password" => "sensitive"},
-      :environment => {"password" => "sensitive"}
-    }
-    notice_document = toadhopper.document_for(error, sensitive_options)
-    assert_false notice_document.include?("sensitive")
-  end
-end