to_factory 2.0.0 → 3.0.0.pre.pre

data/spec/db/migrate/1_create_users.rb

@@ -1,13 +1,13 @@
-class CreateUsers < ActiveRecord::Migration
-  def self.up
+class CreateUsers < ActiveRecord::Migration[6.1]
+  def up
     create_table :users do |t|
-      t.column :name, :string, :null => false
+      t.column :name, :string, null: false
       t.column :email, :string
       t.integer :some_id
     end
   end
 
-  def self.down
+  def down
     drop_table :users
   end
 end

data/spec/db/migrate/2_create_projects.rb

@@ -1,13 +1,13 @@
-class CreateProjects < ActiveRecord::Migration
-  def self.up
+class CreateProjects < ActiveRecord::Migration[6.1]
+  def up
     create_table :projects do |t|
-      t.column :name, :string, :null => false
+      t.column :name, :string, null: false
       t.column :objective, :string
       t.integer :some_id
     end
   end
 
-  def self.down
+  def down
     drop_table :projects
   end
 end

data/spec/db/migrate/3_create_not_namespaced.rb

@@ -1,11 +1,11 @@
-class CreateNotNamespaced < ActiveRecord::Migration
-  def self.up
+class CreateNotNamespaced < ActiveRecord::Migration[6.1]
+  def up
     create_table :not_namespaced_active_record_class_but_long_enough_it_shouldnt_cause_conflicts do |t|
-      t.column :name, :string, :null => false
+      t.column :name, :string, null: false
     end
   end
 
-  def self.down
+  def down
     drop_table :not_namespaced_active_record_class_but_long_enough_it_shouldnt_cause_conflicts
   end
 end

data/spec/db/migrate/4_add_birthday_to_users.rb

@@ -1,9 +1,9 @@
-class AddBirthdayToUsers < ActiveRecord::Migration
-  def self.up
+class AddBirthdayToUsers < ActiveRecord::Migration[6.1]
+  def up
     add_column :users, :birthday, :datetime
   end
 
-  def self.down
+  def down
     remove_column :users, :birthday
   end
 end

data/spec/db/migrate/5_add_serialized_attributes_to_users.rb

@@ -1,9 +1,9 @@
-class AddSerializedAttributesToUsers < ActiveRecord::Migration
-  def self.up
+class AddSerializedAttributesToUsers < ActiveRecord::Migration[6.1]
+  def up
     add_column :users, :some_attributes, :text
   end
 
-  def self.down
+  def down
     remove_column :users, :some_attributes
   end
 end

data/spec/example_factories/admin.rb

@@ -1,7 +1,7 @@
-factory(:admin, :parent => :"to_factory/user") do
-  birthday "2014-07-08T15:30 UTC"
-  email "admin@example.com"
-  name "Admin"
-  some_attributes({:a => 1})
-  some_id 9
+factory(:admin, parent: :"to_factory/user") do
+  birthday { "2014-07-08T15:30 UTC" }
+  email {"admin@example.com"}
+  name {"Admin"}
+  some_attributes {{a: 1}}
+  some_id { 9 }
 end

data/spec/example_factories/admin_with_header.rb

@@ -1,9 +1,9 @@
-FactoryGirl.define do
-  factory(:admin, :parent => :"to_factory/user") do
-    birthday "2014-07-08T15:30 UTC"
-    email "admin@example.com"
-    name "Admin"
-    some_attributes({:a => 1})
-    some_id 9
+FactoryBot.define do
+  factory(:admin, parent: :"to_factory/user") do
+    birthday { "2014-07-08T15:30 UTC" }
+    email { "admin@example.com" }
+    name {"Admin" }
+    some_attributes { {a: 1 } }
+    some_id { 9 }
   end
 end

data/spec/example_factories/inherited_project_with_header.rb

@@ -0,0 +1,7 @@
+FactoryBot.define do
+  factory(:"to_factory/inherited_project") do
+    name { "My Project" }
+    objective { "easy testing" }
+    some_id { 9 }
+  end
+end

data/spec/example_factories/project_with_header.rb

@@ -1,7 +1,7 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory(:"to_factory/project") do
-    name "My Project"
-    objective "easy testing"
-    some_id 9
+    name { "My Project" }
+    objective { "easy testing" }
+    some_id { 9 }
   end
 end

data/spec/example_factories/user.rb

@@ -1,7 +1,7 @@
 factory(:"to_factory/user") do
-  birthday "2014-07-08T15:30 UTC"
-  email "test@example.com"
-  name "Jeff"
-  some_attributes({:a => 1})
-  some_id 8
+  birthday {"2014-07-08T15:30 UTC"}
+  email {"test@example.com"}
+  name {"Jeff"}
+  some_attributes {{a: 1}}
+  some_id { 8 }
 end

data/spec/example_factories/user_admin.rb

@@ -1,15 +1,15 @@
 factory(:"to_factory/user") do
-  birthday "2014-07-08T15:30 UTC"
-  email "test@example.com"
-  name "Jeff"
-  some_attributes({:a => 1})
-  some_id 8
+  birthday { "2014-07-08T15:30 UTC" }
+  email { "test@example.com" }
+  name { "Jeff" }
+  some_attributes { {a: 1 } }
+  some_id { 8 }
 end
 
-factory(:admin, :parent => :"to_factory/user") do
-  birthday "2014-07-08T15:30 UTC"
-  email "admin@example.com"
-  name "Admin"
-  some_attributes({:a => 1})
-  some_id 9
+factory(:admin, parent: :"to_factory/user") do
+  birthday {"2014-07-08T15:30 UTC"}
+  email {"admin@example.com"}
+  name {"Admin"}
+  some_attributes { {a: 1 } }
+  some_id { 9 }
 end

data/spec/example_factories/user_admin_root.rb

@@ -1,21 +1,21 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory(:"to_factory/user") do
-    name("User")
+    name {"User"}
   end
 
-  factory(:root, :parent => :"to_factory/user") do
-    birthday "2014-07-08T15:30 UTC"
-    email "test@example.com"
-    name "Jeff"
-    some_attributes({:a => 1})
-    some_id 8
+  factory(:admin, parent: :"to_factory/user") do
+    name {"Admin"}
   end
 
-  factory(:admin, :parent => :"to_factory/user") do
-    name("Admin")
+  factory(:root, parent: :"to_factory/user") do
+    birthday {"2014-07-08T15:30 UTC"}
+    email {"test@example.com"}
+    name {"Jeff"}
+    some_attributes {{a: 1}}
+    some_id { 8 }
   end
 
-  factory(:super_admin, :parent => :admin) do
-    name("Super Admin")
+  factory(:super_admin, parent: :admin) do
+    name {"Super Admin"}
   end
 end

data/spec/example_factories/user_admin_super_admin.rb

@@ -1,13 +1,13 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory(:"to_factory/user") do
-    name "User"
+    name {"User"}
   end
 
-  factory(:admin, :parent => :"to_factory/user") do
-    name "Admin"
+  factory(:admin, parent: :"to_factory/user") do
+    name {"Admin" }
   end
 
-  factory(:super_admin, :parent => :admin) do
-    name "Super Admin"
+  factory(:super_admin, parent: :admin) do
+    name {"Super Admin"}
   end
 end

data/spec/example_factories/user_admin_with_header.rb

@@ -1,17 +1,17 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory(:"to_factory/user") do
-    birthday "2014-07-08T15:30 UTC"
-    email "test@example.com"
-    name "Jeff"
-    some_attributes({:a => 1})
-    some_id 8
+    birthday {"2014-07-08T15:30 UTC"}
+    email {"test@example.com"}
+    name {"Jeff"}
+    some_attributes {{a: 1}}
+    some_id { 8 }
   end
 
-  factory(:admin, :parent => :"to_factory/user") do
-    birthday "2014-07-08T15:30 UTC"
-    email "admin@example.com"
-    name "Admin"
-    some_attributes({:a => 1})
-    some_id 9
+  factory(:admin, parent: :"to_factory/user") do
+    birthday {"2014-07-08T15:30 UTC"}
+    email {"admin@example.com"}
+    name {"Admin"}
+    some_attributes {{a: 1}}
+    some_id { 9 }
   end
 end

data/spec/example_factories/user_with_header.rb

@@ -1,9 +1,9 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory(:"to_factory/user") do
-    birthday "2014-07-08T15:30 UTC"
-    email "test@example.com"
-    name "Jeff"
-    some_attributes({:a => 1})
-    some_id 8
+    birthday { "2014-07-08T15:30 UTC" }
+    email { "test@example.com" }
+    name { "Jeff" }
+    some_attributes { {:a => 1} }
+    some_id { 8 }
   end
 end

data/spec/integration/empty_factory_file_spec.rb

@@ -0,0 +1,19 @@
+describe "Empty File spec" do
+  let(:user) { create_user! }
+
+  context "with an empty factory file" do
+    before do
+      user
+      FileUtils.mkdir_p "./tmp/factories/to_factory"
+
+      File.open("./tmp/factories/to_factory/empty.rb", "w") do |f|
+        f << " "
+        f << "\n "
+      end
+    end
+
+    it "doesn't blow up" do
+      ToFactory(empty: OpenStruct.new({ attributes: {} }), user: user)
+    end
+  end
+end

data/spec/integration/file_sync_spec.rb

@@ -1,28 +1,25 @@
 describe "FileSync" do
-  let(:user) { create_user!  }
-  let(:admin) { create_admin!  }
-  let(:project) { create_project!  }
-  let(:version) { "new" }
+  let(:user) { create_user! }
+  let(:admin) { create_admin! }
+  let(:project) { create_project! }
   let(:expected_user_file)             { File.read("./spec/example_factories/user.rb") }
   let(:expected_user_with_header_file) { File.read("./spec/example_factories/user_with_header.rb") }
   let(:expected_admin_file)            { File.read("./spec/example_factories/admin.rb") }
   let(:user_with_header)               { File.read("./spec/example_factories/user_with_header.rb") }
   let(:user_admin_with_header)         { File.read("./spec/example_factories/user_admin_with_header.rb") }
 
-
-  before do
-    FileUtils.rm_rf "./tmp/factories"
-  end
-
   def user_file
-    File.read("./tmp/factories/to_factory/user.rb") rescue nil
+    File.read("./tmp/factories/to_factory/user.rb")
+  rescue
+    nil
   end
 
   def project_file
-    File.read("./tmp/factories/to_factory/project.rb") rescue nil
+    File.read("./tmp/factories/to_factory/project.rb")
+  rescue
+    nil
   end
 
-
   context "with no arguments" do
     before do
       user
@@ -33,7 +30,7 @@ describe "FileSync" do
       sync = ToFactory::FileSync.new
       sync.perform
 
-      expect(user_file ).to match_sexp expected_user_with_header_file
+      expect(user_file).to match_sexp expected_user_with_header_file
     end
   end
 
@@ -42,13 +39,11 @@ describe "FileSync" do
       sync = ToFactory::FileSync.new(user)
       sync.perform
 
-      expect(user_file   ).to match_sexp user_with_header
+      expect(user_file).to match_sexp user_with_header
       expect(project_file).to eq nil
     end
   end
 
-
-
   context "with a pre-existing file" do
     let(:sync) { ToFactory::FileSync.new(user) }
     before do
@@ -57,26 +52,23 @@ describe "FileSync" do
     end
 
     it "raises an error" do
-      expect(lambda{ sync.perform }).to raise_error ToFactory::AlreadyExists
+      expect { sync.perform }.to raise_error ToFactory::AlreadyExists
     end
 
     context "with a named factory" do
       it do
-        sync = ToFactory::FileSync.new({:admin => admin})
+        sync = ToFactory::FileSync.new(admin: admin)
         sync.perform
 
         parser = ToFactory::Parsing::File.new(user_file)
         result = parser.parse
-        admin= result.find{|r| r.name == "admin"}
-        user= result.find{|r| r.name == "to_factory/user"}
-
+        admin = result.find { |r| r.name == "admin" }
+        user = result.find { |r| r.name == "to_factory/user" }
 
         expect(admin.definition).to match_sexp expected_admin_file
         expect(user.definition).to match_sexp expected_user_file
 
-        expect(lambda{
-          sync.perform
-        }).to raise_error ToFactory::AlreadyExists
+        expect { sync.perform }.to raise_error ToFactory::AlreadyExists
       end
     end
   end

data/spec/integration/file_writer_spec.rb

@@ -1,18 +1,22 @@
 describe ToFactory::FileWriter do
-  let(:fw) { ToFactory::FileWriter.new }
-  let(:expected)    { File.read "./spec/example_factories/user_with_header.rb"}
-  let(:user_file_contents)    { File.read "./tmp/factories/to_factory/user.rb"}
+  let(:file_writer) { ToFactory::FileWriter.new }
+  let(:user_file_contents)    { File.read "./tmp/factories/to_factory/user.rb" }
   let!(:user) { create_user!  }
-  let!(:admin) { create_admin!  }
+  let!(:admin) { create_admin! }
+  let(:file_sync) { ToFactory::FileSync.new }
+  let(:representations) { file_sync.all_representations }
 
-  it do
-    fs = ToFactory::FileSync.new
-    representations = fs.all_representations
-    #sanity check generation isn't broken
+  let(:expected) { File.read "./spec/example_factories/user_with_header.rb" }
+
+  before do
+    # sanity check generation isn't broken
     expect(representations.keys).to eq ["to_factory/user"]
     expect(representations.values[0][0]).to be_a ToFactory::Representation
+  end
+
+  it 'writes correctly' do
+    file_writer.write representations
 
-    fw.write representations
     expect(user_file_contents).to match_sexp expected
   end
 end

data/spec/integration/lint_spec.rb

@@ -1,12 +1,13 @@
 context "full integration" do
   let(:user) do
-    ToFactory::User.create :name => "Jeff", :email => "test@example.com", :some_id => 8, :birthday => Time.now
+    ToFactory::User.create name: "Jeff", email: "test@example.com", some_id: 8, birthday: Time.now
   end
 
   it "#to_factory linting the output" do
     ToFactory(user)
+    require 'factory_bot'
+
     load "./tmp/factories/to_factory/user.rb"
-    FactoryGirl.lint
+    FactoryBot.lint
   end
 end
-

data/spec/integration/multiple_to_factory_calls_spec.rb

@@ -0,0 +1,96 @@
+describe ToFactory do
+  let!(:user) { create_user! }
+
+  def user_file
+    File.read("./tmp/factories/to_factory/user.rb")
+  rescue
+    nil
+  end
+
+  let(:expected_user_file) { File.read "./spec/example_factories/user_with_header.rb" }
+
+  context "single call" do
+    before do
+      ToFactory()
+    end
+    it "renders a single factory correctly" do
+      expect(user_file).to match_sexp expected_user_file
+    end
+  end
+
+  context "two calls" do
+    before do
+      ToFactory()
+      ToFactory(user_2: ToFactory::User.first)
+    end
+
+    it "renders two factories correctly" do
+      expect(user_file).to eq <<-FACTORY.strip_heredoc
+        FactoryBot.define do
+          factory(:"to_factory/user") do
+            birthday { "2014-07-08T15:30 UTC" }
+            email { "test@example.com" }
+            name { "Jeff" }
+            some_attributes { { :a => 1 } }
+            some_id { 8 }
+          end
+
+          factory(:user_2, :parent => :"to_factory/user") do
+            birthday { "2014-07-08T15:30 UTC" }
+            email { "test@example.com" }
+            name { "Jeff" }
+            some_attributes { {:a => 1} }
+            some_id { 8 }
+          end
+        end
+      FACTORY
+    end
+  end
+
+  context "multiple calls" do
+    before do
+      ToFactory()
+      ToFactory(user_2: ToFactory::User.first)
+      ToFactory(user_3: ToFactory::User.first)
+      ToFactory(user_4: ToFactory::User.first)
+    end
+
+    it "renders multiple factories correctly" do
+      expect(user_file).to match_sexp <<-FACTORY
+       FactoryBot.define do
+         factory(:"to_factory/user") do
+           birthday { "2014-07-08T15:30 UTC" }
+           email { "test@example.com" }
+           name { "Jeff" }
+           some_attributes { {:a => 1} }
+           some_id { 8 }
+         end
+
+         factory(:user_2, :parent => :"to_factory/user") do
+           birthday { "2014-07-08T15:30 UTC" }
+           email { "test@example.com" }
+           name { "Jeff" }
+           some_attributes { {:a => 1} }
+           some_id { 8 }
+         end
+
+         factory(:user_3, :parent => :"to_factory/user") do
+           birthday { "2014-07-08T15:30 UTC" }
+           email { "test@example.com" }
+           name { "Jeff" }
+           some_attributes { {:a => 1} }
+           some_id { 8 }
+         end
+
+         factory(:user_4, :parent => :"to_factory/user") do
+           birthday { "2014-07-08T15:30 UTC" }
+           email { "test@example.com" }
+           name { "Jeff" }
+           some_attributes { {:a => 1} }
+           some_id { 8 }
+         end
+       end
+      FACTORY
+    end
+  end
+end

data/spec/integration/non_active_record_classes_spec.rb

@@ -0,0 +1,40 @@
+describe "non active record classes" do
+  let!(:project) { create_project! }
+
+  def project_file
+    File.read("./tmp/factories/to_factory/project.rb")
+  rescue
+    nil
+  end
+
+  def inherited_project_file
+    File.read("./tmp/factories/to_factory/inherited_project.rb")
+  rescue
+    nil
+  end
+
+  let(:expected_project_file) { File.read "./spec/example_factories/project_with_header.rb" }
+  let(:expected_inherited_project_file) { File.read "./spec/example_factories/inherited_project_with_header.rb" }
+
+  context "given a folder with non active record models in" do
+    before do
+      ToFactory.models = "./spec/support/non_active_record"
+      ToFactory()
+    end
+
+    it "creates an ordinary factory correctly" do
+      expect(project_file).to match_sexp expected_project_file
+    end
+
+    context "STI" do
+      it "creates a single factory correctly" do
+        expect(inherited_project_file).to match_sexp expected_inherited_project_file
+      end
+    end
+
+    it "doesn't create other factories" do
+      count = Dir.glob("./tmp/factories/*.rb").length
+      expect(count).to eq 0
+    end
+  end
+end