to-arff 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 507fda68512fc420f96579514e00264c4e4ac0dd
-  data.tar.gz: 21c267d6299d777d259c1fa55e9157e10103e38c
+  metadata.gz: 6e3569cf355dfe5e6d19f6616a99bfa7a734c848
+  data.tar.gz: 8253d90f77ab8d9745b0fcc35873f50410125008
 SHA512:
-  metadata.gz: eaf66b84e11d9bb215ce2c30b1793117e22bbf2e822e91fc86c5a15bdf0fee4716e515baa96a3d5af7fd4a4a7e8d70f5801198227d7a721d1d112e0762f6b7bb
-  data.tar.gz: 7a24e6157ce6bcb21b9f9fd2441bcb5742ada88cbc0c224ffc110806d71341e608a1182e37376932fdb49020da86f3ec7e4c86d1048ad1f091e03a43d9fc5b77
+  metadata.gz: 58d45ef0093abc7c780220868d6c6e7799ddacb122f2aad3d4d4c599f79170c171b9b136e9c1af911ba16c996d543cf15e3fe19acceed517d33b66c474255534
+  data.tar.gz: 0444fcf9b5580c49c1782cba7c1abedccef851e38b06174accc337f7aa3fcca6aeaffc4a2d828b13b47090706b1fa6f8279b98da6f33c9bb941a1fa4ad8753af

data/README.md

@@ -45,52 +45,30 @@ Or install it yourself as:
 
 ###Convert from an SQLite Database
 #### By Specifying Column Types (Recommended)
-Use the convert() method and specify the column/attribute types as a json (or nested hash).
+Its better to specify column types.
 ```ruby
 require 'to-arff'
-# Get the db file from https://github.com/dhrubomoy/to-arff/blob/master/spec/sample_db_files/sample2.db
-sample = ToARFF::SQLiteDB.new "/path/to/sample2.db"
+# You can download the file from  '/spec /sample_db_files/sample2.db'
+sample = ToARFF::SQLiteDB.new "/path/to/sample_sqlite.db"
 # Attribute names and types must be valid
-# eg. { "table1": {"column11"=>"NUMERIC",
-#                    "column12"=>"STRING"
-#                   },
-#       "table2": {"column21"=>"class {Iris-setosa,Iris-versicolor,Iris-virginica}",
-#                    "column22"=>"DATE \"yyyy-MM-dd HH:mm:ss\""
-#                   }
-#     }
-# OR  { "table1" => {"column11"=>"NUMERIC",
+# eg. { "table1" => {"column11"=>"NUMERIC",
 #                    "column12"=>"STRING"
 #                   },
 #       "table2" => {"column21"=>"class {Iris-setosa,Iris-versicolor,Iris-virginica}",
 #                    "column22"=>"DATE \"yyyy-MM-dd HH:mm:ss\""
 #                   }
-#     }
-sample_column_types_param_json = {
-                                    "albums": {
-                                      "Albumid": "NUMERIC",
-                                      "Title": "STRING"
-                                    },
-                                    "employees": {
-                                      "EmployeeId": "NUMERIC",
-                                      "LastName": "STRING",
-                                      "City": "STRING",
-                                      "HireDate": "DATE 'yyyy-MM-dd HH:mm:ss'"
-                                    }
-                                  }
-sample_column_types_param_hash = { "employees" => {"EmployeeId"=>"NUMERIC",
+sample_column_types_param = { "employees" => {"EmployeeId"=>"NUMERIC",
                                               "LastName"=>"STRING",
                                               "City"=>"STRING",
                                               "HireDate"=>"DATE \"yyyy-MM-dd HH:mm:ss\""
                                              },
-                                    "albums" => { "Albumid"=>"NUMERIC",
-                                                  "Title"=>"STRING"
-                                                }
-                                  }
-puts sample.convert column_types: sample_column_types_param_json
-#OR
-puts sample.convert column_types: sample_column_types_param_hash
+                              "albums" => { "Albumid"=>"NUMERIC",
+                                            "Title"=>"STRING"
+                                          }
+                            }
+puts sample.convert column_types: sample_column_types_param
 ```
-Both will produce string similar to following:
+We will get something similar to following:
 ```
 @RELATION employees
 
@@ -125,20 +103,12 @@ sample = ToARFF::SQLiteDB.new "/path/to/sample_sqlite.db"
 # { "table1" => ["column11", "column12",...],
 #   "table2" => ["column21", "column22",...]
 # }
-# OR
-# { "table1": ["column11", "column12",...],
-#   "table2": ["column21", "column22",...]
-# }
-sample_columns_json = { "albums": ["AlbumId", "Title", "ArtistId"],
-                         "employees": ["EmployeeId", "LastName", "FirstName", "Title"]
-                       }
-sample_columns_hash =  { "albums" => ["AlbumId", "Title", "ArtistId"],
-                         "employees" => ["EmployeeId", "LastName", "FirstName", "Title"]
-                       }
-puts sample.convert columns: sample_columns_json
-puts sample.convert columns: sample_columns_hash
+sample_columns =  { "albums" => ["AlbumId", "Title", "ArtistId"],
+                    "employees" => ["EmployeeId", "LastName", "FirstName", "Title"]
+                  }
+puts sample.convert columns: sample_columns
 ```
-Both json and hash parameters for `columns:` will return string similar to following:
+We will get something similar:
 ```
 @RELATION albums
 
@@ -183,7 +153,7 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/dhrubo
 1. Fork it ( https://github.com/dhrubomoy/to-arff/fork )
 2. Create branch (`git checkout -b my-new-feature`)
 3. Make changes. Add test cases for your changes
-4. Run `rake spec/` and make sure all the test passes
+4. Run `rspec spec/` and make sure all the test passes
 5. Commit your changes (`git commit -am 'Add some feature'`)
 6. Push to the branch (`git push origin my-new-feature`)
 7. Create new Pull Request

data/lib/to-arff/sqlitedb.rb

@@ -1,6 +1,5 @@
 require 'to-arff/version'
 require 'sqlite3'
-require 'json'
 
 module ToARFF
   RELATION_MARKER = '@RELATION'.freeze
@@ -192,14 +191,6 @@ module ToARFF
 			end
 		end
 
-	def stringify_all_keys(hash)
-	  stringified_hash = {}
-	  hash.each do |k, v|
-	    stringified_hash[k.to_s] = v.is_a?(Hash) ? stringify_all_keys(v) : v
-	  end
-	  stringified_hash
-	end
-
 		def convert(options={})
 			temp_tables = options.fetch(:tables, Array.new)
 			temp_columns = options.fetch(:columns, Hash.new)
@@ -214,7 +205,7 @@ module ToARFF
 				if valid_option_given(options)
 					raise ArgumentError.new("Wrong parameter name \":#{options.keys.first}\"")
 				else
-					deal_with_valid_option(temp_tables, stringify_all_keys(temp_columns), stringify_all_keys(temp_column_types), res)
+					deal_with_valid_option(temp_tables, temp_columns, temp_column_types, res)
 				end
 			elsif param_count > 1
 				raise ArgumentError.new("You can specify only one out of the three parameters: table, columns, column_types.")

data/lib/to-arff/version.rb

@@ -1,3 +1,3 @@
 module ToARFF
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/to-arff.gemspec

@@ -23,5 +23,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.12'
   spec.add_development_dependency 'rake', '~> 11.2'
   spec.add_development_dependency 'sqlite3', '~> 1.3'
-  spec.add_development_dependency 'json'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: to-arff
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - dhrubo_moy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-31 00:00:00.000000000 Z
+date: 2016-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,20 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: json
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: 
 email:
 - dhrubo_moy@yahoo.com