tng 0.3.8 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbf8e76f0412c426150b5a9cef4d3a077d9747bf02c16ea6086f621cb78236a0
-  data.tar.gz: 5bb42890de6580034ffc78df9b699433667e07e7877c7dc280ca53d998fa29cf
+  metadata.gz: 4090a9996518027b0e5d49534360ce2269a735c407dcdb5544e4842a1431b590
+  data.tar.gz: 1171ff1e89fe751cb2a4de7a8cb688db9c65b22babdb7c1164f5d24032cc1092
 SHA512:
-  metadata.gz: 868acc7d7fa9b539fac0b9906662cdf906a115da97f86643f8d2c88f9015b536e3ec75bbb50537df0a2283232207d7531a12b81eb8af4bdc8a1aa4abb4a83122
-  data.tar.gz: 1410ad3af1e8b0bfbfa7d9849ba293cddca599e4dfda976f6433651814343592e39ef40aec5ca7c884e4ad28f004ab86bd36a384e1c334ab008629bec9ea3bd5
+  metadata.gz: af6285fd48d5c93a1fad7698b1636aa03fef7f8f6f2b4705ed68390d1b0ee78a2aa118836952c7b2aac63dfaec417f23d9eaf99134e604ce43bed85576b3ddb6
+  data.tar.gz: 24f76ab0623a752f753b26c84b22ec8b971970de6e8493ea0f52c024eb94ee5fcd3f8459d4845782d01dcc23e92f8ac551136fec3a533be7b0ebac09812c973f

data/bin/tng

@@ -10,6 +10,7 @@ require "tng"
 require "tng/services/direct_generation"
 require "tng/services/extract_methods"
 require "tng/services/file_type_detector"
+require "tng/services/fix_orchestrator"
 
 require "tty-screen"
 require "tty-option"
@@ -57,6 +58,23 @@ class CLI
     desc "Method name (for per-method tests)"
   end
 
+  flag :audit do
+    short "-a"
+    long "--audit"
+    desc "Run in audit mode (find issues and behaviours instead of generating tests)"
+  end
+
+  flag :json do
+    long "--json"
+    desc "Output results in JSON format"
+  end
+
+  flag :fix do
+    short "-x"
+    long "--fix"
+    desc "Run in fix mode (automatically repair syntax, lint, and test errors)"
+  end
+
   flag :help do
     short "-h"
     long "--help"
@@ -65,7 +83,13 @@ class CLI
 
   def initialize
     @pastel = Pastel.new
-    @go_ui = Tng::UI::GoUISession.new
+    # Check for --json flag raw before parsing
+    if ARGV.any? { |arg| arg == "--json" }
+      require "tng/ui/json_session"
+      @go_ui = Tng::UI::JsonSession.new
+    else
+      @go_ui = Tng::UI::GoUISession.new
+    end
     @terminal_width = begin
       TTY::Screen.width
     rescue StandardError
@@ -90,7 +114,9 @@ class CLI
 
     initialize_config_and_clients if rails_loaded
 
-    if params[:file]
+    if params[:fix]
+      handle_fix_command
+    elsif params[:file]
       run_direct_generation
     else
       if find_rails_root && !rails_loaded && !defined?(Rails)
@@ -121,6 +147,12 @@ class CLI
         normalized << "--file=#{::Regexp.last_match(2)}"
       when /^(?:--)?(method|m)=(.+)$/
         normalized << "--method=#{::Regexp.last_match(2)}"
+      when /^(?:--)?(audit|a)$/
+        normalized << "--audit"
+      when /^(?:--)?(json)$/
+        normalized << "--json"
+      when /^(?:--)?(fix|x)$/
+        normalized << "--fix"
       when /^(help|h)=(.+)$/
         normalized << "--help=#{::Regexp.last_match(2)}"
       when /^--file$/, /^-f$/
@@ -151,8 +183,11 @@ class CLI
       arg = positional_args[0]
       has_file = normalized.any? { |a| a.match?(/^--file/) }
       has_method = normalized.any? { |a| a.match?(/^--method/) }
+      has_fix = normalized.any? { |a| a.match?(/^--fix/) }
 
-      if !has_file && (arg.end_with?(".rb") || arg.include?("/"))
+      if has_fix && !has_file
+        normalized << "--file=#{arg}"
+      elsif !has_file && (arg.end_with?(".rb") || arg.include?("/"))
         normalized << "--file=#{arg}"
       elsif !has_method && !arg.include?("/")
         normalized << "--method=#{arg}"
@@ -171,6 +206,8 @@ class CLI
       case choice
       when "tests"
         handle_test_generation
+      when "audit"
+        handle_audit_method
       when "stats"
         user_stats
       when "about"
@@ -201,6 +238,332 @@ class CLI
     end
   end
 
+  def handle_audit_method
+    choice = @go_ui.show_test_type_menu("audit")
+
+    case choice
+    when "controller"
+      audit_controller_method
+    when "model"
+      audit_model_method
+    when "service"
+      audit_service_method
+    when "other"
+      audit_other_method
+    end
+  end
+
+  def audit_controller_method
+    controllers = nil
+
+    @go_ui.show_spinner("Analyzing controllers...") do
+      controllers = Tng::Analyzers::Controller.files_in_dir("app/controllers").map do |file|
+        relative_path = file[:path].gsub(%r{^.*app/controllers/}, "").gsub(".rb", "")
+        namespaced_name = relative_path.split("/").map(&:camelize).join("::")
+        { name: namespaced_name, path: file[:path] }
+      end
+      { success: true, message: "Found #{controllers.length} controllers" }
+    end
+
+    if controllers.empty?
+      @go_ui.show_no_items("controllers")
+      return
+    end
+
+    items = controllers.map { |c| { name: c[:name], path: c[:path] } }
+
+    loop do
+      selected_name = @go_ui.show_list_view("Select Controller to Audit", items)
+      return if selected_name == "back"
+
+      controller_choice = controllers.find { |c| c[:name] == selected_name }
+      next unless controller_choice
+
+      show_controller_audit_method_selection(controller_choice)
+      # If we return here, it means user pressed back from method selection
+      # Loop will show controller list again
+    end
+  end
+
+  def show_controller_audit_method_selection(controller)
+    methods = extract_controller_methods(controller)
+
+    if methods.empty?
+      @go_ui.show_no_items("methods in #{controller[:name]}")
+      return
+    end
+
+    items = methods.map { |m| { name: m[:name], path: controller[:name] } }
+    selected_name = @go_ui.show_list_view("Select Method to Audit", items)
+    return if selected_name == "back"
+
+    method_choice = methods.find { |m| m[:name] == selected_name }
+    return unless method_choice
+
+    run_audit_for_controller_method(controller, method_choice)
+  end
+
+  def run_audit_for_controller_method(controller, method_info)
+    result = nil
+
+    @go_ui.show_progress("Auditing #{controller[:name]}##{method_info[:name]}") do |progress|
+      progress.update("Analyzing method context...", 25)
+      progress.update("Running logical analysis...", 50)
+      progress.update("Detecting issues and behaviours...", 75)
+
+      result = Tng::Services::TestGenerator.new(@http_client).run_audit_for_controller_method(
+        controller, method_info, progress: progress
+      )
+
+      progress.update("Processing results...", 100)
+
+      if result&.dig(:error)
+        { message: result[:message] || "Audit failed", error: result[:error] }
+      else
+        { message: "Audit complete!" }
+      end
+    end
+
+    return @go_ui.show_auth_error(result[:message] || "Audit failed") if result&.dig(:error)
+
+    display_audit_results(result)
+  end
+
+  def display_audit_results(result)
+    audit_data = result[:audit_results]
+
+    # Save to JSON for persistence
+    File.write("audit.json", JSON.pretty_generate(audit_data))
+    puts @pastel.green("💾 Audit results saved to audit.json")
+
+    # Send entire audit_data to go-ui (includes issues, behaviours, method_name, class_name, method_source_with_lines)
+    @go_ui.show_audit_results(audit_data, "issues")
+  end
+
+  # Placeholder methods for other component types
+  def audit_model_method
+    models = nil
+
+    @go_ui.show_spinner("Analyzing models...") do
+      models = Tng::Analyzers::Model.files_in_dir("app/models").map do |file|
+        relative_path = file[:path].gsub(%r{^.*app/models/}, "").gsub(".rb", "")
+        namespaced_name = relative_path.split("/").map(&:camelize).join("::")
+        { name: namespaced_name, path: file[:path] }
+      end
+      { success: true, message: "Found #{models.length} models" }
+    end
+
+    if models.empty?
+      @go_ui.show_no_items("models")
+      return
+    end
+
+    items = models.map { |m| { name: m[:name], path: m[:path] } }
+
+    loop do
+      selected_name = @go_ui.show_list_view("Select Model to Audit", items)
+      return if selected_name == "back"
+
+      model_choice = models.find { |m| m[:name] == selected_name }
+      next unless model_choice
+
+      show_model_audit_method_selection(model_choice)
+    end
+  end
+
+  def show_model_audit_method_selection(model)
+    methods = extract_model_methods(model)
+
+    if methods.empty?
+      @go_ui.show_no_items("methods in #{model[:name]}")
+      return
+    end
+
+    items = methods.map { |m| { name: m[:name], path: model[:name] } }
+    selected_name = @go_ui.show_list_view("Select Method to Audit", items)
+    return if selected_name == "back"
+
+    method_choice = methods.find { |m| m[:name] == selected_name }
+    return unless method_choice
+
+    run_audit_for_model_method(model, method_choice)
+  end
+
+  def run_audit_for_model_method(model, method_info)
+    result = nil
+
+    @go_ui.show_progress("Auditing #{model[:name]}##{method_info[:name]}") do |progress|
+      progress.update("Parsing method details...", 25)
+      progress.update("Analyzing method context...", 25)
+      progress.update("Running logical analysis...", 50)
+      progress.update("Detecting issues and behaviours...", 75)
+
+      result = Tng::Services::TestGenerator.new(@http_client).run_audit_for_model_method(
+        model, method_info, progress: progress
+      )
+
+      progress.update("Processing results...", 100)
+
+      if result&.dig(:error)
+        { message: result[:message] || "Audit failed", error: result[:error] }
+      else
+        { message: "Audit complete!" }
+      end
+    end
+
+    return @go_ui.show_auth_error(result[:message] || "Audit failed") if result&.dig(:error)
+
+    display_audit_results(result)
+  end
+
+  def audit_service_method
+    services = nil
+
+    @go_ui.show_spinner("Analyzing services...") do
+      services = Tng::Analyzers::Service.files_in_dir.map do |file|
+        relative_path = file[:path].gsub(%r{^.*app/services?/}, "").gsub(".rb", "")
+        namespaced_name = relative_path.split("/").map(&:camelize).join("::")
+        { name: namespaced_name, path: file[:path] }
+      end
+      { success: true, message: "Found #{services.length} services" }
+    end
+
+    if services.empty?
+      @go_ui.show_no_items("services")
+      return
+    end
+
+    items = services.map { |s| { name: s[:name], path: s[:path] } }
+
+    loop do
+      selected_name = @go_ui.show_list_view("Select Service to Audit", items)
+      return if selected_name == "back"
+
+      service_choice = services.find { |s| s[:name] == selected_name }
+      next unless service_choice
+
+      show_service_audit_method_selection(service_choice)
+    end
+  end
+
+  def show_service_audit_method_selection(service)
+    methods = extract_service_methods(service)
+
+    if methods.empty?
+      @go_ui.show_no_items("methods in #{service[:name]}")
+      return
+    end
+
+    items = methods.map { |m| { name: m[:name], path: service[:name] } }
+    selected_name = @go_ui.show_list_view("Select Method to Audit", items)
+    return if selected_name == "back"
+
+    method_choice = methods.find { |m| m[:name] == selected_name }
+    return unless method_choice
+
+    run_audit_for_service_method(service, method_choice)
+  end
+
+  def run_audit_for_service_method(service, method_info)
+    result = nil
+
+    @go_ui.show_progress("Auditing #{service[:name]}##{method_info[:name]}") do |progress|
+      progress.update("Parsing method details...", 25)
+      progress.update("Analyzing method context...", 25)
+      progress.update("Running logical analysis...", 50)
+      progress.update("Detecting issues and behaviours...", 75)
+
+      result = Tng::Services::TestGenerator.new(@http_client).run_audit_for_service_method(
+        service, method_info, progress: progress
+      )
+
+      progress.update("Processing results...", 100)
+
+      if result&.dig(:error)
+        { message: result[:message] || "Audit failed", error: result[:error] }
+      else
+        { message: "Audit complete!" }
+      end
+    end
+
+    return @go_ui.show_auth_error(result[:message] || "Audit failed") if result&.dig(:error)
+
+    display_audit_results(result)
+  end
+
+  def audit_other_method
+    other_files = nil
+
+    @go_ui.show_spinner("Analyzing other files...") do
+      other_files = Tng::Analyzers::Other.files_in_dir.map do |file|
+        relative_path = file[:relative_path].gsub(".rb", "")
+        namespaced_name = relative_path.split("/").map(&:camelize).join("::")
+
+        { name: namespaced_name, path: file[:path], type: file[:type] }
+      end
+      { success: true, message: "Found #{other_files.length} other files" }
+    end
+
+    if other_files.empty?
+      @go_ui.show_no_items("other files")
+      return
+    end
+
+    items = other_files.map { |f| { name: f[:name], path: f[:path] } }
+    selected_name = @go_ui.show_list_view("Select File", items)
+    return if selected_name == "back"
+
+    other_choice = other_files.find { |f| f[:name] == selected_name }
+    return unless other_choice
+
+    show_audit_other_method_selection(other_choice)
+  end
+
+  def show_audit_other_method_selection(other_file)
+    methods = extract_other_methods(other_file)
+
+    if methods.empty?
+      @go_ui.show_no_items("methods in #{other_file[:name]}")
+      return
+    end
+
+    items = methods.map { |m| { name: m[:name], path: other_file[:name] } }
+    selected_name = @go_ui.show_list_view("Audit Method in #{other_file[:name]}", items)
+    return if selected_name == "back"
+
+    method_choice = methods.find { |m| m[:name] == selected_name }
+    return unless method_choice
+
+    run_audit_for_other_method(other_file, method_choice)
+  end
+
+  def run_audit_for_other_method(other_file, method_info)
+    result = nil
+
+    @go_ui.show_progress("Auditing #{other_file[:name]}##{method_info[:name]}") do |progress|
+      progress.update("Parsing method details...", 25)
+      progress.update("Analyzing method context...", 25)
+      progress.update("Running logical analysis...", 50)
+      progress.update("Detecting issues and behaviours...", 75)
+
+      result = Tng::Services::TestGenerator.new(@http_client).run_audit_for_other_method(
+        other_file, method_info, progress: progress
+      )
+
+      progress.update("Processing results...", 100)
+
+      if result&.dig(:error)
+        { message: result[:message] || "Audit failed", error: result[:error] }
+      else
+        { message: "Audit complete!" }
+      end
+    end
+
+    return @go_ui.show_auth_error(result[:message] || "Audit failed") if result&.dig(:error)
+
+    display_audit_results(result)
+  end
+
   def generate_controller_tests
     controllers = nil
 
@@ -220,13 +583,16 @@ class CLI
     end
 
     items = controllers.map { |c| { name: c[:name], path: c[:path] } }
-    selected_name = @go_ui.show_list_view("Select Controller", items)
-    return if selected_name == "back"
 
-    controller_choice = controllers.find { |c| c[:name] == selected_name }
-    return unless controller_choice
+    loop do
+      selected_name = @go_ui.show_list_view("Select Controller", items)
+      return if selected_name == "back"
 
-    show_controller_test_options(controller_choice)
+      controller_choice = controllers.find { |c| c[:name] == selected_name }
+      next unless controller_choice
+
+      show_controller_test_options(controller_choice)
+    end
   end
 
   def generate_model_tests
@@ -248,13 +614,16 @@ class CLI
     end
 
     items = models.map { |m| { name: m[:name], path: m[:path] } }
-    selected_name = @go_ui.show_list_view("Select Model", items)
-    return if selected_name == "back"
 
-    model_choice = models.find { |m| m[:name] == selected_name }
-    return unless model_choice
+    loop do
+      selected_name = @go_ui.show_list_view("Select Model", items)
+      return if selected_name == "back"
+
+      model_choice = models.find { |m| m[:name] == selected_name }
+      next unless model_choice
 
-    show_model_test_options(model_choice)
+      show_model_test_options(model_choice)
+    end
   end
 
   def generate_service_tests
@@ -276,13 +645,16 @@ class CLI
     end
 
     items = services.map { |s| { name: s[:name], path: s[:path] } }
-    selected_name = @go_ui.show_list_view("Select Service", items)
-    return if selected_name == "back"
 
-    service_choice = services.find { |s| s[:name] == selected_name }
-    return unless service_choice
+    loop do
+      selected_name = @go_ui.show_list_view("Select Service", items)
+      return if selected_name == "back"
 
-    show_service_test_options(service_choice)
+      service_choice = services.find { |s| s[:name] == selected_name }
+      next unless service_choice
+
+      show_service_test_options(service_choice)
+    end
   end
 
   def generate_other_tests
@@ -623,7 +995,8 @@ class CLI
       @testng,
       @http_client,
       params,
-      method(:show_post_generation_menu)
+      method(:show_post_generation_menu),
+      @go_ui
     )
 
     direct_generator.run
@@ -688,6 +1061,18 @@ class CLI
     )
     @testng = Services::Testng.new(@http_client)
   end
+
+  def handle_fix_command
+    file_path = params[:file]
+    unless file_path
+      puts @pastel.red("❌ File parameter is required for fix mode")
+      puts @pastel.yellow("Usage: bundle exec tng --fix --file=your_file.rb")
+      return
+    end
+
+    orchestrator = Tng::Services::FixOrchestrator.new(@pastel, @http_client)
+    orchestrator.run(file_path)
+  end
 end
 
 cli = CLI.new

data/lib/tng/analyzers/controller.rb

@@ -64,12 +64,6 @@ module Tng
               name: method_name.to_s
             }
           end
-        rescue NameError => e
-          puts "❌ Could not load controller class #{controller_name}: #{e.message}"
-          []
-        rescue StandardError => e
-          puts "❌ Error analyzing controller #{controller_name}: #{e.message}"
-          []
         end
       end
     end

data/lib/tng/analyzers/model.rb

@@ -31,7 +31,8 @@ module Tng
           model_class = model_name.constantize
 
           instance_methods = model_class.public_instance_methods(false) +
-                              model_class.private_instance_methods(false)
+                             model_class.protected_instance_methods(false) +
+                             model_class.private_instance_methods(false)
           class_methods = model_class.public_methods(false) - Class.public_methods
 
           model_file = Object.const_source_location(model_class.name)&.first
@@ -78,12 +79,6 @@ module Tng
           else
             []
           end
-        rescue NameError => e
-          puts "❌ Could not load model class #{model_name}: #{e.message}"
-          []
-        rescue StandardError => e
-          puts "❌ Error analyzing model #{model_name}: #{e.message}"
-          []
         end
       end
 
@@ -109,7 +104,7 @@ module Tng
               node.arguments.arguments.each do |arg|
                 if arg.is_a?(Prism::SymbolNode)
                   validation_method = arg.value
-                  validations << validation_method if validation_method
+                  validations << "validate :#{validation_method}" if validation_method
                 end
               end
             else
@@ -117,7 +112,7 @@ module Tng
               node.arguments.arguments.each do |arg|
                 if arg.is_a?(Prism::SymbolNode)
                   attr_name = arg.value
-                  validations << attr_name if attr_name
+                  validations << "validates :#{attr_name}" if attr_name
                 end
               end
             end

data/lib/tng/analyzers/service.rb

@@ -32,7 +32,7 @@ module Tng
           service_class = service_name.constantize
 
           instance_methods = service_class.public_instance_methods(false) +
-                              service_class.private_instance_methods(false)
+                             service_class.private_instance_methods(false)
           class_methods = service_class.public_methods(false) - Class.public_methods
 
           # Try to get source file from any method, fallback to const_source_location
@@ -74,12 +74,6 @@ module Tng
                             end
 
           service_methods.map { |method_name| { name: method_name.to_s } }
-        rescue NameError => e
-          puts "❌ Could not load service class #{service_name}: #{e.message}"
-          []
-        rescue StandardError => e
-          puts "❌ Error analyzing service #{service_name}: #{e.message}"
-          []
         end
       end