tivohmo 0.2.3 → 0.3.0

data/spec/adapters/plex/show_spec.rb

@@ -1,9 +1,9 @@
 require_relative "../../spec_helper"
 require 'tivohmo/adapters/plex'
 
-describe TivoHMO::Adapters::Plex::Show do
+describe TivoHMO::Adapters::Plex::Show, :vcr do
 
-  let(:plex_delegate) { plex_stub(::Plex::Show) }
+  let(:plex_delegate) { plex_tv_section.all.first }
 
   describe "#initialize" do
 
@@ -13,8 +13,23 @@ describe TivoHMO::Adapters::Plex::Show do
       expect(show).to be_a TivoHMO::API::Container
       expect(show.title).to eq(plex_delegate.title)
       expect(show.identifier).to eq(plex_delegate.key)
-      expect(show.modified_at).to eq(Time.at(plex_delegate.updated_at))
-      expect(show.created_at).to eq(Time.at(plex_delegate.added_at))
+      expect(show.modified_at).to eq(Time.at(plex_delegate.updated_at.to_i))
+      expect(show.created_at).to eq(Time.at(plex_delegate.added_at.to_i))
+    end
+
+  end
+
+  describe "#children" do
+
+    it "should memoize" do
+      show = described_class.new(plex_delegate)
+      expect(show.children.object_id).to eq(show.children.object_id)
+    end
+
+    it "should have children" do
+      show = described_class.new(plex_delegate)
+      expect(show.children).to_not be_empty
+      show.children.all? {|c| expect(c).to be_instance_of(TivoHMO::Adapters::Plex::Season) }
     end
 
   end

data/spec/adapters/plex/transcoder_spec.rb

@@ -1,15 +1,10 @@
 require_relative "../../spec_helper"
 require 'tivohmo/adapters/plex'
 
-describe TivoHMO::Adapters::Plex::Transcoder do
+describe TivoHMO::Adapters::Plex::Transcoder, :vcr do
 
 
-  let(:plex_delegate) { plex_stub(::Plex::Movie,
-                                  summary: 'Summary',
-                                  duration: 10000,
-                                  medias: [double('media',
-                                                 parts: [double('part',
-                                                                file: '/foo%20bar')])])}
+  let(:plex_delegate) { plex_movie_section.all.first }
 
   let(:item) { double('item', identifier: plex_delegate.key, delegate: plex_delegate)}
 
@@ -19,7 +14,6 @@ describe TivoHMO::Adapters::Plex::Transcoder do
       trans = described_class.new(item)
       expect(trans).to be_a described_class
       expect(trans).to be_a TivoHMO::API::Transcoder
-      expect(trans.source_filename).to eq '/foo bar'
     end
 
   end

data/spec/adapters/settings/application_spec.rb

@@ -0,0 +1,25 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::Application do
+
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      app = described_class.new('settings')
+      expect(app).to be_a described_class
+      expect(app.metadata_class).to eq TivoHMO::Adapters::Settings::Metadata
+      expect(app.transcoder_class).to eq TivoHMO::Adapters::Settings::Transcoder
+      expect(app.children.size).to eq(TivoHMO::Config.instance.known_config.keys.size + 1)
+      app.children[0..-2].all? do |c|
+        expect(c).to be_instance_of(TivoHMO::Adapters::Settings::KeyContainer)
+        expect(TivoHMO::Config.instance.known_config[c.identifier]).to_not be_nil
+      end
+      expect(app.children.last).to be_instance_of(TivoHMO::Adapters::Settings::ResetDefaultsItem)
+      expect(app.children.last.title).to eq("Reset Defaults")
+    end
+
+  end
+
+end

data/spec/adapters/settings/display_item_spec.rb

@@ -0,0 +1,29 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::DisplayItem do
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      item = described_class.new("Foo")
+      expect(item).to be_a described_class
+      expect(item.children.size).to eq(0)
+      expect(item.title).to eq("Foo")
+    end
+
+    it "should provide metadata description" do
+      item = described_class.new("Foo")
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+      expect(item.metadata.description).to eq("Nothing to do here, hit back to return")
+    end
+
+    it "should provide extended metadata description" do
+      item = described_class.new("Foo", "This is foo")
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+      expect(item.metadata.description).to eq("This is foo.  Nothing to do here, hit back to return")
+    end
+
+  end
+
+end

data/spec/adapters/settings/key_container_spec.rb

@@ -0,0 +1,33 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::KeyContainer do
+
+  let (:config_key) do
+    TivoHMO::Config.instance.known_config.keys.first
+  end
+
+  let (:config_spec) do
+    TivoHMO::Config.instance.known_config[config_key]
+  end
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      cont = described_class.new(config_key)
+      expect(cont).to be_a described_class
+      expect(cont.children.size).to eq(4)
+      expect(cont.children[0]).to be_instance_of(TivoHMO::Adapters::Settings::DisplayItem)
+      expect(cont.children[0].title).to eq("Help")
+      expect(cont.children[1]).to be_instance_of(TivoHMO::Adapters::Settings::DisplayItem)
+      expect(cont.children[1].title).to eq("Default Value: #{config_spec[:default_value]}")
+      expect(cont.children[2]).to be_instance_of(TivoHMO::Adapters::Settings::DisplayItem)
+      val = !!TivoHMO::Config.instance.get(config_key)
+      expect(cont.children[2].title).to eq("Current Value: #{val}")
+      expect(cont.children[3]).to be_instance_of(TivoHMO::Adapters::Settings::SetValueItem)
+      expect(cont.children[3].title).to eq("Set value to #{!val}")
+    end
+
+  end
+
+end

data/spec/adapters/settings/metadata_spec.rb

@@ -0,0 +1,33 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::Metadata do
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      md = described_class.new(double('item'))
+    end
+
+    it "should allow not having a callback" do
+      md = described_class.new(double('item'))
+      expect(md.item_detail_callback).to be_nil
+
+      md.star_rating
+    end
+
+    it "should callback on star_rating" do
+      md = described_class.new(double('item'))
+
+      called = 0
+      md.item_detail_callback = Proc.new do
+        called += 1
+      end
+
+      md.star_rating
+      expect(called).to eq(1)
+    end
+
+  end
+
+end

data/spec/adapters/settings/reset_defaults_item_spec.rb

@@ -0,0 +1,54 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::ResetDefaultsItem do
+
+  let (:config_key) do
+    TivoHMO::Config.instance.known_config.keys.first
+  end
+
+  let (:config_spec) do
+    TivoHMO::Config.instance.known_config[config_key]
+  end
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      item = described_class.new
+      expect(item).to be_a described_class
+      expect(item.children.size).to eq(0)
+      expect(item.title).to eq("Reset Defaults")
+    end
+
+    it "should provide metadata description" do
+      new_value = ! TivoHMO::Config.instance.get(config_key)
+      item = described_class.new
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+
+      expect(item.metadata).to_not be_nil
+      expect(item.metadata.description).to eq("All runtime config has now been reset to defaults, hit back to return")
+    end
+
+    it "should not change when reading metadata" do
+      expect(TivoHMO::Config.instance).to receive(:set).never
+      item = described_class.new
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+
+      expect(item.metadata).to_not be_nil
+    end
+
+    it "should change when reading metadata" do
+      app = TivoHMO::Adapters::Settings::Application.new('settings')
+      app.add_child(item = described_class.new)
+
+      TivoHMO::Config.instance.known_config.each do |key, spec|
+        expect(TivoHMO::Config.instance).to receive(:set).with(key, spec[:default_value])
+      end
+      expect(app.children).to receive(:clear)
+
+      item.metadata.star_rating
+    end
+
+  end
+
+end

data/spec/adapters/settings/set_value_item_spec.rb

@@ -0,0 +1,54 @@
+require_relative "../../spec_helper"
+require 'tivohmo/adapters/settings'
+
+describe TivoHMO::Adapters::Settings::SetValueItem do
+
+  let (:config_key) do
+    TivoHMO::Config.instance.known_config.keys.first
+  end
+
+  let (:config_spec) do
+    TivoHMO::Config.instance.known_config[config_key]
+  end
+
+  describe "#initialize" do
+
+    it "should instantiate" do
+      new_value = ! TivoHMO::Config.instance.get(config_key)
+      item = described_class.new(config_key, new_value)
+      expect(item).to be_a described_class
+      expect(item.children.size).to eq(0)
+      expect(item.title).to eq("Set value to #{new_value}")
+    end
+
+    it "should provide metadata description" do
+      new_value = ! TivoHMO::Config.instance.get(config_key)
+      item = described_class.new(config_key, new_value)
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+
+      expect(item.metadata).to_not be_nil
+      expect(item.metadata.description).to eq("Value has now been set to #{new_value}, hit back to return")
+    end
+
+    it "should not change when reading metadata" do
+      new_value = ! TivoHMO::Config.instance.get(config_key)
+      item = described_class.new(config_key, new_value)
+      item.app = TivoHMO::Adapters::Settings::Application.new('settings')
+
+      expect(item.metadata).to_not be_nil
+      expect(TivoHMO::Config.instance.get(config_key)).to_not eq(new_value)
+    end
+
+    it "should change when reading metadata" do
+      new_value = ! TivoHMO::Config.instance.get(config_key)
+      app = TivoHMO::Adapters::Settings::Application.new('settings')
+      app.add_child(item = described_class.new(config_key, new_value))
+
+      expect(app.children).to receive(:clear)
+      item.metadata.star_rating
+      expect(TivoHMO::Config.instance.get(config_key)).to eq(new_value)
+    end
+
+  end
+
+end

data/spec/api/container_spec.rb

@@ -13,6 +13,7 @@ describe TivoHMO::API::Container do
       expect(node).to be_a(TivoHMO::API::Node)
       expect(node.identifier).to eq('c')
       expect(node.uuid).to_not be_nil
+      expect(node.presorted).to eq(false)
       expect(node.content_type).to eq("x-tivo-container/tivo-videos")
       expect(node.source_format).to eq("x-tivo-container/folder")
     end
@@ -31,4 +32,15 @@ describe TivoHMO::API::Container do
 
   end
 
+  describe "#child_count" do
+
+    it "should count children" do
+      node = test_class.new('c')
+      expect(node.child_count).to eq(0)
+      node2 = node.add_child(test_class.new('c2'))
+      expect(node.child_count).to eq(1)
+    end
+
+  end
+
 end

data/spec/api/item_spec.rb

@@ -14,6 +14,8 @@ describe TivoHMO::API::Item do
       expect(node).to be_a(TivoHMO::API::Node)
       expect(node.identifier).to eq('i')
       expect(node.title).to eq('i')
+      expect(node.file).to eq('i')
+      expect(node.subtitle).to be_nil
       expect(node.content_type).to eq("video/x-tivo-mpeg")
       expect(node.source_format).to eq("video/x-tivo-mpeg")
     end

data/spec/api/transcoder_spec.rb

@@ -17,7 +17,6 @@ describe TivoHMO::API::Transcoder do
       trans = test_class.new(item)
       expect(trans).to be_a(TivoHMO::API::Transcoder)
       expect(trans.item).to eq(item)
-      expect(trans.source_filename).to eq('foo')
     end
 
   end

data/spec/beacon_spec.rb

@@ -77,7 +77,9 @@ describe TivoHMO::Beacon do
     it "sends a packet on the socket" do
       beacon = described_class.new(1234)
       expect(beacon).to receive(:beacon_data).with('broadcast').and_return('packet')
-      socket = beacon.instance_variable_get(:@socket)
+      socket = instance_double("Socket")
+      expect(UDPSocket).to receive(:new).with(Socket::AF_INET).and_return(socket)
+      expect(socket).to receive(:setsockopt).with(Socket::SOL_SOCKET, Socket::SO_BROADCAST, true)
       expect(socket).to receive(:send).with('packet', 0, '<broadcast>', 2190)
       beacon.broadcast
     end

data/spec/cli_spec.rb

@@ -3,10 +3,12 @@ require "tivohmo/cli"
 
 describe TivoHMO::CLI do
 
+  let(:app_title) { 'app_title' }
   let(:app_name) { TestAPI::Application.name }
   let(:app_ident) { 'app_ident' }
   let(:minimal_args) do
     {
+        title: app_title,
         application: app_name,
         identifier: app_ident
     }
@@ -94,28 +96,71 @@ describe TivoHMO::CLI do
 
   describe "--configuration" do
 
-    it "defaults to not loading config" do
-      expect(YAML).to receive(:load_file).never
+    it "defaults to calling setup with nil" do
+      expect(TivoHMO::Config.instance).to receive(:setup).with(nil, nil)
       cli.run(argv(minimal_args))
     end
 
-    it "sets log level to debug" do
-      expect(YAML).to receive(:load_file).with('foo.yml').and_return({})
+    it "can supply a config file" do
+      expect(TivoHMO::Config.instance).to receive(:setup).with(/foo.yml$/, nil)
       cli.run(argv(minimal_args.merge(configuration: 'foo.yml')))
     end
 
-    it "can supply config" do
-      expect(YAML).to receive(:load_file).with('foo.yml').and_return({'port' => 1234})
+    it "can supply config values" do
+      cf = Tempfile.new('cli_config').path
+      File.write(cf, YAML.dump({'port' => 1234}))
       expect(TivoHMO::Server).to receive(:start).with(api_server, 1234)
-      cli.run(argv(minimal_args.merge(configuration: 'foo.yml')))
+      cli.run(argv(minimal_args.merge(configuration: cf)))
+      expect(TivoHMO::Config.instance.get(:port)).to eq(1234)
     end
 
     it "supplies config that can be overriden from cli" do
-      expect(YAML).to receive(:load_file).with('foo.yml').and_return({'port' => 1234})
+      cf = Tempfile.new('cli_config').path
+      File.write(cf, YAML.dump({'port' => 1234}))
       expect(TivoHMO::Server).to receive(:start).with(api_server, 4321)
-      cli.run(argv(minimal_args.merge(configuration: 'foo.yml', port: 4321)))
+      cli.run(argv(minimal_args.merge(configuration: cf, port: 4321)))
+      expect(TivoHMO::Config.instance.get(:port)).to eq(1234)
     end
 
+    it "merges/overrides app config from file with config from cli" do
+      cf = Tempfile.new('cli_config').path
+      OtherApp1 = Class.new(TestAPI::Application)
+      OtherApp2 = Class.new(TestAPI::Application)
+      File.write(cf,
+                 YAML.dump({
+                                   'applications' => {
+                                       "App1" => {
+                                           "application" => TestAPI::Application.name,
+                                           "identifier" => 'app_ident1'
+                                       },
+                                       "App2" => {
+                                           "application" => TestAPI::Application.name,
+                                           "identifier" => 'app_ident2'
+                                       }
+                                   }
+                           }))
+      cli.run(argv(%W[
+                       configuration #{cf}
+                       title App1
+                       application #{OtherApp1.name}
+                       identifier other_ident1
+                       title App2
+                       application #{OtherApp2.name}
+                       identifier other_ident2
+                   ]))
+
+      expect(api_server.children.size).to eq(2)
+      app1 = api_server.children[0]
+      app2 = api_server.children[1]
+      expect(app1.title).to eq('App1')
+      expect(app1.class).to eq(OtherApp1)
+      expect(app1.identifier).to eq('other_ident1')
+      expect(app2.title).to eq('App2')
+      expect(app2.class).to eq(OtherApp2)
+      expect(app2.identifier).to eq('other_ident2')
+    end
+
+
   end
 
   describe "--port" do
@@ -167,7 +212,7 @@ describe TivoHMO::CLI do
 
     it "requires one init per app" do
       expect {
-        described_class.new("").run(["-a", "foo"])
+        described_class.new("").run(["-t", "app", "-a", "foo"])
       }.to raise_error(Clamp::UsageError,
                        'an initializer is needed for each application')
     end
@@ -183,21 +228,14 @@ describe TivoHMO::CLI do
     it "requires the adapter for the application" do
       require 'tivohmo/adapters/filesystem'
       expect(cli).to receive(:require).with('tivohmo/adapters/filesystem')
-      cli.run(%w[-a TivoHMO::Adapters::Filesystem::Application -i .])
+      cli.run(%w[-t App -a TivoHMO::Adapters::Filesystem::Application -i .])
     end
 
     it "starts a server for the app" do
       cli.run(argv(minimal_args))
       expect(api_server.children.size).to eq(1)
       expect(api_server.children.first.class).to eq(TestAPI::Application)
-      expect(api_server.children.first.title).to eq("#{app_ident} on #{api_server.title}")
-    end
-
-    it "starts a server with title" do
-      cli.run(argv(minimal_args.merge(title: 'Foo')))
-      expect(api_server.children.size).to eq(1)
-      expect(api_server.children.first.class).to eq(TestAPI::Application)
-      expect(api_server.children.first.title).to eq("Foo")
+      expect(api_server.children.first.title).to eq(app_title)
     end
 
     it "starts a server with alternate transcoder/metadata" do